[Qemu-devel] [PATCH v5 4/8] virtio-balloon: use virtio wrappers to access page frame numbers

2014-02-21 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio-balloon.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v5 8/8] virtio-9p: use virtio wrappers to access headers

2014-02-21 Thread Greg Kurz
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-device.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index

[Qemu-devel] [PATCH v5 7/8] virtio-serial-bus: use virtio wrappers to access headers

2014-02-21 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/char/virtio-serial-bus.c | 34 ++ 1 file changed, 18 insertions

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Introduce hypervisor call H_GET_TCE

2014-02-21 Thread Greg Kurz
by the kdump kernel which is calling it to retrieve the TCE set up by the panicing kernel. Signed-off-by: Laurent Dufour lduf...@linux.vnet.ibm.com --- FWIW, you can add this :) Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com hw/ppc/spapr_iommu.c | 37 + trace

Re: [Qemu-devel] [PATCH v5 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio

2014-02-25 Thread Greg Kurz
On Tue, 25 Feb 2014 16:21:21 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: On Fri, Feb 21, 2014 at 12:28:11PM +0100, Greg Kurz wrote: diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index aeabf3a..4fd6ac2 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -19,6 +19,9

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-23 Thread Greg Kurz
On Wed, 22 Jan 2014 20:25:05 -0800 Victor Kamensky victor.kamen...@linaro.org wrote: Hi Alex, Sorry, for delayed reply, I was focusing on discussion with Peter. Hope you and other folks may get something out of it :). Please see responses inline On 22 January 2014 02:52, Alexander

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-02-07 Thread Greg Kurz
On Wed, 5 Feb 2014 23:31:11 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kumar K.V wrote: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-02-07 Thread Greg Kurz
In the past, IO space could not be mapped into the memory address space so we introduced a workaround for that. Nowadays it does not look necessary so we can remove the workaround and make sPAPR PCI configuration simplier. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- There has been

Re: [Qemu-devel] [Qemu-ppc] [PATCH V9 5/5] target-ppc: Update ppc_hash64_store_hpte to support updating in-kernel htab

2014-02-10 Thread Greg Kurz
On Tue, 28 Jan 2014 13:30:03 +0530 Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: This support updating htab managed by the hypervisor. Currently we don't have any user for this feature. This actually bring the store_hpte interface in-line with the load_hpte one. We may want to use

Re: [Qemu-devel] [Qemu-ppc] [PATCH V9 3/5] target-ppc: Fix page table lookup with kvm enabled

2014-02-10 Thread Greg Kurz
On Tue, 28 Jan 2014 13:30:01 +0530 Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Greg Kurz
On Mon, 21 Apr 2014 09:46:59 +0530 Bharata B Rao bharata@gmail.com wrote: On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz gk...@linux.vnet.ibm.com wrote: + +#if !defined(CONFIG_USER_ONLY) +bool virtio_is_big_endian(void) +{ +PowerPCCPU *cp = POWERPC_CPU(first_cpu

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Greg Kurz
On Mon, 21 Apr 2014 09:56:48 +0200 Alexander Graf ag...@suse.de wrote: Am 21.04.2014 um 06:16 schrieb Bharata B Rao bharata@gmail.com: On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz gk...@linux.vnet.ibm.com wrote: + +#if !defined(CONFIG_USER_ONLY) +bool virtio_is_big_endian

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-22 Thread Greg Kurz
On Tue, 22 Apr 2014 09:19:48 -0400 (EDT) Dave Anderson ander...@redhat.com wrote: - Original Message - On Mon, Apr 21, 2014 at 4:48 PM, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Mon, 21 Apr 2014 09:56:48 +0200 Alexander Graf ag...@suse.de wrote: Am

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Greg Kurz
On Tue, 22 Apr 2014 12:16:07 +0200 Andreas Färber afaer...@suse.de wrote: Am 22.04.2014 12:12, schrieb Fam Zheng: On Tue, 04/22 17:58, Jason Wang wrote: On 04/22/2014 04:55 PM, Fam Zheng wrote: diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index aeabf3a..222bb73 100644 ---

[Qemu-devel] [PATCH 3/4] target-ppc: ppc can be either endian

2014-04-28 Thread Greg Kurz
for legacy virtio support and crash dump support as well. Suggested-by: Benjamin Herrenschmidt b...@kernel.crashing.org Suggested-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- target-ppc/cpu-qom.h|2 ++ target-ppc/misc_helper.c|7

[Qemu-devel] [PATCH 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-04-28 Thread Greg Kurz
of dump.h from stubs/dump.c by creating a separate dump-arch.h. This patch doesn't change any functionality. Signed-off-by: Bharata B Rao bhar...@linux.ibm.com [ rebased on top of current master branch, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 0/4] little-endian dump for ppc64

2014-04-28 Thread Greg Kurz
ppc64-dump: Support dump for little endian ppc64 ppc64 dump: Set the correct endianness in ELF dump header Greg Kurz (1): target-ppc: ppc can be either endian dump.c | 39 ++-- include/sysemu/dump-arch.h | 28 + include

[Qemu-devel] [PATCH 2/4] ppc64-dump: Support dump for little endian ppc64

2014-04-28 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Fix ppc64 arch specific dump code to work correctly for little endian guests. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com [ rebased on top of current master branch, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk

[Qemu-devel] [PATCH 4/4] ppc64 dump: Set the correct endianness in ELF dump header

2014-04-28 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com [ use ppc_cpu_interrupts_big_endian(), Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- target-ppc/arch_dump.c |9 + 1 file changed, 5

[Qemu-devel] [PATCH v2] target-ppc: ppc can be either endian

2014-04-29 Thread Greg Kurz
for legacy virtio support and crash dump support as well. Suggested-by: Benjamin Herrenschmidt b...@kernel.crashing.org Suggested-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes for v2: - the interrupts_big_endian method now takes a PowerPCCPU * arg

Re: [Qemu-devel] [PATCH 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-04-29 Thread Greg Kurz
On Tue, 29 Apr 2014 11:16:51 +0200 Alexander Graf ag...@suse.de wrote: On 28.04.14 13:29, Greg Kurz wrote: From: Bharata B Rao bhar...@linux.vnet.ibm.com Make DumpState and endian conversion routines available for arch-specific dump code by moving into dump.h. DumpState

Re: [Qemu-devel] [PATCH 3/4] target-ppc: ppc can be either endian

2014-04-29 Thread Greg Kurz
On Tue, 29 Apr 2014 11:14:12 +0200 Alexander Graf ag...@suse.de wrote: On 28.04.14 14:47, Andreas Färber wrote: [fixing Bharata's address] Am 28.04.2014 13:29, schrieb Greg Kurz: POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR special purpose register to decide

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-04-29 Thread Greg Kurz
On Tue, 29 Apr 2014 11:35:46 +0200 Alexander Graf ag...@suse.de wrote: On 29.04.14 11:29, Greg Kurz wrote: On Tue, 29 Apr 2014 11:16:51 +0200 Alexander Graf ag...@suse.de wrote: On 28.04.14 13:29, Greg Kurz wrote: From: Bharata B Rao bhar...@linux.vnet.ibm.com Make DumpState

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-04-29 Thread Greg Kurz
On Tue, 29 Apr 2014 15:51:07 +0530 Bharata B Rao bharata@gmail.com wrote: On Tue, Apr 29, 2014 at 2:59 PM, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Tue, 29 Apr 2014 11:16:51 +0200 Alexander Graf ag...@suse.de wrote: On 28.04.14 13:29, Greg Kurz wrote: From: Bharata B Rao

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] target-ppc: ppc can be either endian

2014-04-29 Thread Greg Kurz
On Tue, 29 Apr 2014 11:22:38 +0200 Alexander Graf ag...@suse.de wrote: On 29.04.14 11:15, Greg Kurz wrote: POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR special purpose register to decide the endianness to use when entering interrupt handlers. When running a Linux guest

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc64-dump: Support dump for little endian ppc64

2014-04-30 Thread Greg Kurz
On Tue, 29 Apr 2014 11:19:40 +0200 Alexander Graf ag...@suse.de wrote: On 28.04.14 13:29, Greg Kurz wrote: From: Bharata B Rao bhar...@linux.vnet.ibm.com Fix ppc64 arch specific dump code to work correctly for little endian guests. Signed-off-by: Bharata B Rao bhar

[Qemu-devel] [PATCH v2 0/4] little-endian dump for ppc64

2014-04-30 Thread Greg Kurz
endianness in ELF dump header Greg Kurz (1): target-ppc: ppc can be either endian dump.c | 239 ++- include/sysemu/dump-arch.h | 28 + include/sysemu/dump.h | 48 +++-- stubs/dump.c|2

[Qemu-devel] [PATCH v2 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-04-30 Thread Greg Kurz
of dump.h from stubs/dump.c by creating a separate dump-arch.h. This patch doesn't change any functionality. Signed-off-by: Bharata B Rao bhar...@linux.ibm.com [ rebased on top of current master branch, added dump_ prefix and pass a DumpState * argument to helpers, Greg Kurz gk

[Qemu-devel] [PATCH v3 3/4] target-ppc: ppc can be either endian

2014-04-30 Thread Greg Kurz
for legacy virtio support and crash dump support as well. Suggested-by: Benjamin Herrenschmidt b...@kernel.crashing.org Suggested-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes in v3: - killed ppc_cpu_interrupts_big_endian() helper target-ppc/cpu

[Qemu-devel] [PATCH v2 2/4] ppc64-dump: Support dump for little endian ppc64

2014-04-30 Thread Greg Kurz
master branch, added dump_ prefix and pass a DumpState * argument to helpers, introduced NoteFuncArg, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes for v2: - added dump_ prefix and pass a DumpState * argument to helpers - introduced

[Qemu-devel] [PATCH v2 4/4] ppc64 dump: Set the correct endianness in ELF dump header

2014-04-30 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com [ use PowerPCCPUClass::interrupts_big_endian(), Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes in v2: - use PowerPCCPUClass

[Qemu-devel] [PATCH v3 0/4] little-endian dump for ppc64

2014-05-05 Thread Greg Kurz
. Cheers. --- Bharata B Rao (3): dump: Make DumpState and endian conversion routines available for arch-specific dump code ppc64-dump: Support dump for little endian ppc64 ppc64 dump: Set the correct endianness in ELF dump header Greg Kurz (1): target-ppc: ppc can be either

[Qemu-devel] [PATCH v3 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-05-05 Thread Greg Kurz
helpers, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes in v3: - better taste with the endian helpers naming dump.c | 228 +--- include/sysemu/dump-arch.h | 28 + include/sysemu

[Qemu-devel] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

2014-05-05 Thread Greg Kurz
master branch, introduced NoteFuncArg, use new cpu_to_dump{16,32,64} endian helpers, Greg Kurz gk...@linux.vnet.ibm.com ] Reviewed-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes in v3: - better taste with the endian helpers naming target-ppc

[Qemu-devel] [PATCH v3 3/4] target-ppc: ppc can be either endian

2014-05-05 Thread Greg Kurz
for legacy virtio support and crash dump support as well. Suggested-by: Benjamin Herrenschmidt b...@kernel.crashing.org Reviewed-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- No changes, resent in case it helps target-ppc/cpu-qom.h|1 + target

[Qemu-devel] [PATCH v2 4/4] ppc64 dump: Set the correct endianness in ELF dump header

2014-05-05 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com [ use PowerPCCPUClass::interrupts_big_endian(), Greg Kurz gk...@linux.vnet.ibm.com ] Reviewed-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- No changes

Re: [Qemu-devel] [PATCH v3 3/4] target-ppc: ppc can be either endian

2014-05-07 Thread Greg Kurz
On Tue, 6 May 2014 19:37:22 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 5 May 2014 09:07, Greg Kurz gk...@linux.vnet.ibm.com wrote: POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR special purpose register to decide the endianness to use when entering interrupt

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

2014-05-07 Thread Greg Kurz
On Mon, 05 May 2014 13:04:35 +0200 Alexander Graf ag...@suse.de wrote: On 05/05/2014 10:05 AM, Greg Kurz wrote: From: Bharata B Rao bhar...@linux.vnet.ibm.com Fix ppc64 arch specific dump code to work correctly for little endian guests. We introduce a NoteFuncArg type to avoid adding

Re: [Qemu-devel] [PATCH v3 3/4] target-ppc: ppc can be either endian

2014-05-07 Thread Greg Kurz
On Wed, 7 May 2014 11:41:10 +0200 Alexander Graf ag...@suse.de wrote: Am 07.05.2014 um 11:26 schrieb Peter Maydell peter.mayd...@linaro.org: On 7 May 2014 10:09, Alexander Graf ag...@suse.de wrote: I don't think we should overengineer hacks for legacy virtio. Agreed. So what's

Re: [Qemu-devel] [PATCH v3 3/4] target-ppc: ppc can be either endian

2014-05-07 Thread Greg Kurz
On Wed, 07 May 2014 13:54:36 +0200 Alexander Graf ag...@suse.de wrote: On 05/07/2014 12:19 PM, Greg Kurz wrote: On Wed, 7 May 2014 11:41:10 +0200 Alexander Graf ag...@suse.de wrote: Am 07.05.2014 um 11:26 schrieb Peter Maydell peter.mayd...@linaro.org: On 7 May 2014 10:09, Alexander

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

2014-05-08 Thread Greg Kurz
On Wed, 07 May 2014 15:54:10 -0500 Tom Musta tommu...@gmail.com wrote: On 5/7/2014 2:02 PM, Tom Musta wrote: It feels like there is an endianness issue here but I have not yet been able to put my finger on it. OK ... after more thought and scribbling ... here is what I mean

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-29 Thread Greg Kurz
On Tue, 27 May 2014 17:01:38 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 14/05/2014 17:42, Greg Kurz ha scritto: +{ .name = virtio/is_big_endian, + .version_id = 1, + .save = virtio_save_device_endian, + .load = virtio_load_device_endian, +}, { .name

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 02/29] target-ppc: Merge 970FX and 970MP into a single 970 class

2014-06-03 Thread Greg Kurz
On Tue, 3 Jun 2014 19:27:37 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: The differences between classes were: 1. SLB size, was 32 for 970 and 64 for others, should be 64 for all; 2. check_pow() callback, HID0 format is the same so should be the same 0x01C0 which means deep nap, doze

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 29/29] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-06-03 Thread Greg Kurz
On Tue, 3 Jun 2014 19:28:04 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. This defines AIL flags for LPCR special register. This changes @excp_prefix according to the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Greg Kurz
On Wed, 04 Jun 2014 11:50:53 +0200 Alexander Graf ag...@suse.de wrote: On 04.06.14 11:47, Peter Maydell wrote: On 4 June 2014 10:39, Paolo Bonzini pbonz...@redhat.com wrote: It's a kind of emergency button on real machines. On PCs it sends an NMI and this results in some kind of crash

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 29 May 2014 12:16:26 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 29/05/2014 11:12, Greg Kurz ha scritto: int virtio_load(VirtIODevice *vdev, QEMUFile *f) { [...] nheads = vring_avail_idx(vdev-vq[i]) - vdev-vq[i].last_avail_idx

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 10:54:48 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: On Thu, 29 May 2014 12:16:26 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 29/05/2014 11:12, Greg Kurz ha scritto: int virtio_load(VirtIODevice

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 10:55:42 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 12/06/2014 09:43, Greg Kurz ha scritto: Since we know that 0 max_nr_ports 32, is it acceptable to guess the correct endianness with a heuristic ? if (max_nr_ports tswap32(s-config.max_nr_ports

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 11:43:20 +0200 Alexander Graf ag...@suse.de wrote: On 12.06.14 11:39, Paolo Bonzini wrote: Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: Maybe just drop unnecessary stuff for new machine types? Then we won't need hacks to migrate it. For any machine type

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 12:39:27 +0200 Alexander Graf ag...@suse.de wrote: Am 12.06.2014 um 12:14 schrieb Greg Kurz gk...@linux.vnet.ibm.com: On Thu, 12 Jun 2014 11:43:20 +0200 Alexander Graf ag...@suse.de wrote: On 12.06.14 11:39, Paolo Bonzini wrote: Il 12/06/2014 11:37

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 13:59:59 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jun 12, 2014 at 12:50:56PM +0200, Greg Kurz wrote: On Thu, 12 Jun 2014 12:39:27 +0200 Alexander Graf ag...@suse.de wrote: Am 12.06.2014 um 12:14 schrieb Greg Kurz gk...@linux.vnet.ibm.com

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-03-17 Thread Greg Kurz
On Wed, 12 Mar 2014 13:34:44 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 07, 2014 at 10:02:52AM +0100, Greg Kurz wrote: On Wed, 5 Feb 2014 23:31:11 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote: Michael

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 1/3] target-ppc: introduce powerisa-207-server flag

2014-03-19 Thread Greg Kurz
-by: Alexey Kardashevskiy a...@ozlabs.ru --- Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com target-ppc/cpu.h| 2 ++ target-ppc/translate_init.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index afab267..27a2cd9

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: reset SPRs on CPU reset

2014-03-19 Thread Greg Kurz
) when the guest kernel calls H_SET_MODE_RESOURCE_LE, we indeed have a window where the guest keeps the endianness from the previous kernel. In case the guest was running a LE kernel, when we reboot we end up running SLOF in a LE environment... but SLOF assumes BE and breaks. Reviewed-by: Greg Kurz

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] spapr-hcall: fix little-endian resource handling in H_SET_MODE

2014-03-19 Thread Greg Kurz
. This adds a set_spr() helper to update an SPR in a CPU's context to avoid possible races and makes use of it to change LPCR. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com hw/ppc/spapr_hcall.c | 38

[Qemu-devel] [PATCH] spapr_pci: turn IOMMU root into an I/O region

2014-08-26 Thread Greg Kurz
... The most visible effect is that all virtio devices are non-fonctionnal on sPAPR. :( This patch plugs the MSI memory ops to the root IOMMU region, and virtio devices work again. I am not sure this is the right way to fix: please comment and enlight ! Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com

[Qemu-devel] [PATCH] spapr_pci: map the MSI window in each PHB

2014-08-27 Thread Greg Kurz
-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/ppc/spapr.c |1 - hw/ppc/spapr_pci.c | 53 +++ include/hw/pci-host/spapr.h |2 +- include/hw/ppc/spapr.h |2 -- 4 files changed, 25 insertions(+), 33 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH] spapr_pci: map the MSI window in each PHB

2014-08-27 Thread Greg Kurz
On Wed, 27 Aug 2014 18:17:12 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X so that writes are made using the bus master address space. ...and follow

Re: [Qemu-devel] [Qemu-stable] [PATCH 06/25] pci: Use bus master address space for delivering MSI/MSI-X messages

2014-08-28 Thread Greg Kurz
...@redhat.com (cherry picked from commit cc943c36faa192cd4b32af8fe5edb31894017d35) Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Hi Michael, This commit breaks virtio for spapr. A fix is available in Alex's ppc-next: From: Greg Kurz gk...@linux.vnet.ibm.com spapr_pci: map the MSI window

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-01 Thread Greg Kurz
On Sat, 30 Aug 2014 15:53:13 +0100 Richard W.M. Jones rjo...@redhat.com wrote: I found out a few days ago that if you: (1) Open a qcow2 file that has lazy_refcounts = on and a backing file, and (2) Write lots of stuff, and (3) Kill qemu with SIGTERM [which I believed, maybe incorrectly,

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-01 Thread Greg Kurz
On Mon, 1 Sep 2014 15:19:28 +0100 Richard W.M. Jones rjo...@redhat.com wrote: A test case, attached. Note that you have to look at the output of the final qemu-img info command. In the case where it goes wrong, the 'backing file:' and 'backing file format:' lines disappear completely. In

Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-01 Thread Greg Kurz
On Mon, 1 Sep 2014 12:07:58 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- Hi Marc, I gave it a try for various host/target combinations involving ppc64 and x86_64. Here is what I

Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-02 Thread Greg Kurz
On Mon, 1 Sep 2014 18:27:34 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: El Mon, 1 Sep 2014 18:09:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com escribió: On Mon, 1 Sep 2014 12:07:58 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH] libqos: fix endianness bug in virtio-blk-test

2014-09-02 Thread Greg Kurz
The virtio block request header is in target cpu byte order, which may be different from the host cpu byte order. This patch allows the virtio-blk-test to run with a x86_64 (LE) target on a ppc64 (BE) host. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- tests/virtio-blk-test.c | 18

Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-02 Thread Greg Kurz
On Mon, 1 Sep 2014 18:52:48 +0800 Jun Li junm...@gmail.com wrote: When every item of refcount block is NULL, free refcount block and reset the corresponding item of refcount table with NULL. Signed-off-by: Jun Li address@hidden --- The v2 do following change to modify some potential

Re: [Qemu-devel] VFIO NATIVE_ENDIAN regions question

2014-09-07 Thread Greg Kurz
On Sat, 6 Sep 2014 12:49:47 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: At the moment VFIO's BARs are NATIVE_ENDIAN. The idea is that since it does not parse BARs content and just provides transport, it should not do byte swaps, the guest does it anyway. That worked fine while the host

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-09 Thread Greg Kurz
PCI devices Old guests forgot to enable bus mastering, enable it automatically on DRIVER_OK. Note: we should either back out the original patch from stable or apply this one on top. Cc: qemu-sta...@nongnu.org Reported-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Greg Kurz
On Wed, 10 Sep 2014 13:44:49 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Greg Kurz gk...@linux.vnet.ibm.com writes: On Mon, 8 Sep 2014 19:05:02 +0300 Michael S. Tsirkin m...@redhat.com wrote: commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Greg Kurz
On Wed, 10 Sep 2014 12:32:30 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: Greg Kurz gk...@linux.vnet.ibm.com writes: On Mon, 8 Sep 2014 19:05:02 +0300 Michael S. Tsirkin m...@redhat.com wrote: commit

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Revert vfio: Make BARs native endian

2014-09-11 Thread Greg Kurz
On Tue, 9 Sep 2014 21:34:46 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This reverts commit c40708176a6b52b73bec14796b7c71b882ceb102. The idea not to swap bytes at all did not work out as MMIO interface is defined as target host endian and it is always big-endian for PPC64 s/target

Re: [Qemu-devel] [PATCH v2] virtio-pci: enable bus master for old guests

2014-09-11 Thread Greg Kurz
PCI devices Old guests forgot to enable bus mastering, enable it automatically when driver discovers device. Cc: qemu-sta...@nongnu.org Reported-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- OK, this should have better luck. Unfortunately

[Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Greg Kurz
). And we must also re-enable bus mastering after migration. Cc: qemu-sta...@nongnu.org Reported-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com [ old guest detection on DRIVER, squashed patch from Michael S. Tsirkin to re-enable bus mastering, Greg Kurz gk

Re: [Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-11 Thread Greg Kurz
PCI devices. For the same reason, rhel6.[56] ppc64 guests cannot boot on a virtio-blk disk anymore. Old guests forgot to enable bus mastering, enable it automatically on DRIVER (guests use some devices before DRIVER_OK). Reported-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-17 Thread Greg Kurz
be able to drop checking OK bit in a bunch of places. Cc: Jason Wang jasow...@redhat.com Cc: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Hi Michael, I am not quite sure how to test this patch with my pseries based setup... Migrating from qemu-2.1

Re: [Qemu-devel] [Qemu-stable] [PATCH 06/25] pci: Use bus master address space for delivering MSI/MSI-X messages

2014-09-18 Thread Greg Kurz
On Thu, 28 Aug 2014 09:39:30 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Quoting Greg Kurz (2014-08-28 05:18:06) On Wed, 27 Aug 2014 12:36:03 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: From: Jan Kiszka jan.kis...@siemens.com The spec says (and real HW confirms

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-22 Thread Greg Kurz
be able to drop checking OK bit in a bunch of places. Cc: Jason Wang jasow...@redhat.com Cc: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Hi, This commit prevents pseries to boot. SLOF complains with the following messages: Trying to load: from: /pci

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-24 Thread Greg Kurz
On Tue, 23 Sep 2014 07:26:32 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote: On Thu, 18 Sep 2014 21:54:58 +0300 Michael S. Tsirkin m...@redhat.com wrote: Current support for bus master (clearing OK bit) together

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Greg Kurz
On Thu, 25 Sep 2014 16:29:31 +1000 Tony Breeds t...@bakeyournoodle.com wrote: On Thu, Sep 25, 2014 at 08:21:27AM +0200, Markus Armbruster wrote: Please copy Kevin Stefan for block patches. Doing that for you. I also copy Max, who left his fingerprints on commit 4f11aa8. Sorry. Is

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-29 Thread Greg Kurz
On Mon, 29 Sep 2014 19:15:05 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote: On Thu, 18 Sep 2014 21:54:58 +0300 Michael S. Tsirkin m...@redhat.com wrote: Current support for bus master (clearing OK bit) together

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Greg Kurz
On Wed, 17 Sep 2014 20:39:25 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: On Sun, 14 Sep 2014 21:30:36 +0300 Michael S. Tsirkin m...@redhat.com wrote: Current support for bus master (clearing OK bit) together

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Greg Kurz
On Mon, 6 Oct 2014 19:26:21 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: On Wed, 17 Sep 2014 20:39:25 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: On Sun, 14

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Greg Kurz
On Mon, 6 Oct 2014 20:25:04 +0300 Michael S. Tsirkin m...@redhat.com wrote: [...] BTW I reverted that patch, and to fix migration, I'm thinking about applying the following patch on top of master. Michael, I could force the migration issue with a rhel65 guest thanks to the following

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Greg Kurz
On Mon, 13 Oct 2014 12:01:07 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: On Mon, 6 Oct 2014 20:25:04 +0300 Michael S. Tsirkin m...@redhat.com wrote: [...] BTW I reverted that patch, and to fix migration, I'm thinking

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Greg Kurz
On Mon, 13 Oct 2014 14:09:54 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: On Mon, 6 Oct 2014 20:25:04 +0300 Michael S. Tsirkin m...@redhat.com wrote: [...] BTW I reverted that patch, and to fix migration, I'm thinking

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Greg Kurz
is set. As this is needed for 2.1 for both pc and ppc, move PC_COMPAT macros from pc.h to a new common header. Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com Tested-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Alexander, could you pls

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Greg Kurz
. - For compat machine types, set PCI_COMMAND if DRIVER_OK is set. As this is needed for 2.1 for both pc and ppc, move PC_COMPAT macros from pc.h to a new common header. Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com Tested-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-21 Thread Greg Kurz
. As this is needed for 2.1 for both pc and ppc, move PC_COMPAT macros from pc.h to a new common header. Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com Tested-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Alexander, could you pls ack

Re: [Qemu-devel] [PATCH] target-arm: Add guest cpu endianness determination for virtio in KVM ARM64

2014-10-28 Thread Greg Kurz
On Tue, 28 Oct 2014 12:08:01 +0530 Pranavkumar Sawargaonkar pranavku...@linaro.org wrote: This patch implements a fucntion pointer virtio_is_big_endian() from CPUClass structure for arm64. Function aarch64_cpu_virtio_endianness() is added to determine and returns the guest cpu endianness to

Re: [Qemu-devel] [PATCH RFC 07/11] dataplane: allow virtio-1 devices

2014-10-28 Thread Greg Kurz
On Tue, 7 Oct 2014 16:40:03 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. It also affects hw/virtio/virtio-pci.c: In file included from

Re: [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices

2014-10-28 Thread Greg Kurz
On Tue, 7 Oct 2014 16:40:01 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: Introduce a helper function to indicate whether a virtio device is operating in legacy or virtio standard mode. It may be used to make decisions about the endianess of virtio accesses and other virtio-1

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 1/2] vhost: add VHOST_VRING_F_BYTESWAP flag

2014-11-03 Thread Greg Kurz
On Mon, 3 Nov 2014 16:29:31 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Wed, 29 Oct 2014 09:42:09 +0100 Cédric Le Goater c...@fr.ibm.com wrote: When the guest and the host have a different endian order, the data being accessed in the vring queues needs to be byteswapped.

Re: [Qemu-devel] How to access guest memory from qemu device internal

2014-11-20 Thread Greg Kurz
On Thu, 20 Nov 2014 21:25:18 +0800 (GMT+08:00) Kaiyuan kaiyu...@tju.edu.cn wrote: Hello, all I added a custom device to qemu. This device is attached to sysbus by mmio and has an address register in which device should access the guest memory the register point to. I write a bare-metal

Re: [Qemu-devel] [PATCH RFC v2 07/12] dataplane: allow virtio-1 devices

2014-11-25 Thread Greg Kurz
On Tue, 25 Nov 2014 14:24:18 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- We still have the same error as

Re: [Qemu-devel] [PATCH RFC v3 07/12] dataplane: allow virtio-1 devices

2014-11-26 Thread Greg Kurz
On Wed, 26 Nov 2014 18:28:38 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Build is ok now. Acked-by: Greg

Re: [Qemu-devel] [PATCH RFC v3 05/12] virtio: introduce legacy virtio devices

2014-11-26 Thread Greg Kurz
On Wed, 26 Nov 2014 18:28:36 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Introduce a helper function to indicate whether a virtio device is operating in legacy or virtio standard mode. It may be used to make decisions about the endianess of virtio accesses and other virtio-1

Re: [Qemu-devel] [PATCH] Fix for crash after migration in virtio-rng on bi-endian targets

2014-11-27 Thread Greg Kurz
-by: Greg Kurz gk...@linux.vnet.ibm.com -- Greg Did you try this on x86 guests, or with multiple rng devices? (keeping context for Greg) Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/virtio/virtio-rng.c | 15 --- 1 file changed, 8 insertions(+), 7

Re: [Qemu-devel] [PATCH] Fix for crash after migration in virtio-rng on bi-endian targets

2014-11-28 Thread Greg Kurz
On Fri, 28 Nov 2014 09:14:46 + Peter Maydell peter.mayd...@linaro.org wrote: On 27 November 2014 at 09:26, Markus Armbruster arm...@redhat.com wrote: David Gibson da...@gibson.dropbear.id.au writes: VirtIO devices now remember which endianness they're operating in in order to support

Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h

2014-12-15 Thread Greg Kurz
On Fri, 12 Dec 2014 16:20:16 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Wed, Dec 10, 2014 at 07:44:04PM +, Peter Maydell wrote: On 10 December 2014 at 19:26, Eduardo Habkost ehabk...@redhat.com wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- exec.c

[Qemu-devel] [PATCH] Fix name error in migration stream analyzation script

2015-02-07 Thread Greg Kurz
, line 250, in read self.file.readvar(n_valid * HASH_PTE_SIZE_64) NameError: global name 'HASH_PTE_SIZE_64' is not defined Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- scripts/analyze-migration.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/analyze

[Qemu-devel] [PATCH] QJSON: fix typo in author's email address

2015-02-07 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- qjson.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qjson.c b/qjson.c index b24..0cda269 100644 --- a/qjson.c +++ b/qjson.c @@ -4,7 +4,7 @@ * Copyright Alexander Graf * * Authors: - * Alexander Graf ag

<    1   2   3   4   5   6   7   8   9   10   >