log.
Each log entry must match the file log GUID in order to be valid (along
with other criteria). Once we have flushed all valid log entries, we
marked the file log GUID to be zero, which indicates a buffer with no
valid entries.
Signed-off-by: Jeff Cody
---
block/Makefile.objs | 2 +-
b
updated
in the header.
Signed-off-by: Jeff Cody
---
block/vhdx-log.c | 282 +++
block/vhdx.h | 3 +
2 files changed, 285 insertions(+)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 0284729..ee5583c 100644
--- a/block/vhdx-log.c
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody
---
block/Makefile.objs | 2 +-
block/vhdx
This is preperation for vhdx_create(). The ability to write headers,
and calculate the number of BAT entries will be needed within the
create() functions, so move this relevant code into helper functions.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 121
--- ~ ~ ~ ---.
| (F) | (G) |(H)|
| Journal Log | BAT / Bitmap | Metadata | data ..
| | | |
. ~ --- ~ ~ ~ ---.
1MB (var.)
In preparation for vhdx_create(), move more endian translation
functions out to vhdx-endian.c.
Signed-off-by: Jeff Cody
---
block/vhdx-endian.c | 75 +
block/vhdx.c| 20 +++---
block/vhdx.h| 9 ++-
3 files changed
file,
post log replay, matched.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/068 | 67 +
tests/qemu-iotests/068.out | 8 +++
tests/qemu-iotests/group | 1 +
.../sample_images/iotest-dirtylog-10G
true uint64_t file offset.
This replaces those steps with just a bit mask, to get rid of the lower
20 bits instead.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 6 ++
block/vhdx.h | 1 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 050f071
This removes the IMGFMT_GENERIC blocker for read-only, so existing
iotests run read/write tests for vhdx images created by qemu-img (e.g.
tests 001, 002, 003).
In addition, this updates the sample image test for the Hyper-V
created image, to verify we can write it as well.
Signed-off-by: Jeff
wording in comments,
and those have been fixed up as well.
Signed-off-by: Jeff Cody
---
block/vhdx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.h b/block/vhdx.h
index 15486c7..f222d18 100644
--- a/block/vhdx.h
+++ b/block/vhdx.h
@@ -58,7 +58,7 @@
typedef
The non-global option output is suppresed in _make_test_img() for
output verification in the 0?? tests. This adds suppression for
the vhdx-unique options as well. This allows check -vhdx to run
successfully.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.rc | 5 -
1 file changed
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 212
about, but are not required).
This adds the capability to register a region for later checking, and
to check against registered regions for any overlap.
Also, if neither the BAT or Metadata region tables are found, return
error.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 82
Signed-off-by: Jeff Cody
---
block/vhdx.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 241703a..3f06ce3 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -778,6 +778,17 @@ exit:
}
+static void vhdx_close
ail due to pathnames with spaces, and
are not addressed in this series: 059, 067.
Jeff Cody (7):
block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests
block: qemu-iotests, fix _make_test_img() to work with spaced
pathnames
block: qemu-iotests, add quotes to $TEST_IMG.base us
There were still instances of $TEST_IMG not being properly quoted.
This was in the usage of a string built up for a 'for' loop; modify
the loop so we can quote $TEST_IMG properly.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/019 | 6 +++---
1 file changed, 3 insertions(+), 3
_make_test_img() currently works with spaced pathnames only when not
specifying a backing file. This fixes it so that the backing file
argument is properly quoted.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.rc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions
$TEST_IMG.base is used unquoted. Add quotes so that pathnames with
spaces are supported.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/017 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/017 b/tests/qemu-iotests/017
index 45f2c0b..aba3faf 100755
--- a
Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
index f85b4ce..8bade92 100755
--- a/tests/qemu-iotests
There were still a couple of instances of unquoted usage of
$TEST_IMG and $TEST_IMG.orig. Quoted these so they will not fail
on pathnames with spaces in them.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/051 | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests
When creating images with backing files in the test, the backing
file argument was not quoted properly. This caused the test to fail
when run from a pathname with a space. Pass the backing argument in
with the -b option to _make_test_img, so it can be properly quoted.
Signed-off-by: Jeff Cody
The usage of $TEST_IMG was not properly quoted everywhere in
common.pattern.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.pattern | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/common.pattern
b/tests/qemu-iotests/common.pattern
On Fri, Nov 01, 2013 at 06:04:19AM +0100, Philipp Hahn wrote:
> Hello,
>
> sorry for high-jacking this thread, but I have a questing regarding VHD
> (without the X): Xen-4.3 switched to upstream QEMUs support for VHD. The
> dropped their own VHD implementation in blktap2, which supported backing
On Thu, Oct 31, 2013 at 02:10:48PM +0100, Stefan Hajnoczi wrote:
> On Wed, Oct 30, 2013 at 10:44:37AM -0400, Jeff Cody wrote:
> > This patch series contains the initial VHDX log parsing, replay,
> > write support, and image creation.
> >
> > === v8 changes ===
>
On Tue, Mar 04, 2014 at 09:12:14PM +0100, Stefan Hajnoczi wrote:
> On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber wrote:
> > Supply a required Error ** argument to qemu_gluster_init() in
> > qemu_gluster_reopen_prepare(), as done in qemu_gluster_open().
> >
> > Cc: Stefan Hajnoczi
> > Signed-off-
On 32-bit hosts, some compilers will warn on too large integer constants
for constants that are 64-bit in length. Explicitly put a 'ULL' suffix
on those defines.
Reported-by: Alexander Graf
Signed-off-by: Jeff Cody
---
block/vhdx.h | 6 +++---
1 file changed, 3 insertions(+), 3
On Wed, Mar 12, 2014 at 12:16:04PM +0100, Kevin Wolf wrote:
> Am 24.01.2014 um 14:48 hat Jeff Cody geschrieben:
> > On Fri, Jan 24, 2014 at 02:33:19PM +0100, Kevin Wolf wrote:
> > > Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben:
> > > > Having both read-only=on and
Both tests 019 and 086 need proper quotations to work with pathnames
that contain spaces.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/019 | 2 +-
tests/qemu-iotests/086 | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests
This adds some common functionality to control QEMU for qemu-iotests.
Additionally, test 085 is updated to use this new functionality.
Some minor fixups along the way, to clear up spaced pathname issues,
for common.rc, test 019, and test 086.
Jeff Cody (4):
block: qemu-iotests - add
$2 is not seen in that time (anywhere in the response), then
the test fails. Primarily used by _send_qemu_cmd, but could
be useful standalone, as well.
4. _cleanup_qemu()
Kills the running QEMU processes, and removes the fifos.
Signed-off-by: Jeff Cody
---
tests
The _rm_test_img() function in common.rc did not quote the image
file, which left droppings in the scratch directory (and performed
a potentially unsafe rm -f).
This adds the necessary quotes.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.rc | 4 ++--
1 file changed, 2 insertions
The new functionality of common.qemu implements the QEMU control
and communication functionality that was originally in test 085.
This removes that now-duplicate functionality, and uses the
common.qemu functions.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/085 | 73
On Wed, Mar 19, 2014 at 02:39:25PM +0100, Benoît Canet wrote:
> The Monday 17 Mar 2014 à 21:24:37 (-0400), Jeff Cody wrote :
> > This creates some common functions for bash language qemu-iotests
> > to control, and communicate with, a running QEMU process.
> >
> >
On Wed, Mar 19, 2014 at 08:28:07AM -0600, Eric Blake wrote:
> On 03/19/2014 08:19 AM, Jeff Cody wrote:
>
> >>> +then
> >>> +_timed_wait_for ${h} "${@: -1}"
> >>
> >> You have done shift before this. Aren't ${*} the remai
fset 268435456
> +128 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +read 134217728/134217728 bytes at offset 402653184
> +128 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +read 134217728/134217728 bytes at offset 536870912
> +128 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +read 134217728/134217728 bytes at offset 671088640
> +128 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +read 134217728/134217728 bytes at offset 805306368
> +128 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +read 134217728/134217728 bytes at offset 939524096
> +128 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> read 60817408/60817408 bytes at offset 103809024
> 58 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> *** done
> --
> 2.1.0
>
Reviewed-by: Jeff Cody
This fixes an off-by-one error introduced in 9a29e18. Both qcow and
qcow2 need to make sure to leave room for string terminator '\0' for
the backing file, so the max length of the non-terminated string is
either 1023 or PATH_MAX - 1.
Reported-by: Kevin Wolf
Signed-off-by: Jeff Cody
On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote:
> Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben:
> > Am 09.02.2015 um 17:09 schrieb Kevin Wolf:
> > >The CHS calculation as done per the VHD spec imposes a maximum
> > >image size of ~127 GB. Real VHD images exist that are larger tha
On Tue, Feb 10, 2015 at 02:54:39PM +0100, Kevin Wolf wrote:
> Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben:
> > On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote:
> > > Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben:
> > > > Am 09.02.2015 um 17:09 sc
The size compared should be PATH_MAX, rather than sizeof(char *).
Reported-by: Paolo Bonzini
Signed-off-by: Jeff Cody
---
block/vmdk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 7d079ad..8410a15 100644
--- a/block/vmdk.c
+++ b/block
On Thu, Apr 02, 2015 at 01:24:02PM +0200, Kevin Wolf wrote:
> Am 02.04.2015 um 12:58 hat Michael Tokarev geschrieben:
> > 01.04.2015 15:34, Kevin Wolf wrote:
> > []
> > > Overriding the backing file should work like this:
> > >
> > > -drive file=...,backing.file.filename=/dev/fdset/2
> >
> >
On Thu, Apr 02, 2015 at 07:07:23AM -0600, Eric Blake wrote:
> On 04/02/2015 06:04 AM, Michael Tokarev wrote:
> > 02.04.2015 14:24, Kevin Wolf wrote:
> > []
> >>> But overall, I think qemu-system should not modify backing
> >>> file name in this case.
> >>
> >> So you would leave the backing file wi
On Fri, Apr 03, 2015 at 01:49:01PM -0600, Eric Blake wrote:
> On 04/02/2015 10:28 PM, Jeff Cody wrote:
>
> >>
> >> Basically, once a commit crosses more than one file, all intermediate
> >> files are useless and might as well be discarded.
>
> That's
On Tue, Dec 23, 2014 at 05:07:16AM -0500, Lokesha, Amulya wrote:
>
> -Original Message-
> From: Jeff Cody [mailto:jc...@redhat.com]
> Sent: Wednesday, December 17, 2014 5:44 PM
> To: Lokesha, Amulya
> Cc: Max Reitz; qemu-devel@nongnu.org; kw...@redhat.com; stefa...@re
On Wed, Jan 07, 2015 at 03:30:28PM +, Stefan Hajnoczi wrote:
> On Thu, Dec 04, 2014 at 01:31:38PM -, AMULYA L wrote:
> > Public bug reported:
> >
> > We are trying to convert a VMDK image to VHDX image for deploy to HyperV
> > Server ( SCVMM 2012 SP1) using qemu-img.
> > We tried converti
On Sun, Jan 11, 2015 at 11:33:31PM -0500, Lokesha, Amulya wrote:
> Please find comments inline
>
> -Original Message-
> From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Jeff
> Cody
> Sent: Wednesday, January 07, 2015 9:11 PM
> To: Lokesha,
es match
the most common usage.
This patch also updates two block drivers that still use 1024-byte sized
arrays for 'backing_file'.
Signed-off-by: Jeff Cody
---
block/mirror.c| 2 +-
block/qapi.c | 2 +-
include/block/block_int.h | 8
3 files change
about are in the diff context and
not the actual changes, so I did not fix them up to satisfy checkpatch.
Changes from v2:
- Change stack allocations to dybnamic (Thanks Kevin)
- Update qcow/qcow2 ti perform safety checks for platforms that
have a PATH_MAX < 1024 (thanks John,
Rather than allocate PATH_MAX bytes on the stack, use g_strndup() to
dynamically allocate the string, and add an exit label for cleanup.
Signed-off-by: Jeff Cody
---
block.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index cbe4a32..39cd7a6
Functions 'vmdk_parse_extents' and 'vmdk_create' allocate several
PATH_MAX sized arrays on the stack. Make these dynamically allocated.
Signed-off-by: Jeff Cody
---
block/vmdk.c | 64
1 file changed, 38 inserti
Rather than declaring 'backing_filename2' on the stack in
bdrv_quiery_image_info(), dynamically allocate it on the heap.
Signed-off-by: Jeff Cody
---
block/qapi.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index a6fd6f
ename[] is populated by bdrv_get_backing_filename(), a
string size of 1 will always only return '\0';
Signed-off-by: Jeff Cody
---
block/mirror.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 9019d1b..4056164 100644
--- a
Keep the variable 'ret' something that is returned by the function it is
defined in. For the return value of 'sscanf', use a more meaningful
variable name.
Signed-off-by: Jeff Cody
---
block/vmdk.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff
stack usage for qemu-img does not seem worrisome.
Signed-off-by: Jeff Cody
---
block/qapi.c | 4 ++--
block/qcow.c | 2 +-
block/qcow2.c | 3 ++-
block/vvfat.c | 4 ++--
include/block/block_int.h | 8
qemu-img.c| 4 ++-
not there
(PAYLOAD_BLOCK_UNDEFINED, PAYLOAD_BLOCK_NOT_PRESENT,
PAYLOAD_BLOCK_UNMAPPED) have multiple options for what FileOffsetMB may
be set to, and '0' is explicitly called out as an option.
For all the above states, we will also just set the FileOffsetMB value
to 0.
Signed-off-by: Jeff Cod
On Mon, Jan 19, 2015 at 03:19:05PM +, Lokesha, Amulya wrote:
>
>
> -Original Message-
> From: Jeff Cody [mailto:jc...@redhat.com]
> Sent: Tuesday, January 13, 2015 9:18 AM
> To: Lokesha, Amulya
> Cc: Bug 1399191; Geoffroy, Daniel
> Subject: Re: [Qemu-devel] [
On Thu, Jan 22, 2015 at 11:37:54AM +, Stefan Hajnoczi wrote:
> On Tue, Jan 20, 2015 at 12:31:31PM -0500, Jeff Cody wrote:
> > Rather than allocate PATH_MAX bytes on the stack, use g_strndup() to
> > dynamically allocate the string, and add an exit label for cleanup.
> &g
xed typo in commit message (Thanks Stefan)
Changes from v2:
- Change stack allocations to dybnamic (Thanks Kevin)
- Update qcow/qcow2 ti perform safety checks for platforms that
have a PATH_MAX < 1024 (thanks John, Kevin).
Jeff Cody (6):
block: vmdk - make ret variable us
Functions 'vmdk_parse_extents' and 'vmdk_create' allocate several
PATH_MAX sized arrays on the stack. Make these dynamically allocated.
Signed-off-by: Jeff Cody
---
block/vmdk.c | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
stack usage for qemu-img does not seem worrisome.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/qapi.c | 4 ++--
block/qcow.c | 2 +-
block/qcow2.c | 3 ++-
block/vvfat.c | 4 ++--
include/block/blo
Keep the variable 'ret' something that is returned by the function it is
defined in. For the return value of 'sscanf', use a more meaningful
variable name.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/vmdk.c | 14 -
Rather than declaring 'backing_filename2' on the stack in
bdrv_query_image_info(), dynamically allocate it on the heap.
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/qapi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/qapi.c b/block/qa
ename[] is populated by bdrv_get_backing_filename(), a
string size of 1 will always only return '\0';
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/mirror.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c b
As Stefan pointed out, the variable 'filename' in bdrv_commit is unused,
despite being maintained in previous patches.
With this patch, get rid of the variable for good.
Signed-off-by: Jeff Cody
---
block.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block.c b/block.c
ind
On Thu, Jan 22, 2015 at 05:20:20AM +, Lokesha, Amulya wrote:
>
>
[...]
>
>> Yes, I have sent a patch that I believe fixes the issue (I cc'ed you on
>> the patch). If you wouldn't mind testing, and verifying that it fixes
>> your particular issue, that would be great. I test
On Thu, Jan 22, 2015 at 04:24:45PM +, Lokesha, Amulya wrote:
>
> -Original Message-
> From: Jeff Cody [mailto:jc...@redhat.com]
> Sent: Thursday, January 22, 2015 9:33 PM
> To: Lokesha, Amulya
> Cc: Bug 1399191; Geoffroy, Daniel
> Subject: Re: [Qemu-devel] [Bug
On Tue, Nov 04, 2014 at 10:39:36AM +0100, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 30.10.2014 um 13:49 hat Markus Armbruster geschrieben:
> >> Kevin Wolf writes:
> >>
> >> > Am 29.10.2014 um 14:54 hat Markus Armbruster geschrieben:
> >> >> Kevin Wolf writes:
> >> >> > Instead, le
On Tue, Nov 04, 2014 at 07:45:38PM +0100, Markus Armbruster wrote:
> I'll try to explain all solutions fairly. Isn't easy when you're as
> biased towards one of them as I am. Please bear with me.
>
>
> = The trust boundary between image contents and meta-data =
>
> A disk image consists of ima
rsed and the image is reopened as bs->file to keep the
> rest of the driver untouched. This would be changed later with more
> features added.
>
> Signed-off-by: Denis V. Lunev
> Acked-by: Roman Kagan
> CC: Jeff Cody
> CC: Kevin Wolf
&
On Wed, Oct 29, 2014 at 04:38:08PM +0300, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev
> Acked-by: Roman Kagan
> CC: Jeff Cody
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> tests/qemu-iotests/076| 6 ++
> te
his is available in DiskDescriptor.xml ONLY. There
> is no such data in the image header.
>
> There share of such images could be evaluated as 6-8% according to the
> statistics in my hands.
>
> This patch obtains proper value from XML and applies it on reading.
>
> Sig
h data in the image header.
>
> This patch contains very simple image with padding and corresponding
> XML disk descriptor created in authentic way.
>
> Signed-off-by: Denis V. Lunev
> Acked-by: Roman Kagan
> CC: Jeff Cody
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
&g
On Wed, Oct 29, 2014 at 04:38:11PM +0300, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev
> Acked-by: Roman Kagan
> CC: Jeff Cody
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
On Thu, Nov 06, 2014 at 02:57:07PM +0100, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 04.11.2014 um 19:45 hat Markus Armbruster geschrieben:
[...]
> >> I proposed something less radical, namely to keep guessing the image
> >> format, but base the guess on trusted meta-data only: file
On Thu, Nov 06, 2014 at 01:53:35PM +0100, Max Reitz wrote:
> On 2014-11-06 at 13:26, Markus Armbruster wrote:
> >Max Reitz writes:
> >
> >>On 2014-11-04 at 19:45, Markus Armbruster wrote:
> >>>I'll try to explain all solutions fairly. Isn't easy when you're as
> >>>biased towards one of them as I
On Thu, Nov 06, 2014 at 03:14:19PM +0100, Eric Blake wrote:
> On 11/06/2014 02:57 PM, Markus Armbruster wrote:
>
> >> Yes, you can override the backing file driver (backing.driver=raw should
> >> do the trick). Not really user-friendly, especially with long backing
> >> file chains, but it happens
On Fri, Nov 07, 2014 at 04:21:38PM +0100, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 06.11.2014 um 14:57 hat Markus Armbruster geschrieben:
> >> Kevin Wolf writes:
> >>
> >> > Am 04.11.2014 um 19:45 hat Markus Armbruster geschrieben:
> >> >> I'll try to explain all solutions fairly.
On Mon, Nov 10, 2014 at 11:30:25AM +0100, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 10.11.2014 um 09:12 hat Markus Armbruster geschrieben:
> >> Jeff Cody writes:
> >> > So that would mean .img would always require format=, right?
> >> >
In commit 7074786, the need for NOCOW was removed from the vdi driver,
as we removed the the posix calls. However, the BLOCK_OPT_NOCOW was not
removed from vdi_create_opts. This was a mistake - remove the opt from
there as well.
Signed-off-by: Jeff Cody
---
block/vdi.c | 5 -
1 file
In commit fef6070, the need for NOCOW was removed from the vpc driver,
as we removed the the posix calls. However, the BLOCK_OPT_NOCOW was not
removed from vpc_create_opts. This was a mistake - remove the opt from
there as well.
Signed-off-by: Jeff Cody
---
block/vpc.c | 5 -
1 file
This removes the unneeded BLOCK_OPT_NOCOW options from vdi
and vpc.
Jeff Cody (2):
block: remove BLOCK_OPT_NOCOW from vdi_create_opts
block: remove BLOCK_OPT_NOCOW from vpc_create_opts
block/vdi.c | 5 -
block/vpc.c | 5 -
2 files changed, 10 deletions(-)
--
1.9.3
On Fri, Dec 05, 2014 at 12:49:22PM +0100, Kevin Wolf wrote:
> Am 05.12.2014 um 11:26 hat Kevin Wolf geschrieben:
> > Like for most other image formats, vhdx images read as all zero in qemu
> > after their creation (we're taking advantage from the fact that qemu has
> > just created the image, becau
On Fri, Dec 05, 2014 at 12:07:19PM +0100, Kevin Wolf wrote:
> Am 05.12.2014 um 11:26 hat Kevin Wolf geschrieben:
> > Like for most other image formats, vhdx images read as all zero in qemu
> > after their creation (we're taking advantage from the fact that qemu has
> > just created the image, becau
: block: vhdx - update PAYLOAD_BLOCK_UNMAPPED value to
match 1.00 spec
3/4: compiling: 44f08c2: block: vhdx - change .vhdx_create default block state
to ZERO
4/4: compiling: 3eb0cd2: block: vhdx - set .bdrv_has_zero_init to
bdrv_has_zero_init_1
Jeff Cody (4):
block: vhdx - remove redundant comments
s the default to 'on', and provides some help
information to warn against setting it to 'off' when using qemu-img
convert.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 6 --
qemu-doc.texi | 6 +-
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/vhdx
Minor cleanup.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 12bfe75..f1e1e2e 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1109,8 +1109,8 @@ static coroutine_fn int vhdx_co_readv
compatibility with any images out in the wild
that may have been created in accordance to the 0.95 spec.
Reported-by: Kevin Wolf
Signed-off-by: Jeff Cody
---
block/vhdx.c | 3 ++-
block/vhdx.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index
Now that new VHDX images will default to BAT block states of
PAYLOAD_BLOCK_ZERO, we can indicate that VHDX has zero init.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vhdx.c b/block/vhdx.c
index ddefc2a..2bbb3ee 100644
--- a/block/vhdx.c
On Fri, Dec 12, 2014 at 09:43:16AM -0500, Lokesha, Amulya wrote:
>Hi Max,
>
>
Please reply in-line, it makes it easier to follow technical
discussions - thanks :)
>
>We applied all the 5 patches from the mail chain I got since the last
>week. Please find attached the patches us
gt; of a syntax error in the file.
>
> Please find my comments inline for your questions
>
> Please let us know if there is anything else you need from us.
>
>
Amulya,
I will try to test this on Windows Server, and see if I can reproduce
what you are seeing.
-Jeff
>
>
On Tue, Apr 14, 2015 at 11:57:35AM +0200, Kevin Wolf wrote:
> Am 11.04.2015 um 05:41 hat Andreas Färber geschrieben:
> > Hi,
> >
> > 001 seems to hang for -qcow (or is not reasonably "quick": >5 min).
> >
> > 033 is failing for -vhdx.
> >
> > (Note that `make check-block` only tests -qcow2, so d
iov2.iov_len);
> sectors_to_write += iov2.iov_len >> BDRV_SECTOR_BITS;
> }
> }
acked-by: Jeff Cody
iov2.iov_len);
Definite bug fix here
> sectors_to_write += iov2.iov_len >> BDRV_SECTOR_BITS;
> }
> }
> --
> 1.8.3.1
>
Acked-by: Jeff Cody
refresh_filename = blkdebug_refresh_filename,
>
> .bdrv_aio_readv = blkdebug_aio_readv,
> --
> 1.8.3.1
>
Reviewed-by: Jeff Cody
different patch:
As we split out the block layer, we will begin using the qemu-block
mailing list as a catchall for all of the block layer subcomponents.
Please CC qemu-bl...@nongnu.org for all block layer patches, including
any that touch the above listed areas.
Signed-off-by: Jeff Cody
On Fri, Mar 06, 2015 at 03:08:29PM -0600, Stefan Hajnoczi wrote:
> On Fri, Mar 06, 2015 at 12:16:06PM -0500, Jeff Cody wrote:
> > The block layer maintainership is being split up into smaller, more
> > manageable pieces.
> >
> > I propose that I take over / assi
Now that active layer block-commit is supported, the 'top' argument
no longer needs to be mandatory.
Change it to optional, with the default being the active layer in the
device chain.
Reviewed-by: Eric Blake
Reviewed-by: Benoit Canet
Signed-off-by: Jeff Cody
---
blockdev.c
u-img rebase -u', with respect to change the backing file string.
Signed-off-by: Jeff Cody
---
blockdev.c | 118 +++
hmp-commands.hx | 16
hmp.c| 16
hmp.h| 1 +
qa
prefix is to aid in identifying it as a qemu-generated name, the
numeric portion is to guarantee uniqueness in a given qemu session, and
the random characters are to further avoid any accidental collisions
with user-specified node-names.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cod
specifying the backing
file string will be treated as an error (there is no overlay image
to modify in that case).
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Signed-off-by: Jeff Cody
--
This simplifies the function bdrv_find_base(), while keeping the
same functionality.
Signed-off-by: Jeff Cody
---
block.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/block.c b/block.c
index 577d4f1..cf29494 100644
--- a/block.c
+++ b/block.c
@@ -4363,20
701 - 800 of 2395 matches
Mail list logo
