Re: [Qemu-devel] summary of current vfio mdev upstreaming status

2016-09-29 Thread Kirti Wankhede
On 9/29/2016 2:47 PM, Neo Jia wrote: > On Thu, Sep 29, 2016 at 04:55:39PM +0800, Jike Song wrote: >> Hi all, >> >> In order to have a clear understanding about the VFIO mdev upstreaming >> status, I'd like to summarize it. Please share your opinions on this, >> and correct my misunderstandings.

Re: [Qemu-devel] summary of current vfio mdev upstreaming status

2016-09-29 Thread Kirti Wankhede
On 9/29/2016 3:16 PM, Xiao Guangrong wrote: > > > On 09/29/2016 05:36 PM, Neo Jia wrote: >> On Thu, Sep 29, 2016 at 05:05:47PM +0800, Xiao Guangrong wrote: >>> >>> >>> On 09/29/2016 04:55 PM, Jike Song wrote: Hi all, In order to have a clear understanding about the VFIO mdev

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-10-03 Thread Kirti Wankhede
On 9/30/2016 10:49 AM, Kirti Wankhede wrote: > ... >>>>>> Hi Daniel, >>>>>> >>>>>> Here you are proposing to add a class named "gpu", which will make all >>>>>> those gpu >>>>>> rela

[Qemu-devel] [PATCH v8 3/6] vfio iommu: Add support for mediated devices

2016-10-10 Thread Kirti Wankhede
- One GPU pass through and one vGPU device - Linux VM hot plug and unplug vGPU device while GPU pass through device exist - Linux VM hot plug and unplug GPU pass through device while vGPU device exist Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@n

[Qemu-devel] [PATCH v8 2/6] vfio: VFIO based driver for Mediated devices

2016-10-10 Thread Kirti Wankhede
operations to vendor driver for mediated devices. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I583f4734752971d3d112324d69e2508c88f359ec --- drivers/vfio/mdev/Kconfig | 6 ++ drivers/vfio/mdev/Makefile | 1 +

[Qemu-devel] [PATCH v8 0/6] Add Mediated device support

2016-10-10 Thread Kirti Wankhede
use mediated device framework. - Moved updated document and example driver to 'vfio-mdev' directory in Documentation. Kirti Wankhede (6): vfio: Mediated device Core driver vfio: VFIO based driver for Mediated devices vfio iommu: Add support for mediated devices docs: Add Documenta

[Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver

2016-10-10 Thread Kirti Wankhede
ern int mdev_register_device(struct device *dev, const struct parent_ops *ops); extern void mdev_unregister_device(struct device *dev); There are no locks to serialize above callbacks in mdev driver and vfio_mdev driver. If required, vendor driver can have locks to serialize above APIs

[Qemu-devel] [PATCH v8 5/6] Add simple sample driver for mediated device framework

2016-10-10 Thread Kirti Wankhede
Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/vfio-mdev/Makefile

[Qemu-devel] [PATCH v8 6/6] Add common functions for SET_IRQS and GET_REGION_INFO ioctls

2016-10-10 Thread Kirti Wankhede
Add common functions for SET_IRQS and to add capability buffer for GET_REGION_INFO ioctls Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Id9e976a2c08b9b2b37da77dac4365ae8f6024b4a --- drivers/vfio/pci/vfio

[Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-10 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d --- Documentation/vfio-mdev/v

Re: [Qemu-devel] [PATCH v9 01/12] vfio: Mediated device Core driver

2016-10-26 Thread Kirti Wankhede
>> Medisted bus driver is responsible to add/delete mediated devices to/from > > Medisted -> Mediated > Thanks for pointing out the typeo. Correcting it. >> VFIO group when devices are bound and unbound to the driver. >> >> 2. Physical device driver interface >> This interface provides vendor

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-26 Thread Kirti Wankhede
On 10/26/2016 12:49 PM, Tian, Kevin wrote: >> From: Alex Williamson [mailto:alex.william...@redhat.com] >> Sent: Monday, October 24, 2016 10:32 AM >> > -static long vfio_unpin_pages(unsigned long pfn, long npage, > - int prot, bool do_accounting) > +static long

Re: [Qemu-devel] [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices

2016-10-26 Thread Kirti Wankhede
>> +static void vfio_mdev_release(void *device_data) >> +{ >> +struct mdev_device *mdev = device_data; >> +struct parent_device *parent = mdev->parent; >> + >> +if (parent->ops->release) > > likely() > >> +parent->ops->release(mdev); >> + >> +module_put(THIS_MODULE);

Re: [Qemu-devel] [PATCH v10 07/19] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-10-27 Thread Kirti Wankhede
On 10/27/2016 5:41 PM, Jike Song wrote: > On 10/27/2016 05:29 AM, Kirti Wankhede wrote: >> Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input >> argument. >> >> Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-27 Thread Kirti Wankhede
On 10/27/2016 12:50 PM, Alexey Kardashevskiy wrote: > On 18/10/16 08:22, Kirti Wankhede wrote: >> VFIO IOMMU drivers are designed for the devices which are IOMMU capable. >> Mediated device only uses IOMMU APIs, the underlying hardware can be >> managed by an IO

Re: [Qemu-devel] [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-10-28 Thread Kirti Wankhede
On 10/28/2016 6:10 PM, Alex Williamson wrote: > On Fri, 28 Oct 2016 15:33:58 +0800 > Jike Song <jike.s...@intel.com> wrote: > >> On 10/27/2016 05:29 AM, Kirti Wankhede wrote: >>> Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers >>>

Re: [Qemu-devel] [PATCH v11 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 5:15 AM, Alex Williamson wrote: > On Sat, 5 Nov 2016 02:40:45 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> >> +int vfio_register_notifier(struct device *dev, struct notifier_block *nb) > > Is the expectation here that this is

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 4:46 AM, Alex Williamson wrote: > On Sat, 5 Nov 2016 02:40:44 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> -static void vfio_unmap_unpin(struct vfio_iommu *iommu, struct vfio_dma *dma) >> +static int __vfio_pin_page_external(struct v

Re: [Qemu-devel] [PATCH v11 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 10:09 PM, Alex Williamson wrote: > On Tue, 8 Nov 2016 19:25:35 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >>>> - >>>> + int (*pin_pages)(void *iommu_data, unsigned long *user_pfn, >>>>

Re: [Qemu-devel] [PATCH v11 13/22] vfio: Introduce common function to add capabilities

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 12:59 PM, Alexey Kardashevskiy wrote: > On 05/11/16 08:10, Kirti Wankhede wrote: >> Vendor driver using mediated device framework should use >> vfio_info_add_capability() to add capabilities. >> Introduced this function to reduce code duplication in vendor driv

Re: [Qemu-devel] [PATCH v11 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 2:16 PM, Alexey Kardashevskiy wrote: > On 05/11/16 08:10, Kirti Wankhede wrote: >> Vendor driver using mediated device framework would use same mechnism to >> validate and prepare IRQs. Introducing this function to reduce code >> replication in multiple driv

Re: [Qemu-devel] [PATCH v11 17/22] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare()

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 2:22 PM, Alexey Kardashevskiy wrote: > On 05/11/16 08:10, Kirti Wankhede wrote: >> Updated vfio_platform_common.c file to use >> vfio_set_irqs_validate_and_prepare() >> >> Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v11 01/22] vfio: Mediated device Core driver

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 2:55 PM, Dong Jia Shi wrote: > * Kirti Wankhede <kwankh...@nvidia.com> [2016-11-05 02:40:35 +0530]: > > Hi Kirti, > > [...] >> diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig >> index da6e2ce77495..23eced02aaf6 100644 >> --- a/dri

Re: [Qemu-devel] [PATCH v11 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 11:16 PM, Alex Williamson wrote: > On Tue, 8 Nov 2016 21:56:29 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 11/8/2016 5:15 AM, Alex Williamson wrote: >>> On Sat, 5 Nov 2016 02:40:45 +0530 >>> Kirt

Re: [Qemu-devel] [PATCH v11 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 2:33 AM, Alex Williamson wrote: > On Sat, 5 Nov 2016 02:40:43 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> static int vfio_dma_do_map(struct vfio_iommu *iommu, >> struct vfio_iommu_type1_dma_map *map) >>

Re: [Qemu-devel] [PATCH v11 00/22] Add Mediated device support

2016-11-06 Thread Kirti Wankhede
On 11/7/2016 9:00 AM, Alexey Kardashevskiy wrote: > On 05/11/16 08:10, Kirti Wankhede wrote: >> This series adds Mediated device support to Linux host kernel. Purpose >> of this series is to provide a common interface for mediated device >> management that can be used

Re: [Qemu-devel] [PATCH v11 00/22] Add Mediated device support

2016-11-06 Thread Kirti Wankhede
Verified that this patch series gets applied cleanly to Linux-next upto: bc33b0ca11e3 Linux 4.9-rc4 Also tested this patch series with above kernel. Thanks, Kirti On 11/7/2016 9:29 AM, Kirti Wankhede wrote: > > > On 11/7/2016 9:00 AM, Alexey Kardashevskiy wrote: >> On 05/11/

Re: [Qemu-devel] [PATCH v11 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-08 Thread Kirti Wankhede
On 11/8/2016 1:06 AM, Alex Williamson wrote: > On Sat, 5 Nov 2016 02:40:39 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> +int vfio_pin_pages(struct device *dev, unsigned long *user_pfn, >> + int npage, int prot, unsigned long *phy

[Qemu-devel] [PATCH v11 03/22] vfio: Rearrange functions to get vfio_group from dev

2016-11-04 Thread Kirti Wankhede
This patch rearranges functions to get vfio_group from device Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 --- drivers/vfio/vfio.c | 23 --- 1 file changed, 1

[Qemu-devel] [PATCH v11 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-04 Thread Kirti Wankhede
and unpin pages. Renamed static functions in vfio_type1_iommu.c to resolve conflicts Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Ia7417723aaae86bec2959ad9ae6c2915ddd340e0 --- drivers/vfio/vfio.c

[Qemu-devel] [PATCH v11 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-04 Thread Kirti Wankhede
should use VFIO_IOMMU_NOTIFY_DMA_UNMAP action to invalidate mappings. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I5910d0024d6be87f3e8d3e0ca0eaeaaa0b17f271 --- drivers/vfio/vfio.c

[Qemu-devel] [PATCH v11 20/22] docs: Sysfs ABI for mediated device framework

2016-11-04 Thread Kirti Wankhede
Added details of sysfs ABI for mediated device framework Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Icb0fd4ed58a2fa793fbcb1c3d5009a4403c1f3ac --- Documentation/ABI/testing/sysfs-bus-vfio-mdev | 111 ++

[Qemu-devel] [PATCH v11 13/22] vfio: Introduce common function to add capabilities

2016-11-04 Thread Kirti Wankhede
Vendor driver using mediated device framework should use vfio_info_add_capability() to add capabilities. Introduced this function to reduce code duplication in vendor drivers. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com&g

[Qemu-devel] [PATCH v11 02/22] vfio: VFIO based driver for Mediated devices

2016-11-04 Thread Kirti Wankhede
operations to vendor driver for mediated devices. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I583f4734752971d3d112324d69e2508c88f359ec --- drivers/vfio/mdev/Kconfig | 9 ++- drivers/vfio/mdev/Makefile| 1 + drive

[Qemu-devel] [PATCH v11 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare()

2016-11-04 Thread Kirti Wankhede
Updated vfio_pci.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I9f3daba89d8dba5cb5b01a8cff420412f30686c7 --- drivers/vfio/pci/vfio_pci.c | 34 +++---

[Qemu-devel] [PATCH v11 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-04 Thread Kirti Wankhede
Add a notifier calback to parent's ops structure of mdev device so that per device notifer for vfio module is registered through vfio_mdev module. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Iafa6f1721aecdd6e50eb93b153b5

[Qemu-devel] [PATCH v11 21/22] docs: Sample driver to demonstrate how to use Mediated device framework.

2016-11-04 Thread Kirti Wankhede
The Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/vfio-mediated-device.txt | 103 ++-

[Qemu-devel] [PATCH v11 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-11-04 Thread Kirti Wankhede
Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com&g

[Qemu-devel] [PATCH v11 22/22] MAINTAINERS: Add entry VFIO based Mediated device drivers

2016-11-04 Thread Kirti Wankhede
Adding myself as a maintainer of mediated device framework, a sub module of VFIO. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I58f6717783e0d4008ca31f4a5c4494696bae8571 --- MAINTAINERS | 9 + 1 file changed,

[Qemu-devel] [PATCH v11 07/22] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-11-04 Thread Kirti Wankhede
Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input argument. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I885fd4cd4a9f66f4ee2c1caf58267464ec239f52 --- drivers/vfio/vfio_iommu_

[Qemu-devel] [PATCH v11 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability()

2016-11-04 Thread Kirti Wankhede
Update msix_sparse_mmap_cap() to use vfio_info_add_capability() Update region type capability to use vfio_info_add_capability() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I52bb28c7875a6da5a79ddad1843e6088aff58a45 --- driv

[Qemu-devel] [PATCH v11 04/22] vfio: Common function to increment container_users

2016-11-04 Thread Kirti Wankhede
This change rearrange functions to have common function to increment container_users Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I8bdeb352bc8439b107ffd519480fd4dc238677f2 --- drivers/vfio

[Qemu-devel] [PATCH v11 00/22] Add Mediated device support

2016-11-04 Thread Kirti Wankhede
lows, bitmask check Kirti Wankhede (22): vfio: Mediated device Core driver vfio: VFIO based driver for Mediated devices vfio: Rearrange functions to get vfio_group from dev vfio: Common function to increment container_users vfio iommu: Added pin and unpin callback funct

[Qemu-devel] [PATCH v11 19/22] docs: Add Documentation for Mediated devices

2016-11-04 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d --- Documentation/vfio-mediated-devi

[Qemu-devel] [PATCH v11 06/22] vfio iommu type1: Update arguments of vfio_lock_acct

2016-11-04 Thread Kirti Wankhede
Updated arguments of vfio_lock_acct to take mm structure as input argument Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I5d3673cc9d3786bb436b395d5f74537f1a36da80 --- drivers/vfio/vfio_iommu_type1.c | 22 ++

[Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-04 Thread Kirti Wankhede
- Linux VM hot plug and unplug GPU pass through device while vGPU device exist Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I295d6f0f2e0579b8d9882bfd8fd5a4194b97bd9a --- drivers/vfio/vfio_iommu_t

[Qemu-devel] [PATCH v11 17/22] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare()

2016-11-04 Thread Kirti Wankhede
Updated vfio_platform_common.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Id87cd6b78ae901610b39bf957974baa6f40cd7b0 --- drivers/vfio/platform/vfio_platform_c

[Qemu-devel] [PATCH v11 01/22] vfio: Mediated device Core driver

2016-11-04 Thread Kirti Wankhede
ocks to serialize above callbacks in mdev driver and vfio_mdev driver. If required, vendor driver can have locks to serialize above APIs in their driver. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I73a5084574270b14541c5294

[Qemu-devel] [PATCH v11 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-04 Thread Kirti Wankhede
MAP is successful. This address space structure is used to track pages pinned by external user in later changes. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I7600f1bea6b384fd589fa72421ccf031bcfd9ac5 --- drivers/vfio/vfio_iomm

[Qemu-devel] [PATCH v11 08/22] vfio iommu type1: Add find_iommu_group() function

2016-11-04 Thread Kirti Wankhede
Add find_iommu_group() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I9d372f1ebe9eb01a5a21374b8a2b03f7df73601f --- drivers/vfio/vfio_iommu_type1.c | 58 - 1 file changed, 34 inser

[Qemu-devel] [PATCH v11 18/22] vfio: Define device_api strings

2016-11-04 Thread Kirti Wankhede
Defined device API strings. Vendor driver using mediated device framework should use corresponding string for device_api attribute. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I42d29f475f02a7132ce13297fbf2b48f1da10995 ---

Re: [Qemu-devel] [PATCH v11 00/22] Add Mediated device support

2016-11-06 Thread Kirti Wankhede
On 11/7/2016 11:45 AM, Alexey Kardashevskiy wrote: > On 07/11/16 14:59, Kirti Wankhede wrote: >> >> >> On 11/7/2016 9:00 AM, Alexey Kardashevskiy wrote: >>> On 05/11/16 08:10, Kirti Wankhede wrote: ... >>>> >>>> Patch series teste

Re: [Qemu-devel] [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework.

2016-10-19 Thread Kirti Wankhede
On 10/18/2016 10:47 PM, Alex Williamson wrote: > On Tue, 18 Oct 2016 10:54:11 +0800 > Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote: > >> * Kirti Wankhede <kwankh...@nvidia.com> [2016-10-18 02:52:12 +0530]: >> >> ...snip... >> >>> +sta

Re: [Qemu-devel] [PATCH v9 01/12] vfio: Mediated device Core driver

2016-10-19 Thread Kirti Wankhede
On 10/19/2016 4:46 AM, Alex Williamson wrote: > On Tue, 18 Oct 2016 02:52:01 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> +static struct mdev_device *__find_mdev_device(struct parent_device *parent, >> +

Re: [Qemu-devel] [PATCH v8 6/6] Add common functions for SET_IRQS and GET_REGION_INFO ioctls

2016-10-12 Thread Kirti Wankhede
On 10/12/2016 4:48 AM, Alex Williamson wrote: > On Tue, 11 Oct 2016 01:58:37 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Add common functions for SET_IRQS and to add capability buffer for >> GET_REGION_INFO ioctls > > Clearly should be two

Re: [Qemu-devel] [PATCH v8 3/6] vfio iommu: Add support for mediated devices

2016-10-14 Thread Kirti Wankhede
On 10/12/2016 4:01 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Tuesday, October 11, 2016 4:29 AM >> > [...] >> diff --git a/drivers/vfio/vfio_iommu_type1.c >> b/drivers/vfio/vfio_iommu_type1.c >> index 2ba19424e4a

[Qemu-devel] [PATCH v9 01/12] vfio: Mediated device Core driver

2016-10-17 Thread Kirti Wankhede
ern int mdev_register_device(struct device *dev, const struct parent_ops *ops); extern void mdev_unregister_device(struct device *dev); There are no locks to serialize above callbacks in mdev driver and vfio_mdev driver. If required, vendor driver can have locks to serialize above APIs

[Qemu-devel] [PATCH v9 10/12] vfio: Add function to get device_api string from vfio_device_info.flags

2016-10-17 Thread Kirti Wankhede
Function vfio_device_api_string() returns string based on flag set in vfio_device_info's flag. This should be used by vendor driver to get string based on flag for device_api attribute. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com&g

[Qemu-devel] [PATCH v9 05/12] vfio: Introduce common function to add capabilities

2016-10-17 Thread Kirti Wankhede
Vendor driver using mediated device framework should use vfio_info_add_capability() to add capabilities. Introduced this function to reduce code duplication in vendor drivers. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com&g

[Qemu-devel] [PATCH v9 08/12] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare()

2016-10-17 Thread Kirti Wankhede
Updated vfio_pci.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I9f3daba89d8dba5cb5b01a8cff420412f30686c7 --- drivers/vfio/pci/vfio_pci.c | 29 +

[Qemu-devel] [PATCH v9 11/12] docs: Add Documentation for Mediated devices

2016-10-17 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d --- Documentation/vfio-mdev/v

[Qemu-devel] [PATCH v9 07/12] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-10-17 Thread Kirti Wankhede
Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com&g

[Qemu-devel] [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework.

2016-10-17 Thread Kirti Wankhede
The Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/vfio-mdev/Makefile

Re: [Qemu-devel] [PATCH v9 06/12] vfio_pci: Update vfio_pci to use vfio_info_add_capability()

2016-10-24 Thread Kirti Wankhede
On 10/21/2016 12:54 AM, Alex Williamson wrote: > On Tue, 18 Oct 2016 02:52:06 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Update msix_sparse_mmap_cap() to use vfio_info_add_capability() >> Update region type capability to use vfio_info_add_capability()

Re: [Qemu-devel] [PATCH v9 05/12] vfio: Introduce common function to add capabilities

2016-10-24 Thread Kirti Wankhede
On 10/21/2016 12:54 AM, Alex Williamson wrote: > On Tue, 18 Oct 2016 02:52:05 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Vendor driver using mediated device framework should use >> vfio_info_add_capability() to add capabilities. >> Introd

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-24 Thread Kirti Wankhede
On 10/21/2016 8:06 PM, Alex Williamson wrote: > On Fri, 21 Oct 2016 15:49:07 +0800 > Jike Song <jike.s...@intel.com> wrote: > >> On 10/18/2016 05:22 AM, Kirti Wankhede wrote: >>> diff --git a/drivers/vfio/vfio_iommu_type1.c >>> b/drivers/vfio/vf

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-20 Thread Kirti Wankhede
Alex, Addressing your comments other than invalidation part. On 10/20/2016 2:32 AM, Alex Williamson wrote: > On Tue, 18 Oct 2016 02:52:04 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> Tested by assigning below combinations of devices to a single VM: >&

Re: [Qemu-devel] [PATCH v9 10/12] vfio: Add function to get device_api string from vfio_device_info.flags

2016-10-20 Thread Kirti Wankhede
On 10/21/2016 1:04 AM, Alex Williamson wrote: > On Tue, 18 Oct 2016 02:52:10 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Function vfio_device_api_string() returns string based on flag set in >> vfio_device_info's flag. This should be used by vendor dr

Re: [Qemu-devel] [PATCH v9 10/12] vfio: Add function to get device_api string from vfio_device_info.flags

2016-10-20 Thread Kirti Wankhede
On 10/21/2016 2:35 AM, Alex Williamson wrote: > On Fri, 21 Oct 2016 01:59:55 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 10/21/2016 1:04 AM, Alex Williamson wrote: >>> On Tue, 18 Oct 2016 02:52:10 +0530 >>> Kirti Wankhede <kwankh.

Re: [Qemu-devel] [PATCH v9 10/12] vfio: Add function to get device_api string from vfio_device_info.flags

2016-10-20 Thread Kirti Wankhede
On 10/21/2016 2:52 AM, Alex Williamson wrote: > On Fri, 21 Oct 2016 02:44:37 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >>>>>> >>>>>> +extern const char *vfio_device_api_string(u32 flags); >>>>>> +

[Qemu-devel] [PATCH v9 03/12] vfio: Rearrange functions to get vfio_group from dev

2016-10-17 Thread Kirti Wankhede
Rearrange functions to have common function to increment container_users. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 --- drivers/vfio

[Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-17 Thread Kirti Wankhede
- One GPU pass through and one vGPU device - Linux VM hot plug and unplug vGPU device while GPU pass through device exist - Linux VM hot plug and unplug GPU pass through device while vGPU device exist Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@n

[Qemu-devel] [PATCH v9 00/12] Add Mediated device support

2016-10-17 Thread Kirti Wankhede
Documentation and sample driver, mtty.c, accordingly. Kirti Wankhede (12): vfio: Mediated device Core driver vfio: VFIO based driver for Mediated devices vfio: Rearrange functions to get vfio_group from dev vfio iommu: Add support for mediated devices vfio: Introduce common function to ad

[Qemu-devel] [PATCH v9 09/12] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare()

2016-10-17 Thread Kirti Wankhede
Updated vfio_platform_common.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Id87cd6b78ae901610b39bf957974baa6f40cd7b0 --- drivers/vfio/platform/vfio_platform_c

[Qemu-devel] [PATCH v9 06/12] vfio_pci: Update vfio_pci to use vfio_info_add_capability()

2016-10-17 Thread Kirti Wankhede
Update msix_sparse_mmap_cap() to use vfio_info_add_capability() Update region type capability to use vfio_info_add_capability() Can't split this commit for MSIx and region_type cap since there is a common code which need to be updated for both the cases. Signed-off-by: Kirti Wankhede <kwa

[Qemu-devel] [PATCH v12 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-14 Thread Kirti Wankhede
these functions. Renamed static functions in vfio_type1_iommu.c to resolve conflicts Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Ia7417723aaae86bec2959ad9ae6c2915ddd340e0 --- drivers/vfio/vfio.c

[Qemu-devel] [PATCH v12 20/22] docs: Sysfs ABI for mediated device framework

2016-11-14 Thread Kirti Wankhede
Added details of sysfs ABI for mediated device framework Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Icb0fd4ed58a2fa793fbcb1c3d5009a4403c1f3ac --- Documentation/ABI/testing/sysfs-bus-vfio-mdev | 111 ++

[Qemu-devel] [PATCH v12 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-14 Thread Kirti Wankhede
should use VFIO_IOMMU_NOTIFY_DMA_UNMAP action to invalidate mappings. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I5910d0024d6be87f3e8d3e0ca0eaeaaa0b17f271 --- drivers/vfio/vfio.c

[Qemu-devel] [PATCH v12 21/22] docs: Sample driver to demonstrate how to use Mediated device framework.

2016-11-14 Thread Kirti Wankhede
The Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/vfio-mediated-device.txt | 103 ++-

[Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-14 Thread Kirti Wankhede
Add a notifier calback to parent's ops structure of mdev device so that per device notifer for vfio module is registered through vfio_mdev module. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Iafa6f1721aecdd6e50eb93b153b5

[Qemu-devel] [PATCH v12 22/22] MAINTAINERS: Add entry VFIO based Mediated device drivers

2016-11-14 Thread Kirti Wankhede
Adding myself as a maintainer of mediated device framework, a sub module of VFIO. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I58f6717783e0d4008ca31f4a5c4494696bae8571 --- MAINTAINERS | 9 + 1 file changed,

[Qemu-devel] [PATCH v12 02/22] vfio: VFIO based driver for Mediated devices

2016-11-14 Thread Kirti Wankhede
operations to vendor driver for mediated devices. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Reviewed-by: Jike Song <jike.s...@intel.com> Change-Id: I583f4734752971d3d112324d69e2508c88f359ec --- drivers/vfio/mdev/Kconfig | 7 ++

[Qemu-devel] [PATCH v12 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-14 Thread Kirti Wankhede
. Since child shares same address space, DMA_UNMAP is successful. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I7600f1bea6b384fd589fa72421ccf031bcfd9ac5 --- drivers/vfio/vfio_iommu_type1.c | 137 +--

[Qemu-devel] [PATCH v12 00/22] Add Mediated device support

2016-11-14 Thread Kirti Wankhede
ices to a single VM: - GPU pass through only - vGPU device only - One GPU pass through and one vGPU device - Linux VM hot plug and unplug vGPU device while GPU pass through device exist - Linux VM hot plug and unplug GPU pass through device while vGPU device exist Tested with Linux 4.9-rc5 Ki

[Qemu-devel] [PATCH v12 18/22] vfio: Define device_api strings

2016-11-14 Thread Kirti Wankhede
Defined device API strings. Vendor driver using mediated device framework should use corresponding string for device_api attribute. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I42d29f475f02a7132ce13297fbf2b48f1da10995 ---

[Qemu-devel] [PATCH v12 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare()

2016-11-14 Thread Kirti Wankhede
Updated vfio_pci.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I9f3daba89d8dba5cb5b01a8cff420412f30686c7 --- drivers/vfio/pci/vfio_pci.c | 34 +++---

[Qemu-devel] [PATCH v12 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability()

2016-11-14 Thread Kirti Wankhede
Update msix_sparse_mmap_cap() to use vfio_info_add_capability() Update region type capability to use vfio_info_add_capability() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I52bb28c7875a6da5a79ddad1843e6088aff58a45 --- driv

[Qemu-devel] [PATCH v12 06/22] vfio iommu type1: Update arguments of vfio_lock_acct

2016-11-14 Thread Kirti Wankhede
Added task structure as input argument to vfio_lock_acct() function. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I5d3673cc9d3786bb436b395d5f74537f1a36da80 --- drivers/vfio/vfio_iommu_type1.c | 30 --

[Qemu-devel] [PATCH v12 04/22] vfio: Common function to increment container_users

2016-11-14 Thread Kirti Wankhede
This change rearrange functions to have common function to increment container_users Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Reviewed-by: Jike Song <jike.s...@intel.com> Change-Id: I8bdeb352bc8439b107ffd519480fd4dc238677f2

[Qemu-devel] [PATCH v12 19/22] docs: Add Documentation for Mediated devices

2016-11-14 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d --- Documentation/vfio-mediated-devi

[Qemu-devel] [PATCH v12 08/22] vfio iommu type1: Add find_iommu_group() function

2016-11-14 Thread Kirti Wankhede
Add find_iommu_group() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Reviewed-by: Jike Song <jike.s...@intel.com> Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> Change-Id: I9d372f1ebe9eb01a5a21374b8a2b03f7df

[Qemu-devel] [PATCH v12 03/22] vfio: Rearrange functions to get vfio_group from dev

2016-11-14 Thread Kirti Wankhede
This patch rearranges functions to get vfio_group from device Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Reviewed-by: Jike Song <jike.s...@intel.com> Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 --- driver

[Qemu-devel] [PATCH v12 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-11-14 Thread Kirti Wankhede
Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com&g

[Qemu-devel] [PATCH v12 01/22] vfio: Mediated device Core driver

2016-11-14 Thread Kirti Wankhede
ocks to serialize above callbacks in mdev driver and vfio_mdev driver. If required, vendor driver can have locks to serialize above APIs in their driver. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Reviewed-by: Jike Song <jike.s...@i

[Qemu-devel] [PATCH v12 07/22] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-11-14 Thread Kirti Wankhede
Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input argument. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I885fd4cd4a9f66f4ee2c1caf58267464ec239f52 --- drivers/vfio/vfio_iommu_

[Qemu-devel] [PATCH v12 10/22] vfio iommu type1: Add support for mediated devices

2016-11-14 Thread Kirti Wankhede
gh device exist - Linux VM hot plug and unplug GPU pass through device while vGPU device exist Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I295d6f0f2e0579b8d9882bfd8fd5a4194b97bd9a --- drivers/vfio/vfi

[Qemu-devel] [PATCH v12 13/22] vfio: Introduce common function to add capabilities

2016-11-14 Thread Kirti Wankhede
is documented in a uapi header. Changing vfio_info_cap_shift symbol to be available to all drivers. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I6fca329fa2291f37a2c859d0bc97574d9e2ce1a6 --- drivers/vfio/

[Qemu-devel] [PATCH v12 17/22] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare()

2016-11-14 Thread Kirti Wankhede
Updated vfio_platform_common.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: Id87cd6b78ae901610b39bf957974baa6f40cd7b0 --- drivers/vfio/platform/vfio_platform_c

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-15 Thread Kirti Wankhede
On 11/15/2016 12:57 PM, Alexey Kardashevskiy wrote: > On 15/11/16 17:33, Kirti Wankhede wrote: >> >> >> On 11/15/2016 10:47 AM, Alexey Kardashevskiy wrote: >>> On 08/11/16 17:52, Alexey Kardashevskiy wrote: >>>> On 05/11/16 08:10, Kirti Wankhede wr

Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-15 Thread Kirti Wankhede
On 11/15/2016 12:15 PM, Jike Song wrote: > On 11/14/2016 11:42 PM, Kirti Wankhede wrote: >> Add a notifier calback to parent's ops structure of mdev device so that per >> device notifer for vfio module is registered through vfio_mdev module. >> >> Signed-off

<    1   2   3   4   5   6   7   8   9   10   >