-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 19091a3..5bcbe71 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -108,3 +108,7 @@ static TYPE raw_has_zero_init(BlockDriverState
see how this already accounts
for 100+ SLOC roughly...
The implementations of bdrv_co_readv and bdrv_co_writev should also call
BLKDBG_EVENT on bs-file too, before forwarding to bs-file. The events
to be generated are BLKDBG_READ_AIO and BLKDBG_WRITE_AIO.
Signed-off-by: Laszlo Ersek ler
-off-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 5bcbe71..86e018d 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -112,3 +112,23 @@ static TYPE
On 08/05/13 15:03, Paolo Bonzini wrote:
- Original Message -
From: Laszlo Ersek ler...@redhat.com
To: Paolo Bonzini pbonz...@redhat.com
Sent: Monday, August 5, 2013 2:43:46 PM
Subject: Re: [PATCH 1/2] raw: add license header
On 08/02/13 00:27, Paolo Bonzini wrote:
On 08/01/2013
and
commit 7c80ab3f21f0b1342f23057d4345ae266c7348d9
Author: Jes Sorensen jes.soren...@redhat.com
Date: Fri Dec 17 16:02:39 2010 +0100
block/qcow2.c: rename qcow_ functions to qcow2_
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c | 13 -
1 files
Incoming function prototypes and outgoing function calls must match
reality. Implemented using the struct BlockDriver definition in
include/block/block_int.h, and gcc errors warnings.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
block/Makefile.objs |2 +-
block/raw_bsd.c | 81
2010 +
Fix OpenBSD build
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c | 38 +-
1 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 12debb2..79916c4 100644
--- a/block
On 08/16/13 15:39, Yaodong Yang wrote:
Hello everyone,
in QEMU 1.5.1, block-migration.c, there is a function below:
static void alloc_aio_bitmap(BlkMigDevState *bmds)
{
BlockDriverState *bs = bmds-bs;
int64_t bitmap_size;
bitmap_size = (bdrv_getlength(bs)
On 08/16/13 18:00, Alex Williamson wrote:
Since commit 23326164 we align access sizes to match the alignment of
the address, but we don't align the access size itself. This means we
let illegal access sizes (ex. 3) slip through if the address is
sufficiently aligned (ex. 4). This results in
:)
Reviewed-by: Laszlo Ersek ler...@redhat.com
(Bit-counting is a great complement to the Saturday morning espresso :))
(side point)
On 08/17/13 10:23, Laszlo Ersek wrote:
if (l = access_size_max) {
return access_size_max;
}
return 1 max(3, lmb(l));
lol, of course this should have been min()...
Alex's patch is OK of course.
Laszlo
to be modified. OK.
Reviewed-by: Laszlo Ersek ler...@redhat.com
insertions(+), 13 deletions(-)
Reviewed-by: Laszlo Ersek ler...@redhat.com
with ram_size the global.)
The rest of the code below this hunk (in the full source file, not just
in the patch) alternates between RAM_size / args-ram_size and
ram_size quite schizophrenically too; see eg. FW_CFG_RAM_SIZE.
Anyway the patch only improves things.
Reviewed-by: Laszlo Ersek ler
++
hw/ppc/mpc8544ds.c | 18 ++
2 files changed, 12 insertions(+), 24 deletions(-)
Reviewed-by: Laszlo Ersek ler...@redhat.com
at all. If
ram_size is a well-founded global, then let's treat it as such. Whatever.
Reviewed-by: Laszlo Ersek ler...@redhat.com
missed anything.
Reviewed-by: Laszlo Ersek ler...@redhat.com
Eric,
On 08/16/13 15:18, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
This gets rid of one of the last get_param_value() users, makes
multiple -smbios work sanely, cleans up the gross side effect in
qemu_uuid_parse(), and more. Topped off with a little feature in the
On 08/19/13 11:24, Markus Armbruster wrote:
Laszlo Ersek ler...@redhat.com writes:
Please always use
-O/path/to/order_file
when invoking git-format-patch.
The contents of order_file should be minimally
configure
Makefile*
*.json
*.h
*.c
It's much easier to review
On 08/13/13 00:43, Michael S. Tsirkin wrote:
Migration code assumes that each RAM block is a multiple of target page
size.
Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro
call in qemu_ram_alloc_from_ptr() [exec.c]?
We can fix this in a variety of ways, the simplest
On 08/19/13 12:21, Peter Maydell wrote:
On 19 August 2013 10:59, Laszlo Ersek ler...@redhat.com wrote:
On 08/13/13 00:43, Michael S. Tsirkin wrote:
Migration code assumes that each RAM block is a multiple of target page
size.
Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN
On 08/13/13 00:43, Michael S. Tsirkin wrote:
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but
they are not backed by RAM so they don't get migrated.
Can you please elaborate on this? Do you mean the 384 KB range between
640KB and 1MB that is covered by RAMBlock, but no
On 08/19/13 13:06, Laszlo Ersek wrote:
On 08/13/13 00:43, Michael S. Tsirkin wrote:
@@ -646,6 +669,7 @@ int rom_add_file(const char *file, const char *fw_dir,
if (rom-fw_file fw_cfg) {
const char *basename;
char fw_file_name[56];
+void *data
On 08/19/13 13:18, Michael S. Tsirkin wrote:
On Mon, Aug 19, 2013 at 01:09:36PM +0200, Laszlo Ersek wrote:
On 08/19/13 12:21, Peter Maydell wrote:
On 19 August 2013 10:59, Laszlo Ersek ler...@redhat.com wrote:
On 08/13/13 00:43, Michael S. Tsirkin wrote:
Migration code assumes that each RAM
| 6 ++
hw/core/loader.c | 54
---
hw/i386/pc_piix.c | 2 ++
hw/i386/pc_q35.c | 2 ++
include/exec/memory.h | 1 +
include/hw/loader.h | 1 +
6 files changed, 63 insertions(+), 3 deletions(-)
Reviewed-by: Laszlo Ersek
On 08/19/13 14:31, Andreas Färber wrote:
Am 19.08.2013 12:48, schrieb Miroslav Rezanina:
usb-bt-dongle device can't be disabled as there's dependency in vl.c file.
This patch add preprocesor condition to be able to disable it.
Please limit to 76 chars per line (check `git log` output).
On 08/18/13 16:25, Paolo Bonzini wrote:
Il 16/08/2013 16:59, Anthony Liguori ha scritto:
Laszlo Ersek ler...@redhat.com writes:
Paolo asked me to write such a driver based on his textual specification
alone. The first patch captures his email in full, the rest re-quotes
parts that are being
On 08/19/13 16:26, Michael S. Tsirkin wrote:
Migration code assumes that each MR is a multiple of TARGET_PAGE_SIZE:
MR size is divided by TARGET_PAGE_SIZE, so if it isn't migration
never completes.
But this isn't really required for regions set up with
memory_region_init_ram, since that calls
On 08/19/13 19:48, Michael S. Tsirkin wrote:
On Mon, Aug 19, 2013 at 07:37:44PM +0200, Laszlo Ersek wrote:
On 08/19/13 16:26, Michael S. Tsirkin wrote:
Migration code assumes that each MR is a multiple of TARGET_PAGE_SIZE:
MR size is divided by TARGET_PAGE_SIZE, so if it isn't migration
never
...@redhat.com
---
hw/core/loader.c| 49 ++---
hw/i386/pc_piix.c | 2 ++
hw/i386/pc_q35.c| 2 ++
include/hw/loader.h | 1 +
4 files changed, 51 insertions(+), 3 deletions(-)
checked the v3-v4 diff in v4 0/2.
Reviewed-by: Laszlo Ersek
On 08/19/13 21:26, Luiz Capitulino wrote:
On Mon, 22 Jul 2013 23:07:36 +0200
Laszlo Ersek ler...@redhat.com wrote:
Signed-off-by: Laszlo Ersek ler...@redhat.com
This patch now conflicts, can you respin please?
Can you retry with git am -3?
git rebase -i didn't ask me to do anything
On 08/19/13 21:55, Laszlo Ersek wrote:
On 08/19/13 21:26, Luiz Capitulino wrote:
On Mon, 22 Jul 2013 23:07:36 +0200
Laszlo Ersek ler...@redhat.com wrote:
Signed-off-by: Laszlo Ersek ler...@redhat.com
This patch now conflicts, can you respin please?
Can you retry with git am -3?
git
On 07/27/13 17:41, Markus Armbruster wrote:
The parser handles erroneous input badly. To be improved shortly.
Signed-off-by: Markus Armbruster arm...@redhat.com
diff --git a/tests/Makefile b/tests/Makefile
index cdbb79e..ddb957c 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@
When a well-formed range value, bounded by signed integers, is encountered
while processing a repeated option, enter LM_SIGNED_INTERVAL and return
the low bound.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 34 --
1 files changed, 28
=65534,cpus=65535,cpus=65536,cpus=65537
and visit_type_uint16() [qapi/qapi-visit-core.c] will catch the first
element (= 65536) that has been parsed by opts_type_int() but cannot be
represented as 'uint16'.
Laszlo Ersek (8):
OptsVisitor: introduce basic list modes
OptsVisitor: introduce list
to parse a scalar into it. List mode restrictions are expressed in
positive / inclusive form.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 45 +++--
1 files changed, 35 insertions(+), 10 deletions(-)
diff --git a/qapi/opts-visitor.c
test-int128 was probably missed in commit 6046c620
(int128: optimize and add test cases).
test-bitops was probably missed in commit 3464700f
(tests: Add test-bitops.c with some sextract tests).
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
v1-v2:
- add test-bitops too
.gitignore |2
According to commit 4f193e34
(tests: Use qapi-schema-test.json as schema parser test)
the tests/qapi-schema/qapi-schema-test.out file must be updated as well.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
v1-v2:
- rebase to master,
- synch qapi-schema-test.out.
tests/Makefile
Prevent mistyped command line options from incurring high memory and CPU
usage at startup. 64K elements in a range should be enough for everyone
(TM).
The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can
construct corner cases with it.
Signed-off-by: Laszlo Ersek ler...@redhat.com
When a well-formed range value, bounded by unsigned integers, is
encountered while processing a repeated option, enter LM_UNSIGNED_INTERVAL
and return the low bound.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 32 +++-
1 files changed, 27
/ inclusive
sense. The restrictions for lookup_scalar() and processed() are
automatically satisfied by current qapi traversals if the schema to build
is compatible with OptsVisitor.
The new list modes are not entered yet.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 67
Simplify the code in preparation for the next patch.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 23 +--
1 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 90be583..d8f9a0e 100644
+++
tests/Makefile | 8
2 files changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Laszlo Ersek ler...@redht.com
Thanks!
Laszlo
On 08/20/13 21:16, Andreas Färber wrote:
Am 20.08.2013 20:39, schrieb Luiz Capitulino:
On Tue, 20 Aug 2013 18:23:00 +0200
Andreas Färber afaer...@suse.de wrote:
Am 20.08.2013 18:10, schrieb Luiz Capitulino:
diff --git a/.gitignore b/.gitignore
index 0fe114d..a8e0f17 100644
--- a/.gitignore
On 08/20/13 03:09, Wanlong Gao wrote:
On 08/20/2013 06:35 AM, Laszlo Ersek wrote:
v1-v2:
Tested-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Thank you.
Laszlo
On 08/20/13 10:21, Kevin Wolf wrote:
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben:
Paolo asked me to write such a driver based on his textual specification
alone. The first patch captures his email in full, the rest re-quotes
parts that are being implemented.
The tree compiles at each
On 08/20/13 03:07, Wanlong Gao wrote:
V7-V8:
rebase to current master with Laszlo's V2 of OptsVisitor patch set
fix an adding white space line error
My R-b's that you've kept from V7, for patches 01 and 02, stand.
Thanks
Laszlo
see how this already accounts
for 100+ SLOC roughly...
The implementations of bdrv_co_readv and bdrv_co_writev should also call
BLKDBG_EVENT on bs-file too, before forwarding to bs-file. The events
to be generated are BLKDBG_READ_AIO and BLKDBG_WRITE_AIO.
Signed-off-by: Laszlo Ersek ler
:
On 08/20/13 10:11, Kevin Wolf wrote:
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben:
+static int raw_probe(void)
+{
+return 1;
+}
Maybe add a comment here like smallest possible positive score so that
raw is used if and only if no other block driver works.
Signed-off-by: Laszlo
-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 19091a3..5bcbe71 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -108,3 +108,7 @@ static TYPE raw_has_zero_init(BlockDriverState
of my brain.
Laszlo Ersek (7):
add skeleton for BSD licensed raw BlockDriver
raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev()
raw_bsd: add raw_create()
raw_bsd: introduce special members
raw_bsd: add raw_create_options
raw_bsd: register bdrv_raw
switch raw block driver
On 08/05/13 15:03, Paolo Bonzini wrote:
- Original Message -
From: Laszlo Ersek ler...@redhat.com
To: Paolo Bonzini pbonz...@redhat.com
Sent: Monday, August 5, 2013 2:43:46 PM
Subject: Re: [PATCH 1/2] raw: add license header
On 08/02/13 00:27, Paolo Bonzini wrote:
On 08/01/2013
and
commit 7c80ab3f21f0b1342f23057d4345ae266c7348d9
Author: Jes Sorensen jes.soren...@redhat.com
Date: Fri Dec 17 16:02:39 2010 +0100
block/qcow2.c: rename qcow_ functions to qcow2_
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c | 13 -
1 files
/2013 16:15, Laszlo Ersek ha scritto:
+static int raw_reopen_prepare(BDRVReopenState *reopen_state,
+ BlockReopenQueue *queue, Error **errp)
{
-return bdrv_reopen_prepare(bs-file);
+BDRVReopenState tmp = *reopen_state;
+
+tmp.bs = tmp.bs-file
2010 +
Fix OpenBSD build
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
block/raw_bsd.c | 38 +-
1 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index b70245d..2dc1921 100644
--- a/block
-by: Laszlo Ersek ler...@redhat.com
(Note that my R-b is mostly worthless: similarly to the ACPI table move,
I've been happily acking patches with opposite goals here, and that
seriously questions whether my review adds any value (beyond the lowest
technical level).)
Laszlo
On 08/21/13 17:32, Paolo Bonzini wrote:
To support 1.5, libvirt should simply be ready to react to unanticipated
GUEST_PANICKED events. reboot-on-panic will simply be broken for 1.5
and Linux 3.10+ guests. :(
I'm probably misunderstanding the discussion, but it might be possible
to disable
On 08/22/13 05:16, Wanlong Gao wrote:
On 08/22/2013 10:29 AM, Eric Blake wrote:
On 08/21/2013 07:12 PM, Wanlong Gao wrote:
+ '*mem':'str' }}
Why is size passed as a 'str' instead of an integral type? If anything,
at the QMP layer, it should be an integer representing size in bytes
On 08/22/13 11:19, Paolo Bonzini wrote:
Il 22/08/2013 10:38, Laszlo Ersek ha scritto:
To support 1.5, libvirt should simply be ready to react to unanticipated
GUEST_PANICKED events. reboot-on-panic will simply be broken for 1.5
and Linux 3.10+ guests. :(
I'm probably misunderstanding
On 08/22/13 12:34, Laszlo Ersek wrote:
(I think I'm recalling this from the 0xCF9 reset control register, which
falls into the [0xCF8..0xCFA] range.)
[0xCF8..0xCFB], sigh
())
is removed anyway.
Seems OK to me.
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 08/21/13 19:06, Paolo Bonzini wrote:
Il 21/08/2013 19:07, Michael S. Tsirkin ha scritto:
NACK
You know that a single developer's NACK counts nothing (it can be you,
it can be me), don't you?
going meta...
What's this?
All I know (... I think I know) about patch acceptance is that
On 08/22/13 18:14, Eric Blake wrote:
On 08/22/2013 02:46 AM, Laszlo Ersek wrote:
Yes. This part of the schema is not for exposure over QMP, it just
generates stuff for OptsVisitor, and it must remain compatible with the
original, manual parsing of the option.
This came up for V6:
http
On 08/22/13 18:10, Paolo Bonzini wrote:
The thread from yesterday has died off (perhaps also because of
my inappropriate answer to Michael, for which I apologize to him
and everyone). I took some time to discuss the libvirt requirements
further with Daniel Berrange and Eric Blake on IRC. If
On 08/22/13 18:44, Anthony Liguori wrote:
pvpanic has been a failure. It's a poorly designed device with even
worse semantics.
I disagree somewhat.
Requiring a separate ioport is not ideal, I admit. Configuration over
ACPI is good OTOH (it seems to put standards to good use anyway).
Noone
On 08/22/13 21:19, Paolo Bonzini wrote:
Il 22/08/2013 19:15, Laszlo Ersek ha scritto:
2) On all versions, on_crash will only work if the element is there.
I like this, because, if on_crash doesn't work without panic_notifier
*at all*, then we can just drop panic_notifier, and make on_crash
On 08/22/13 22:09, Anthony Liguori wrote:
The difference is that ACPI or platform devices in general are
unexpected to be added. By definition it means that the motherboard has
most likely been changed.
You could encounter a new ACPI artifact after simply re-flashing your MB
with an updated
On 08/27/13 14:29, Lasse wrote:
Public bug reported:
When qemu receives SIGQUIT, it should first try to run system_powerdown
(giving the guest an ACPI signal to begin the shutdown process), before
ending the whole qemu process.
I strongly disagree. SIGQUIT is an interactive debugging
On 08/20/13 13:43, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
v2: Nominate for qemu-stable (Andreas)
Markus Armbruster (2):
tests: Fix schema parser test for in-tree build
tests: Update .gitignore for test-int128 and test-bitops
tests/.gitignore | 3 +++
On 08/21/13 12:41, Laszlo Ersek wrote:
v1-v2:
- added comment to raw_probe() [Kevin]
- fixed raw_reopen_prepare() [Paolo Kevin]
- keeping BSDL: according to the v1 discussion, LGPLv2+ could work too,
but but most of the block layer is BSD [Paolo] and I haven't been
clearly instructed
On 08/28/13 11:22, Xie, Huawei wrote:
Hi Stefan:
I think you mention the descriptor address? I mean the vring PFN register.
/* A 32-bit r/w PFN for the currently selected queue */
#define VIRTIO_PCI_QUEUE_PFN 8
And the linux driver sample code:
iowrite32(virt_to_phys(info-queue)
(qemu-devel CC'd)
On 08/28/13 12:35, Gary Ching-Pang Lin wrote:
Hi,
I recently updated qemu to 1.6.0 and found OVMF just showed a blank
screen when kvm was enabled. I tried to dump OVMF log with the
following commond but nothing was stored in debug.log.
qemu-system-x86_64 -s -enable-kvm
On 08/28/13 13:49, Andreas Färber wrote:
Am 28.08.2013 13:45, schrieb Laszlo Ersek:
(qemu-devel CC'd)
On 08/28/13 12:35, Gary Ching-Pang Lin wrote:
Hi,
I recently updated qemu to 1.6.0 and found OVMF just showed a blank
screen when kvm was enabled. I tried to dump OVMF log
the flash drive.
I'm attaching the trace output (stderr backend, saved by libvirt); you
should be able to pair segments of the file with the above actions.
Laszlo Ersek (2):
qemu_hexstr(): hexdump a small buffer to a string, for in-line
printing
add some virtio-scsi trace events
include
This function should primarily serve tracing needs.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
include/qemu-common.h | 11 +++
util/hexdump.c| 20
2 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/include/qemu-common.h b/include/qemu
The events that log a hexdump of the cdb and the sense buffer are disabled
by default, because they require more processing than a simple trace_XXX()
function call.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/scsi/virtio-scsi.c | 76
On 08/29/13 15:59, Paolo Bonzini wrote:
Il 29/08/2013 15:37, Laszlo Ersek ha scritto:
The events that log a hexdump of the cdb and the sense buffer are disabled
by default, because they require more processing than a simple trace_XXX()
function call.
Signed-off-by: Laszlo Ersek ler
On 08/29/13 16:53, Paolo Bonzini wrote:
(c) The way I submitted the series, the events in question are disabled
in trace-events. Check out the functions themselves: they are
protected (ie. even the trace_event_get_state() calls are protected)
with preprocessing directives. I did it this way
On 08/30/13 05:28, Gary Ching-Pang Lin wrote:
On Fri, Aug 30, 2013 at 02:04:40AM +1000, Bruce Rogers wrote:
On 8/29/2013 at 02:23 AM, Gary Ching-Pang Lin g...@suse.com wrote:
On Wed, Aug 28, 2013 at 02:55:26PM +0200, Andreas Färber wrote:
Am 28.08.2013 14:10, schrieb Laszlo Ersek:
On 08/28
Hello Benjamin,
On 08/27/13 02:43, Benjamin Herrenschmidt wrote:
Am I dreaming ? Those patches were written about a year ago and you guys
are still nitpicking on names ? They should have been merged a LONG time
ago ...
I'm seriously wondering how people get anything done with qemu KVM when
On 07/25/14 17:48, Igor Mammedov wrote:
Changing the ACPI table size causes migration to break, and the memory
hotplug work opened our eyes on how horribly we were breaking things in
2.0 already.
To trigger issue start
QEMU-1.7 with -M pc-i440fx-1.7 -device pci-bridge,chassis_nr=1
and
On 07/25/14 17:48, Igor Mammedov wrote:
Add API to mark memory region as extend-able on migration,
to allow migration code to load smaller RAMBlock into
a bigger one on destination QEMU instance.
This will allow to fix broken migration from QEMU 1.7/2.0 to
QEMU 2.1 due to ACPI tables size
, false)
#define rom_add_blob_fixed(_f, _b, _l, _a) \
-rom_add_blob(_f, _b, _l, _a, NULL, NULL, NULL)
+rom_add_blob(_f, _b, _l, _a, NULL, NULL, NULL, false)
#define PC_ROM_MIN_VGA 0xc
#define PC_ROM_MIN_OPTION 0xc8000
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 07/28/14 09:40, Igor Mammedov wrote:
On Fri, 25 Jul 2014 19:56:40 +0200
Laszlo Ersek ler...@redhat.com wrote:
On 07/25/14 17:48, Igor Mammedov wrote:
Add API to mark memory region as extend-able on migration,
to allow migration code to load smaller RAMBlock into
a bigger one
deletions(-)
Thank you.
Reviewed-by: Laszlo Ersek ler...@redhat.com
have my R-b.
3 3d5061f bios-tables-test: fix ASL normalization false positive
Just gave my R-b in this thread.
4 82631f6 pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug
is disabled
Acked-by: Laszlo Ersek ler...@redhat.com
5 1cffcf8 acpi-build: minor code cleanup
On 07/30/14 15:20, Michael S. Tsirkin wrote:
On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Add an SSDT ACPI table for the TPM device.
Add a TCPA table for BIOS logging area when a TPM is being used.
The latter follows this spec
On 07/30/14 16:46, Michael S. Tsirkin wrote:
On Wed, Jul 30, 2014 at 04:36:38PM +0200, Laszlo Ersek wrote:
On 07/30/14 15:20, Michael S. Tsirkin wrote:
On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Add an SSDT ACPI table
On 07/30/14 17:03, Igor Mammedov wrote:
On Wed, 30 Jul 2014 16:36:38 +0200
Laszlo Ersek ler...@redhat.com wrote:
On 07/30/14 15:20, Michael S. Tsirkin wrote:
On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Add an SSDT ACPI
On 07/30/14 17:10, Stefan Berger wrote:
Laszlo Ersek ler...@redhat.com wrote on 07/30/2014 10:36:38 AM:
From: Laszlo Ersek ler...@redhat.com
To: Michael S. Tsirkin m...@redhat.com, Stefan Berger/Watson/IBM@IBMUS
Cc: qemu-devel@nongnu.org, Stefan Berger stef...@linux.vnet.ibm.com
Date: 07/30
On 07/30/14 17:29, Stefan Berger wrote:
Michael S. Tsirkin m...@redhat.com wrote on 07/30/2014 11:20:41 AM:
From: Michael S. Tsirkin m...@redhat.com
To: Stefan Berger/Watson/IBM@IBMUS
Cc: Laszlo Ersek ler...@redhat.com, qemu-devel@nongnu.org, Stefan
Berger stef...@linux.vnet.ibm.com
Date
On 07/30/14 17:44, Stefan Berger wrote:
Laszlo Ersek ler...@redhat.com wrote on 07/30/2014 11:41:10 AM:
From: Laszlo Ersek ler...@redhat.com
To: Stefan Berger/Watson/IBM@IBMUS, Michael S. Tsirkin m...@redhat.com
Cc: qemu-devel@nongnu.org, Stefan Berger stef...@linux.vnet.ibm.com
Date: 07/30
On 07/30/14 17:37, Michael S. Tsirkin wrote:
1. execute alloc instructions, building a data structure mapping fwcfg
file names to memory.
Yes, edk2 currently lacks a good (== sub-linear) dictionary data type.
This week I started porting a red-black tree library that I had
originally written
On 07/30/14 17:52, Michael S. Tsirkin wrote:
On Wed, Jul 30, 2014 at 05:37:26PM +0200, Laszlo Ersek wrote:
On 07/30/14 17:10, Stefan Berger wrote:
Laszlo Ersek ler...@redhat.com wrote on 07/30/2014 10:36:38 AM:
From: Laszlo Ersek ler...@redhat.com
To: Michael S. Tsirkin m...@redhat.com
On 07/30/14 18:05, Michael S. Tsirkin wrote:
On Wed, Jul 30, 2014 at 11:59:43AM -0400, Stefan Berger wrote:
Michael S. Tsirkin m...@redhat.com wrote on 07/30/2014 11:50:36 AM:
From: Michael S. Tsirkin m...@redhat.com
To: Stefan Berger/Watson/IBM@IBMUS
Cc: Laszlo Ersek ler...@redhat.com, qemu
On 07/30/14 18:10, Michael S. Tsirkin wrote:
On Wed, Jul 30, 2014 at 12:03:46PM -0400, Stefan Berger wrote:
Laszlo Ersek ler...@redhat.com wrote on 07/30/2014 11:58:52 AM:
In the short term, probably skip TCPA, or advise users in documentation
not to enable the TPM device when running OVMF
On 07/30/14 18:07, Michael S. Tsirkin wrote:
On Wed, Jul 30, 2014 at 06:02:21PM +0200, Laszlo Ersek wrote:
On 07/30/14 17:37, Michael S. Tsirkin wrote:
1. execute alloc instructions, building a data structure mapping fwcfg
file names to memory.
Yes, edk2 currently lacks a good (== sub
On 07/30/14 18:11, Michael S. Tsirkin wrote:
On Wed, Jul 30, 2014 at 06:07:28PM +0200, Laszlo Ersek wrote:
On 07/30/14 17:52, Michael S. Tsirkin wrote:
How does EFI want to handle TCPA? Does caller allocate it
log and fill in the address?
TPM 1.2 seems to be completely absent from edk2, so
On 07/30/14 18:35, Stefan Berger wrote:
Laszlo Ersek ler...@redhat.com wrote on 07/30/2014 12:18:02 PM:
From: Laszlo Ersek ler...@redhat.com
To: Michael S. Tsirkin m...@redhat.com, Stefan Berger/Watson/IBM@IBMUS
Cc: qemu-devel@nongnu.org, Stefan Berger stef...@linux.vnet.ibm.com
Date: 07/30
comments below
On 08/03/14 17:28, Chen Gang wrote:
In dump_init(), when failure occurs, need notice about 'fd' and memory
mapping. So call dump_cleanup() for it (need let all initializations at
front).
Also simplify dump_cleanup(): remove redundant 'ret' and redundant 'fd'
checking.
801 - 900 of 4203 matches
Mail list logo
