(rsdp_table, sizeof *rsdp);
-bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 1,
+bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 16,
true /* fseg memory */);
memcpy(rsdp-signature, RSD PTR , 8);
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 08/06/14 09:40, Reza Jelveh wrote:
Hello,
EDK2 integrates FAT as a binary driver. What is the license of the FAT driver?
https://svn.code.sf.net/p/edk2/code/trunk/edk2/FatBinPkg/License.txt
What are the guidelines for use of binary drivers with EDK2? Specifically if
you want to bundle
commit message.
Reviewed-by: Laszlo Ersek ler...@redhat.com
a number of comments -- feel free to address or ignore each as you see fit:
On 08/13/14 21:09, Alex Williamson wrote:
The SDM specifies (June 2014 Vol3 11.11.5):
On a hardware reset, the P6 and more recent processors clear the
valid flags in variable-range MTRRs and clear the E flag
On 08/14/14 00:06, Alex Williamson wrote:
On Wed, 2014-08-13 at 22:33 +0200, Laszlo Ersek wrote:
a number of comments -- feel free to address or ignore each as you see fit:
On 08/13/14 21:09, Alex Williamson wrote:
mappings which are now stale after reset. The result is that OVMF
rebooting
On 08/14/14 01:17, Laszlo Ersek wrote:
- With KVM, the lack of loading MTRR state from KVM, combined with the
(partial) storing of MTRR state to KVM, has two consequences:
- migration invalidates (loses) MTRR state,
I'll concede that migration *already* loses MTRR state (on KVM), even
-by: Alex Williamson alex.william...@redhat.com
Cc: Laszlo Ersek ler...@redhat.com
Cc: qemu-sta...@nongnu.org
---
target-i386/cpu.h |2 +-
target-i386/machine.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index
alex.william...@redhat.com
Cc: Laszlo Ersek ler...@redhat.com
Cc: qemu-sta...@nongnu.org
---
target-i386/cpu.h |2 +
target-i386/kvm.c | 101
-
2 files changed, 101 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.h b/target-i386
-by: Alex Williamson alex.william...@redhat.com
Cc: Laszlo Ersek ler...@redhat.com
Cc: qemu-sta...@nongnu.org
---
target-i386/cpu.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6d008ab..9768be1 100644
--- a/target-i386
was already
slightly undersized for holding every possible MSR, so this patch
increases it beyond the 28 new entries necessary for MTRR state.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Cc: Laszlo Ersek ler...@redhat.com
Cc: qemu-sta...@nongnu.org
---
target-i386/cpu.h |2
was already
slightly undersized for holding every possible MSR, so this patch
increases it beyond the 28 new entries necessary for MTRR state.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Cc: Laszlo Ersek ler...@redhat.com
Cc: qemu-sta...@nongnu.org
---
target-i386/cpu.h |2
On 12/18/13 15:19, Paolo Bonzini wrote:
Il 11/12/2013 12:04, Gal Hammer ha scritto:
Michael,
True, I haven't figure it out yet, but the current status is that recover
from sleep doesn't work.
As far as I can tell it could be either:
1. piix4_reset shouldn't be call on resume.
2.
On 12/18/13 17:34, Paolo Bonzini wrote:
- Messaggio originale -
Da: Michael S. Tsirkin m...@redhat.com
A: marcel a marce...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com, Gal Hammer
gham...@redhat.com, seab...@seabios.org,
qemu-devel@nongnu.org
Inviato: Mercoledì, 18
On 12/18/13 23:10, Laszlo Ersek wrote:
1. SEC after cold boot
2. PEI after cold boot
2.5 DXE IPL PEIM loads DXE core
3. DXE after cold boot
4. BDS after cold boot
5. runtime (OSPM), normal entry
6. PEI after S3 resume
6.5 DXE IPL PEIM branches to S3 resume PEIM
7. runtime (OSPM), entry
kra...@redhat.com
Forward ported to 83d08f26 (pc: map PCI address space as catchall region
for not mapped addresses).
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
include/hw/i386/pc.h | 1 +
hw/i386/pc_piix.c| 1 +
hw/pci-host/piix.c | 11 ++-
3 files changed, 4 insertions
On 12/22/13 16:34, Gabriel L. Somlo wrote:
AppleSMC (-device isa-applesmc) is required to boot OS X guests.
OS X expects a SMC node to be present in the ACPI DSDT. This patch
adds a SMC node to the DSDT, and dynamically patches the return value
of SMC._STA to either 0x0B if the chip is
On 12/22/13 18:14, Gabriel L. Somlo wrote:
On Sun, Dec 22, 2013 at 04:58:58PM +0100, Laszlo Ersek wrote:
After this patch, ISA interrupt 6 is used by both SMC and FDC0. The
latter depends on the FDEN object, but FDEN is currently constant 1.
Probably not a problem in practice (ie. most users
On 12/23/13 17:24, Igor Mammedov wrote:
On Mon, 23 Dec 2013 16:48:49 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Dec 23, 2013 at 02:06:27PM +0100, Igor Mammedov wrote:
On Mon, 23 Dec 2013 13:26:37 +0200
Michael S. Tsirkin m...@redhat.com wrote:
Interesting. This seems to imply
---
dump.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
I assume the direct calls to fd_write_vmcore() (which we're not
replacing here) will be substituted / abstracted later on in the series.
Reviewed-by: Laszlo Ersek ler...@redhat.com
:)
[...]
Reviewed-by: Laszlo Ersek ler...@redhat.com
doesn't warrant a respin.
Reviewed-by: Laszlo Ersek ler...@redhat.com
we can live with it.
Using s-note_size as limit seems correct.
+
+s-note_buf_offset += size;
+
+return 0;
+}
+
static ram_addr_t get_start_block(DumpState *s)
{
GuestPhysBlock *block;
Reviewed-by: Laszlo Ersek ler...@redhat.com
settings along with the other
settings in the big echo block. But it's not too important; if you
want you can add it later.
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 01/07/14 07:25, Qiao Nuohan wrote:
On 01/07/2014 03:25 AM, Laszlo Ersek wrote:
You could have displayed the lzo / snappy settings along with the other
settings in the big echo block. But it's not too important; if you
want you can add it later.
You mean the following part? Thanks
On 01/07/14 07:32, Qiao Nuohan wrote:
Hello Eric, Luiz and Laszlo,
What do you think about my series? And I have add the light-weight
introspection in the last patch, do you have some comments on it?
I haven't finished reviewing it yet, but thus far (up to including
patch 05) I'm OK with
you can address what you want from the above later too.
Reviewed-by: Laszlo Ersek ler...@redhat.com
members elsewhere (with dynamically set values) for the same purpose, is
a mess.
However that could be refactored in a separate series, *if* you think it
would be worthwhile.
Reviewed-by: Laszlo Ersek ler...@redhat.com
these magic constants are somewhat tied to x86, and therefore
should be in an arch-specific file rather than a common file, but
whoever wants to extend this to another architecture can do that.
I think I haven't found anything that I'd call a bug.
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 01/07/14 15:49, Laszlo Ersek wrote:
On 01/05/14 08:27, Qiao Nuohan wrote:
diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h
index 9e47b4c..b5eaf8d 100644
--- a/include/sysemu/dump.h
+++ b/include/sysemu/dump.h
@@ -27,11 +27,18 @@
#define DUMP_DH_COMPRESSED_LZO (0x2
comments below
On 01/05/14 08:27, Qiao Nuohan wrote:
functions are used to write page to vmcore. vmcore is written page by page.
page desc is used to store the information of a page, including a page's size,
offset, compression format, etc.
Signed-off-by: Qiao Nuohan
comments below
On 01/05/14 08:27, Qiao Nuohan wrote:
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF
comments below
On 01/05/14 08:27, Qiao Nuohan wrote:
'query-dump-guest-memory-capability' is used to query whether option 'format'
is available for 'dump-guest-memory' and the available format. The output
of the command will be like:
- { execute: query-dump-guest-memory-capability }
- {
-by: Laszlo Ersek ler...@redhat.com
On 11/28/13 17:03, Laszlo Ersek wrote:
Mike,
On 11/27/13 12:57, Gerd Hoffmann wrote:
Make the 32bit pci hole start at end of ram, so all possible address
space is covered. Of course the firmware can use less than that.
Leaving space unused is no problem, mapping pci bars outside the
hole
On 01/13/14 11:03, Qiao Nuohan wrote:
Sorry for responsing late.
On 01/07/2014 07:38 PM, Laszlo Ersek wrote:
+kh-offset_note = DISKDUMP_HEADER_BLOCKS * dh-block_size +
size;
+kh-note_size = s-note_size;
+
+if (write_buffer(s-fd, s-flag_flatten, dh-block_size, kh
On 01/14/14 03:07, Qiao Nuohan wrote:
On 01/13/2014 06:39 PM, Laszlo Ersek wrote:
- When this write_buffer() is directed to a regular file in
non-flat
mode, then the file might become sparse (you jump over a range of
offsets with lseek() in write_buffer()). If the output has been
Hi,
On 01/21/14 10:56, Qiao Nuohan wrote:
Do you have some comments on the version?
it's in my review queue. The last version took a lot of energy on my
part to review (it's long and complex) so I'm still gearing up.
I very much hope I can review this version by diffing it with the last
On 03/25/14 15:44, Michael Roth wrote:
Hi everyone,
I am pleased to announce that the QEMU v1.7.1 stable release is now
available at:
http://wiki.qemu.org/download/qemu-1.7.1.tar.bz2
v1.7.1 is now tagged in the official qemu.git repository,
and the stable-1.7 branch has been updated
On 03/26/14 11:31, Michael S. Tsirkin wrote:
On Wed, Mar 26, 2014 at 06:45:10AM -, Robert Hu wrote:
Date: Mon Mar 17 17:05:16 2014 +0100
i386/acpi-build: allow more than 255 elements in CPON
The build_ssdt() function builds a number of AML objects that are related
to CPU
On 03/26/14 13:58, Michael S. Tsirkin wrote:
On Wed, Mar 26, 2014 at 01:28:02PM +0100, Laszlo Ersek wrote:
On 03/26/14 11:31, Michael S. Tsirkin wrote:
On Wed, Mar 26, 2014 at 06:45:10AM -, Robert Hu wrote:
Date: Mon Mar 17 17:05:16 2014 +0100
i386/acpi-build: allow more than 255
On 03/26/14 14:48, Igor Mammedov wrote:
On Wed, 26 Mar 2014 14:58:28 +0200
Michael S. Tsirkin m...@redhat.com wrote:
If we want to change ACPI rev, I think we should do this
conditionally when max_cpus 255.
Would be worth it if this fixes some guests.
As for reverting, I think it's a
On 03/26/14 16:23, Eduardo Habkost wrote:
On Wed, Mar 26, 2014 at 05:09:29PM +0200, Michael S. Tsirkin wrote:
On Wed, Mar 26, 2014 at 12:06:38PM -0300, Eduardo Habkost wrote:
On Wed, Mar 26, 2014 at 04:54:31PM +0200, Michael S. Tsirkin wrote:
On Wed, Mar 26, 2014 at 02:48:29PM +0100, Igor
On 03/27/14 09:41, Erik Rull wrote:
Hi all,
I would like to have the guest drifting to a new set clock on the host.
My problem is the following:
- Host System (Linux) starts up, hwclock and kernel time are synced,
guest starts up with -rtc clock=host,driftfix=slew (which I assume
On 03/27/14 13:40, Gerd Hoffmann wrote:
On Do, 2014-03-27 at 10:57 +0100, Markus Armbruster wrote:
Olaf Hering o...@aepfle.de writes:
Right now qemu does appearently just emulate a graphics card (Cirrus for
example), but not an attached monitor/display. The result is confusion
in the guest
On 03/27/14 21:14, Erik Rull wrote:
Laszlo Ersek wrote:
On 03/27/14 09:41, Erik Rull wrote:
Hi all,
I would like to have the guest drifting to a new set clock on the
host.
My problem is the following:
- Host System (Linux) starts up, hwclock and kernel time are synced,
guest starts up
uni_overflow;
uint8_t *macs;
I ran
git grep -EHn '\(in_use|first_multi)\'
Many hits, hard to audit (esp. because I'm unfamiliar with the code).
Several loops with signed int loop variables. I checked cursorily.
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 03/31/14 22:18, Gabriel L. Somlo wrote:
On Wed, Mar 26, 2014 at 06:36:10PM -0400, Kevin O'Connor wrote:
On Wed, Mar 26, 2014 at 03:58:50PM -0400, Gabriel L. Somlo wrote:
- SeaBIOS is still in charge of providing the smbios_entry_point
structure, and it's unlikely we can reasonably expect
On 04/01/14 16:39, Kevin O'Connor wrote:
On Tue, Apr 01, 2014 at 10:40:00AM +0200, Laszlo Ersek wrote:
On 03/31/14 22:18, Gabriel L. Somlo wrote:
The only sticking point remaining would be who gets to generate the
Type 0 (BIOS Information) table and when, which is something QEMU
should
On 04/01/14 17:01, Fabio Fantoni wrote:
Today I tried latest qemu 2.0 compiled from git (commit
63678e17cf399ff81b93417fe7bee8d6ef6b6b1b) on this dom0:
Debian 7 (Wheezy) 64 bit with kernel from package
linux-image-3.2.0-4-amd64 version 3.2.54-2 and all dependency packages
for xen, spice and
On 04/01/14 23:28, Gabriel L. Somlo wrote:
On Tue, Apr 01, 2014 at 04:28:32PM -0400, Kevin O'Connor wrote:
From the conversation so far, it seems to me that:
- type 0 is best left to the BIOS (user overrides via
command line at their own risk)
- therefore, the maximum
On 04/02/14 00:00, Kevin O'Connor wrote:
On Tue, Apr 01, 2014 at 11:44:12PM +0200, Laszlo Ersek wrote:
Right now, OVMF can accept individual fields, or table-at-a-time blobs,
via fw_cfg.
The internal interface (EFI_SMBIOS_PROTOCOL) expects one table at a time
(for which table-at-a-time blobs
On 04/02/14 13:13, Fabio Fantoni wrote:
Il 01/04/2014 18:24, Laszlo Ersek ha scritto:
On 04/01/14 17:01, Fabio Fantoni wrote:
Today I tried latest qemu 2.0 compiled from git (commit
63678e17cf399ff81b93417fe7bee8d6ef6b6b1b) on this dom0:
Debian 7 (Wheezy) 64 bit with kernel from package
On 04/02/14 14:38, Gabriel L. Somlo wrote:
On Wed, Apr 02, 2014 at 12:35:26AM +0200, Laszlo Ersek wrote:
On 04/02/14 00:00, Kevin O'Connor wrote:
On Tue, Apr 01, 2014 at 11:44:12PM +0200, Laszlo Ersek wrote:
Right now, OVMF can accept individual fields, or table-at-a-time blobs,
via fw_cfg
On 04/03/14 03:57, Gabriel L. Somlo wrote:
On Wed, Apr 02, 2014 at 01:01:28PM -0400, Gabriel L. Somlo wrote:
Speaking of, I *thought* I had a vague idea of how all this stuff fits
together, but it turns out I don't... There's
- OVMF
On 04/02/14 00:09, Andy Lutomirski wrote:
Running:
./virtme-run --installed-kernel
from this virtme commit:
https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git/commit/?id=2b409a086d15b7a878c7d5204b1f44a6564a341f
results in a bunch of missing lines of text once bootup finishes.
On 04/03/14 15:32, Gabriel L. Somlo wrote:
On Thu, Apr 03, 2014 at 11:42:31AM +0200, Laszlo Ersek wrote:
You don't see SMBIOS tables in the guest because you've built upstream
OVMF. As I said before, upstream OvmfPkg doesn't include my SMBIOS
patches. Both (a) and (b) do however.
Oh, OK
On 04/06/14 13:08, Michael Tokarev wrote:
06.04.2014 14:53, Michael S. Tsirkin wrote:
On Sun, Apr 06, 2014 at 01:49:11PM +0400, Michael Tokarev wrote:
When building RSDT table, pick OEM ID fields from uer-supplied SLIC
table instead of using hard-coded QEMU defaults. This way, say,
OEM
On 04/07/14 16:14, Kevin O'Connor wrote:
On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote:
The only fly in this ointment may be that type 0 doesn't have a fixed
length that could be edited in place, if you consider the various
strings that get tacked on to the end of it. So you'd
-by: Laszlo Ersek ler...@redhat.com
))
+{
error_setg(errp, Catalog size is too small for this disk size);
ret = -EINVAL;
goto fail;
Nice! If I may voice my liking.
Reviewed-by: Laszlo Ersek ler...@redhat.com
Thanks
Laszlo
diff --git a/tests/qemu-iotests/078 b/tests/qemu-iotests/078
index 872e734..d4d6da7 100755
On 04/03/14 07:18, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
assigned_dev_register_msix_mmio(), meanwhile the set the one
page memmory to zero, so the rest memory will be random value
(maybe etnry.data is
qemu_parse_fd() used to handle at least the following strings incorrectly:
o -2: simply let through
o 2147483648: returned as LONG_MAX==INT_MAX on ILP32 (with ERANGE
ignored); implementation-defined behavior on LP64
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
util
... and rebase pci_add_capability() to it.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
include/hw/pci/pci.h | 4
hw/pci/pci.c | 32 ++--
2 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
-by: Laszlo Ersek ler...@redhat.com
---
include/monitor/monitor.h | 1 +
monitor.c | 29 +++--
2 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
index a49ea11..07e3d29 100644
--- a/include
()
get_real_id()
error_report()
error_printf()
error_report()
assign_intx()
check_irqchip_in_kernel()
error_report()
error_report()
error_printf()
Laszlo Ersek (16):
cutils: tighten qemu_parse_fd
-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index b4696aa..f91d4fb 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 45 +++--
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index c6d1094..2de6559 100644
--- a/hw/i386/kvm/pci
-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index a825871..bfce97f 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
@@ -539,22
Rename check_irqchip_in_kernel() to verify_irqchip_in_kernel(), so that
the name reflects our expectation better. Rather than returning a bool,
make it do nothing or set an Error.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 25 +
1 file
This allows us to report the entire error with one error_report() call,
easing future error propagation.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/i386/kvm/pci
Among the callers, only assigned_initfn() should set the monitor's stored
error. Other callers may run in contexts where the monitor's stored error
makes no sense. For example:
assigned_dev_pci_write_config()
assigned_dev_update_msix()
assign_intx()
Signed-off-by: Laszlo Ersek ler
The return type is also changed from int to void, because it was used
in a success vs. failure sense only (the caller didn't distinguish error
codes from each other, and even assigned_dev_register_msix_mmio() masked
mmap()'s errno values with a common -EFAULT).
Signed-off-by: Laszlo Ersek ler
assigned_initfn()
get_real_device()
read()
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index f91d4fb..e89bb6a 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index e89bb6a..c6d1094 100644
--- a/hw/i386/kvm/pci
get_real_id() has two thin wrappers (and no other callers),
get_real_vendor_id() and get_real_device_id(); it's easiest to convert
them in one fell swoop.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 45 +++--
1 file changed
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index 3a904e8..9aa92a1 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386
Also, change the return type to void; the function is static (with a
sole caller) and the negative errno values are not distinguished from each
other.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 29 +++--
1 file changed, 15 insertions
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/i386/kvm/pci-assign.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index 6891729..e55421a 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw
On 04/11/14 14:02, Michael Tokarev wrote:
Chris Boot updated his qemu from 1.7.0 to 1.7.1, and noticed that windows
guests
which was using virtio-scsi does not work anymore. Windows BSODs at
boot with the following error:
STOP: c221 Unknown Hard Error
On 04/11/14 14:27, Laszlo Ersek wrote:
On 04/11/14 14:02, Michael Tokarev wrote:
More, the same issue exists on 2.0-tobe as well, but in this case, reverting
the same commit from there -- a87f39543a9259f671c5413723311180ee2ad2a8 --
does NOT fix the problem. I'm bisecting between 1.7.0
On 03/20/14 20:21, Michael Roth wrote:
Quoting Markus Armbruster (2014-03-18 04:32:08)
Peter Maydell peter.mayd...@linaro.org writes:
This is something clang's -fsanitize=undefined spotted. The
code generated by qapi-commands.py in qmp-marshal.c for
qmp_marshal_* functions where there are
On 04/13/14 02:55, Gabriel L. Somlo wrote:
Kevin,
Thanks for the comments. I'll work your feedback (and any other
feedback I get by early next week) into another iteration of smbios
patches for both SeaBIOS and QEMU.
In the mean time, there's one remaining big picture design question:
On 04/14/14 04:27, Amos Kong wrote:
We already have a function buffer_is_zero() in util/cutils.c
Signed-off-by: Amos Kong ak...@redhat.com
---
arch_init.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 60c975d..342e5dc 100644
On 04/14/14 20:47, Pieter Hollants wrote:
Public bug reported:
libvirtd 1.2.3
virt-manager 1.0.1
qemu 1.7.92 (2.0.0-rc2)
I think this should be fixed by Cole's patch, in rc3:
commit 92b3eeadd9bc72f1f4e5ba1f62a289dc0190e88f
Author: Cole Robinson crobi...@redhat.com
Date: Thu Apr 10
On 04/15/14 01:55, Michael R. Hines wrote:
On 04/14/2014 05:19 PM, Laszlo Ersek wrote:
On 04/14/14 04:27, Amos Kong wrote:
We already have a function buffer_is_zero() in util/cutils.c
Signed-off-by: Amos Kong ak...@redhat.com
---
arch_init.c | 9 ++---
1 file changed, 2 insertions
On 04/15/14 11:58, Dr. David Alan Gilbert wrote:
* Kevin Grandemange (grandemange.ke...@gmail.com) wrote:
Hi,
I was wondering if a document describing how the differents parts of Qemu
worked together existed and if someone could pinpoint it to me. (or explain
it to me ;) )
This project is
On 05/29/14 23:05, Eric Blake wrote:
On 05/29/2014 02:43 PM, Laszlo Ersek wrote:
+# backend (eg. with the chardev=... option) is in open or
+# closed state (since 2.2)
Why 2.2? Are you saying it is too late to make the 2.1 soft freeze?
I thought
On 06/25/14 15:16, Luiz Capitulino wrote:
On Wed, 25 Jun 2014 07:14:08 -0600
Eric Blake ebl...@redhat.com wrote:
On 06/25/2014 07:02 AM, Luiz Capitulino wrote:
On Tue, 24 Jun 2014 08:36:36 -0600
Eric Blake ebl...@redhat.com wrote:
[cc'ing Luiz]
On 06/24/2014 08:21 AM, Laszlo Ersek wrote
in the
v1 blurb. Please review.
Thanks,
Laszlo
Laszlo Ersek (2):
virtio-serial: report frontend connection state via monitor
char: report frontend open/closed state in 'query-chardev'
qapi-event.json | 16
qapi-schema.json | 24 +++-
hw/char
Libvirt wants to know about the guest-side connection state of some
virtio-serial ports (in particular the one(s) assigned to guest agent(s)).
Report such states with a new monitor event.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
Signed-off-by: Laszlo Ersek ler...@redhat.com
identifies the frontend device, by id. The
'query-chardev' QMP command identifies the backend device (again by id).
The association is under libvirt's control.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
Notes:
v2:
- rename
On 06/26/14 14:09, Eric Blake wrote:
On 06/26/2014 05:11 AM, Laszlo Ersek wrote:
In addition to the on-line reporting added in the previous patch, allow
libvirt to query frontend state independently of events.
Libvirt's path to identify the guest agent channel it cares about differs
between
identifies the frontend device, by id. The
'query-chardev' QMP command identifies the backend device (again by id).
The association is under libvirt's control.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
Reviewed-by: Amit Shah amit.s...@redhat.com
Signed-off-by: Laszlo Ersek ler
Libvirt wants to know about the guest-side connection state of some
virtio-serial ports (in particular the one(s) assigned to guest agent(s)).
Report such states with a new monitor event.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
Signed-off-by: Laszlo Ersek ler...@redhat.com
Changes in v3: patch 1 creates the event with a bool field called
open in the data portion, instead of introducing a two-valued enum.
Patch 2 is left intact. Retested.
Laszlo Ersek (2):
virtio-serial: report frontend connection state via monitor
char: report frontend open/closed state
On 06/26/14 18:37, Eric Blake wrote:
On 06/26/2014 09:50 AM, Laszlo Ersek wrote:
Changes in v3: patch 1 creates the event with a bool field called
open in the data portion, instead of introducing a two-valued enum.
Patch 2 is left intact. Retested.
Laszlo Ersek (2):
virtio-serial: report
On 06/26/14 22:16, Laszlo Ersek wrote:
2014-06-26 15:41:37.895+: 1637: debug :
qemuMonitorJSONIOProcessLine:172 : QEMU_MONITOR_RECV_EVENT:
mon=0x7f2e2400cfd0 event={timestamp: {seconds: 1403797297,
microseconds: 895242}, event: VSERPORT_CHANGE, data: {open:
true, id: channel0}}
2014
On 05/07/14 16:42, Marcel Apfelbaum wrote:
Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields
are copied into MachineState. Removed duplicated fields from MachineState.
All the other changes are only mechanical refactoring, no semantic changes.
Signed-off-by: Marcel
On 05/13/14 14:58, Jaeyong Yoo wrote:
Hello qemu!
I am currently writing a vga device emulator and need to debug vga-bios.
What I want is to set break-point on the entry of vga-bios and for this,
I'm reading qemu source around pci device and rom-related memory regions
to find out
more useful when
used with edk2/ovmf. Only pc machines 2.1 and newer are affected, and only
when the user explicitly requests that a type 0 struct be generated.
Signed-off-by: Gabriel Somlo so...@cmu.edu
---
On Mon, May 12, 2014 at 11:20:15PM +0200, Laszlo Ersek wrote:
I think exposing
901 - 1000 of 4203 matches
Mail list logo