[Qemu-devel] [PULL 18/43] qapi event: convert STOP

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- cpus.c | 4 +++- docs/qmp/qmp-events.txt | 12 qapi-event.json | 9 + 3 files changed, 12 insertions(+), 13

[Qemu-devel] [PULL 08/43] qapi: Add includes from qapi/ as dependencies

: Eric Blake Signed-off-by: Luiz Capitulino --- Makefile | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 3c8f19c..800fbf3 100644 --- a/Makefile +++ b/Makefile @@ -246,18 +246,21 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi

[Qemu-devel] [PULL 26/43] qapi event: convert DEVICE_TRAY_MOVED

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- block.c | 21 +++-- docs/qmp/qmp-events.txt | 18 -- qapi/block.json | 14 ++ 3 files

[Qemu-devel] [PULL 40/43] qemu-char: move pty_chr_update_read_handler around

From: Paolo Bonzini Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- qemu-char.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 28ea9f2..9961b02 100644 --- a/qemu

[Qemu-devel] [PULL 23/43] qapi event: convert RTC_CHANGE

From: Wenchao Xia This patch also eliminates build time warning caused by no caller of monitor_qapi_event_throttle(). Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 16 hw/ppc

[Qemu-devel] [PULL 17/43] qapi event: convert RESET

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 12 qapi-event.json | 9 + vl.c| 2 +- 3 files changed, 10 insertions(+), 13

[Qemu-devel] [PULL 16/43] qapi event: convert POWERDOWN

From: Wenchao Xia There is no existing comments for POWERDOWN in doc/qmp/qmp-events.txt, so no change on it like other conversion patch. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi-event.json | 10 ++ vl.c

[Qemu-devel] [PULL 36/43] qapi event: convert QUORUM events

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- block/quorum.c | 25 - docs/qmp/qmp-events.txt | 41 - monitor.c | 6

[Qemu-devel] [PULL 22/43] qapi event: convert WAKEUP

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 12 qapi-event.json | 9 + vl.c| 2 +- 3 files changed, 10 insertions(+), 13

[Qemu-devel] [PULL 42/43] monitor: protect outbuf and mux_out with mutex

From: Paolo Bonzini This lets the block layer emit QMP events from outside the I/O thread. Reviewed-by: Luiz Capitulino Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- monitor.c | 45 - 1 file changed, 36 insertions(+), 9 deletions

[Qemu-devel] [PULL 10/43] qapi script: add event support

ned-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- Makefile | 11 +- Makefile.objs| 2 +- docs/qapi-code-gen.txt | 18 ++ scripts/qap

[Qemu-devel] [PULL 19/43] qapi event: convert RESUME

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 12 qapi-event.json | 9 + vl.c| 4 ++-- 3 files changed, 11 insertions(+), 14

[Qemu-devel] [PULL 21/43] qapi event: convert SUSPEND_DISK

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 14 -- hw/acpi/core.c | 4 ++-- qapi-event.json | 12 3 files changed, 14 insertions

[Qemu-devel] [PULL 43/43] monitor: protect event emission

From: Paolo Bonzini Event emission must be protected by a mutex because of access to the shared rate-limiting state, and to guard against concurrent monitor "hot-plug" by means of human-monitor-command. Reviewed-by: Luiz Capitulino Signed-off-by: Paolo Bonzini Signed-off-by: Luiz

[Qemu-devel] [PULL 28/43] qapi event: convert BLOCK_IMAGE_CORRUPTED

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- block/qcow2-refcount.c | 14 -- docs/qmp/qmp-events.txt | 22 -- qapi/block-core.json| 24 3

[Qemu-devel] [PULL 37/43] qapi event: clean up

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- include/monitor/monitor.h | 40 - monitor.c | 220 + stubs/Makefile.objs| 1

Re: [Qemu-devel] [PULL 00/43] QMP queue

[Forgot CC'ing Paolo and Eric] On Mon, 23 Jun 2014 12:36:00 -0400 Luiz Capitulino wrote: > The following changes since commit d9c1647d896d3192cba9dbf98fb7efab876edde5: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging

[Qemu-devel] [PULL 33/43] qmp: convert ACPI_DEVICE_OST event

From: Igor Mammedov ... using new QAPI event infrastructure Signed-off-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 10 -- hw/acpi/memory_hotplug.c | 34 ++ include/monitor/monitor.h | 1 - monitor.c

[Qemu-devel] [PULL 05/43] qapi: Suppress unwanted space between type and identifier

From: Amos Kong We always generate a space between type and identifier in parameter and variable declarations, even when idiomatic C style doesn't have a space there. Suppress it. Signed-off-by: Amos Kong Signed-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 4 ++-- scripts/qa

[Qemu-devel] [PULL 14/43] qapi: add new schema file qapi-event.json

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- Makefile | 3 ++- qapi-event.json | 0 qapi-schema.json | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 qapi-event.json

[Qemu-devel] [PULL 34/43] qapi event: convert BALLOON_CHANGE

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- balloon.c | 13 - docs/qmp/qmp-events.txt| 17 - hw/virtio/virtio-balloon.c | 6 -- include/sysemu

[Qemu-devel] [PULL 25/43] qapi event: convert DEVICE_DELETED

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 18 -- hw/core/qdev.c | 12 ++-- qapi-event.json | 16 3 files changed, 18

[Qemu-devel] [PULL 29/43] qapi event: convert other BLOCK_JOB events

Signed-off-by: Luiz Capitulino --- block/mirror.c | 2 +- blockdev.c | 12 blockjob.c | 36 +--- docs/qmp/qmp-events.txt | 71 include/block/blockjob.h | 17 +--- qapi/block

[Qemu-devel] [PULL 38/43] qemu-char: introduce qemu_chr_alloc

From: Paolo Bonzini The next patch will modify this function to initialize state that is common to all backends. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- backends/baum.c | 2 +- backends/msmouse.c| 2 +- include/sysemu/char.h | 9

[Qemu-devel] [PULL 32/43] qapi event: convert SPICE events

docs/qmp/qmp-events.txt before this patch. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 62 --- include/qemu/sockets.h | 1 - qapi-event.json | 55

[Qemu-devel] [PULL 41/43] qemu-char: make writes thread-safe

state is protected with the chr_write_lock too. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- include/sysemu/char.h | 11 ++ qemu-char.c | 58 --- 2 files changed, 53 insertions(+), 16

[Qemu-devel] [PULL 09/43] qapi: add event helper functions

From: Wenchao Xia This file holds some functions that do not need to be generated. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- include/qapi/qmp-event.h | 27 ++ qapi/Makefile.objs | 1 + qapi/qmp

[Qemu-devel] [PULL 35/43] qapi event: convert GUEST_PANICKED

From: Wenchao Xia 'monitor.h' is still included in target-s390x/kvm.c, since I have no good way to verify whether other code need it on my x86 host. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-

[Qemu-devel] [PULL 27/43] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- block.c | 41 - blockjob.c| 6 +- docs/qmp/qmp-events.txt | 47

[Qemu-devel] [PULL 15/43] qapi event: convert SHUTDOWN

From: Wenchao Xia This patch also eliminates build time warning caused by QAPI_EVENT_MAX = 0. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 15 --- qapi-event.json | 12

[Qemu-devel] [PULL 24/43] qapi event: convert WATCHDOG

From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 19 --- hw/watchdog/watchdog.c | 23 +++ monitor.c | 2 +- qapi-event.json

[Qemu-devel] [PULL 30/43] qapi event: convert NIC_RX_FILTER_CHANGED

From: Wenchao Xia Param name is declared as optional, since in code it is an optional one. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 17 - hw/net/virtio-net.c | 13

[Qemu-devel] [PULL 13/43] monitor: add an implemention of qapi event emit method

by no caller of monitor_qapi_event_throttle(), the other one is caused by QAPI_EVENT_MAX = 0. They will be fixed automatically after full event conversion later. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- monitor.c | 128

[Qemu-devel] [PULL 04/43] qapi: add const prefix to 'char *' insider c_type()

d-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 4 +--- scripts/qapi.py | 4 +++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 7d93d01..34f200a 100644 --- a/scripts/qapi-commands.py +++ b/scripts

[Qemu-devel] [PULL 31/43] qapi event: convert VNC events

From: Wenchao Xia Since VNC_CONNECTED, VNC_DISCONNECTED, VNC_INITIALIZED share some common functions, convert them in one patch. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 90

[Qemu-devel] [PULL 39/43] qemu-char: do not call chr_write directly

From: Paolo Bonzini Make the mux always go through qemu_chr_fe_write, so that we'll get the mutex for the underlying chardev. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- qemu-char.c | 14 +++--- 1 file changed, 7 insertions(+), 7 dele

[Qemu-devel] [PULL 01/43] fpu: softfloat: drop INLINE macro

at-2b. Signed-off-by: Luiz Capitulino --- fpu/softfloat-macros.h | 38 +-- fpu/softfloat.c | 48 include/fpu/softfloat.h | 99 - 3 files changed, 92 insertions(+), 93 deletions(-) diff --git a/fpu/soft

[Qemu-devel] [PULL 11/43] test: add test cases for qapi event

From: Wenchao Xia These cases will verify whether the expected qdict is built. Signed-off-by: Wenchao Xia Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/Makefile | 16 +- tests/qapi-schema/qapi-schema-test.json | 12

[Qemu-devel] [PULL 00/43] QMP queue

nwanted space between type and identifier Igor Mammedov (1): qmp: convert ACPI_DEVICE_OST event Luiz Capitulino (2): fpu: softfloat: drop INLINE macro audio: fmopl: drop INLINE macro Max Reitz (1): qapi: Add includes from qapi/ as dependencies Paolo Bonzini (7): jso

Re: [Qemu-devel] [RFC 0/3] QMP: extend BLOCK_IO_ERROR event

On Tue, 5 Aug 2014 11:13:39 +0200 Kevin Wolf wrote: > Am 23.07.2014 um 15:17 hat Luiz Capitulino geschrieben: > > > > Management software, such as OpenStack and RHEV's vdsm, wants to be able > > to allocate VM disk space on demand. The basic use case is to start a VM

Re: [Qemu-devel] [RFC 3/3] QMP: extend BLOCK_IO_ERROR event with no-space indicator

On Tue, 05 Aug 2014 06:19:27 -0600 Eric Blake wrote: > On 07/23/2014 07:17 AM, Luiz Capitulino wrote: > > Management software, such as OpenStack and RHEV's vdsm, want to be able > > to allocate disk space on demand. The basic use case is to start a VM > > with a small

Re: [Qemu-devel] [RFC 2/3] QMP: rate limit BLOCK_IO_ERROR

On Mon, 11 Aug 2014 09:17:19 +0100 "Daniel P. Berrange" wrote: > On Wed, Jul 23, 2014 at 09:17:17AM -0400, Luiz Capitulino wrote: > > This event has the same characteristics of the other rate-limited > > events, mainly we can emit dozens of it. Rate limit it then. >

Re: [Qemu-devel] [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()

On Sun, 03 Aug 2014 23:28:56 +0800 Chen Gang wrote: > In dump_init(), when failure occurs, need notice about 'fd' and memory > mapping. So call dump_cleanup() for it (need let all initializations at > front). > > Also simplify dump_cleanup(): remove redundant 'ret' and redundant 'fd' > checking.

Re: [Qemu-devel] [PATCH v3 00/14] drop qapi nested structs

On Tue, 5 Aug 2014 19:14:19 -0600 Eric Blake wrote: > According to this email: > https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html > we want to repurpose 'data': { 'name': {dict...} } in qapi files > for future use of designating default values of optional parameters. > But to

Re: [Qemu-devel] [PATCH v6 02/10] monitor: fix access freed memory

On Thu, 14 Aug 2014 12:30:10 +0200 "Michael S. Tsirkin" wrote: > On Thu, Aug 14, 2014 at 03:29:13PM +0800, zhanghailiang wrote: > > The function monitor_fdset_dup_fd_find_remove() references member of > > 'mon_fdset' > > which may be freed in function monitor_fdset_cleanup() > > > > Reviewed-by

Re: [Qemu-devel] Tracing HMP commands

On Mon, 18 Aug 2014 17:10:36 +0200 Lluís Vilanova wrote: > Hi! I've been writing some QAPI/QMP commands to control tracing state, and I > was > wondering if the HMP commands (trace-event, trace-file and trace-events) can > be > dropped, or whether I should adapt them to the new ones. As far as

Re: [Qemu-devel] [PATCH] monitor: fix use after free

On Sun, 17 Aug 2014 11:45:17 +0200 "Michael S. Tsirkin" wrote: > The function monitor_fdset_dup_fd_find_remove() references member of > 'mon_fdset' which - when remove flag is set - may be freed in function > monitor_fdset_cleanup(). > remove is set by monitor_fdset_dup_fd_remove which in practic

[Qemu-devel] [PULL 3/3] monitor: fix use after free

urned value, so make it void, and return -1 from monitor_fdset_dup_fd_find_remove. Reported-by: zhanghailiang Signed-off-by: Michael S. Tsirkin Signed-off-by: Luiz Capitulino --- include/monitor/monitor.h | 2 +- monitor.c | 8 +--- stubs/fdset-remove-fd.c | 3 +--

[Qemu-devel] [PULL 2/3] dump.c: Fix memory leak issue in cleanup processing for dump_init()

Chen Gang Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/dump.c b/dump.c index ce646bc..71d3e94 100644 --- a/dump.c +++ b/dump.c @@ -71,18 +71,14 @@ uint64_t cpu_to_dump64(DumpState *

[Qemu-devel] [PULL 0/3] QMP queue

Three little birds. The following changes since commit 08ab59770da57648bfb8fc9be37f0ef7fb50b0f9: Merge remote-tracking branch 'remotes/mcayland/qemu-sparc' into staging (2014-08-18 12:55:02 +0100) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp fo

[Qemu-devel] [PULL 1/3] monitor: Remove hardcoded watchdog event names

From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- monitor.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index cdbaa60..48f0fdc 100644 --- a/monitor.c +++ b/monitor.c @@ -4521,16 +4521,15 @@ void

Re: [Qemu-devel] [PATCH] monitor: fix use after free

On Mon, 18 Aug 2014 22:03:31 +0200 "Michael S. Tsirkin" wrote: > On Mon, Aug 18, 2014 at 02:05:46PM -0400, Luiz Capitulino wrote: > > On Sun, 17 Aug 2014 11:45:17 +0200 > > "Michael S. Tsirkin" wrote: > > > > > The function monit

[Qemu-devel] [BUG] Possible ACPI regression in v2.1.0

Starting a QEMU instance manually configured to boot a Fedora installation kernel with the -kernel/-initrd command-line options cause ACPI to brake in the guest with the following messages: [0.00] ACPI: uC\xffcdT 3ffe1854 2009587B (v49 \xffb2?a\xffdf?? \xffca\xfff

Re: [Qemu-devel] [PATCH] pc: reserve more memory for ACPI for new machine types

memory. > > As a result, issues on boot and halt are observed. > > Fix this up by doubling reserved memory for new machine types. > > Cc: qemu-sta...@nongnu.org > Reported-by: Stefan Hajnoczi Tested-by: Luiz Capitulino > Signed-off-by: Michael S. Tsirkin >

Re: [Qemu-devel] [BUG] Possible ACPI regression in v2.1.0

On Wed, 20 Aug 2014 23:00:57 +0200 "Michael S. Tsirkin" wrote: > On Wed, Aug 20, 2014 at 04:41:25PM -0400, Luiz Capitulino wrote: > > > > Starting a QEMU instance manually configured to boot a Fedora installation > > kernel with the -kernel/-initrd command-l

Re: [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error

On Thu, 21 Aug 2014 21:03:09 +0800 wrote: > From: Gonglei > > error: 'i' undeclared (first use in this function) > > Signed-off-by: Gonglei Applied to the qmp branch, thanks. > --- > v2: > avoid to mix code and declarations, add a pair of {}, thanks Peter. > --- > monitor.c | 7 +-- >

Re: [Qemu-devel] [PATCH] dump: let dump_error printf the error reason

On Wed, 27 Aug 2014 19:18:53 +0800 zhanghailiang wrote: > The second parameter of dump_error is unused, but one purpose of > using this function is to report the error info. > > Signed-off-by: zhanghailiang > --- > dump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dump.c b/du

[Qemu-devel] Suspend/Hibernation support status in RHEL7

Hi, After having debugged a hibernation BZ reported by QE, I got confused about the support status of suspend/hibernate in RHEL7. What I had in mind was that S3 was supported but S4 was not. Amit confirmed that S4 is not supported in RHEL7, but: 1. We document, or at least imply, that both S3 a

Re: [Qemu-devel] Suspend/Hibernation support status in RHEL7

On Wed, 27 Aug 2014 15:07:48 -0400 Luiz Capitulino wrote: > Hi, > > After having debugged a hibernation BZ reported by QE, I got confused > about the support status of suspend/hibernate in RHEL7. Please, disregard. Internal email :(

[Qemu-devel] [BUG] Guest freezes when resuming from S3

Hi, I won't have time to keep debugging this so I'll just report what I have. The basic problem is: you suspend a Linux guest to RAM, and the screen (or maybe the guest) freezes when resuming. Here's some debugging info: v1.6.0: last fully working version v1.7.0: doesn't exactly freeze, but the

Re: [Qemu-devel] [PATCH V7 00/13] monitor: support sub command group in auto completion and help

On Fri, 26 Jul 2013 11:22:56 +0800 Wenchao Xia wrote: > >> > >Luiz, do you like a respin for this version? There are some typo in > > commit message Eric have pointed out. > > >I have respinned v8 to fix the typo issues, sorry for interrupt. I was on vacation. I'll review v8 soon.

Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage

On Fri, 19 Jul 2013 11:23:45 +0900 Pawit Pornkitprasan wrote: > The "completed" stage sets total_time but not has_total_time and > thus it is not sent via QMP reply (but sent via HMP nevertheless) > > Signed-off-by: Pawit Pornkitprasan Applied to the qmp branch, thanks. > --- > migration.c |

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

On Fri, 19 Jul 2013 11:36:41 +0900 Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 4 ++--

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

On Fri, 19 Jul 2013 04:57:51 -0600 Eric Blake wrote: > On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote: > > The qmp_migrate method uses the 'blk' and 'inc' parameter without > > checking if they're valid or not (they may be uninitialized if > > command is received via QMP) > > > > Signed-off-b

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek wrote: > (Apologies for the long To: list, I'm including everyone who > participated in > ). > > Conceptually, the dump-guest-memory command works as follows: > (a) pause the gues

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

On Mon, 22 Jul 2013 23:23:29 +0200 Andreas Färber wrote: > Am 22.07.2013 23:03, schrieb Seiji Aguchi: > > Convert stderr messages calling error_get_pretty() > > to error_report(). > > > > Timestamp is prepended by -msg timstamp option with it. > > > &g

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

On Mon, 29 Jul 2013 23:23:32 +0200 Andreas Färber wrote: > Am 29.07.2013 23:20, schrieb Luiz Capitulino: > > On Mon, 22 Jul 2013 23:23:29 +0200 > > Andreas Färber wrote: > >> Am 22.07.2013 23:03, schrieb Seiji Aguchi: > >>> Convert stderr messages

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

On Tue, 30 Jul 2013 02:00:40 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 29 Jul 2013 23:23:32 +0200 > > Andreas Färber wrote: > > > >> Am 29.07.2013 23:20, schrieb Luiz Capitulino: > >> > On Mon, 22 Jul 2013 23:23:29 +

Re: [Qemu-devel] [PATCH v2] migration: don't use uninitialized variables

On Tue, 30 Jul 2013 08:39:52 +0900 Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan Applied to the qmp branch, th

Re: [Qemu-devel] [PATCH V8 09/13] monitor: support sub command in help

On Fri, 26 Jul 2013 11:20:38 +0800 Wenchao Xia wrote: > The old code in help_cmd() uses global 'info_cmds' and treats it as a > special case. Actually 'info_cmds' is a sub command group of 'mon_cmds', > in order to avoid direct use of it, help_cmd() needs to change its work > mechanism to support

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

On Fri, 26 Jul 2013 11:20:29 +0800 Wenchao Xia wrote: > This series make auto completion and help functions works normal for sub > command, by using reentrant functions. In order to do that, global variables > are not directly used in those functions any more. With this series, cmd_table > is a m

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

On Fri, 26 Jul 2013 20:14:06 +0200 Kevin Wolf wrote: > Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: > > Overall, I like where this is headed, but I'm not quite sure it is ready > > for commit as-is; looking forward to v2. Given my positive review on > > the rest of the series, I think you

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek wrote: > (Apologies for the long To: list, I'm including everyone who > participated in > ). > > Conceptually, the dump-guest-memory command works as follows: > (a) pause the gues

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

olf > Cc: Anthony Liguori > Cc: Markus Armbruster > Cc: Stefan Hajnoczi > Cc: Luiz Capitulino > Cc: Jeff Cody > Cc: Peter Lieven > Signed-off-by: Paolo Bonzini > --- > block/raw.c | 23 +++ > 1 file changed, 23 insertions(+) Signed-off-by: L

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

On Wed, 31 Jul 2013 14:23:08 +0200 Laszlo Ersek wrote: > Hi Qiao, > > On 07/31/13 11:26, Qiao Nuohan wrote: > > Hello Luiz and Amos, > > > > My patches are waiting for introspection. But now I cannot quite catch > > the situation of introspection, so I hope to get some information about > > cur

[Qemu-devel] [PULL 1/2] migration: send total time in QMP at "completed" stage

From: Pawit Pornkitprasan The "completed" stage sets total_time but not has_total_time and thus it is not sent via QMP reply (but sent via HMP nevertheless) Signed-off-by: Pawit Pornkitprasan Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman Signed-off-by: Luiz Capitulino --- m

[Qemu-devel] [PULL for-1.6 0/2] QMP queue

The following changes since commit 1197cbb9eda1dc82e2fa1815ca62bc3de158353e: qdev: Use clz in print_size (2013-07-31 07:54:21 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to 8c0426aed1d2279845e6a2c3355da8b5d9926c

[Qemu-devel] [PULL 2/2] migration: don't use uninitialized variables

From: Pawit Pornkitprasan The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan Reviewed-by: Eric Blake Signed-off-by: Luiz Cap

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

On Thu, 1 Aug 2013 09:41:07 -0400 Luiz Capitulino wrote: > Applied to the qmp branch, thanks. Hmm, it brakes the build. Dropping it from the queue for now: /home/lcapitulino/work/src/upstream/qmp-unstable/target-s390x/arch_dump.c:179:5: error: conflicting types for ‘cpu_get_dump_info’

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

son J. Herne > > What are your thoughts on this? Looks good: Reviewed-by: Luiz Capitulino > > Thanks, > Andreas > > > --- > > hmp-commands.hx | 13 + > > hmp.c | 10 ++ > > hmp.h |1 + > > 3 files ch

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek wrote: > (Apologies for the long To: list, I'm including everyone who > participated in > ). > > Conceptually, the dump-guest-memory command works as follows: > (a) pause the gues

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

On Thu, 01 Aug 2013 07:52:17 -0600 Eric Blake wrote: > On 08/01/2013 12:31 AM, Fam Zheng wrote: > > Fix it by calling strtoll instead, which will report ERANGE as expected. > > > > (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 > > (HMP) block_set_io_throttle ide0-hd0

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc1 is now available

On Mon, 05 Aug 2013 14:01:10 +0200 Laszlo Ersek wrote: > Please do consider it for 1.6, it addresses a serious bug (= vmcores saved > with dump-guest-memory/paging=false are broken for > 3.5G x86(_64) guests). No worries, it is going to be included (unless someone has a serious objection, of cou

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

On Tue, 6 Aug 2013 12:37:07 +0200 Laszlo Ersek wrote: > v2->v3 [Paolo]: > - The memory API guarantees an increasing traversal. Drop the hash > tables and build the final list directly in the region_add callback, > merging any adjacent region only with the last element on the list. > (Patch

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

On Thu, 8 Aug 2013 11:46:14 +0300 Orit Wasserman wrote: > "ram" is present also when migration completes. > total-time and downtime are no longer part of "ram" data. expected-downtime has to be moved too, looks good otherwise. > > Signed-off-by: Orit Wasserman > --- > qmp-commands.hx | 14 +

[Qemu-devel] [PULL 1/4] dump: clamp guest-provided mapping lengths to ramblock sizes

alid portion of the PT_LOAD entry. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c | 65 - 1 file changed, 40 insertions(+), 25 deletions(-)

[Qemu-devel] [PULL for-1.6 0/4] QMP queue

The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to 56c4bfb3f07f310

[Qemu-devel] [PULL 3/4] dump: populate guest_phys_blocks

t the dump will be based on. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c | 2 +- include/sysemu/memory_mapping.h | 1 + memory_mapping.c

[Qemu-devel] [PULL 4/4] dump: rebase from host-private RAMBlock offsets to guest-physical addresses

---+ ram_size + 512 MB Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c | 77 - include

[Qemu-devel] [PULL 2/4] dump: introduce GuestPhysBlockList

https://bugzilla.redhat.com/show_bug.cgi?id=981582 Signed-off-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c | 31 +++ include/sysemu/memory_mapping.h | 22 ++ memory_mapping.c| 17 + 3 files ch

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

On Thu, 08 Aug 2013 19:47:50 +0300 Orit Wasserman wrote: > On 08/08/2013 05:50 PM, Luiz Capitulino wrote: > > On Thu, 8 Aug 2013 11:46:14 +0300 > > Orit Wasserman wrote: > > > >> "ram" is present also when migration completes. > >> total-t

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

On Thu, 8 Aug 2013 20:05:48 +0300 Orit Wasserman wrote: > "ram" is present also when migration completes. > expected-downtime, total-time and downtime are no longer part of "ram" data. > > Signed-off-by: Orit Wasserman Applied to the qmp branch, thanks. > --- > qmp-commands.hx | 20

Re: [Qemu-devel] [PATCH v2] Convert stderr message calling error_get_pretty() to error_report()

On Tue, 13 Aug 2013 20:27:15 + Seiji Aguchi wrote: > Luiz, > > Can you pick up to your tree? Yes, this is queued for review for 1.7. I should start reviewing patches for 1.7 in the end of this week or in the beginning of next week.

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

On Mon, 5 May 2014 14:21:26 -0400 Luiz Capitulino wrote: > On Fri, 2 May 2014 15:52:19 +0200 > Lluís Vilanova wrote: > > > Adds an include primitive to the syntax of QAPI schema files, allowing > > these to > > be modularized into multiple per-topic files in the

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

On Wed, 07 May 2014 19:07:56 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Mon, 5 May 2014 14:21:26 -0400 > > Luiz Capitulino wrote: > > >> On Fri, 2 May 2014 15:52:19 +0200 > >> Lluís Vilanova wrote: > >> > >> >

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

On Wed, 07 May 2014 19:20:14 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Wed, 07 May 2014 19:07:56 +0200 > > Lluís Vilanova wrote: > > >> Luiz Capitulino writes: > >> > >> > On Mon, 5 May 2014 14:21:26 -0400 > >>

Re: [Qemu-devel] [PATCH] qapi: fix null pointer dereference on invalid parameter

On Wed, 07 May 2014 18:55:26 +0200 Markus Armbruster wrote: > Peter Lieven writes: > > > On 07.05.2014 05:05, Eric Blake wrote: > >> On 05/06/2014 06:24 PM, Peter Lieven wrote: > >>> qemu segfaults if it receives an invalid parameter via a > >>> qmp command instead of throwing an error. > >>> >

Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file

On Wed, 07 May 2014 20:46:15 +0200 Lluís Vilanova wrote: > The primitive uses JSON syntax, and include paths are relative to the file > using the directive: > > { 'include': 'path/to/file.json' } > > Signed-off-by: Lluís Vilanova > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()"

On Thu, 8 May 2014 18:03:15 +0200 Peter Lieven wrote: > This reverts commit 25a7017555f1b4aeb543b5d323ff4afb8f9c5437. > > Turns out the argument *can* be null: QEMU now segfaults if it > receives an invalid parameter via a qmp command instead of throwing an > error. > > For example: > { "execu

[Qemu-devel] [PULL 01/38] qapi: [trivial] Break long command lines

From: Lluís Vilanova Signed-off-by: Lluís Vilanova Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- Makefile | 24 ++-- tests/Makefile | 18 ++ 2 files changed, 32 insertions(+), 10 deletions(-) diff --git a

<    6   7   8   9   10   11   12   13   14   15   >