Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 16:49:11 +0200 Kevin Wolf kw...@redhat.com wrote: Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben: On Mon, 17 Jun 2013 15:46:52 +0200 Kevin Wolf kw...@redhat.com wrote: Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: It's just a warning, that you

[Qemu-devel] [PULL 2/9] rng-random: use error_setg_file_open()

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- backends/rng-random.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index 830360c..68dfc8a 100644 --- a/backends/rng-random.c +++ b

[Qemu-devel] [PULL 3/9] block: mirror_complete(): use error_setg_file_open()

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8b07dec..1ae724f 100644

[Qemu-devel] [PULL 5/9] cpus: use error_setg_file_open()

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..c8bc8ad 100644 --- a/cpus.c +++ b/cpus.c @@ -1278,7 +1278,7 @@ void qmp_memsave(int64_t

[Qemu-devel] [PULL 1/9] error: add error_setg_file_open() helper

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- include/qapi/error.h | 5 + util/error.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/qapi/error.h b/include/qapi/error.h index 5cd2f0c..ffd1cea 100644 --- a/include

[Qemu-devel] [PULL 0/9] QMP queue

2013-06-17 Thread Luiz Capitulino
to dbfbc6373441e436ac6e2bcf7a8acb284225aa21: qerror: drop QERR_OPEN_FILE_FAILED macro (2013-06-17 11:01:14 -0400) Luiz Capitulino (9): error: add error_setg_file_open() helper rng-random: use error_setg_file_open() block: mirror_complete

[Qemu-devel] [PULL 4/9] blockdev: use error_setg_file_open()

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9937311..5975dde 100644

[Qemu-devel] [PULL 6/9] dump: qmp_dump_guest_memory(): use error_setg_file_open()

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump.c b/dump.c index 44a1339..c812cfa 100644 --- a/dump.c +++ b/dump.c @@ -853,7 +853,7 @@ void qmp_dump_guest_memory(bool

[Qemu-devel] [PULL 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro

2013-06-17 Thread Luiz Capitulino
Not used since the last commit. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 6c0a18d..c30c2f6 100644

[Qemu-devel] [PULL 7/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open()

2013-06-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2ce439f..ff5ece6 100644 --- a/savevm.c +++ b/savevm.c @@ -2410,7 +2410,7 @@ void

[Qemu-devel] [PULL 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED

2013-06-17 Thread Luiz Capitulino
The call to drv-bdrv_reopen_prepare() can fail due to reasons other than an open failure. Unfortunately, we can't use errno nor -ret, cause they are not always set. Stick to a generic error message then. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Stefan Hajnoczi stefa

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Luiz Capitulino
On Tue, 18 Jun 2013 11:24:54 +0200 Gerd Hoffmann kra...@redhat.com wrote: On 06/17/13 16:50, Luiz Capitulino wrote: +struct screendump_job { +QEMUBH *bh; +QemuConsole *con; +char *filename; +}; We have a job API in the block layer. Would it make sense

Re: [Qemu-devel] Virtio-Balloon : config_set_size

2013-06-20 Thread Luiz Capitulino
On Thu, 20 Jun 2013 12:49:17 +0800 Saptarshi Sen saptarshi@gmail.com wrote: Hi all, I am experimenting with the Virtio- balloon driver in qemu. When I set the balloon size to a arbitrary low value. I see the actual value of the balloon set is not what I intended but

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-06-20 Thread Luiz Capitulino
On Wed, 19 Jun 2013 20:24:37 +0800 Amos Kong ak...@redhat.com wrote: Introduces new monitor command to query QMP schema information, the return data is a nested dict/list, it contains the useful metadata. Thanks for the good work, Amos! When testing this though I actually get qemu-ga's

Re: [Qemu-devel] [PATCH] hmp: Make info block output more readable

2013-06-20 Thread Luiz Capitulino
On Wed, 19 Jun 2013 16:10:55 +0200 Kevin Wolf kw...@redhat.com wrote: HMP is meant for humans and you should notice it. This changes the output format to use a bit more space to display the information more readable and leaves out irrelevant information (e.g. mention only that an image is

Re: [Qemu-devel] [PATCH] hmp: Make info block output more readable

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 11:07:51 +0200 Kevin Wolf kw...@redhat.com wrote: Am 21.06.2013 um 05:27 hat Luiz Capitulino geschrieben: On Wed, 19 Jun 2013 16:10:55 +0200 Kevin Wolf kw...@redhat.com wrote: HMP is meant for humans and you should notice it. This changes the output format

Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 11:31:28 +0100 Eric Blake ebl...@redhat.com wrote: On 06/19/2013 05:28 PM, Kevin Wolf wrote: We don't have to duplicate the definition any more now that we may refer to a type instead. Signed-off-by: Kevin Wolf kw...@redhat.com --- qapi-schema.json | 3 +-- 1

Re: [Qemu-devel] [PATCH 1/2] monitor: discard global variable in auto completion functions

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 14:37:37 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: In monitor_find_completion() and related functions, Global variable *mon_cmds is not used any more, make them reenterable safely. *cur_mon is also not used now. *info_cmds is still there, but soon will be removed

Re: [Qemu-devel] [PATCH 2/2] monitor: support sub commands in auto completion

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 14:37:38 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch allow auot completion work normal in sub command case, info block [DEVICE] can auto complete now, by re-enter the completion function. Also, original info is treated as a special case, now it is

Re: [Qemu-devel] [PATCH] hmp: Make info block output more readable

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 10:43:19 -0500 Anthony Liguori anth...@codemonkey.ws wrote: Kevin Wolf kw...@redhat.com writes: HMP is meant for humans and you should notice it. This changes the output format to use a bit more space to display the information more readable and leaves out

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 08:54:46 +0200 Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: On 05/23/2013 03:07 AM, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster arm...@redhat.com wrote: Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise. I don't think it is. But this series got applied to Michael's tree, so if you want your comments addressed before applying to

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 13:38:04 +0200 Gerd Hoffmann kra...@redhat.com wrote: This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: framebuffer-display enable=on|off scale=on|off device=/dev/fbn hmp: framebuffer-display on|off There

Re: [Qemu-devel] [PATCH V2 5/7] monitor: support sub commands in auto completion

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 12:03:39 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-6-24 20:48, Wenchao Xia 写道: This patch allow auot completion work normal in sub command case, info block [DEVICE] can auto complete now, by re-enter the completion function. Also, original info is

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 11:58:57 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, +/* open framebuffer */ +if (device == NULL) { +device = getenv(FRAMEBUFFER); +} +if (device == NULL) { +device = /dev/fb0; +} Maybe this is a matter of taste,

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-27 Thread Luiz Capitulino
On Thu, 27 Jun 2013 12:05:33 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3608,3 +3608,46 @@ '*cpuid-input-ecx': 'int', 'cpuid-register': 'X86CPURegister32', 'features': 'int' } } +

Re: [Qemu-devel] x86-64 apic panic on shutdown on 1.4.93.

2013-06-27 Thread Luiz Capitulino
On Wed, 26 Jun 2013 00:52:31 -0500 Rob Landley r...@landley.net wrote: I intermittently get this from current kernels running under currentish qemu-git. Look familiar to anybody? Which kernel do you run in the host? Is the guest doing anything special? reboot: machine restart general

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-28 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:03:48 -0600 Eric Blake ebl...@redhat.com wrote: On 06/27/2013 07:29 AM, Luiz Capitulino wrote: On Thu, 27 Jun 2013 12:05:33 +0200 Gerd Hoffmann kra...@redhat.com wrote: +# @device: #optional specifies framebuffer device, default: /dev/fb0 Actually

[Qemu-devel] [PULL] QMP queue

2013-06-28 Thread Luiz Capitulino
The following changes since commit 36125631e79d53ffb9365740f43f386e2171d116: Merge remote-tracking branch 'kwolf/for-anthony' into staging (2013-06-28 10:37:34 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to

[Qemu-devel] [PULL] hmp: Make info block output more readable

2013-06-28 Thread Luiz Capitulino
...@redhat.com Acked-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp.c | 94 +++ 1 file changed, 55 insertions(+), 39 deletions(-) diff --git a/hmp.c b/hmp.c index 148a3fb..2daed43 100644

Re: [Qemu-devel] [PATCH] vl: add missing transition debug-finish_migrate

2013-12-06 Thread Luiz Capitulino
On Tue, 3 Dec 2013 13:00:15 +0100 Paolo Bonzini pbonz...@redhat.com wrote: This fixes an abort if you invoke the migrate command while the guest is being debugged. Cc: qemu-sta...@nongnu.org Cc: lcapitul...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Applied to the qmp

Re: [Qemu-devel] [PATCH] Fix incorrect state information for migrate_cancel

2013-12-06 Thread Luiz Capitulino
On Thu, 05 Dec 2013 18:49:15 -0700 Lin Ma l...@suse.com wrote: In qemu-1.4.x, When performing migrate_cancel on hmp, Sometimes s-state is incorrrectly saved to MIG_STATE_ERROR instead of MIG_STATE_CANCELLED. If the migrate_fd_cancel in main thread is scheduled to run before the thread

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-06 Thread Luiz Capitulino
On Thu, 5 Dec 2013 18:15:00 +0100 Benoît Canet ben...@irqsave.net wrote: --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1675,7 +1675,11 @@ # determine which ones are encrypted, set the passwords with this command, and # then start the guest with the @cont command. # -# @device:

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-06 Thread Luiz Capitulino
On Fri, 06 Dec 2013 08:24:33 -0700 Eric Blake ebl...@redhat.com wrote: On 12/06/2013 07:27 AM, Luiz Capitulino wrote: On Thu, 5 Dec 2013 18:15:00 +0100 Benoît Canet ben...@irqsave.net wrote: -{ 'command': 'block_passwd', 'data': {'device': 'str', 'password': 'str'} } +{ 'command

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-09 Thread Luiz Capitulino
On Mon, 9 Dec 2013 17:23:09 +0100 Kevin Wolf kw...@redhat.com wrote: I'm leaning slightly towards the approach that Benoît took, if only for the naming aspect (that is, I also thought of the idea of a bool flag, but didn't suggest it because I didn't like the implications on the

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-09 Thread Luiz Capitulino
On Mon, 9 Dec 2013 17:48:50 +0100 Benoît Canet benoit.ca...@irqsave.net wrote: Le Monday 09 Dec 2013 à 11:41:09 (-0500), Luiz Capitulino a écrit : On Mon, 9 Dec 2013 17:23:09 +0100 Kevin Wolf kw...@redhat.com wrote: I'm leaning slightly towards the approach that Benoît took, if only

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-10 Thread Luiz Capitulino
On Tue, 10 Dec 2013 10:57:50 +0100 Kevin Wolf kw...@redhat.com wrote: Am 09.12.2013 um 17:41 hat Luiz Capitulino geschrieben: On Mon, 9 Dec 2013 17:23:09 +0100 Kevin Wolf kw...@redhat.com wrote: I'm leaning slightly towards the approach that Benoît took, if only

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-10 Thread Luiz Capitulino
On Tue, 10 Dec 2013 15:25:07 +0100 Kevin Wolf kw...@redhat.com wrote: My objection to your approach is strong because Benoît already sent an alternative which I believe is less worse because with it, arguments actually mean what their names tell instead of having additional bools for oh, and

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-11 Thread Luiz Capitulino
On Wed, 11 Dec 2013 11:52:28 +0800 Fam Zheng f...@redhat.com wrote: On 2013年12月10日 23:16, Luiz Capitulino wrote: On Tue, 10 Dec 2013 15:25:07 +0100 Kevin Wolf kw...@redhat.com wrote: My objection to your approach is strong because Benoît already sent an alternative which I believe

Re: [Qemu-devel] [PATCH v3 0/6] Add error_abort and associated cleanups

2013-12-12 Thread Luiz Capitulino
On Thu, 12 Dec 2013 08:23:06 +0100 Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Wed, Dec 11, 2013 at 11:57 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Following our

Re: [Qemu-devel] [PATCH v3 0/6] Add error_abort and associated cleanups

2013-12-16 Thread Luiz Capitulino
On Tue, 10 Dec 2013 20:09:25 -0800 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Following our discussion RE self asserting API calls, here is a spin of my proposal. This series obsoletes the need for _nofail variants for Error ** accepting APIs. Is also greatly reduces the verbosity

Re: [Qemu-devel] [PATCH 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-16 Thread Luiz Capitulino
On Tue, 10 Dec 2013 19:15:05 +0100 Paolo Bonzini pbonz...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 10/12/2013 19:00, Eric Blake ha scritto: + 'data': {'qom-type': 'str', 'id': 'str', '*props': 'dict'}, + 'gen': 'no' } This feels VERY open-coded. No

Re: [Qemu-devel] [PATCH 0/5] Monitor commands for object-add/del

2013-12-16 Thread Luiz Capitulino
On Tue, 10 Dec 2013 18:00:23 +0100 Paolo Bonzini pbonz...@redhat.com wrote: These allow hotplugging (and hot-unplugging without leaking an object) virtio-rng devices. They can also be used for memory hotplug. Looks OK to me.

Re: [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator

2013-12-16 Thread Luiz Capitulino
On Mon, 16 Dec 2013 10:41:13 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013/12/14 7:50, Eric Blake 写道: On 12/10/2013 10:48 PM, Wenchao Xia wrote: After this patch, hidden enum type BlockdevOptionsKind will not be generated, and other API can use enum BlockdevDriver.

Re: [Qemu-devel] [PATCH] [PATCH RFC v4] qemu-monitor: HMP cpu-add wrapper

2013-12-16 Thread Luiz Capitulino
On Wed, 11 Dec 2013 13:24:14 -0500 Jason J. Herne jjhe...@us.ibm.com wrote: From: Jason J. Herne jjhe...@us.ibm.com Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com Applied to the qmp branch, thanks. --- hmp-commands.hx |

Re: [Qemu-devel] [PATCH v2 0/5] Monitor commands for object-add/del

2013-12-18 Thread Luiz Capitulino
On Tue, 17 Dec 2013 12:25:59 +0100 Paolo Bonzini pbonz...@redhat.com wrote: These allow hotplugging (and hot-unplugging without leaking an object) virtio-rng devices. They can also be used for memory hotplug. v1-v2: fix mistyped underscores in qapi-schema.json Applied to the qmp branch,

[Qemu-devel] [PULL 11/13] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-18 Thread Luiz Capitulino
JSON-based properties dictionary. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-By: Igor Mammedov imamm...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx | 14 +++ hmp.c | 58

[Qemu-devel] [PULL 12/13] monitor: add object-del (QMP) and object_del (HMP) command

2013-12-18 Thread Luiz Capitulino
From: Paolo Bonzini pbonz...@redhat.com These two commands invoke the unparent method of Object. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-By: Igor Mammedov imamm...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx | 14 ++ hmp.c

[Qemu-devel] [PULL 13/13] qemu-monitor: HMP cpu-add wrapper

2013-12-18 Thread Luiz Capitulino
From: Jason J. Herne jjhe...@us.ibm.com Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com Reviewed-By: Igor Mammedov imamm...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx | 13

[Qemu-devel] [PULL 01/13] vl: add missing transition debug-finish_migrate

2013-12-18 Thread Luiz Capitulino
From: Paolo Bonzini pbonz...@redhat.com This fixes an abort if you invoke the migrate command while the guest is being debugged. Cc: qemu-sta...@nongnu.org Cc: lcapitul...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- vl.c

[Qemu-devel] [PULL 06/13] qemu-option: Remove qemu_opts_create_nofail

2013-12-18 Thread Luiz Capitulino
the normal and no_fail variants. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block/blkdebug.c | 2 +- block/blkverify.c | 2 +- block/curl.c | 2 +- block

[Qemu-devel] [PULL 00/13] QMP queue

2013-12-18 Thread Luiz Capitulino
The following changes since commit e157b8fdd412d48eacfbb8c67d3d58780154faa3: Merge remote-tracking branch 'bonzini/virtio' into staging (2013-12-13 11:10:33 -0800) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to

Re: [Qemu-devel] [PATCH] monitor: properly handle invalid fd/vhostfd from command line

2010-10-08 Thread Luiz Capitulino
On Tue, 28 Sep 2010 16:57:44 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Sep 28, 2010 at 11:53:43AM -0300, Luiz Capitulino wrote: On Mon, 27 Sep 2010 15:52:44 +0800 Jason Wang jasow...@redhat.com wrote: monitor_get_fd() may also be used to parse fd or vhostfd from command

Re: [Qemu-devel] [PATCH] monitor: add usb_detach

2010-10-08 Thread Luiz Capitulino
On Tue, 5 Oct 2010 16:40:29 +0200 Alon Levy al...@redhat.com wrote: Signed-off-by: Alon Levy al...@redhat.com This needs to be rebased as it now conflicts with my last series merged on master. I have some minor comments (below), but in general seems ok to me. However, I'd like to get an ACK

[Qemu-devel] Re: [RFT] qemu 0.13.0-rc3

2010-10-11 Thread Luiz Capitulino
that there non-monitor fixes too. Alex Williamson (1): savevm: Reset last block info at beginning of each save Amit Shah (1): migration: Accept 'cont' only after successful incoming migration Eduardo Habkost (1): disable guest-provided stats on info balloon command Luiz

Re: [Qemu-devel] [PATCH] monitor: properly handle invalid fd/vhostfd from command line

2010-10-13 Thread Luiz Capitulino
On Tue, 12 Oct 2010 14:32:25 +0800 jason wang jasow...@redhat.com wrote: On 10/09/2010 01:40 AM, Luiz Capitulino wrote: On Tue, 28 Sep 2010 16:57:44 +0200 Michael S. Tsirkinm...@redhat.com wrote: On Tue, Sep 28, 2010 at 11:53:43AM -0300, Luiz Capitulino wrote: On Mon, 27

Re: [Qemu-devel] [PATCH] Trivial fix for QMP/qmp-events.txt

2010-10-18 Thread Luiz Capitulino
On Thu, 14 Oct 2010 09:51:02 +0900 Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: Fix example of STOP event that was just copy-and-pasted. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Applied to the QMP queue, thanks. --- QMP/qmp-events.txt |2 +- 1 files

Re: [Qemu-devel] [PATCH] Silence compiler warning in json test case

2010-10-18 Thread Luiz Capitulino
On Sat, 16 Oct 2010 19:42:43 +0200 Jan Kiszka jan.kis...@web.de wrote: Am 16.10.2010 18:28, Blue Swirl wrote: On Sat, Oct 16, 2010 at 12:37 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/15/2010 07:41 PM, Blue Swirl wrote: Which functions are optimized away and which aren't? It's

[Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing

2010-10-18 Thread Luiz Capitulino
On Mon, 18 Oct 2010 11:36:55 +0530 Prerna Saxena pre...@linux.vnet.ibm.com wrote: This patch set introduces two QMP interfaces for tracing : * query-trace: to list current contents of trace-buffer * query-trace-events : to list all available trace-events with their state. This is in

Re: [Qemu-devel] qemu aborts if i add a already registered device from qemu monitor ..

2010-10-19 Thread Luiz Capitulino
On Tue, 19 Oct 2010 15:27:37 +0530 pradeep psuri...@linux.vnet.ibm.com wrote: Hi I tried to add a device to guest from upstream qemu monitor using device_add. Are you developing a new device or does it happen with existing ones? If it's the latter, can you describe steps to reproduce it?

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-20 Thread Luiz Capitulino
On Tue, 19 Oct 2010 15:35:01 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, +.help = attach USB device 'bus.addr', +...@item usb_attach @var{devname} /me sees a mismatch here. There is still the use case question. Also note that this might have unwanted side

Re: [Qemu-devel] [PATCH] Fix test suite build with tracing enabled

2010-10-20 Thread Luiz Capitulino
On Tue, 19 Oct 2010 16:03:15 +0200 Jan Kiszka jan.kis...@siemens.com wrote: qemu_malloc instrumentations require linking against the trace objects. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Applied to the Monitor queue, thanks. --- Makefile | 12 ++-- 1 files changed, 6

Re: [Qemu-devel] [PATCH] monitor: Ignore . and .. when completing file name.

2010-10-20 Thread Luiz Capitulino
On Wed, 20 Oct 2010 18:00:01 +0900 Kusanagi Kouichi sl...@ac.auone-net.jp wrote: Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp Applied to the Monitor queue, thanks. --- monitor.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c

[Qemu-devel] Re: [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-20 Thread Luiz Capitulino
On Tue, 19 Oct 2010 11:57:50 +0530 Prerna Saxena pre...@linux.vnet.ibm.com wrote: [PATCH 2/2] Add documentation for QMP commands: - query-trace - query-trace-events - query-trace-file. Please, split this. Each command should be in a separate patch. Signed-off-by: Prerna Saxena

[Qemu-devel] Re: [Tracing][RFC] QMP interface to toggle state of a trace-event

2010-10-20 Thread Luiz Capitulino
On Wed, 20 Oct 2010 15:28:49 +0530 Prerna Saxena pre...@linux.vnet.ibm.com wrote: QMP command trace-event to toggle state of a trace-event. Illustration : - { execute: trace-event, arguments: { name: qemu_malloc, option: true} } - { return: {} } Posting this as an RFC for now. I'll

[Qemu-devel] Re: [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-21 Thread Luiz Capitulino
On Thu, 21 Oct 2010 12:21:46 +0530 Prerna Saxena pre...@linux.vnet.ibm.com wrote: Hi Luiz, Thanks for your feedback. On 10/21/2010 12:47 AM, Luiz Capitulino wrote: On Tue, 19 Oct 2010 11:57:50 +0530 Prerna Saxenapre...@linux.vnet.ibm.com wrote: [PATCH 2/2] Add documentation for QMP

[Qemu-devel] Re: [RESEND PATCH] monitor: properly handle illegal fd/vhostfd from command line

2010-10-22 Thread Luiz Capitulino
. This patch is based on the suggestions from Luiz Capitulino lcapitul...@redhat.com. Signed-off-by: Jason Wang jasow...@redhat.com --- net.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/net.c b/net.c index ed74c7f..ab9c3bb 100644 --- a/net.c +++ b

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levy al...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2-v3 changes: * add configure parameter * fix docs v2

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 07:55:02 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 10/22/2010 07:48 AM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levyal...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzini pbonz...@redhat.com wrote: This is a small start from the autoconfy configure series. Actually, this part is almost completely new. It cleans up the tests Makefile so that the i386-linux-user testsuite's Makefile targets are more easily

[Qemu-devel] [PATCH 1/4] Trivial fix for QMP/qmp-events.txt

2010-10-22 Thread Luiz Capitulino
From: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Fix example of STOP event that was just copy-and-pasted. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 15:38:34 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/22/2010 03:26 PM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzinipbonz...@redhat.com wrote: This is a small start from the autoconfy configure series. Actually, this part

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 15:53:39 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/22/2010 03:44 PM, Luiz Capitulino wrote: We could also have check-i386, check-qmp, etc. and check would simply call all of them. That would be perfect, I think. I mean, if we could stick only to check

[Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-22 Thread Luiz Capitulino
From: Jan Kiszka jan.kis...@web.de This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- check-qjson.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] Fix test suite build with tracing enabled

2010-10-22 Thread Luiz Capitulino
From: Jan Kiszka jan.kis...@siemens.com qemu_malloc instrumentations require linking against the trace objects. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Acked-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile | 12

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 08:43:39 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 10/22/2010 08:17 AM, Luiz Capitulino wrote: You and Gerd asked about the purpose of this command, turns out that it's only useful for developing new USB devices for QEMU, so I thought it would be better

[Qemu-devel] [PULL 0/4]: Monitor queue

2010-10-22 Thread Luiz Capitulino
Anthony, The following patches have been sent to the list and look good to me. I've also tested them. The changes (since d03703c81a202cea156811e5dbc8e88627c19986) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git for-anthony Hidetoshi Seto (1): Trivial

[Qemu-devel] [PATCH 4/4] monitor: Ignore . and .. when completing file name.

2010-10-22 Thread Luiz Capitulino
From: Kusanagi Kouichi sl...@ac.auone-net.jp Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 260cc02..61607c5 100644

Re: [Qemu-devel] [PATCH 2/2] v3 Fix Block Hotplug race with drive_unplug()

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 21:55:53 -0500 Ryan Harper ry...@us.ibm.com wrote: Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that

Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 21:55:51 -0500 Ryan Harper ry...@us.ibm.com wrote: This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some

Re: [Qemu-devel] [PATCH 1/2] v2 Add drive_get_by_id

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 21:55:52 -0500 Ryan Harper ry...@us.ibm.com wrote: Add a function to find a drive by id string. Changes since v1: -Coding Style fix Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 13 + blockdev.h |1 + 2 files changed, 14

Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 19:15:07 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: From: Jan Kiszka jan.kis...@web.de This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed

Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-25 Thread Luiz Capitulino
On Fri, 22 Oct 2010 22:49:10 +0200 Stefan Weil w...@mail.berlios.de wrote: Am 22.10.2010 19:33, schrieb Luiz Capitulino: On Fri, 22 Oct 2010 19:15:07 +0200 Markus Armbrusterarm...@redhat.com wrote: Luiz Capitulinolcapitul...@redhat.com writes: From: Jan Kiszkajan.kis

[Qemu-devel] Re: [V3 PATCH] net: properly handle illegal fd/vhostfd from command line

2010-10-25 Thread Luiz Capitulino
. This patch is based on the suggestions from Luiz Capitulino lcapitul...@redhat.com. Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- net.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/net.c b

[Qemu-devel] [RFC 0/2]: QMP: Human Monitor passthrough

2010-10-25 Thread Luiz Capitulino
This is my first try on implementing HMP passthrough via QMP. I've tried to follow Anthony's advice on creating a buffered char device. If this approach is good (and the implementation is not faulty), I believe this is very near a mergeble state (although I haven't tested much yet). Example: -

[Qemu-devel] [PATCH 2/2] QMP: Introduce Human Monitor passthrough command

2010-10-25 Thread Luiz Capitulino
data from the user (eg. cont when the block device is encrypted) TODO: Create a blacklist for those bad commands or just let them fail? (assuming they won't blowup, of course) TODO: Maybe a command like 'cpu' requires a blacklist Signed-off-by: Luiz Capitulino lcapitul...@redhat.com

[Qemu-devel] [PATCH 1/2] qemu-char: Introduce Buffered driver

2010-10-25 Thread Luiz Capitulino
. This driver is going to be used by the monitor subsystem, which needs to 'emulate' a qemu-char device, so that monitor handlers can be ran without a backing device and have their output stored. TODO: Move buffer growth logic to cutils. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com

[Qemu-devel] [PATCH 0/3]: QMP: Improve demo scripts

2010-10-29 Thread Luiz Capitulino
Please, check individual patches for details. Thanks.

[Qemu-devel] [PATCH 1/3] QMP: Revamp the Python class example

2010-10-29 Thread Luiz Capitulino
to 10 commits, it's really not worth it for a simple demo class. Highlights: o TCP sockets support o QMP events support o Add documentation o Fix a number of unhandled errors o Simplify methods that send commands to the Monitor Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP

[Qemu-devel] [PATCH v1 0/3]: QMP: Human Monitor passthrough

2010-10-29 Thread Luiz Capitulino
Simple example: - { execute: hmp_passthrough, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches for details. Also note that this series depends on the script improvements one. Thanks.

[Qemu-devel] [PATCH 3/3] QMP: Drop vm-info example script

2010-10-29 Thread Luiz Capitulino
It's broken and not really useful, let's just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/README |5 + QMP/vm-info | 33 - 2 files changed, 1 insertions(+), 37 deletions(-) delete mode 100755 QMP/vm-info diff --git a/QMP

[Qemu-devel] [PATCH 2/3] QMP: Revamp the qmp-shell script

2010-10-29 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 179 +--- 1 files changed, 144 insertions(+), 35 deletions(-) diff --git a/QMP/qmp-shell b/QMP/qmp-shell index a5b72d1..1fb7e76 100755 --- a/QMP/qmp-shell +++ b/QMP/qmp-shell @@ -1,8

[Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode

2010-10-29 Thread Luiz Capitulino
) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 70 + 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-shell b/QMP/qmp-shell index 1fb7e76..8eb5b3e 100755 --- a/QMP/qmp-shell +++ b/QMP/qmp-shell

[Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-10-29 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 42

[Qemu-devel] [PATCH 1/3] qemu-char: Introduce Buffered driver

2010-10-29 Thread Luiz Capitulino
to be used by the monitor's HMP passthrough via QMP feature, which needs to run monitor handlers without a backing device. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-char.c | 63 +++ qemu-char.h |6 + 2 files

Re: [Qemu-devel] [PATCH 1/2] monitor: add sub_args_type for second level parameters

2010-11-04 Thread Luiz Capitulino
On Thu, 21 Oct 2010 08:37:19 +0200 Alon Levy al...@redhat.com wrote: --- hmp-commands.hx |1 + monitor.c | 13 - 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 3014b17..289fbcb 100644 --- a/hmp-commands.hx

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Introduce Buffered driver

2010-11-10 Thread Luiz Capitulino
On Wed, 10 Nov 2010 10:26:15 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory qemu-char driver operations, that's, all writes to this driver are stored in an internal buffer. The driver doesn't talk

Re: [Qemu-devel] [PATCH 2/2] QMP: Introduce Human Monitor passthrough command

2010-11-10 Thread Luiz Capitulino
On Wed, 10 Nov 2010 11:03:56 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This command allows QMP clients to execute HMP commands, please check its documentation in the hmp-commands.hx file for usage information. Please, also note

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Introduce Buffered driver

2010-11-10 Thread Luiz Capitulino
On Wed, 10 Nov 2010 13:56:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 10 Nov 2010 10:26:15 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-10 Thread Luiz Capitulino
On Wed, 10 Nov 2010 14:20:12 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about

<    1   2   3   4   5   6   7   8   9   10   >