On Wed, 20 Jun 2012 22:58:20 +0530
Rabin Vincent wrote:
> Make dump-guest-memory not create read-only files, so that it can
> overwrite a file created by a previous invocation without having it to
> be removed externally.
I think we need a force parameter to do this, the command shouldn't overwr
On Fri, 22 Jun 2012 14:36:09 -0400
Corey Bryant wrote:
> Signed-off-by: Corey Bryant
If this patch doesn't change anymore you can add:
Reviewed-by: Luiz Capitulino
> ---
> v2:
> -Convert getfd and closefd to QAPI (lcapitul...@redhat.com)
> -Remove changes that re
On Fri, 22 Jun 2012 14:36:11 -0400
Corey Bryant wrote:
> Signed-off-by: Corey Bryant
> ---
> v4:
> -This patch is new in v4.
Can you explain why it's needed?
>
> monitor.c | 40
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/
On Tue, 26 Jun 2012 13:45:52 +0200
Kevin Wolf wrote:
> Am 26.06.2012 11:10, schrieb Daniel P. Berrange:
> > I was thinking about some of the sources complexity when using
> > FD passing from libvirt and wanted to raise one idea for discussion
> > before we continue.
> >
> > With this proposed se
On Tue, 26 Jun 2012 17:15:05 -0400
Corey Bryant wrote:
>
>
> On 06/26/2012 04:44 PM, Luiz Capitulino wrote:
> > On Fri, 22 Jun 2012 14:36:09 -0400
> > Corey Bryant wrote:
> >
> >> Signed-off-by: Corey Bryant
> >
> > If this patch doesn
On Tue, 26 Jun 2012 17:16:28 -0400
Corey Bryant wrote:
>
>
> On 06/26/2012 04:45 PM, Luiz Capitulino wrote:
> > On Fri, 22 Jun 2012 14:36:11 -0400
> > Corey Bryant wrote:
> >
> >> Signed-off-by: Corey Bryant
> >> ---
> >> v4:
> >&g
On Wed, 27 Jun 2012 17:59:04 +0800
Amos Kong wrote:
> On 27/06/12 04:22, Luiz Capitulino wrote:
> > On Wed, 20 Jun 2012 06:53:40 -0600
> > Eric Blake wrote:
> >
> >> On 06/19/2012 10:47 PM, Amos Kong wrote:
> >>> Convert 'sendkey' to us
On Wed, 27 Jun 2012 18:22:48 +0800
Amos Kong wrote:
> On 27/06/12 04:21, Luiz Capitulino wrote:
> > On Wed, 20 Jun 2012 12:47:40 +0800
> > Amos Kong wrote:
> >
> >> Convert 'sendkey' to use QAPI. do_sendkey() depends on some
> >> variabl
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
exec.c | 19 ---
qemu-config.c | 4
qemu-options.hx | 5 -
3 files changed, 24 insertions(+), 4 deletions(-)
diff --git a
On Thu, 28 Jun 2012 11:25:10 +0200
Jan Kiszka wrote:
> On 2012-06-27 18:49, Luiz Capitulino wrote:
> > Allows to disable memory merge support (KSM on Linux), which is enabled
> > by default otherwise.
> >
> > Signed-off-by: Luiz Capitulino
> &
On Wed, 27 Jun 2012 10:58:01 +0200
Kevin Wolf wrote:
> Am 26.06.2012 20:40, schrieb Corey Bryant:
> >>> Here is a quick proof of concept (ie untested) patch to demonstrate
> >>> what I mean. It relies on Cory's patch which converts everything
> >>> to use qemu_open. It is also still valuable to m
Clarify a few points and makes it looks more like the other commands'
documentation.
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 3b
Also say why loading the bios has failed.
Signed-off-by: Luiz Capitulino
---
hw/pc_sysfw.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c
index b45f0ac..5670651 100644
--- a/hw/pc_sysfw.c
+++ b/hw/pc_sysfw.c
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v2: improve manpage description
exec.c | 19 ---
qemu-config.c | 4
qemu-options.hx | 7 ++-
3 files changed, 26 insertions
On Fri, 29 Jun 2012 09:18:09 -0500
Anthony Liguori wrote:
> On 06/29/2012 09:00 AM, Luiz Capitulino wrote:
> > Allows to disable memory merge support (KSM on Linux), which is enabled
> > by default otherwise.
> >
> > Signed-off-by: Luiz Capitulino
> >
On Fri, 29 Jun 2012 16:18:14 +0200
Andreas Färber wrote:
> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> > On Mon, 25 Jun 2012 22:26:58 +0200
> > Jan Kiszka wrote:
> >
> >> On 2012-06-25 18:55, Luiz Capitulino wrote:
> >>> Allow for disabling mem
On Fri, 29 Jun 2012 09:25:36 -0500
Anthony Liguori wrote:
> On 06/29/2012 09:18 AM, Andreas Färber wrote:
> > Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> >> On Mon, 25 Jun 2012 22:26:58 +0200
> >> Jan Kiszka wrote:
> >>
> >>> On 2012-06-2
On Fri, 29 Jun 2012 16:30:19 +0200
Jan Kiszka wrote:
> On 2012-06-29 16:25, Anthony Liguori wrote:
> > On 06/29/2012 09:18 AM, Andreas Färber wrote:
> >> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> >>> On Mon, 25 Jun 2012 22:26:58 +0200
> >>> Jan Ki
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v3: rename madvise_mergeable() to memory_try_enable_merging()
exec.c | 19 ---
qemu-config.c | 4
qemu-options.hx | 7 ++-
3
The enum string is pointed to by 'enum_str' not 'name'. This bug
causes the error message to be:
{ "error": { "class": "InvalidParameter",
"desc": "Invalid parameter 'null'",
"data&
On Sun, 01 Jul 2012 15:33:13 +0200
Paolo Bonzini wrote:
> Il 13/06/2012 12:54, Paolo Bonzini ha scritto:
> > Il 13/06/2012 10:22, Laszlo Ersek ha scritto:
> >> Inspired by [1], the first half of this series attempts to implement a new
> >> visitor that should clean up defining and processing comm
On Mon, 02 Jul 2012 07:47:56 -0500
Anthony Liguori wrote:
> > So far, there haven't been any calls for a change of the wire protocol.
>
> Changing all existing errors and repurposing 'desc' is effectively changing
> the
> wire protocol.
We're not going to change existing errors and I disagree
On Thu, 05 Jul 2012 11:06:56 -0400
Corey Bryant wrote:
>
>
> On 07/04/2012 04:09 AM, Kevin Wolf wrote:
> > Am 03.07.2012 20:21, schrieb Corey Bryant:
> >> On 07/03/2012 02:00 PM, Eric Blake wrote:
> >>> On 07/03/2012 11:46 AM, Corey Bryant wrote:
> >>>
>
> Yes, I think adding a +1 to
On Mon, 09 Jul 2012 17:46:00 +0200
Kevin Wolf wrote:
> Am 09.07.2012 17:05, schrieb Corey Bryant:
> > I'm not sure this is an issue with current design. I know things have
> > changed a bit as the email threads evolved, so I'll paste the current
> > design that I am working from. Please let m
On Mon, 09 Jul 2012 13:35:19 -0400
Corey Bryant wrote:
>
>
> On 07/09/2012 11:46 AM, Kevin Wolf wrote:
> > Am 09.07.2012 17:05, schrieb Corey Bryant:
> >> I'm not sure this is an issue with current design. I know things have
> >> changed a bit as the email threads evolved, so I'll paste the cu
On Mon, 09 Jul 2012 13:40:34 -0500
Anthony Liguori wrote:
> On 06/26/2012 04:10 AM, Daniel P. Berrange wrote:
> > On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote:
> >> libvirt's sVirt security driver provides SELinux MAC isolation for
> >> Qemu guest processes and their corresponding
It allows for specifying an alias for each option name, see next commits
examples.
Signed-off-by: Luiz Capitulino
---
qemu-option.c | 9 -
qemu-option.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/qemu-option.c b/qemu-option.c
index bb3886c..59a1f6e 100644
--- a
QOM conversion wants option names with dashes (instead of underscores),
this commit does the change for the kernel_irqchip machine option.
The underscore is still supported through an option alias for backwards
compatibility.
Signed-off-by: Luiz Capitulino
---
kvm-all.c | 2 +-
qemu
QOM conversion wants option names with dashes (instead of underscores),
this commit does the change for the dt_compatible machine option.
The underscore is still supported through an option alias for backwards
compatibility.
Signed-off-by: Luiz Capitulino
---
hw/ppce500_mpc8544ds.c | 2
QOM conversion wants option names with dashes (instead of underscores),
this commit does the change for the kvm_shadow_mem machine option.
The underscore is still supported through an option alias for backwards
compatibility.
Signed-off-by: Luiz Capitulino
---
qemu-config.c | 3 ++-
qemu
QOM conversion wants option names with dashes (instead of underscores),
this commit does the change for the phandle_start machine option.
The underscore is still supported through an option alias for backwards
compatibility.
Signed-off-by: Luiz Capitulino
---
device_tree.c | 2 +-
qemu
Today, machine options use underscores to separate words (eg. kernel_irqchip),
however upcoming QOM conversion wants to use dashes instead.
This series converts all machine type options to use dashes. Command-line
backwards compatibility is maintained by adding an alias for each changed
option.
On Wed, 11 Jul 2012 09:00:59 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > It allows for specifying an alias for each option name, see next commits
> > examples.
> >
> > Signed-off-by: Luiz Capitulino
> > ---
> > qemu-option.c | 9
On Mon, 09 Jul 2012 16:43:40 +0200
Kevin Wolf wrote:
> Am 15.06.2012 23:07, schrieb Eric Blake:
> > On 06/15/2012 02:47 PM, Supriya Kannery wrote:
> >> Enhance "info block" to display hostcache setting for each
> >> block device.
> >>
> >
> >> ##
> >> { 'type': 'BlockInfo',
> >>'data': {'d
On Sat, 16 Jun 2012 02:17:30 +0530
Supriya Kannery wrote:
> New command "block_set_hostcache" added for dynamically changing
> host pagecache setting of a block device.
>
> Usage:
> block_set_hostcache
> = block device
> = on/off
>
> Example:
> (qemu) block_set_hostcache ide0-hd0
On Fri, 29 Jun 2012 18:43:57 +0200
Juan Quintela wrote:
> We add time spent for migration to the output of "info migrate"
> command. 'total_time' means time since the start fo migration if
> migration is 'active', and total time of migration if migration is
> completed. As we are also intereste
On Wed, 11 Jul 2012 12:25:38 -0600
Eric Blake wrote:
> On 07/11/2012 12:08 PM, Luiz Capitulino wrote:
> > On Fri, 29 Jun 2012 18:43:57 +0200
> > Juan Quintela wrote:
> >
> >> We add time spent for migration to the output of "info migrate"
> >>
On Fri, 22 Jun 2012 14:36:09 -0400
Corey Bryant wrote:
> Signed-off-by: Corey Bryant
I've cherry-picked this one into the qmp tree.
> ---
> v2:
> -Convert getfd and closefd to QAPI (lcapitul...@redhat.com)
> -Remove changes that returned fd from getfd (lcapitul...@redhat.com)
> -Wrap hmp_*
Signed-off-by: Luiz Capitulino
---
docs/virtio-balloon-stats.txt | 73 +++
1 file changed, 73 insertions(+)
create mode 100644 docs/virtio-balloon-stats.txt
diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt
new file mode 100644
Next commit will re-enable balloon stats with a different interface, but
this old code conflicts with it, drop it then.
Signed-off-by: Luiz Capitulino
---
hw/virtio-balloon.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
.
Luiz Capitulino (3):
virtio-balloon: drop old stats code
virtio-balloon: re-enable balloon stats
docs: document virtio-balloon stats
docs/virtio-balloon-stats.txt | 73 +
hw/virtio-balloon.c | 178 --
2 files changed, 228
erval(),
virtio_balloon_handle_output() can run in parallel?
XXX: Should we return an error instead of -1? Might require a specific
error. Although this is not exactly a failure...
Signed-off-by: Luiz Capitulino
---
NOTE: Anthony suggested having a bool to enable/disable polling, but I prefer
to let the c
On Tue, 04 Dec 2012 15:42:32 +0100
Ján Tomko wrote:
> On 12/04/12 12:46, Luiz Capitulino wrote:
> > On Mon, 03 Dec 2012 16:55:35 +0100
> > Ján Tomko wrote:
> >
> >> Hello,
> >>
> >> is there a way to check if QEMU was compiled with --enable
On Fri, 30 Nov 2012 22:33:57 +0900
Tomoki Sekiyama wrote:
> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
> - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot
>
> Signed-off-by: Tomoki Sekiyama
>
On Fri, 30 Nov 2012 22:33:49 +0900
Tomoki Sekiyama wrote:
> Hi,
>
> This is version 6 of the qemu-ga fsfreeze hook patchset.
Made two small comments, otherwise series looks good to me now.
by fsfreeze-freeze
> command. As for fsfreeze-thaw command, the hook is executed with "thaw"
> argument after the filesystem is thawed.
>
> This patch depends on patchset to improve error reporting by Luiz Capitulino:
> http://lists.gnu.org/archive/html/qemu-devel/2012-11/ms
On Wed, 05 Dec 2012 17:41:08 +0900
Tomoki Sekiyama wrote:
> On 2012/12/05 1:51, Luiz Capitulino wrote:
> > On Fri, 30 Nov 2012 22:33:57 +0900
> > Tomoki Sekiyama wrote:
> >
> >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> >> - fsfr
On Wed, 05 Dec 2012 15:07:24 +0100 (CET)
Alexandre DERUMIER wrote:
> Hi,
> I'm trying to use qmp "query-balloon", to get stats,
>
> From Doc, I expect to have
>
>
> -> { "execute": "query-balloon" }
> <- {
> "return":{
> "actual":1073741824,
> "mem_swapped_in":0,
>
On Thu, 6 Dec 2012 13:24:11 +
"Daniel P. Berrange" wrote:
> On Tue, Dec 04, 2012 at 01:04:48PM -0200, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino
> > ---
> > docs/virtio-balloon-stats.txt | 73
> > +
On Thu, 6 Dec 2012 11:03:21 -0600
mdroth wrote:
> On Tue, Dec 04, 2012 at 01:04:47PM -0200, Luiz Capitulino wrote:
> > The statistics are now available through device properties via a
> > polling mechanism. First, a client has to enable polling, then it
> > can query th
On Fri, 7 Dec 2012 05:30:17 +
Dietmar Maurer wrote:
> > +The memory statistics are:
> > +
> > + o stat-swap-in
> > + o stat-swap-out
> > + o stat-major-faults
> > + o stat-minor-faults
> > + o stat-free-memory
> > + o stat-total-memory
>
> I want to implement an automatic ballooning policy,
On Fri, 07 Dec 2012 17:39:32 +0900
Tomoki Sekiyama wrote:
> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
> - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot
>
> Signed-off-by: Tomoki Sekiyama
>
by fsfreeze-freeze
> command. As for fsfreeze-thaw command, the hook is executed with "thaw"
> argument after the filesystem is thawed.
>
> This patch depends on patchset to improve error reporting by Luiz Capitulino:
> http://lists.gnu.org/archive/html/qemu-devel/2012-11/m
On Fri, 7 Dec 2012 11:47:24 -0600
mdroth wrote:
> On Fri, Dec 07, 2012 at 11:55:16AM -0200, Luiz Capitulino wrote:
> > On Fri, 07 Dec 2012 17:39:32 +0900
> > Tomoki Sekiyama wrote:
> >
> > > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
>
On Fri, 07 Dec 2012 11:22:54 -0700
Eric Blake wrote:
> On 12/07/2012 06:55 AM, Luiz Capitulino wrote:
> > On Fri, 07 Dec 2012 17:39:32 +0900
> > Tomoki Sekiyama wrote:
> >
> >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> >> - fsfr
On Fri, 7 Dec 2012 15:01:36 +
Dietmar Maurer wrote:
> > > Is it possible to extent those statistic to include buffer/cache values?
> >
> > Yes, should be possible but the kernel virtio-balloon driver has to be
> > extended too (and I suspect this kind of change goes into the kernel first).
>
On Fri, 07 Dec 2012 11:37:44 -0700
Eric Blake wrote:
> On 12/07/2012 11:31 AM, Luiz Capitulino wrote:
> >>>> +++ b/.gitignore
> >>>> @@ -93,3 +93,4 @@ cscope.*
> >>>> tags
> >>>> TAGS
> >>>> *~
> >>>>
On Sat, 8 Dec 2012 06:26:05 +
Dietmar Maurer wrote:
> > 2. wait for the (kernel-based) auto-ballooning feature, which is on the
> > works
>
> Do you have more information on that? Any links?
No, no links. What's being worked right now is a notification mechanism for
the kernel to infor
()
running in parallel
- small renames and re-writes for better readability
- update documentation
Luiz Capitulino (3):
virtio-balloon: drop old stats code
virtio-balloon: re-enable balloon stats
docs: document virtio-balloon stats
docs/virtio-balloon-stats.txt | 87 +++
hw
, all values are in bytes:
o stat-swap-in
o stat-swap-out
o stat-major-faults
o stat-minor-faults
o stat-free-memory
o stat-total-memory
Please, refer to the documentation introduced by the next commit for
more information and examples.
Signed-off-by: Luiz Capitulino
---
hw/virtio
Next commit will re-enable balloon stats with a different interface, but
this old code conflicts with it. Drop it.
Signed-off-by: Luiz Capitulino
---
hw/virtio-balloon.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index
Signed-off-by: Luiz Capitulino
---
docs/virtio-balloon-stats.txt | 87 +++
1 file changed, 87 insertions(+)
create mode 100644 docs/virtio-balloon-stats.txt
diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt
new file mode 100644
-Original Message-
> > From: qemu-devel-bounces+dietmar=proxmox@nongnu.org
> > [mailto:qemu-devel-bounces+dietmar=proxmox@nongnu.org] On
> > Behalf Of Luiz Capitulino
> > Sent: Montag, 10. Dezember 2012 20:36
> > To: qemu-devel@nongnu.org
> > Cc:
On Tue, 11 Dec 2012 12:05:32 +
Dietmar Maurer wrote:
> > > and simply return all stats with one API call (query-ballon)?
> >
> > We can't use query-balloon because this changes query-balloon from
> > synchronous to asynchronous, and this is an incompatible change.
>
> Why don't we simply ca
On Tue, 11 Dec 2012 12:29:01 +
Dietmar Maurer wrote:
> > > Can't we enable stat queries by default (10s interval),
> >
> > I'm not sure I like this for two reasons. First, there will be cases where
> > the
> > user doesn't want this to be enabled. Second, we'll be forcing an interval
> > o
On Tue, 11 Dec 2012 16:28:40 -0200
Luiz Capitulino wrote:
> On Tue, 11 Dec 2012 11:38:08 -0600
> mdroth wrote:
>
> > On Tue, Dec 11, 2012 at 03:14:02PM +, Dietmar Maurer wrote:
> > > > > > I'm not sure I like this for two reasons. First, there wi
On Tue, 11 Dec 2012 11:38:08 -0600
mdroth wrote:
> On Tue, Dec 11, 2012 at 03:14:02PM +, Dietmar Maurer wrote:
> > > > > I'm not sure I like this for two reasons. First, there will be cases
> > > > > where the user doesn't want this to be enabled. Second, we'll be
> > > > > forcing an interva
On Tue, 11 Dec 2012 19:07:48 +
Dietmar Maurer wrote:
> > I could move the check for the stats feature bit from the function that
> > enables polling to the timer callback. This would solve Dietmar's use-case,
>
> that would be great.
>
> > but it would silently fail if the feature is never
On Tue, 11 Dec 2012 19:39:40 +
Dietmar Maurer wrote:
> > > > but it would silently fail if the feature is never negotiated (as
> > > > you said above).
> > >
> > > Why don't we raise the error when we query the values?
> >
> > Hmm, that's a good idea.
> >
> > Only small nit is that, today o
Tomoki Sekiyama
Looks good to me:
Reviewed-by: Luiz Capitulino
> ---
> .gitignore |1
> Makefile |2 -
> scripts/qemu-guest-agent/fsfreeze-hook | 33
> .../fsfreez
On Wed, 12 Dec 2012 13:17:15 +
Dietmar Maurer wrote:
> > > > > Why don't we raise the error when we query the values?
>
> You already raise an error here, so that works out of the box:
>
> if (s->stats[i] == -1) {
> error_setg(errp,
> "timer hasn't been enabled or gu
On Wed, 12 Dec 2012 13:36:20 +
Dietmar Maurer wrote:
> > > The following patch seems to work for me:
> >
> > Yeah, that's what I'll do and the doc has to be updated too.
>
> Btw, do you know a qmp call which returns the memory assigned to the VM
> (the value qemu is started with (-m megs))?
On Wed, 12 Dec 2012 13:45:54 +
Dietmar Maurer wrote:
> > > Btw, do you know a qmp call which returns the memory assigned to the
> > > VM (the value qemu is started with (-m megs))?
> >
> > No, we only have info/query- balloon. I was also thinking about this the
> > other day.
>
> Can we add
tional
2. This has never been really used
Signed-off-by: Luiz Capitulino
---
hmp.c | 24 +---
hw/virtio-balloon.c | 22 --
qapi-schema.json| 20 +---
qmp-commands.hx | 13 -
4 files changed, 2 insertions(+
On Thu, 13 Dec 2012 16:40:35 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> error.c | 8
> error.h | 6 ++
> 2 files changed, 14 insertions(+)
>
> diff --git a/error.c b/error.c
> index 128d88c..dd3ab66 100644
> --- a/error.c
> +++ b/error.c
> @@ -113,3 +113,11 @@
the guest hasn't negotiated
stats feature bit
- update doc
Luiz Capitulino (3):
balloon: drop old stats code & API
balloon: re-enable balloon stats
docs: document virtio-balloon stats
docs/virtio-balloon-stats.txt | 91 +++
hmp.c |
Signed-off-by: Luiz Capitulino
---
docs/virtio-balloon-stats.txt | 91 +++
1 file changed, 91 insertions(+)
create mode 100644 docs/virtio-balloon-stats.txt
diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt
new file mode 100644
, all values are in bytes:
o stat-swap-in
o stat-swap-out
o stat-major-faults
o stat-minor-faults
o stat-free-memory
o stat-total-memory
Please, refer to the documentation introduced by the next commit for
more information and examples.
Signed-off-by: Luiz Capitulino
---
hw/virtio
On Thu, 13 Dec 2012 16:40:36 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> block.c| 26 ++
> block.h| 3 ++-
> block/qcow2-snapshot.c | 11 ++-
> block/qcow2.h | 4 +++-
> block/rbd.c| 17 ++
On Thu, 13 Dec 2012 16:40:37 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
The same comments I made in the previous patch apply here: you're
keeping the error code and converting callers to propagate error
in the same patch (which makes this difficult to review).
> ---
> block.c
On Thu, 13 Dec 2012 16:40:41 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> savevm.c | 12
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 7ab7c7c..3ee7da5 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -2094,22 +2094,
On Thu, 13 Dec 2012 16:40:42 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> migration.c | 2 +-
> savevm.c| 7 +--
> sysemu.h| 3 ++-
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 73ce170..bf51a07 100644
> ---
On Thu, 13 Dec 2012 16:40:46 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> migration.c | 8
> savevm.c| 39 +++
> sysemu.h| 3 ++-
> 3 files changed, 29 insertions(+), 21 deletions(-)
>
> diff --git a/migration.c b/migrat
[Forgot adding block layer guys, re-sending]
On Thu, 13 Dec 2012 16:40:36 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> block.c| 26 ++
> block.h| 3 ++-
> block/qcow2-snapshot.c | 11 ++-
> block/qcow2.h
On Thu, 13 Dec 2012 16:40:47 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> hmp-commands.hx | 4 ++--
> hmp.c| 9 +
> hmp.h| 1 +
> qapi-schema.json | 19 +++
> qmp-commands.hx | 29 +
> savevm.c
On Thu, 13 Dec 2012 16:40:34 +0100
Pavel Hrdina wrote:
> This patch series convert these commands into qapi and introduce QMP commands
> vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots.
> It also rewrite error report for functions used by these commands.
I've review
On Thu, 13 Dec 2012 16:40:50 +0100
Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> hmp.c| 33 +
> hmp.h| 1 +
> monitor.c| 2 +-
> qapi-schema.json | 13 +
> qmp-commands.hx | 34 +++
On Sat, 15 Dec 2012 07:19:13 +
Dietmar Maurer wrote:
> > - drop qmp & hmp interface of old stats code
>
> I think the old interface is not that bad (the new one is clumsy, because
> we need 6 qmp call instead of one to get all stats). Can't
> we try to make it functional and keep it?
No, b
On Mon, 17 Dec 2012 10:13:40 +
Dietmar Maurer wrote:
> > Next commit will re-enable balloon stats with a different interface, but
> > this
> > old code conflicts with it. Let's drop it.
>
> I don't really see any conflicts here?
query-balloon resets all stats to -1. So, if it's issued afte
On Mon, 17 Dec 2012 11:21:10 +0530
Shraddha Kamat wrote:
> I am implementing couple of QMP commands to Qemu - so trying a
> hello-world command first as shown here
> https://github.com/qemu/qemu/blob/master/docs/writing-qmp-commands.txt
>
> Step 1 :
>
> Added to qapi-schema.json file t
On Mon, 17 Dec 2012 12:17:28 +
Dietmar Maurer wrote:
> > Let me try once more to explain our options and why I think this is series
> > is
> > our best choice.
> >
> > Basically, we have try options:
> >
> > 1. Add stats to query-balloon
> >
> > This breaks existing clients, because query
On Mon, 17 Dec 2012 12:23:59 +
Dietmar Maurer wrote:
> > > I don't really see any conflicts here?
> >
> > query-balloon resets all stats to -1. So, if it's issued after the stats
> > have been
> > polled all values are lost.
>
> I can't see that in the code. I also tested with my patch, an
On Mon, 17 Dec 2012 12:26:34 +
Dietmar Maurer wrote:
> > > No, there is no need to wait (see my patch).
> >
> > It has problems, replied to it.
>
> Please can you post a test case which show those problems? I simply can't
> reproduce any problem you mention.
Which problems are you referri
On Mon, 17 Dec 2012 12:36:59 +
Dietmar Maurer wrote:
> > > There is no code to reset stats inside virtio_balloon_stat()
> >
> > static void virtio_balloon_stat(void *opaque, BalloonInfo *info) {
> > VirtIOBalloon *dev = opaque;
> >
> > #if 0
> > /* Disable guest-provided stats for n
On Sat, 15 Dec 2012 15:09:31 +0100
Stefan Weil wrote:
> There is no good system error for this kind of error,
> so it needs special handling instead of strerror.
>
> Signed-off-by: Stefan Weil
> ---
> blockdev.c |9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --gi
ortly.
Any feedback is appreciated!
Luiz Capitulino (3):
virtio-balloon: add guest_get_actual_ram()
virtio-balloon: add virtio_balloon_conf skeleton
virtio-balloon: add auto-ballooning support
hw/virtio-balloon.c | 166 +++-
hw/virtio-balloon.h
Next commit wants it.
Signed-off-by: Luiz Capitulino
---
hw/virtio-balloon.c | 2 +-
hw/virtio-balloon.h | 4
hw/virtio-pci.c | 2 +-
hw/virtio-pci.h | 2 ++
hw/virtio.h | 3 ++-
5 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio
A future commit will also want to use this.
Signed-off-by: Luiz Capitulino
---
hw/virtio-balloon.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index dd1a650..03248df 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio
user manually
Signed-off-by: Luiz Capitulino
---
hw/virtio-balloon.c | 156
hw/virtio-balloon.h | 4 ++
hw/virtio-pci.c | 5 ++
3 files changed, 165 insertions(+)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 97d49b1..40
On Tue, 18 Dec 2012 14:34:16 -0700
Eric Blake wrote:
> On 12/17/2012 03:13 AM, Dietmar Maurer wrote:
> >> Next commit will re-enable balloon stats with a different interface, but
> >> this
> >> old code conflicts with it. Let's drop it.
> >
> > I don't really see any conflicts here?
> >
> >> I
401 - 500 of 5376 matches
Mail list logo
