[PATCH v4 8/8] hw/i386: Introduce the microvm machine type

2019-09-24 Thread Sergio Lopez
aw,if=none \ -device virtio-blk-device,drive=test \ -netdev tap,id=tap0,script=no,downscript=no \ -device virtio-net-device,netdev=tap0 Signed-off-by: Sergio Lopez --- default-configs/i386-softmmu.mak | 1 + hw/i386/Kconfig | 4 + hw/i386/Makefile.objs|

[PATCH v4 1/8] hw/i386: Factorize PVH related functions

2019-09-24 Thread Sergio Lopez
Extract PVH related functions from pc.c, and put them in pvh.c, so they can be shared with other components. Signed-off-by: Sergio Lopez --- hw/i386/Makefile.objs | 1 + hw/i386/pc.c | 120 +- hw/i386/pvh.c | 113

[PATCH v4 5/8] fw_cfg: add "modify" functions for all types

2019-09-24 Thread Sergio Lopez
This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez --- hw/nvram/fw_cfg.c | 29 +++ include/hw/nvram/fw_cfg.h | 42 +++ 2 files changed, 71 insertions(+) diff --git a/hw/nvram/fw_cfg.c b/hw

[PATCH v4 2/8] hw/i386: Factorize e820 related functions

2019-09-24 Thread Sergio Lopez
Extract e820 related functions from pc.c, and put them in e820.c, so they can be shared with other components. Signed-off-by: Sergio Lopez --- hw/i386/Makefile.objs | 1 + hw/i386/e820.c| 99 +++ hw/i386/e820.h| 11 + hw/i386/pc.c

[PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-24 Thread Sergio Lopez
Document the new microvm machine type. Signed-off-by: Sergio Lopez --- docs/microvm.txt | 78 1 file changed, 78 insertions(+) create mode 100644 docs/microvm.txt diff --git a/docs/microvm.txt b/docs/microvm.txt new file mode 100644 index

Re: [PATCH v4 2/8] hw/i386: Factorize e820 related functions

2019-09-24 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 9/24/19 2:44 PM, Sergio Lopez wrote: >> Extract e820 related functions from pc.c, and put them in e820.c, so >> they can be shared with other components. >> >> Signed-off-by: Sergio Lopez >> --- >> hw/i386/

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-24 Thread Sergio Lopez
Paolo Bonzini writes: > On 24/09/19 14:44, Sergio Lopez wrote: >> +Microvm is a machine type inspired by both NEMU and Firecracker, and >> +constructed after the machine model implemented by the latter. > > I would say it's inspired by Firecracker only. The NEMU vir

Re: [PATCH v4 0/8] Introduce the microvm machine type

2019-09-24 Thread Sergio Lopez
Peter Maydell writes: > On Tue, 24 Sep 2019 at 14:25, Sergio Lopez wrote: >> >> Microvm is a machine type inspired by both NEMU and Firecracker, and >> constructed after the machine model implemented by the latter. >> >> It's main purpose is providin

Re: [PATCH v4 8/8] hw/i386: Introduce the microvm machine type

2019-09-24 Thread Sergio Lopez
Paolo Bonzini writes: > On 24/09/19 14:44, Sergio Lopez wrote: >> microvm.option-roms=bool (Set off to disable loading option ROMs) > > Please make this x-option-roms OK. >> microvm.isa-serial=bool (Set off to disable the instantiation an ISA serial >> port) >

Re: [PATCH v4 8/8] hw/i386: Introduce the microvm machine type

2019-09-24 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Tue, Sep 24, 2019 at 02:44:33PM +0200, Sergio Lopez wrote: >> +static void microvm_fix_kernel_cmdline(MachineState *machine) >> +{ >> +X86MachineState *x86ms = X86_MACHINE(machine); >> +BusState *bus; >> +Bus

Re: [PATCH v4 1/8] hw/i386: Factorize PVH related functions

2019-09-24 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > Hi Sergio, > > On 9/24/19 2:44 PM, Sergio Lopez wrote: >> Extract PVH related functions from pc.c, and put them in pvh.c, so >> they can be shared with other components. >> >> Signed-off-by: Sergio Lopez >> --- >&g

Re: [PATCH v4 6/8] roms: add microvm-bios (qboot) as binary and git submodule

2019-09-24 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 9/24/19 2:44 PM, Sergio Lopez wrote: >> qboot is a minimalist x86 firmware for booting Linux kernels. It does >> the mininum amount of work required for the task, and it's able to >> boot both PVH images and bzImages with

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-25 Thread Sergio Lopez
Gerd Hoffmann writes: > Hi, > >> +microvm.kernel-cmdline=bool (Set off to disable adding virtio-mmio devices >> to the kernel cmdline) > > Hmm, is that the long-term plan? IMO the virtio-mmio devices should be > discoverable somehow. ACPI, or device-tree, or fw_cfg, or ... I'd say that dep

Re: [PATCH v4 0/8] Introduce the microvm machine type

2019-09-25 Thread Sergio Lopez
David Hildenbrand writes: > On 24.09.19 14:44, Sergio Lopez wrote: >> Microvm is a machine type inspired by both NEMU and Firecracker, and >> constructed after the machine model implemented by the latter. >> >> It's main purpose is providing users a minimali

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-25 Thread Sergio Lopez
Paolo Bonzini writes: > On 25/09/19 07:49, Sergio Lopez wrote: >>>> +serving as a stepping stone >>>> +for future projects aiming at improving boot times, reducing the >>>> +attack surface and slimming down QEMU's footprint. >>> >>>

Re: [PATCH v4 0/8] Introduce the microvm machine type

2019-09-25 Thread Sergio Lopez
Paolo Bonzini writes: > On 25/09/19 10:10, Sergio Lopez wrote: >> That would be great. I'm also looking forward for virtio-mem (and an >> hypothetical virtio-cpu) to eventually gain hotplug capabilities in >> microvm. > > I disagree with this. virtio is

Re: [PATCH v4 1/8] hw/i386: Factorize PVH related functions

2019-09-25 Thread Sergio Lopez
Stefano Garzarella writes: > Hi Sergio, > > On Tue, Sep 24, 2019 at 02:44:26PM +0200, Sergio Lopez wrote: >> Extract PVH related functions from pc.c, and put them in pvh.c, so >> they can be shared with other components. >> >> Signed-off-by: Sergio Lopez >&

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-25 Thread Sergio Lopez
Paolo Bonzini writes: > On 25/09/19 10:40, Sergio Lopez wrote: >>>> We need the PIT for non-KVM accel (if present with KVM and >>>> kernel_irqchip_split = off, it basically becomes a placeholder) >>> Why? >> >> Perhaps I'm missing somethin

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-25 Thread Sergio Lopez
Paolo Bonzini writes: > On 24/09/19 14:44, Sergio Lopez wrote: >> +Microvm is a machine type inspired by both NEMU and Firecracker, and >> +constructed after the machine model implemented by the latter. > > I would say it's inspired by Firecracker only. The NEMU vir

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-25 Thread Sergio Lopez
Paolo Bonzini writes: > On 25/09/19 17:04, Sergio Lopez wrote: >> I'm going back to this level of the thread, because after your >> suggestion I took a deeper look at how things work around the PIC, and >> discovered I was completely wrong about my assumptions. >

Re: [PATCH v4 8/8] hw/i386: Introduce the microvm machine type

2019-09-25 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 9/24/19 2:44 PM, Sergio Lopez wrote: >> Microvm is a machine type inspired by both NEMU and Firecracker, and >> constructed after the machine model implemented by the latter. >> >> It's main purpose is providing users a mini

Re: [PATCH v4 0/8] Introduce the microvm machine type

2019-09-26 Thread Sergio Lopez
Christian Borntraeger writes: > On 24.09.19 14:44, Sergio Lopez wrote: >> Microvm is a machine type inspired by both NEMU and Firecracker, and >> constructed after the machine model implemented by the latter. >> >> It's main purpose is providing users a minimali

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-26 Thread Sergio Lopez
Paolo Bonzini writes: > On 26/09/19 08:23, Sergio Lopez wrote: >> >> There's still one problem. If the Guest doesn't have TSC_DEADLINE_TIME, >> Linux hangs on APIC timer calibration. I'm looking for a way to work >> around this. Worst case scena

Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type

2019-09-26 Thread Sergio Lopez
Paolo Bonzini writes: > On 26/09/19 12:16, Sergio Lopez wrote: >>> If KVM is in use, the >>> LAPIC timer frequency is known to be 1 GHz. >>> >>> arch/x86/kernel/kvm.c can just set >>> >>> lapic_timer_period = 10 / HZ;

[no subject]

2019-09-30 Thread Sergio Lopez
Hi, Commit 137b5cb6ab565cb3781d5337591e155932b4230e (hmp: change hmp_info_cpus to use query-cpus-fast) updated the "info cpus" commit to make it more lightweight, but also removed the ability to get the architecture specific status of each vCPU. This information was really useful to diagnose cert

Arch info lost in "info cpus"

2019-09-30 Thread Sergio Lopez
Hi, Commit 137b5cb6ab565cb3781d5337591e155932b4230e (hmp: change hmp_info_cpus to use query-cpus-fast) updated the "info cpus" commit to make it more lightweight, but also removed the ability to get the architecture specific status of each vCPU. This information was really useful to diagnose cert

Re: Arch info lost in "info cpus"

2019-09-30 Thread Sergio Lopez
Alex Bennée writes: > Sergio Lopez writes: > >> Hi, >> >> Commit 137b5cb6ab565cb3781d5337591e155932b4230e (hmp: change >> hmp_info_cpus to use query-cpus-fast) updated the "info cpus" commit to >> make it more lightweight, but also removed the abil

Re: Arch info lost in "info cpus"

2019-10-01 Thread Sergio Lopez
Eduardo Habkost writes: > On Mon, Sep 30, 2019 at 12:22:22PM +0200, Sergio Lopez wrote: >> >> Alex Bennée writes: >> >> > Sergio Lopez writes: >> > >> >> Hi, >> >> >> >> Commit 137b5cb6ab565cb3781d5337591e155932

Re: [PATCH v4 8/8] hw/i386: Introduce the microvm machine type

2019-10-01 Thread Sergio Lopez
Sergio Lopez writes: > Michael S. Tsirkin writes: > >> On Tue, Sep 24, 2019 at 02:44:33PM +0200, Sergio Lopez wrote: >>> +static void microvm_fix_kernel_cmdline(MachineState *machine) >>> +{ >>> +X86MachineState *x86ms = X86_MACHINE(machine); >>

[PATCH v5 00/10] Introduce the microvm machine type

2019-10-02 Thread Sergio Lopez
ons. - Replace use of Linux's Zero Page with PVH (thanks Maran and Paolo). --- Sergio Lopez (10): hw/virtio: Factorize virtio-mmio headers hw/i386/pc: rename functions shared with non-PC machines hw/i386/pc: move shared x86 functions to x86.c and export them hw/i386: split PCMachineState

[PATCH v5 01/10] hw/virtio: Factorize virtio-mmio headers

2019-10-02 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accessed from other components. Signed-off-by: Sergio Lopez --- hw/virtio/virtio-mmio.c | 48 +- include/hw/virtio/virtio-mmio.h | 73 + 2 files changed, 74

[PATCH v5 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-02 Thread Sergio Lopez
Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez --- hw/i386/Makefile.objs | 1 + hw/i386/pc.c | 582 +-- hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c

[PATCH v5 02/10] hw/i386/pc: rename functions shared with non-PC machines

2019-10-02 Thread Sergio Lopez
sible_cpu_arch_ids old_pc_system_rom_init -> x86_system_rom_init Signed-off-by: Sergio Lopez --- hw/i386/pc.c | 28 ++-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- hw/i386/pc_sysfw.c | 6 +++--- include/hw/i386/pc.h | 2 +- 5 files c

[PATCH v5 06/10] fw_cfg: add "modify" functions for all types

2019-10-02 Thread Sergio Lopez
This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez --- hw/nvram/fw_cfg.c | 29 +++ include/hw/nvram/fw_cfg.h | 42 +++ 2 files changed, 71 insertions(+) diff --git a/hw/nvram/fw_cfg.c b/hw

[PATCH v5 04/10] hw/i386: split PCMachineState deriving X86MachineState from it

2019-10-02 Thread Sergio Lopez
Split up PCMachineState and PCMachineClass and derive X86MachineState and X86MachineClass from them. This allows sharing code with non-PC x86 machine types. Signed-off-by: Sergio Lopez --- hw/acpi/cpu_hotplug.c | 10 +-- hw/i386/acpi-build.c | 29 --- hw/i386/amd_iommu.c | 3 +- hw

[PATCH v5 07/10] hw/intc/apic: reject pic ints if isa_pic == NULL

2019-10-02 Thread Sergio Lopez
In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic == NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index

[PATCH v5 09/10] docs/microvm.rst: document the new microvm machine type

2019-10-02 Thread Sergio Lopez
Document the new microvm machine type. Signed-off-by: Sergio Lopez --- docs/microvm.rst | 98 1 file changed, 98 insertions(+) create mode 100644 docs/microvm.rst diff --git a/docs/microvm.rst b/docs/microvm.rst new file mode 100644 index

[PATCH v5 08/10] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-02 Thread Sergio Lopez
ff-by: Sergio Lopez --- .gitmodules | 3 +++ pc-bios/bios-microvm.bin | Bin 0 -> 65536 bytes roms/Makefile| 6 ++ roms/qboot | 1 + 4 files changed, 10 insertions(+) create mode 100755 pc-bios/bios-microvm.bin create mode 16 roms/qboot diff

[PATCH v5 05/10] hw/i386: make x86.c independent from PCMachineState

2019-10-02 Thread Sergio Lopez
As a last step into splitting PCMachineState and deriving X86MachineState from it, make the functions previously extracted from pc.c to x86.c independent from PCMachineState, using X86MachineState instead. Signed-off-by: Sergio Lopez --- hw/i386/pc.c | 13 +++- hw/i386

[PATCH v5 10/10] hw/i386: Introduce the microvm machine type

2019-10-02 Thread Sergio Lopez
stems, since it is optimized for both boot time and footprint. Signed-off-by: Sergio Lopez --- default-configs/i386-softmmu.mak | 1 + hw/i386/Kconfig | 4 + hw/i386/Makefile.objs| 1 + hw/i386/microvm.c| 574 +++ inclu

Re: [PATCH v5 10/10] hw/i386: Introduce the microvm machine type

2019-10-02 Thread Sergio Lopez
Thomas Huth writes: > On 02/10/2019 13.31, Sergio Lopez wrote: >> Microvm is a machine type inspired by Firecracker and constructed >> after the its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-li

Re: [PATCH v5 09/10] docs/microvm.rst: document the new microvm machine type

2019-10-02 Thread Sergio Lopez
Paolo Bonzini writes: > On 02/10/19 13:31, Sergio Lopez wrote: >> +- LAPIC (in userspace by default) > > Note that LAPIC should be in kernel by default. The userspace LAPIC is > slow (cannot use APIC virtualization in recent Intel and AMD processors) > and probably somewh

Re: [Qemu-block] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare

2019-10-03 Thread Sergio Lopez
Sergio Lopez writes: > Kevin Wolf writes: > >> Am 13.09.2019 um 21:54 hat John Snow geschrieben: >>> >>> >>> On 9/13/19 11:25 AM, Sergio Lopez wrote: >>> > do_drive_backup() already acquires the AioContext, so release it >>>

Re: [PATCH v5 02/10] hw/i386/pc: rename functions shared with non-PC machines

2019-10-03 Thread Sergio Lopez
architecture, rename them:" OK, thanks for the tip. > On 10/2/19 1:30 PM, Sergio Lopez wrote: >> load_linux -> x86_load_linux >> pc_new_cpu -> x86_new_cpu > > Maybe we can rename this one 'x86_cpu_new'? OK. >

Re: [PATCH v5 08/10] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-03 Thread Sergio Lopez
Sergio Lopez writes: > qboot is a minimalist x86 firmware for booting Linux kernels. It does > the mininum amount of work required for the task, and it's able to > boot both PVH images and bzImages without relying on option roms. I've just noticed all other submodules refe

Re: [PATCH v5 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-03 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 10/2/19 1:30 PM, Sergio Lopez wrote: >> Move x86 functions that will be shared between PC and non-PC machine >> types to x86.c, along with their helpers. >> >> Signed-off-by: Sergio Lopez >> --- >> hw/i386/

Re: [PATCH v5 08/10] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-03 Thread Sergio Lopez
Paolo Bonzini writes: > On 03/10/19 12:07, Sergio Lopez wrote: >> >>> qboot is a minimalist x86 firmware for booting Linux kernels. It does >>> the mininum amount of work required for the task, and it's able to >>> boot both PVH images and bzImages wit

Re: [PATCH v5 04/10] hw/i386: split PCMachineState deriving X86MachineState from it

2019-10-03 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > Hi Sergio, > > On 10/2/19 1:30 PM, Sergio Lopez wrote: >> Split up PCMachineState and PCMachineClass and derive X86MachineState >> and X86MachineClass from them. This allows sharing code with non-PC >> x86 machine types. >&g

Re: [PATCH v5 01/10] hw/virtio: Factorize virtio-mmio headers

2019-10-03 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 10/2/19 1:30 PM, Sergio Lopez wrote: >> Put QOM and main struct definition in a separate header file, so it >> can be accessed from other components. >> >> Signed-off-by: Sergio Lopez >> --- >>

Re: [PATCH 070/104] virtiofsd: fail when parent inode isn't known in lo_do_lookup()

2020-01-20 Thread Sergio Lopez
t; > Also clean up lo_do_lookup() while we're here. > > Signed-off-by: Miklos Szeredi > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 071/104] virtiofsd: extract root inode init into setup_root()

2020-01-20 Thread Sergio Lopez
hanged, 24 insertions(+), 2 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-20 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi > --- > tools/virtiofsd/passthrough_ll.c | 50 +++- > 1 file changed, 49 insertions(+), 1 deletion(-) This one is missing a commit message, and I think the patch isn't tr

Re: [PATCH 084/104] Virtiofsd: fix memory leak on fuse queueinfo

2020-01-20 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Liu Bo > > For fuse's queueinfo, both queueinfo array and queueinfos are allocated in > fv_queue_set_started() but not cleaned up when the daemon process quits. > > This fixes the leak in proper places. > > Signed-off-by: Liu Bo > Signed-off-by: Eri

Re: [PATCH 093/104] virtiofsd: introduce inode refcount to prevent use-after-free

2020-01-20 Thread Sergio Lopez
efan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 168 ++- > 1 file changed, 145 insertions(+), 23 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 094/104] virtiofsd: do not always set FUSE_FLOCK_LOCKS

2020-01-20 Thread Sergio Lopez
+++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 01/19] hvf: Move assert_hvf_ok() into common directory

2021-05-27 Thread Sergio Lopez
vf/hvf-all.c > create mode 100644 accel/hvf/meson.build > create mode 100644 include/sysemu/hvf_int.h Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 04/19] hvf: Move hvf internal definitions into common header

2021-05-27 Thread Sergio Lopez
--- > 2 files changed, 31 insertions(+), 30 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 05/19] hvf: Make hvf_set_phys_mem() static

2021-05-27 Thread Sergio Lopez
les changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 02/19] hvf: Move vcpu thread functions into common directory

2021-05-27 Thread Sergio Lopez
d | 1 + > target/i386/hvf/meson.build| 1 - > target/i386/hvf/x86hvf.c | 2 +- > 5 files changed, 2 insertions(+), 2 deletions(-) > rename {target/i386 => accel}/hvf/hvf-accel-ops.c (100%) > rename {target/i386 => accel}/hv

Re: [PATCH v8 07/19] hvf: Split out common code on vcpu init and destroy

2021-05-27 Thread Sergio Lopez
> Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 30 ++ > accel/hvf/hvf-accel-ops.h | 2 -- > include/sysemu/hvf_int.h | 2 ++ > target/i386/hvf/hvf.c | 23 ++- > 4 files changed, 34 insertions(+), 23 del

Re: [PATCH v8 10/19] hvf: Remove hvf-accel-ops.h

2021-05-27 Thread Sergio Lopez
/hvf-accel-ops.h | 17 - > include/sysemu/hvf_int.h | 1 + > target/i386/hvf/hvf.c | 2 -- > 4 files changed, 1 insertion(+), 21 deletions(-) > delete mode 100644 accel/hvf/hvf-accel-ops.h Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 06/19] hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t

2021-05-27 Thread Sergio Lopez
file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 03/19] hvf: Move cpu functions into common directory

2021-05-27 Thread Sergio Lopez
+- > include/sysemu/hvf_int.h | 4 + > target/i386/hvf/hvf-i386.h | 2 - > target/i386/hvf/hvf.c | 302 > target/i386/hvf/x86hvf.h | 2 - > 5 files changed, 311 insertions(+), 307 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 09/19] hvf: Make synchronize functions static

2021-05-27 Thread Sergio Lopez
l/hvf/hvf-accel-ops.h | 3 --- > 2 files changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 11/19] hvf: Introduce hvf vcpu struct

2021-05-27 Thread Sergio Lopez
| 4 +- > target/i386/hvf/x86_task.c | 12 +-- > target/i386/hvf/x86hvf.c| 210 ++------ > 11 files changed, 248 insertions(+), 237 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 08/19] hvf: Use cpu_synchronize_state()

2021-05-27 Thread Sergio Lopez
allows us to make hvf_cpu_synchronize_state() static. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 2 +- > accel/hvf/hvf-accel-ops.h | 1 - > target/i386/hvf/x86hvf.c | 9 - > 3 files changed, 5 insertions(+), 7 deletions(-) Reviewed-

Re: [PATCH v8 12/19] hvf: Simplify post reset/init/loadvm hooks

2021-05-27 Thread Sergio Lopez
> accel/hvf/hvf-accel-ops.c | 27 +++ > target/i386/hvf/x86hvf.c | 5 ++++- > 2 files changed, 11 insertions(+), 21 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 13/19] hvf: Add Apple Silicon support

2021-05-27 Thread Sergio Lopez
| 5 + > accel/hvf/hvf-accel-ops.c | 14 + > include/sysemu/hvf_int.h| 9 +- > meson.build | 1 + > target/arm/hvf/hvf.c| 703 ++++++++++++ > target/arm/hvf/trace-events | 10 + > 6 files changed, 741 insertions(+), 1 deletion(-) > create mode 100644 target/arm/hvf/hvf.c > create mode 100644 target/arm/hvf/trace-events Reviewed-by: Sergio Lopez Tested-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 15/19] hvf: arm: Implement -cpu host

2021-05-27 Thread Sergio Lopez
72 > target/arm/hvf_arm.h | 19 > target/arm/kvm_arm.h | 2 -- > 5 files changed, 100 insertions(+), 4 deletions(-) > create mode 100644 target/arm/hvf_arm.h Reviewed-by: Sergio Lopez Tested-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 14/19] arm/hvf: Add a WFI handler

2021-05-27 Thread Sergio Lopez
; - Improve comment wording > --- > accel/hvf/hvf-accel-ops.c | 5 ++- > include/sysemu/hvf_int.h | 1 + > target/arm/hvf/hvf.c | 68 +++ > 3 files changed, 71 insertions(+), 3 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 17/19] arm: Add Hypervisor.framework build target

2021-05-27 Thread Sergio Lopez
son build file > --- > meson.build| 7 +++ > target/arm/hvf/meson.build | 3 +++ > target/arm/meson.build | 2 ++ > 3 files changed, 12 insertions(+) > create mode 100644 target/arm/hvf/meson.build Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 19/19] hvf: arm: Handle Windows 10 SMC call

2021-05-27 Thread Sergio Lopez
; --- > > v7 -> v8: > > - fix checkpatch > --- > target/arm/hvf/hvf.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Sergio Lopez Tested-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v8 16/19] hvf: arm: Implement PSCI handling

2021-05-27 Thread Sergio Lopez
> v8: > > - Do not advance for HVC, PC is already updated by hvf > - Fix checkpatch error > --- > target/arm/cpu.c| 4 +- > target/arm/hvf/hvf.c| 123 ++-- > target/arm/hvf/trace-events | 1 + > 3 files chan

Re: [PATCH v8 18/19] arm: Enable Windows 10 trusted SMCCC boot call

2021-05-27 Thread Sergio Lopez
> --- > target/arm/kvm-consts.h | 2 ++ > target/arm/psci.c | 2 ++ > 2 files changed, 4 insertions(+) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

[PATCH 0/2] nbd/server: Quiesce server on drained section

2021-05-31 Thread Sergio Lopez
sh this, we add ".drained_poll" to BlockDevOps and use it in the NBD server, along with ".drained_being" and "drained_end", to coordinate the quiescing of the server while entering a drained section. Sergio Lopez (2): block-backend: add drained_poll nbd/server

[PATCH 1/2] block-backend: add drained_poll

2021-05-31 Thread Sergio Lopez
Allow block backends to poll their devices/users to check if they have been quiesced when entering a drained section. This will be used in the next patch to wait for the NBD server to be completely quiesced. Suggested-by: Kevin Wolf Signed-off-by: Sergio Lopez --- block/block-backend.c

[PATCH 2/2] nbd/server: Use drained block ops to quiesce the server

2021-05-31 Thread Sergio Lopez
s. With these changes, "blk_aio_attach()" and "blk_aio_detach()" can be reverted to be as simple as they were before f148ae7d36. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1960137 Suggested-by: Kevin Wolf Signed-off-by: Sergio Lopez --- nbd/server.c | 99 +++

Re: [PATCH 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-01 Thread Sergio Lopez
On Tue, Jun 01, 2021 at 06:08:41PM +0200, Kevin Wolf wrote: > Am 01.06.2021 um 07:57 hat Sergio Lopez geschrieben: > > Before switching between AioContexts we need to make sure that we're > > fully quiesced ("nb_requests == 0" for every client) when entering the >

Re: [PATCH 1/2] block-backend: add drained_poll

2021-06-01 Thread Sergio Lopez
On Tue, Jun 01, 2021 at 05:59:10PM +0200, Kevin Wolf wrote: > Am 01.06.2021 um 07:57 hat Sergio Lopez geschrieben: > > Allow block backends to poll their devices/users to check if they have > > been quiesced when entering a drained section. > > > > This will be used in

Re: [PATCH 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-01 Thread Sergio Lopez
On Tue, Jun 01, 2021 at 04:29:07PM -0500, Eric Blake wrote: > On Tue, Jun 01, 2021 at 07:57:28AM +0200, Sergio Lopez wrote: > > Before switching between AioContexts we need to make sure that we're > > fully quiesced ("nb_requests == 0" for every client) when en

[PATCH v2 0/2] nbd/server: Quiesce server on drained section

2021-06-01 Thread Sergio Lopez
Change .drained_poll comment to reflect that the returned boolean value will be true if the device is still busy, or false otherwise - Drop yield_co_list and use recv_coroutine and read_yielding [Kevin] - Return "true" or "false" in nbd_drained_poll [Kevin] - Fix grammar i

[PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-01 Thread Sergio Lopez
ests. With these changes, "blk_aio_attach()" and "blk_aio_detach()" can be reverted to be as simple as they were before f148ae7d36. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1960137 Suggested-by: Kevin Wolf Signed-off-by: Sergio Lopez --- nbd/server.c | 82 +++

[PATCH v2 1/2] block-backend: add drained_poll

2021-06-01 Thread Sergio Lopez
-by: Sergio Lopez --- block/block-backend.c | 7 ++- include/sysemu/block-backend.h | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index de5496af66..8fcc2b4b3d 100644 --- a/block/block-backend.c +++ b/block/block

Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Sergio Lopez
On Wed, Jun 02, 2021 at 03:06:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 02.06.2021 09:05, Sergio Lopez wrote: > > Before switching between AioContexts we need to make sure that we're > > fully quiesced ("nb_requests == 0" for every client) when entering the &g

Re: [PATCH] virtiofsd: Add qemu version and copyright info

2021-03-07 Thread Sergio Lopez
; Reported-by: Eric Ernst > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/passthrough_ll.c |8 > 1 file changed, 8 insertions(+) Reviewed-by: Sergio Lopez > Index: rhvgoyal-qemu/tools/virtiofsd/passthrough_ll.c >

Re: GSoC introduction: Rust vhost-user-scsi device

2021-05-19 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:14:36AM +0100, Stefan Hajnoczi wrote: > On Tue, May 18, 2021 at 07:10:31PM -0700, Gaelan Steele wrote: > > I'm Gaelan Steele, one of QEMU's Google Summer of Code students this > > year. My mentor (Sergio Lopez) has asked me to introduce mysel

[PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup()

2021-01-21 Thread Sergio Lopez
: https://bugzilla.redhat.com/show_bug.cgi?id=1900505 Signed-off-by: Sergio Lopez --- block.c| 1 - softmmu/runstate.c | 9 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 3da99312db..9682c82fa8 100644 --- a/block.c +++ b/block.c

[PATCH v3 1/2] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2021-01-21 Thread Sergio Lopez
xts. To avoid this problem, add every child and parent to the ignore list before actually processing them. Suggested-by: Kevin Wolf Signed-off-by: Sergio Lopez --- block.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c in

[PATCH v3 0/2] nbd/server: Quiesce coroutines on context switch

2021-01-21 Thread Sergio Lopez
ck: Close block exports in two steps" - Rename nbd_read_eof() to nbd_server_read_eof() (Eric Blake) - Fix double space and typo in comment. (Eric Blake) Sergio Lopez (2): block: Avoid processing BDS twice in bdrv_set_aio_context_ignore() block: move blk_exp_close_all() to qemu_cleanu

Re: [PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup()

2021-02-01 Thread Sergio Lopez
On Mon, Feb 01, 2021 at 01:20:30PM +0100, Kevin Wolf wrote: > Am 21.01.2021 um 18:07 hat Sergio Lopez geschrieben: > > Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before > > bdrv_drain_all_begin(). > > > > Export drivers may have coroutines yielding

Re: [PATCH v3 1/2] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2021-02-01 Thread Sergio Lopez
On Mon, Feb 01, 2021 at 01:06:31PM +0100, Kevin Wolf wrote: > Am 21.01.2021 um 18:06 hat Sergio Lopez geschrieben: > > Some graphs may contain an indirect reference to the first BDS in the > > chain that can be reached while walking it bottom->up from one its > > chi

[PATCH v4 0/2] nbd/server: Quiesce coroutines on context switch

2021-02-01 Thread Sergio Lopez
block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()" - Add "block: Close block exports in two steps" - Rename nbd_read_eof() to nbd_server_read_eof() (Eric Blake) - Fix double space and typo in comment. (Eric Blake) Sergio Lopez (2): block: Avoid processing BD

[PATCH v4 2/2] block: move blk_exp_close_all() to qemu_cleanup()

2021-02-01 Thread Sergio Lopez
: https://bugzilla.redhat.com/show_bug.cgi?id=1900505 Signed-off-by: Sergio Lopez --- block.c | 1 - qemu-nbd.c | 1 + softmmu/runstate.c | 9 + storage-daemon/qemu-storage-daemon.c | 1 + 4 files changed, 11

[PATCH v4 1/2] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2021-02-01 Thread Sergio Lopez
xts. To avoid this problem, add every child and parent to the ignore list before actually processing them. Suggested-by: Kevin Wolf Signed-off-by: Sergio Lopez --- block.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c in

Re: [PATCH v3 03/12] x86: add support for second ioapic

2020-12-03 Thread Sergio Lopez
oapic_internal.h | 2 +- > include/hw/i386/x86.h | 3 +++ > hw/i386/acpi-common.c | 10 ++ > hw/i386/x86.c | 21 + > 5 files changed, 37 insertions(+), 1 deletion(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v3 04/12] microvm: make number of virtio transports runtime changeable

2020-12-03 Thread Sergio Lopez
microvm.c | 9 +++-- > 2 files changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v3 06/12] microvm: drop microvm_gsi_handler()

2020-12-03 Thread Sergio Lopez
e changed, 1 insertion(+), 13 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v3 05/12] microvm: make pcie irq base runtime changeable

2020-12-03 Thread Sergio Lopez
1 ++- > 2 files changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH v3 07/12] microvm: add second ioapic

2020-12-03 Thread Sergio Lopez
off-by: Gerd Hoffmann > --- > include/hw/i386/microvm.h | 2 ++ > hw/i386/microvm.c | 56 +++--- > tests/qtest/bios-tables-test.c | 8 ++--- > 3 files changed, 57 insertions(+), 9 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

[PATCH 1/2] virtio-blk: Acquire context while switching them on dataplane start

2020-12-04 Thread Sergio Lopez
ext' was called with an unprotected AIO context. Signed-off-by: Sergio Lopez --- hw/block/dataplane/virtio-blk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 37499c5564..034e43cb1f 100644 --- a/hw/block/dataplane/v

<    1   2   3   4   5   6   >