Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Stefan Berger
On 05/24/2013 05:59 AM, Stefan Hajnoczi wrote: On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: This patch series provides VNVRAM persistent storage support that QEMU can use internally. The initial target user will be a software vTPM 1.2 backend that needs to store keys in VNVRAM

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-19 Thread Stefan Berger
: + * Stefan Berger stef...@us.ibm.com + * Corey Bryantcor...@linux.vnet.ibm.com + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#include sysemu/tpm_backend.h +#include tpm_int.h +#include tpm_nvram.h

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-20 Thread Stefan Berger
On 11/19/2013 06:03 PM, Anthony Liguori wrote: On Tue, Nov 19, 2013 at 1:32 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch series provides support for a

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Stefan Berger
On 06/14/2013 11:38 AM, Anthony Liguori wrote: Corey Bryant cor...@linux.vnet.ibm.com writes: On 06/14/2013 10:01 AM, Anthony Liguori wrote: Corey Bryant cor...@linux.vnet.ibm.com writes: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-12-02 Thread Stefan Berger
On 12/02/2013 09:16 AM, Corey Bryant wrote: Stefan, do you know if this is the same code that was used to build our bios.bin? Probably similar, but forward-ported to a more recent version.

[Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-17 Thread Stefan Berger
On 01/16/2011 09:43 AM, Avi Kivity wrote: On 01/14/2011 09:27 PM, Stefan Berger wrote: Can you sprinkle some printfs() arount kvm_run (in qemu-kvm.c) to verify this? Here's what I did: interrupt exit requested It appears from this you're using qemu.git. Please try qemu-kvm.git

[Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-24 Thread Stefan Berger
On 01/18/2011 03:53 AM, Jan Kiszka wrote: On 2011-01-18 04:03, Stefan Berger wrote: On 01/16/2011 09:43 AM, Avi Kivity wrote: On 01/14/2011 09:27 PM, Stefan Berger wrote: Can you sprinkle some printfs() arount kvm_run (in qemu-kvm.c) to verify this? Here's what I did: interrupt exit

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-24 Thread Stefan Berger
On 01/24/2011 05:34 PM, Jan Kiszka wrote: On 2011-01-24 19:27, Stefan Berger wrote: On 01/18/2011 03:53 AM, Jan Kiszka wrote: On 2011-01-18 04:03, Stefan Berger wrote: On 01/16/2011 09:43 AM, Avi Kivity wrote: On 01/14/2011 09:27 PM, Stefan Berger wrote: Can you sprinkle some printfs

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-25 Thread Stefan Berger
On 01/25/2011 02:26 AM, Jan Kiszka wrote: Do you see a chance to look closer at the issue yourself? E.g. instrument the kernel's irqchip models and dump their states once your guest is stuck? The device runs on iRQ 3. So I applied this patch here. diff --git a/arch/x86/kvm/i8259.c

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote: On 01/25/2011 02:26 AM, Jan Kiszka wrote: Do you see a chance to look closer at the issue yourself? E.g. instrument the kernel's irqchip models and dump their states once your guest is stuck? The device runs

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 07:09 AM, Jan Kiszka wrote: On 2011-01-26 13:05, Stefan Berger wrote: On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote: On 01/25/2011 02:26 AM, Jan Kiszka wrote: Do you see a chance to look closer at the issue yourself? E.g. instrument

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 08:31 AM, Jan Kiszka wrote: On 2011-01-26 14:15, Jan Kiszka wrote: On 2011-01-26 14:08, Stefan Berger wrote: On 01/26/2011 07:09 AM, Jan Kiszka wrote: On 2011-01-26 13:05, Stefan Berger wrote: On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote

[Qemu-devel] qemu crashes since today

2011-02-16 Thread Stefan Berger
Qemu is crashing for me. Bisecting the code I found this here as the reason. Stepping one commit further into the past does not cause the crash. 6792a57bf19ab37f61f5acf0f8e3003cf08814af is the first bad commit commit 6792a57bf19ab37f61f5acf0f8e3003cf08814af Author: Jan Kiszka

Re: [Qemu-devel] Re: qemu crashes since today

2011-02-16 Thread Stefan Berger
On 02/16/2011 05:45 PM, Jan Kiszka wrote: On 2011-02-16 23:18, Stefan Berger wrote: Qemu is crashing for me. Bisecting the code I found this here as the reason. Stepping one commit further into the past does not cause the crash. 6792a57bf19ab37f61f5acf0f8e3003cf08814af is the first bad commit

Re: [Qemu-devel] Re: qemu crashes since today

2011-02-17 Thread Stefan Berger
On 02/17/2011 04:21 AM, Gerd Hoffmann wrote: Hi, Does F14 happen to use the vmport/vmmount? Maybe this crash is related to [1]. Yes. Try 'rpm -e xorg-x11-drv-vmmouse' in the guest and check whenever this avoids the crash to confirm vmmouse is the culprit. I removed this one and it's

Re: [Qemu-devel] [PATCH 1/5] Add TPM 1.2 device interface

2011-02-18 Thread Stefan Berger
On 02/18/2011 10:33 AM, Andreas Niederl wrote: This implementation is based on the TPM 1.2 interface for virtualized TPM devices from the Xen-4.0.0 ioemu-qemu-xen fork. A backend driver infrastructure is provided to be able to use different device backends. Signed-off-by: Andreas

Re: [Qemu-devel] [PATCH 2/5] Provide SSDT for enabled TPM device

2011-02-18 Thread Stefan Berger
On 02/18/2011 10:33 AM, Andreas Niederl wrote: Signed-off-by: Andreas Niederlandreas.nied...@iaik.tugraz.at --- Makefile.target |3 +++ hw/acpi.c | 28 hw/pc.h |1 + hw/tpm.h|2 ++ hw/tpm_acpi.c | 40

Re: [Qemu-devel] [PATCH 1/5] Add TPM 1.2 device interface

2011-02-18 Thread Stefan Berger
On 02/18/2011 12:37 PM, Andreas Niederl wrote: On 02/18/2011 05:37 PM, Stefan Berger wrote: On 02/18/2011 10:33 AM, Andreas Niederl wrote: This implementation is based on the TPM 1.2 interface for virtualized TPM devices from the Xen-4.0.0 ioemu-qemu-xen fork. A backend driver infrastructure

Re: [Qemu-devel] [PATCH 1/5] Add TPM 1.2 device interface

2011-02-18 Thread Stefan Berger
On 02/18/2011 10:33 AM, Andreas Niederl wrote: + +static const VMStateDescription vmstate_loc = { +.name = loc, +.version_id = 0, +.fields = (VMStateField []) { +VMSTATE_UINT32(state, TPMLocality), +VMSTATE_UINT32(inte, TPMLocality), +

Re: [Qemu-devel] [PATCH 1/5] Add TPM 1.2 device interface

2011-02-22 Thread Stefan Berger
On 02/21/2011 12:03 PM, Andreas Niederl wrote: On 02/18/2011 09:27 PM, Stefan Berger wrote: On 02/18/2011 12:37 PM, Andreas Niederl wrote: [...] So I'm guessing that this library is not publicly available right now? Not via the fedora repository at least. So yum install does not work, yet

[Qemu-devel] [PATCH] Fix the RARP protocol ID

2010-04-24 Thread Stefan Berger
The packet(s) sent out after migration are supposed to be RAPR type of packets. If they are supposed to go anywhere useful, the RAPR ethernet identifier needs to be fix. Also see http://www.iana.org/assignments/ethernet-numbers for 0x8035 for RARP. Signed-off-by: Stefan Berger stef...@us.ibm.com

Re: [Qemu-devel] [PATCH] Fix the RARP protocol ID

2010-04-29 Thread Stefan Berger
send an ARP request packet asking for an IP address of 0.0.0.0 ? Stefan Signed-off-by: Stefan Berger stef...@us.ibm.com --- savevm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu-git/savevm.c

[Qemu-devel] [PATCH 0/5]: Qemu Trusted Platform Module (TPM) integration

2011-02-24 Thread Stefan Berger
The following series of patches adds a TPM (Trusted Platform Module) TIS (TPM Interface Spec) interface to Qemu and with that provides means to access a backend implementing the actual TPM functionality. This frontend enables for example Linux's TPM TIS (tpm_tis) driver. I am also posting the

Re: [Qemu-devel] [PATCH 1/5] Add TPM 1.2 device interface

2011-02-24 Thread Stefan Berger
On 02/24/2011 10:30 AM, Andreas Niederl wrote: On 02/18/2011 05:37 PM, Stefan Berger wrote: [...] I have a tpm_tis.c with major changes in it getting rid of the polling, closer to specs that passes a test suite and a registerable backend as well that has several more interface functions, due

[Qemu-devel] [PATCH 2/5]: Support for TPM command line options

2011-02-24 Thread Stefan Berger
into the backend driver, which needs to implement the interface function 'handle_options' and return true if the VM can be started or 'false' if not enough or bad parameters were provided. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- arch_init.c | 77

[Qemu-devel] [PATCH 1/5]: Add tpm_tis driver to build process

2011-02-24 Thread Stefan Berger
, at least initially. The list can be easily extend. I am trying to prevent that one will end up with support for a frontend but no available backend. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Index:qemu/Makefile.target

[Qemu-devel] [PATCH 4/5]: Implement qemu_thread_join function

2011-02-24 Thread Stefan Berger
thread's termination before terminating the TPM, creating a new one and loading previous state from the time of the snapshot into the TPM. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- qemu-thread.c |5 + qemu-thread.h |1 + 2 files changed, 6 insertions(+) Index: qemu-git

[Qemu-devel] [PATCH 5/5]: Implementation of the libtpms-based backend

2011-02-24 Thread Stefan Berger
location) due to a presumed fatal error and let the VM run (without TPM functionality). Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.target |5 configure|3 hw/tpm_builtin.c | 1253 +++ hw/tpm_tis.c

[Qemu-devel] [PATCH 3/5]: Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-02-24 Thread Stefan Berger
not exercise all functionality. So, for testing I wrote have a fairly extensive test suite as a SeaBIOS patch since there full access to all the registers is possible. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/pc.c |3 hw/tpm_tis.c | 1011

[Qemu-devel] [PATCH Appendix] Skeleton backend driver

2011-02-24 Thread Stefan Berger
-by: Stefan Berger stef...@us.ibm.com Index: qemu-git/hw/tpm_be_skeleton.c === --- /dev/null +++ qemu-git/hw/tpm_be_skeleton.c @@ -0,0 +1,369 @@ +/* + * + * Copyright (c) 2010, 2011 IBM Corporation + * Copyright (c) 2010, 2011 Stefan Berger

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-21 Thread Stefan Berger
On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for UINT8 indexes. Anthony, please apply, without this migration using hpet is broken. (only current user). I have just been bisecting the

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix

Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 07:50 AM, Stefan Berger wrote: On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM

[Qemu-devel] [PATCH V1 0/8] Add TPM support to SeaBIOS

2011-03-30 Thread Stefan Berger
The following set of patches add TPM and Trusted Computing support to SeaBIOS. In particular the patches add: - a TPM driver for the Qemu's TPM TIS emulation (not yet in Qemu git) - ACPI support for the TPM device (SSDT table) - ACPI support for measurement logging (TCPA table) - Support for

[Qemu-devel] [PATCH V1 4/8] Build the TCG BIOS extensions and TPM drivers.

2011-03-30 Thread Stefan Berger
This patch allows to configure the TCGBIOS extensions to be built into SeaBIOS, depending on not COREBOOT being selected. All TCG BIOS extensions are activated with CONFIG_TCGBIOS. Add the two new code files (tcgbios.c, tpm_drivers.c) to be built. Signed-off-by: Stefan Berger stef

[Qemu-devel] [PATCH V1 5/8] Support for BIOS interrupt handler

2011-03-30 Thread Stefan Berger
a threshold for the size of data to hash (100k) below which the TPM is used and above the internal faster SHA1 algorithm is used. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/Kconfig |8 src/clock.c |9 src/stacks.c | 14 + src/tcgbios.c | 714

[Qemu-devel] [PATCH V1 1/8] Add an implementation for a TPM TIS driver

2011-03-30 Thread Stefan Berger
with a corresponding driver here. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/tpm_drivers.c | 215 ++ src/tpm_drivers.h | 55 + 2 files changed, 270 insertions(+) Index: seabios/src/tpm_drivers.c

[Qemu-devel] [PATCH V1 7/8] Add a menu for TPM control

2011-03-30 Thread Stefan Berger
-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/boot.c| 10 - src/tcgbios.c | 576 +- 2 files changed, 584 insertions(+), 2 deletions(-) Index: seabios/src/tcgbios.c

[Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions

2011-03-30 Thread Stefan Berger
didn't work once in an S3 resume. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/boot.c|2 src/post.c|5 src/resume.c |2 src/tcgbios.c | 525 ++ src/tcgbios.h | 386

[Qemu-devel] [PATCH V1 6/8] Add measurement code to the BIOS

2011-03-30 Thread Stefan Berger
54c83965978de9708d026016ecb0e70660e04388 1305 [] 5 2431ed60130faeaf3a045f21963f71cacd46a029 04 [OS Event Separator] 8 2431ed60130faeaf3a045f21963f71cacd46a029 04 [OS Event Separator] 8 f3973cae05d6e2055062119d6e6e1e077b7df876 1005 [] Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/boot.c

[Qemu-devel] [PATCH V1 8/8] Optional tests for the TIS interface

2011-03-30 Thread Stefan Berger
from 92.6% at the previous patch to 98.4%. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile |2 src/Kconfig|7 src/tcgbios.c | 34 +- src/tis_test.c | 846 + src/tis_test.h | 52 +++ 5 files

[Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-03-30 Thread Stefan Berger
issues when run in interrupt mode. The description of the TCPA (client) table can be found here: http://www.trustedcomputinggroup.org/resources/server_work_group_acpi_general_specification_version_10 The compiled SSDT description is also part of this patch. Signed-off-by: Stefan Berger stef

[Qemu-devel] [PATCH V2 3/9] Add persistent state handling to TPM TIS frontend driver

2011-03-30 Thread Stefan Berger
disk where the buffer's content are copied into the currently used buffer. I adapated the structure to those used by the Xen driver in order to provide compatibility to existing state. For that I am adding Andreas Niederl as an author to the file. Signed-off-by: Stefan Berger stef

[Qemu-devel] [PATCH V2 5/9] Add a debug register

2011-03-30 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_tis.c | 67

[Qemu-devel] [PATCH V2 1/9] Support for TPM command line options

2011-03-30 Thread Stefan Berger
into the backend driver, which needs to implement the interface function 'handle_options' and return true if the VM can be started or 'false' if not enough or bad parameters were provided. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- arch_init.c | 77

[Qemu-devel] [PATCH V2 0/9] Qemu Trusted Platform Module (TPM) integration

2011-03-30 Thread Stefan Berger
The following series of patches adds a TPM (Trusted Platform Module) TIS (TPM Interface Spec) interface to Qemu and with that provides means to access a backend implementing the actual TPM functionality. This frontend enables for example Linux's TPM TIS (tpm_tis) driver. I am also posting the

[Qemu-devel] [PATCH V2 8/9] Implementation of the libtpms-based backend

2011-03-30 Thread Stefan Berger
coding style Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure|3 hw/tpm_builtin.c | 424 --- hw/tpm_tis.h | 17 ++ 3 files changed, 423 insertions(+), 21 deletions(-) Index: qemu-git/hw/tpm_tis.h

[Qemu-devel] [PATCH V2 4/9] Add tpm_tis driver to build process

2011-03-30 Thread Stefan Berger
, at least initially. The list can be easily extend. This measure prevents that one will end up with support for a frontend but no available backend. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Index:qemu/Makefile.target

[Qemu-devel] [PATCH V2 2/9] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-03-30 Thread Stefan Berger
not exercise all functionality. So, for testing there is a fairly extensive test suite as part of the SeaBIOS patches since from within the BIOS one can have full access to all the TPM's registers. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/pc.c |3 hw/tpm_tis.c | 826

[Qemu-devel] [PATCH V2 7/9] Add a TPM backend skeleton implementation

2011-03-30 Thread Stefan Berger
This patch provides a TPM backend skelteon implementation. It doesn't do anything but it compiles. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.target |5 hw/tpm_builtin.c | 372 +++ hw/tpm_tis.c |3 3

[Qemu-devel] [PATCH V2 9/9] Add block storage support for libtpms based TPM backend

2011-03-30 Thread Stefan Berger
fatal error and let the VM run (without TPM functionality). Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_builtin.c | 685 ++- 1 file changed, 684 insertions(+), 1 deletion(-) Index: qemu-git/hw/tpm_builtin.c

[Qemu-devel] [PATCH V2 6/9] Implement qemu_thread_join function

2011-03-30 Thread Stefan Berger
with the TPM thread's termination before terminating the TPM, creating a new one and loading previous state from the time of the snapshot into the TPM. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- qemu-thread-posix.c |5 + qemu-thread.h |1 + 2 files changed, 6

[Qemu-devel] [PATCH] hmp: Fix freeing of PciInfoList

2012-01-11 Thread Stefan Berger
Remember the original PciInfoList in info_list and use the info variable to traverse the list. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hmp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: qemu-git.pt/hmp.c

Re: [Qemu-devel] Summary of Anthony's 'next' queue

2011-11-14 Thread Stefan Berger
On 11/14/2011 03:17 PM, Anthony Liguori wrote: Hi, This is a summary of the patches that I have queued in my next tree that were identified as 1.1 candidates. These patches will not be applied until after the 1.1 tree opens (December 1st). These patches have not been tested yet and may

[Qemu-devel] [PATCH] Adapt libvirt's Qemu version parser for Qemu 1.0

2011-12-02 Thread Stefan Berger
Qemu 1.0 does not show a micro version like 0.15.50 did. Adapt the Qemu version parser to handle this. --- src/qemu/qemu_capabilities.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) Index: libvirt-tpm/src/qemu/qemu_capabilities.c

Re: [Qemu-devel] [PATCH] Adapt libvirt's Qemu version parser for Qemu 1.0

2011-12-02 Thread Stefan Berger
On 12/02/2011 03:32 PM, Eric Blake wrote: On 12/02/2011 01:08 PM, Stefan Berger wrote: Qemu 1.0 does not show a micro version like 0.15.50 did. Adapt the Qemu version parser to handle this. --- src/qemu/qemu_capabilities.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion

[Qemu-devel] [PATCH V13 7/7] Add fd parameter for TPM passthrough driver

2011-12-12 Thread Stefan Berger
Enable the passing of a file descriptor via fd=.. to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v13: - Only accepting a character device's file descriptor v12: - added documentation part --- hw/tpm_passthrough.c

[Qemu-devel] [PATCH V13 4/7] Build the TPM frontend code

2011-12-12 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.target |1 + configure | 11 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index 39b2e5a

[Qemu-devel] [PATCH V13 6/7] Introduce --enable-tpm-passthrough configure option

2011-12-12 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 25995bc..ffb599e 100755 --- a/configure +++ b/configure

[Qemu-devel] [PATCH V13 1/7] Support for TPM command line options

2011-12-12 Thread Stefan Berger
: type=passthrough,path=/dev/tpm0 Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v12: - use all 4 bytes of the message length indicator v10: - tpm_display_backend_drivers always prints to stderr v9: - prefixing all functions with tpm_tis_ and all constants with TPM_TIS_

[Qemu-devel] [PATCH V13 5/7] Add a TPM Passthrough backend driver implementation

2011-12-12 Thread Stefan Berger
, Andreas Niederl, Stefan Berger [1] http://trustedjava.sourceforge.net/ Signed-off-by: Andreas Niederl andreas.nied...@iaik.tugraz.at Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Changes for v12: - check size indicator in response from TPM to match that of the received packet

[Qemu-devel] [PATCH V13 0/7] Qemu Trusted Platform Module (TPM) integration

2011-12-12 Thread Stefan Berger
Stefan Berger (7): Support for TPM command line options Add TPM (frontend) hardware interface (TPM TIS) to Qemu Add a debug register Build the TPM frontend code Add a TPM Passthrough backend driver implementation Introduce --enable-tpm-passthrough configure option Add fd parameter

[Qemu-devel] [PATCH V13 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-12-12 Thread Stefan Berger
not exercise all functionality. So, for testing there is a fairly extensive test suite as part of the SeaBIOS patches since from within the BIOS one can have full access to all the TPM's registers. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v13: - don't call destroy callback in error

[Qemu-devel] [PATCH V13 3/7] Add a debug register

2011-12-12 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v9: - prefixing all function

Re: [Qemu-devel] [PATCH V13 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-12-12 Thread Stefan Berger
On 12/12/2011 06:23 PM, Anthony Liguori wrote: On 12/12/2011 01:12 PM, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet

Re: [Qemu-devel] [PATCH V13 4/7] Build the TPM frontend code

2011-12-12 Thread Stefan Berger
On 12/12/2011 06:24 PM, Anthony Liguori wrote: On 12/12/2011 01:12 PM, Stefan Berger wrote: Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com --- Makefile.target |1 + configure | 11 +++ 2 files changed, 12

Re: [Qemu-devel] [PATCH V13 5/7] Add a TPM Passthrough backend driver implementation

2011-12-12 Thread Stefan Berger
On 12/12/2011 06:27 PM, Anthony Liguori wrote: On 12/12/2011 01:12 PM, Stefan Berger wrote: From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series Qemu Trusted Platform Module (TPM) integration

Re: [Qemu-devel] [PATCH V13 6/7] Introduce --enable-tpm-passthrough configure option

2011-12-12 Thread Stefan Berger
On 12/12/2011 06:27 PM, Anthony Liguori wrote: On 12/12/2011 01:12 PM, Stefan Berger wrote: Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com --- configure | 16 +++- 1 files changed, 15 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH V13 7/7] Add fd parameter for TPM passthrough driver

2011-12-12 Thread Stefan Berger
On 12/12/2011 06:30 PM, Anthony Liguori wrote: On 12/12/2011 01:12 PM, Stefan Berger wrote: Enable the passing of a file descriptor via fd=.. to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com [...] -tb-s.tpm_pt

Re: [Qemu-devel] [PATCH V13 1/7] Support for TPM command line options

2011-12-12 Thread Stefan Berger
On 12/12/2011 06:16 PM, Anthony Liguori wrote: On 12/12/2011 01:12 PM, Stefan Berger wrote: @@ -2735,6 +2736,15 @@ static mon_cmd_t info_cmds[] = { .help = show available trace-events their state, .mhandler.info = do_trace_print_events, }, +#if defined

Re: [Qemu-devel] [PATCH V13 0/7] Qemu Trusted Platform Module (TPM) integration

2011-12-13 Thread Stefan Berger
On 12/13/2011 12:45 AM, Stefan Weil wrote: Am 12.12.2011 20:12, schrieb Stefan Berger: The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend

Re: [Qemu-devel] [PATCH V13 6/7] Introduce --enable-tpm-passthrough configure option

2011-12-13 Thread Stefan Berger
On 12/12/2011 11:51 PM, Paul Brook wrote: +tpm_passthrough=no Same as before, please probe for existence. We would be probing for /dev/tpm0. Is that really what we want that this driver only gets compiled if /dev/tpm0 is (currently) available? If what you say is true then this code should

Re: [Qemu-devel] [PATCH V13 6/7] Introduce --enable-tpm-passthrough configure option

2011-12-13 Thread Stefan Berger
On 12/13/2011 12:41 PM, Anthony Liguori wrote: On 12/13/2011 07:51 AM, Michael S. Tsirkin wrote: On Tue, Dec 13, 2011 at 07:51:17AM -0500, Stefan Berger wrote: On 12/12/2011 11:51 PM, Paul Brook wrote: +tpm_passthrough=no Same as before, please probe for existence. We would be probing

[Qemu-devel] [PATCH V14 6/7] Introduce --enable-tpm-passthrough configure option

2011-12-14 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 25995bc..ffb599e 100755 --- a/configure +++ b/configure

[Qemu-devel] [PATCH V14 7/7] Add fd parameter for TPM passthrough driver

2011-12-14 Thread Stefan Berger
Enable the passing of a file descriptor via fd=.. to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_passthrough.c | 73 +- qemu-config.c|5 +++ qemu

[Qemu-devel] [PATCH V14 5/7] Add a TPM Passthrough backend driver implementation

2011-12-14 Thread Stefan Berger
, Andreas Niederl, Stefan Berger [1] http://trustedjava.sourceforge.net/ Signed-off-by: Andreas Niederl andreas.nied...@iaik.tugraz.at Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.target |1 + configure|3 + hw/tpm_passthrough.c | 493

[Qemu-devel] [PATCH V14 1/7] Support for TPM command line options

2011-12-14 Thread Stefan Berger
: type=passthrough,path=/dev/tpm0 Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hmp-commands.hx |2 + hmp.c| 28 +++ hmp.h|1 + hw/tpm_tis.h | 80 monitor.c|8 ++ qapi-schema.json | 29 +++ qemu

[Qemu-devel] [PATCH V14 4/7] Build the TPM frontend code

2011-12-14 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.target |2 ++ configure | 11 +++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index 3df3057

[Qemu-devel] [PATCH V14 0/7] Qemu Trusted Platform Module (TPM) integration

2011-12-14 Thread Stefan Berger
on the ppc64 host] v2: - splitting some of the patches into smaller ones for easier review - fixes in individual patches Regards, Stefan Stefan Berger (7): Support for TPM command line options Add TPM (frontend) hardware interface (TPM TIS) to Qemu Add a debug register Build the TPM

[Qemu-devel] [PATCH V14 3/7] Add a debug register

2011-12-14 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_tis.c | 70

[Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-12-14 Thread Stefan Berger
not exercise all functionality. So, for testing there is a fairly extensive test suite as part of the SeaBIOS patches since from within the BIOS one can have full access to all the TPM's registers. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_tis.c | 807

Re: [Qemu-devel] [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Stefan Berger
On 12/15/2011 08:02 AM, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being phased out as an API. Management tools should rely only on QMP for new commands.

Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options

2011-05-17 Thread Stefan Berger
On 05/17/2011 04:58 PM, Serge E. Hallyn wrote: Quoting Stefan Berger (stef...@linux.vnet.ibm.com): This patch adds support for TPM command line options. The command line supported here (considering the libtpms based backend) are ./qemu-... -tpm type=type,path=path to blockstorage file, Hm, I

Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options

2011-05-17 Thread Stefan Berger
On 05/17/2011 04:58 PM, Serge E. Hallyn wrote: Quoting Stefan Berger (stef...@linux.vnet.ibm.com): This patch adds support for TPM command line options. The command line supported here (considering the libtpms based backend) are ./qemu-... -tpm type=type,path=path to blockstorage file, Hm, I

Re: [Qemu-devel] [PATCH V4 03/10] Add persistent state handling to TPM TIS frontend driver

2011-05-18 Thread Stefan Berger
On 05/18/2011 03:25 AM, Markus Armbruster wrote: Stefan Bergerstef...@linux.vnet.ibm.com writes: Why is this device no_user? Because I instantiated it still with isa_create_simple(). This is going to change in v5. Thanks. Stefan

Re: [Qemu-devel] [PATCH V4 02/10] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-05-18 Thread Stefan Berger
On 05/18/2011 03:23 AM, Markus Armbruster wrote: Stefan Bergerstef...@linux.vnet.ibm.com writes: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on my previous implementation for Xen but has been significantly extended to

Re: [Qemu-devel] [PATCH V4 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-05-18 Thread Stefan Berger
On 04/12/2011 09:32 AM, Stefan Berger wrote: + +static u32 add_tpm_device(void **tpm_addr, void **tcpa_addr) +{ +struct tcpa_descriptor_rev2 *tcpa; + +*tpm_addr = NULL; +*tcpa_addr = NULL; + +if (has_working_tpm()) { +u32 laml = 64 * 1024; Kevin, the above line

[Qemu-devel] [PATCH V5 00/12] Qemu Trusted Platform Module (TPM) integration

2011-05-20 Thread Stefan Berger
The following series of patches adds a TPM (Trusted Platform Module) TIS (TPM Interface Spec) interface to Qemu and with that provides means to access a backend implementing the actual TPM functionality. This frontend enables for example Linux's TPM TIS (tpm_tis) driver. I am also posting the

[Qemu-devel] [PATCH V5 05/12] Add a debug register

2011-05-20 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). v3: - all output goes to stderr Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

[Qemu-devel] [PATCH V5 01/12] Support for TPM command line options

2011-05-20 Thread Stefan Berger
has a destroy() function for cleaning up after the create() function was called - added support for 'info tpm' in monitor v4: - coding style fixes v3: - added hw/tpm_tis.h to this patch so Qemu compiles at this stage Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

[Qemu-devel] [PATCH V5 02/12] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-05-20 Thread Stefan Berger
and gracefully fails Qemu if it's not available. This works with migration using shared storage but doesn't support migration with block storage migration. For encyrypted QCoW2 and in case of a snapshot resue the late_startup_tpm interface function is called Signed-off-by: Stefan Berger

[Qemu-devel] [PATCH V5 04/12] Add tpm_tis driver to build process

2011-05-20 Thread Stefan Berger
for a frontend but no available backend. v3: - fixed and moved hunks in Makefile.target into right place Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Index:qemu/Makefile.target === --- Makefile.target |1 + configure | 20

[Qemu-devel] [PATCH V5 03/12] Add persistent state handling to TPM TIS frontend driver

2011-05-20 Thread Stefan Berger
data to the block storage) Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_tis.c | 166 +++ 1 file changed, 166 insertions(+) Index: qemu-git/hw/tpm_tis.c

[Qemu-devel] [PATCH V5 08/12] Introduce file lock for the block layer

2011-05-20 Thread Stefan Berger
with a standalone test program locking shared storage from two different machines. To enable locking a file multiple times, a counter is used. Actual locking happens the very first time and unlocking happens when the counter is zero. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

[Qemu-devel] [PATCH V5 12/12] Experimental support for taking measurements when kernel etc. are passed to Qemu

2011-05-20 Thread Stefan Berger
retrieve it in SeaBIOS's and concat the setup and rest of the kernel to get the correct measurement. An alternative would be to measure the files in Qemu and make the measurements available to SeaBIOS. This would introduce a dependency of Qemu on a sha1 algorithm. Signed-off-by: Stefan Berger stef

[Qemu-devel] [PATCH V5 06/12] Add a TPM backend skeleton implementation

2011-05-20 Thread Stefan Berger
termination; the libtpms-based driver will require Qemu's main thread to write data to the block storage device while trying to join V2: - only terminating thread in tpm_atexit if it's running Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.target |5 configure

[Qemu-devel] [PATCH V5 10/12] Encrypt state blobs using AES CBC encryption

2011-05-20 Thread Stefan Berger
is missing. In either one of the cases the backend returns an error and Qemu terminates. -v5: - -tpmdev now also gets a key parameter - add documentation about key parameter Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_builtin.c | 213

[Qemu-devel] [PATCH V5 07/12] Implementation of the libtpms-based backend

2011-05-20 Thread Stefan Berger
: - temporarily deactivate the building of the tpm_builtin.c until subsequent patch completely converts it to the libtpms based driver v2: - fixes to adhere to the qemu coding style Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure|1 hw/tpm_builtin.c | 422

[Qemu-devel] [PATCH V5 11/12] Experimental support for block migrating TPMs state

2011-05-20 Thread Stefan Berger
-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm_builtin.c |5 + savevm.c | 22 +++--- 2 files changed, 16 insertions(+), 11 deletions(-) Index: qemu-git/hw/tpm_builtin.c === --- qemu

  1   2   3   4   5   6   7   8   9   10   >