From: Riku Voipio
Remove "if(__put_user" checks and their related error paths
for all architecture's setup_frame, setup_rt_frame and similar.
Remove the unlock_user_struct when the only way to end up there is
from failed lock_user_struct.
Remove err variable if there are no user
From: Riku Voipio
This series is primarily motivated to have a gcc-4.9 buildfix:
linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression has no
effect [-Werror=unused-value]
((hptr), (x)), 0)
removing the unused
From: Riku Voipio
Make all implementations of setup_sigcontext void and
remove checking it's return value from functions calling
setup_sigcontext.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 65 +
1 file changed, 21 inser
From: Riku Voipio
Remove all the simple cases or reading the return value
of __get_user and __put_user.
We set err = 0 in sparc versions of do_sigreturn and
sparc64_set_context to avoid compile error, but else this patch is
just the removal of err |= __get_user ... idiom.
Signed-off-by: Riku
From: Riku Voipio
make most implementations of restore_sigcontext void and
remove checking it's return value from functions calling
restore_sigcontext.
The exception is the X86 version of the function that is
too different from others to deal in this way.
Signed-off-by: Riku Voipio
---
From: Riku Voipio
Remove "if(__get_user" checks and their related error paths
for all architecture's do_sigreturn. Remove the unlock_user_struct
when the only way to end up there is from failed lock_user_struct.
Signed-off-by: Riku Voipio
---
linux-use
From: Riku Voipio
gcc-4.9 finds unused operand:
linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression
has no effect [-Werror=unused-value]
((hptr), (x)), 0)
Just removing the rh operand is no good, it will error
From: Riku Voipio
As __get_user and __put_user do not return errors, remove the
if checks from around them. This allows making the save/restore
functions void.
Signed-off-by: Riku Voipio
Cc: Alexander Graf
---
linux-user/signal.c | 126 +---
1
From: Riku Voipio
Remove checks of __get_user and the err variable
used to control flow with it.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index efb3562..487fa2f
On Wed, Apr 23, 2014 at 02:22:32PM +0100, Peter Maydell wrote:
> On 23 April 2014 14:11, wrote:
> > From: Riku Voipio
> >
> > This series is primarily motivated to have a gcc-4.9 buildfix:
> >
> > linux-user/syscall.c: In function ‘host_to_target_stat64’:
&g
Hi,
On Fri, Apr 25, 2014 at 02:42:14PM +0100, Huw Davies wrote:
> > This makes adding more message types cleaner.
> >
> > Signed-off-by: Huw Davies
> > ---
> > linux-user/syscall.c | 51
> > +--
> > 1 file changed, 33 insertions(+), 18 deletions(
& argv
> > exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
> > updated when another NEW_AUX_ENT is added.
> >
> > Signed-off-by: James Hogan
> > Cc: Riku Voipio
> > Cc: Peter Maydell
> > ---
> > This should be applie
t.pc);
> __put_user(pstate_read(env), &sf->uc.tuc_mcontext.pstate);
>
> -__put_user(/*current->thread.fault_address*/ 0,
> -&sf->uc.tuc_mcontext.fault_address);
> +__put_user(env->exception.vaddress,
> &sf->uc.tuc_mcontext.fault_address);
>
> for (i = 0; i < TARGET_NSIG_WORDS; i++) {
> __put_user(set->sig[i], &sf->uc.tuc_sigmask.sig[i]);
> --
> 1.9.2
>
> --
> Riku Voipio
On Tue, Apr 29, 2014 at 10:06:31PM +0200, Natanael Copa wrote:
> On Tue, 29 Apr 2014 09:02:13 -0600
> Eric Blake wrote:
>
> > On 04/29/2014 08:53 AM, Natanael Copa wrote:
> > > On Tue, 29 Apr 2014 08:28:29 -0600
> > > Eric Blake wrote:
> > >
> > >> On 04/29/2014 08:17 AM, Natanael Copa wrote:
>
: Natanael Copa
Signed-off-by: Riku Voipio
Reviewed-by: Peter Maydell
---
linux-user/syscall.c | 2 +-
linux-user/syscall_defs.h | 16 +++-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 15de6f8..af0bb35 100644
--- a
From: Maxim Ostapenko
QEMU already supports /proc/self/{maps,stat,auxv} so addition of
/proc/self/exe is rather trivial.
Fixes https://bugs.launchpad.net/qemu/+bug/1299190
Signed-off-by: Maxim Ostapenko
Reviewed-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 5
From: Huw Davies
This makes adding more message types cleaner.
Signed-off-by: Huw Davies
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 51 +--
1 file changed, 33 insertions(+), 18 deletions(-)
diff --git a/linux-user/syscall.c b/linux
From: Peter Maydell
The ARM kernel has chosen to spill into the HWCAP2 ELF feature bit flags
early, even though it hasn't yet exhausted all 32 bits of the HWCAP word.
Add support for setting this in the same way we do for HWCAP.
Signed-off-by: Peter Maydell
Signed-off-by: Riku V
, defining
TARGET_NR__llseek as TARGET_NR_llseek.
Signed-off-by: James Hogan
Cc: Riku Voipio
Cc: Jia Liu
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 27073b1..15de6f8 100644
--- a
From: Riku Voipio
To move more uname related functions out of syscall.c,
rename cpu-uname.{c,h} to uname.{c.h}
Signed-off-by: Riku Voipio
---
linux-user/Makefile.objs | 2 +-
linux-user/cpu-uname.c | 72
linux-user/cpu-uname.h | 1
From: Peter Maydell
Set the fault address correctly in the signal information passed
to a signal handler for AArch64 guests.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/linux-user
From: Riku Voipio
--enable-uname-release was a rather heavyweight hammer, as it allows
providing values less that UNAME_MINIMUM_RELEASE. Also, it affects
all built linux-user targets, which in most cases is not what user
wants.
Now that we have UNAME_MINIMUM_RELEASE for all linux-user platforms
From: Riku Voipio
Make syscall.c slightly smaller by moving uname-related
functions to uname.c.
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 102 ---
linux-user/uname.c | 101 ++
linux
From: Huw Davies
Signed-off-by: Huw Davies
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 52bd000..27073b1 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
From: Riku Voipio
The following changes since commit fdaad4715ae9e998fd0595bedfb16fdaf0c68ccc:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140501'
into staging (2014-05-02 11:32:00 +0100)
are available in the git repository at:
http://git.linaro.org/
. Fix this by properly separating the 64 and 32 bit code,
since they have more differences than similarities.
Signed-off-by: Peter Maydell
Cc: qemu-sta...@nongnu.org
Signed-off-by: Riku Voipio
---
linux-user/elfload.c | 86
1 file changed, 73
ter Maydell
Cc: qemu-sta...@nongnu.org
Signed-off-by: Riku Voipio
---
linux-user/elfload.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 18ea1b3..d372300 100644
--- a/linux-user/elfload.c
+++ b/linux
From: James Hogan
Assert that the amount of stack space used for auxvec, envp & argv
exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
updated when another NEW_AUX_ENT is added.
Signed-off-by: James Hogan
Cc: Riku Voipio
Cc: Peter Maydell
Signed-off-by: Ri
that weird hardware,
so it's otherwise uninteresting to us.)
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/elfload.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elflo
Hi,
Thanks, looks good and fixes getrusage02 ltp test.
Added to the linux-user que:
https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream
Peter, do you prefer a new pull request for linux-user with this patch
added on top, or is pulling the updated branc
From: Riku Voipio
The following changes since commit fdaad4715ae9e998fd0595bedfb16fdaf0c68ccc:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140501'
into staging (2014-05-02 11:32:00 +0100)
are available in the git repository at:
http://git.linaro.org/
On 5 May 2014 16:02, Peter Maydell wrote:
> On 5 May 2014 13:34, wrote:
> > From: Riku Voipio
> >
> > The following changes since commit
> fdaad4715ae9e998fd0595bedfb16fdaf0c68ccc:
> >
> > Merge remote-tracking branch
> 'remotes/pmaydell/tags/pul
On 4 March 2014 13:41, Peter Maydell wrote:
> On 4 March 2014 11:32, Alex Bennée wrote:
> > Is the effect of this to report system uname or minimum whichever is
higher?
>
> That's what this patch does. The old configure stuff which
> this patchset removed made it report "always that version",
> I
On 7 March 2014 10:45, Peter Maydell wrote:
>> On 7 March 2014 02:19, Riku Voipio wrote:
> > So you agree these patches are the way to go?
> I haven't actually reviewed them but I think the idea is right,
> yes.
With the hard freeze getting close, and me being away u
From: Andreas Schwab
The AArch64 kernel defines its __kernel_uid_t type as 32 bits, unlike
32 bit ARM, so don't enable our 16-bit UID wrapper handling.
Signed-off-by: Andreas Schwab
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
Reviewed-by: Richard Henderson
---
linux
From: Michael Matz
Implement support for signal handlers with the SA_RESTORER
flag set.
Signed-off-by: Michael Matz
[PMM: minor tweaks to make patch apply to current master]
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
Reviewed-by: Richard Henderson
---
linux-user/signal.c | 16
From: Peter Maydell
Fix the loop restoring the FP registers from the signal frame to match
the one used when setting up the signal frame, so that it handles
TARGET_WORDS_BIGENDIAN being set.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
Reviewed-by: Richard Henderson
---
linux
From: Petar Jovanovic
On success, sigtimedwait() returns a signal number that needs to be
translated from a host value to a target value.
This change also fixes issues with sigwait (that is implemented using
sigtimedwait()).
Signed-off-by: Petar Jovanovic
Signed-off-by: Riku Voipio
Reviewed
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
Reviewed-by: Andreas Färber
Reviewed-by: Richard Henderson
---
linux-user/syscall.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 1407b7a..ccdbc4e
From: Riku Voipio
Popular glibc based distributions[1] require minimum
2.6.32 as kernel version. For some targets 2.6.18
would be enough, but dropping so low would mean some
suboptimal system calls could get used.
Set the minimum kernel advertized to 2.6.32 for
all architectures but aarch64 to
From: Petar Jovanovic
Exception with break instruction has not been correctly propagated as
SIGTRAP. This resolves crash issues with examples that use break
instruction on MIPS.
Signed-off-by: Petar Jovanovic
Signed-off-by: Riku Voipio
---
linux-user/main.c | 4
1 file changed, 4
cking operations);
cap the vector length as the kernel implementation does;
don't lock guest memory twice;
support MSG_WAITFORONE flag]
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
Reviewed-by: Richard Henderson
---
linux-user/syscall.c
From: Riku Voipio
The following changes since commit d844a7b6569fb2b5252773444b18841426e5b906:
modules: Fix building with --enable-modules (2014-02-28 12:30:13 +)
are available in the git repository at:
git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream
for you
On Mon, Mar 10, 2014 at 12:59:17PM +, Peter Maydell wrote:
> AArch64 Linux, unlike AArch32, doesn't use a commpage. This means we
> should not be reserving room in the guest address space for one.
> Fixes LP:1287195.
Looks good,
Reviewed-by: Riku Voipio
> Reported-by:
On Thu, Mar 13, 2014 at 08:19:48PM -0700, Anthony Liguori wrote:
> Please add entries to the ChangeLog for the 2.0 release below:
> http://wiki.qemu.org/ChangeLog/Next
I could do some updates for linux-user - but how does one get an account to
edit on wiki.l.o ?
Riku
On Fri, Mar 14, 2014 at 06:10:50PM +, Peter Maydell wrote:
> Implement the capget and capset syscalls. This is useful because
> simple programs like 'ls' try to use it in AArch64
I'm not seing this with ubuntu trusty, wookeys debian or my
static busybox. Where is your ls from? Also, runnning q
From: Riku Voipio
some people get numerous unimplemented capget/capset warnings. Since qemu
linux-user is not secure to begin with, just skip the system call
warning for now. Proper capset/capget to be added in Qemu 2.1
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 4 ++--
1 file
On Mon, Mar 17, 2014 at 12:15:35PM +, Peter Maydell wrote:
> Implement the capget and capset syscalls. This is useful because
> simple programs like 'ls' try to use it in AArch64, and otherwise
> we emit a lot of noise about it being unimplemented.
> Signed-off-by: Peter Maydell
> ---
> Chan
On 17 March 2014 22:17, Andreas Färber wrote:
> Am 17.03.2014 12:55, schrieb riku.voi...@linaro.org:
> > From: Riku Voipio
> >
> > some people get numerous unimplemented capget/capset warnings. Since qemu
> > linux-user is not secure to begin with, just skip the syst
-provided signal masks.]
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/qemu.h| 1 +
linux-user/signal.c | 58 ++--
linux-user/syscall.c | 14 ++---
3 files changed, 42 insertions(+), 31 deletions(-)
diff --git a/linux
From: Riku Voipio
The following changes since commit 6fffa26244737f8fd8641a21fee29bd6aa9fdff5:
Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-03-15'
into staging (2014-03-15 18:22:11 +)
are available in the git repository at:
git://git.linaro.
From: Peter Maydell
AArch64 Linux, unlike AArch32, doesn't use a commpage. This means we
should not be reserving room in the guest address space for one.
Fixes LP:1287195.
Reported-by: Amanieu d'Antras
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/elf
ch is based on an idea by Alex Barcelo, but rather than
simply lying to the guest about the SIGSEGV state we track it.
Signed-off-by: Peter Maydell
Reported-by: Alex Barcelo
Signed-off-by: Riku Voipio
---
linux-user/qemu.h | 1 +
linux-user/signal.c
From: Peter Maydell
Implement the capget and capset syscalls. This is useful because
simple programs like 'ls' try to use it in AArch64, and otherwise
we emit a lot of noise about it being unimplemented.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user
nothing).
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 24c91f3..209855e 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -1340,7 +1340,7
From: Andreas Schwab
F_GETOWN is replaced by F_GETOWN_EX inside the glibc fcntl wrapper
Signed-off-by: Andreas Schwab
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 36
linux-user/syscall_defs.h | 7 +++
2 files changed, 43 insertions
From: Peter Maydell
QEMU's implementation of the m68k atomic_barrier syscall, like the kernel's,
is just a no-op. However we still need to return a result code from it.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 1 +
1 file changed, 1
From: Peter Maydell
The aCC array in fpopcode.c is completely unused in QEMU; delete
it (silencing a clang warning).
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/arm/nwfpe/fpopcode.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/linux
From: Alex Suykov
When passing ancillary data through a unix socket, handle
credentials properly instead of doing a simple copy and
issuing a warning.
Signed-off-by: Alex Suykov
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 18 ++
1 file changed, 14 insertions(+), 4
chard Henderson
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/alpha/syscall_nr.h | 4
1 file changed, 4 insertions(+)
diff --git a/linux-user/alpha/syscall_nr.h b/linux-user/alpha/syscall_nr.h
index 625f301..dde8d5c 100644
--- a/linux-user/alpha/syscall_nr.h
+++ b/l
From: Ed Swierk
Without this fix, qemu segfaults when emulating the sigaltstack syscall,
because it incorrectly treats the ss_flags field as 64 bits rather than 32
bits.
Signed-off-by: Ed Swierk
Signed-off-by: Riku Voipio
---
linux-user/mips64/target_signal.h | 2 +-
1 file changed, 1
mains will be better served by adding the correct
code from scratch based on the kernel sources at that time.
This change also fixes some clang warnings about the function being
defined but not used for some target architectures.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linu
e intended retaddr+0,retaddr+2, resulting in a guest crash when
it tried to execute the invalid zero-bytes at retaddr+0.
Fix by using uint32_t instead; also use uint16_t rather than short
for consistency. This fixes bug LP:1404690.
Reported-by: Michel Boaventura
Signed-off-by: Peter Maydell
Signed-of
ned-off-by: Riku Voipio
---
linux-user/main.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/linux-user/main.c b/linux-user/main.c
index 8c70be4..95e8a51 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -283,7 +283,9 @@ void cpu_loop(CPUX86State *env)
target_sigi
From: Riku Voipio
The following changes since commit b00c92e3ef59b78f6029d66353aaf995ceaa6605:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2015-01-27 13:17:30 +)
are available in the git repository at:
git://git.linaro.org/people/riku.voipi
, causing the comparison
to fail and resulting in lots of spurious "Unsupported ioctl" errors.
Changing the target_cmd field in the ioctl_entries list to a signed int
causes those values to be sign-extended as well during the comparison.
Signed-off-by: Ed Swierk
Signed-off-by: Riku Voipio
From: Peter Maydell
The function end_exclusive() isn't used on all targets; mark it as
such to avoid a clang warning.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/
configs.
Signed-off-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index fa955ef..8065710 100644
--- a/linux-user/signal.c
+++ b
From: Felix Janda
The resource argument is translated from host to target for
[gs]etprlimit but not for prlimit64. Fix this.
Signed-off-by: Felix Janda
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linux-user
Hi,
First of all, thanks Chen for taking time to improve the linux-user
codebase in qemu!
On Mon, Jan 26, 2015 at 03:01:52PM +, Peter Maydell wrote:
> On 26 January 2015 at 14:59, Chen Gang S wrote:
> > On 1/26/15 06:10, Peter Maydell wrote:
> >> I would just like the commit message to be cl
On Monday, March 23, 2015 3:02:29 PM EET, Andreas Färber wrote:
Am 23.03.2015 um 13:55 schrieb Leon Alrae:
New threads always point at the same env which is incorrect
and usually leads
to a crash.
Signed-off-by: Leon Alrae
---
Hi, ...
Clearly my fault and might explain some breakage in our
t_timer_id typedef that is s32, just like Linux has it. It also changes the
magic offset to a value that makes all timer ids be positive.
Reported-by: Tom Musta
Signed-off-by: Alexander Graf
Reviewed-by: Peter Maydell
Reviewed-by: Tom Musta
Tested-by: Tom Musta
Signed-off-by: Riku Voipio
---
RM 64 bit cmpxchg kernel helper".
Signed-off-by: Chen Gang
Signed-off-by: Riku Voipio
---
linux-user/main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 6e446de..31eb60f 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -525,8 +525
From: Riku Voipio
The following changes since commit 3c6c9fe034c0c07b77f272e4a53d7735220a16a4:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into
staging (2015-03-20 12:26:09 +)
are available in the git repository at:
git://git.linaro.org/people/r
From: Andreas Schwab
The second and fourth argument are in/out parameters, store them back
after the syscall. Also, the fourth argument was mishandled, and EFAULT
handling was missing.
Signed-off-by: Andreas Schwab
Reviewed-by: Peter Maydell
Signed-off-by: Riku Voipio
---
linux-user
From: Tom Musta
When computing the upper address of a program segment, do not subtract the
offset from the virtual address; instead compute the sum of the virtual address
and the memory size.
Signed-off-by: Tom Musta
Signed-off-by: Riku Voipio
---
linux-user/elfload.c | 2 +-
1 file changed
From: Leon Alrae
New threads always point at the same env which is incorrect and usually
leads to a crash.
Signed-off-by: Leon Alrae
Reviewed-by: Andreas Färber
Signed-off-by: Riku Voipio
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user
Hi,
Sorry for these two patches, please ignore.
Riku
Hi,
On Tue, Jan 20, 2015 at 02:54:20PM +, Peter Maydell wrote:
> Ping!
I've just updated my linux-user-for-upstream tree. I'll get it
reviewed/tested tonight.
> thanks
> -- PMM
>
> On 8 January 2015 at 12:19, Peter Maydell wrote:
> > This patchset fixes warnings produced by clang in the li
On Thu, Nov 06, 2014 at 01:43:13PM -0600, Tom Musta wrote:
> When computing the upper address of a program segment, do not subtract the
> offset from the virtual address; instead compute the sum of the virtual
> address
> and the memory size.
Thanks, I'll test this and try to get it applied ASAP.
From: Tom Musta
When computing the upper address of a program segment, do not subtract the
offset from the virtual address; instead compute the sum of the virtual address
and the memory size.
Signed-off-by: Tom Musta
Signed-off-by: Riku Voipio
---
linux-user/elfload.c | 2 +-
1 file changed
From: Riku Voipio
The following changes since commit 558c2c8ddfb165a36eb95dc93125c04829d68aa7:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2014-11-10 16:28:51 +)
are available in the git repository at:
git://git.linaro.org/people/riku.voipi
t_timer_id typedef that is s32, just like Linux has it. It also changes the
magic offset to a value that makes all timer ids be positive.
Reported-by: Tom Musta
Signed-off-by: Alexander Graf
Reviewed-by: Peter Maydell
Reviewed-by: Tom Musta
Tested-by: Tom Musta
Signed-off-by: Riku Voipio
---
Hi,
On Tue, Jun 03, 2014 at 03:07:59PM +0100, Peter Maydell wrote:
> Ping!
Looks good, I'll collect this and other linux-user patches and submit
linux-user update
by tomorrow.
Riku
> thanks
> -- PMM
>
> On 10 May 2014 12:25, Peter Maydell wrote:
> > We were returning the incorrect uname stri
Hi,
On Wed, Jun 04, 2014 at 09:49:00AM +0200, Natanael Copa wrote:
> The __SIGRTMIN and __SIGRTMAX are glibc internals and are not available
> on all platforms, so we define those if they are missing. We also check
> that those corresponds with the posix variables SIGRTMIN/SIGRTMAX which
> may onl
On Thu, Jun 05, 2014 at 02:21:42PM +0100, Peter Maydell wrote:
> On 5 June 2014 14:11, Riku Voipio wrote:
> > Hi,
> >
> > On Tue, Jun 03, 2014 at 03:07:59PM +0100, Peter Maydell wrote:
> >> Ping!
> >
> > Looks good, I'll collect this and other linux
From: Riku Voipio
Make all implementations of setup_sigcontext void and
remove checking it's return value from functions calling
setup_sigcontext.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 65 +
1 file changed, 21 inser
From: Riku Voipio
As __get_user and __put_user do not return errors, remove the
if checks from around them. This allows making the save/restore
functions void.
Signed-off-by: Riku Voipio
Cc: Alexander Graf
---
linux-user/signal.c | 126 +---
1
From: Riku Voipio
Remove "if(__get_user" checks and their related error paths
for all architecture's do_sigreturn. Remove the unlock_user_struct
when the only way to end up there is from failed lock_user_struct.
Signed-off-by: Riku Voipio
---
linux-use
From: Riku Voipio
make most implementations of restore_sigcontext void and
remove checking it's return value from functions calling
restore_sigcontext.
The exception is the X86 version of the function that is
too different from others to deal in this way.
Signed-off-by: Riku Voipio
---
From: Riku Voipio
Remove all the simple cases of reading the return value
of __get_user and __put_user.
We set err = 0 in sparc versions of do_sigreturn and
sparc64_set_context to avoid compile error, but else this patch is
just general removal of err |= __get_user ... idiom.
Signed-off-by
From: Riku Voipio
Remove "if(__put_user" checks and their related error paths
for all architecture's setup_frame, setup_rt_frame and similar.
Remove the unlock_user_struct when the only way to end up there is
from failed lock_user_struct.
Remove err variable if there are no user
From: Riku Voipio
Remove the remaining check for __put_user return
value, and all the checks for err variable which
isn't set anywhere anymore.
No we can only end up in give_sigsegv due to failed
lock_user_struct - thus we remove the unlock_user_struct
to avoid unlocking a region never l
From: Riku Voipio
gcc-4.9 finds unused operand:
linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression
has no effect [-Werror=unused-value]
((hptr), (x)), 0)
Just removing the rh operand is no good, it will error
From: Riku Voipio
Since copy_siginfo_to_user always returns 0, make it void
and remove any checks for return value from calling functions.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 28 +---
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/linux
From: Riku Voipio
A function never called from anywhere, obviously half-complete.
Remove function and if someone wants to complete this, please
check the old version out of git history.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 37 -
1 file
From: Riku Voipio
This series is a cleanup and gcc-4.9 buildfix:
linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression has no
effect [-Werror=unused-value]
((hptr), (x)), 0)
removing the unused 0 moves the bar
From: Riku Voipio
Access is already checked in the lock_user_struct
call before.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 91fd27f..56d6e29 100644
--- a/linux
From: Riku Voipio
The last remaining check for return value of __get_user.
Signed-off-by: Riku Voipio
Cc: Alexander Graf
---
linux-user/signal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 29d87f9..e47db2c 100644
--- a
From: Riku Voipio
Remove checks of __get_user and the err variable
used to control flow with it.
Signed-off-by: Riku Voipio
---
linux-user/signal.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 052c03a..29d87f9
501 - 600 of 1342 matches
Mail list logo
