Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-15 Thread Michael S. Tsirkin
On Mon, Apr 15, 2024 at 05:11:05PM +0800, Cindy Lu wrote: > On Mon, Apr 15, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > > > On Fri, Apr 12, 2024 at 02:26:55PM +0800, Cindy Lu wrote: > > > During the booting process of the non-standard image, the behavior of the > > > called function in qemu is

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-15 Thread Cindy Lu
On Mon, Apr 15, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > On Fri, Apr 12, 2024 at 02:26:55PM +0800, Cindy Lu wrote: > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net_stop() was triggered by guest

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-15 Thread Michael S. Tsirkin
On Fri, Apr 12, 2024 at 02:26:55PM +0800, Cindy Lu wrote: > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function > virtio_pci_set_guest_notifiers() with

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-15 Thread Jason Wang
On Fri, Apr 12, 2024 at 2:28 PM Cindy Lu wrote: > > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function > virtio_pci_set_guest_notifiers() with assgin=

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-14 Thread Lei Yang
QE tested this patch with regression tests, everything works fine. Tested-by: Lei Yang On Fri, Apr 12, 2024 at 2:37 PM Cindy Lu wrote: > > Hi All > I apologize for bothering you again > I send the new patch is because I found that the function >

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-12 Thread Cindy Lu
Hi All I apologize for bothering you again I send the new patch is because I found that the function kvm_virtio_pci_vector_use_one/kvm_virtio_pci_vector_release_one can only change the vector that already set to the device. ret = virtio_pci_get_notifier(proxy, queue_no, , ); if (ret < 0)

[PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-12 Thread Cindy Lu
During the booting process of the non-standard image, the behavior of the called function in qemu is as follows: 1. vhost_net_stop() was triggered by guest image. This will call the function virtio_pci_set_guest_notifiers() with assgin= false, virtio_pci_set_guest_notifiers() will release the