Re: [Qgis-developer] Feature fix #4273 and possibly #3756 (qgsdecorationitem)

2015-12-30 Thread Duncan
Morning, I've put the changes together for these features. This is my first contribution, so I wondered if I could check that I'm making the pull request properly. Hopefully make it a bit easier for whoever deals with it. I ran the changes through prepare-commit.sh which fixed a few formattin

Re: [Qgis-developer] Feature fix #4273 and possibly #3756 (qgsdecorationitem)

2015-12-30 Thread Nyall Dawson
On 30 Dec 2015 8:08 PM, "Duncan" wrote: > > Morning, > > I've put the changes together for these features. This is my first > contribution, so I wondered if I could check that I'm making the pull request > properly. Hopefully make it a bit easier for whoever deals with it. Sounds great - and mu

Re: [Qgis-developer] Feature fix #4273 and possibly #3756 (qgsdecorationitem)

2015-12-30 Thread Médéric RIBREUX
Hello, On Wed, Dec 30, 2015 at 09:07:59AM +, Duncan wrote: > Morning, > > I've put the changes together for these features. This is my first > contribution, so I wondered if I could check that I'm making the pull > request properly. Hopefully make it a bit easier for whoever deals with it. >

Re: [Qgis-developer] Feature fix #4273 and possibly #3756 (qgsdecorationitem)

2015-12-30 Thread Duncan
Thanks for the info Nyall. I'll get the pull request setup and see what comes back. I've had a look at the test writing guidance on the site and have a rough idea of what to do, so I'll start getting them sorted while I wait for feedback on the pull request. If I get stuck I'll let you know.

[Qgis-developer] Cross heap contamination with OSGEO4W64

2015-12-30 Thread Stuart Brittain
Hi, I am experiencing cross heap contamination with OSGEO4W64. The issue causes apps using QgsApplication to crash unless the application is built with VS 2010 in Release configuration. I have tried VS 2008, VS 2013, and VS 2010. Only Release mode in VS 2010 will run without crash. Debug mode in VS

[Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Stefan Ziegler
Hi I add a virtual field to a layer with e.g. following expression attribute(get_feature('pnf_pnf','t_id',afrom),'year') This works really great. Then I'm using this new virtual field for filtering the features in the rule based renderer. How does affect this the rendering performance? It seems

Re: [Qgis-developer] Feature fix #4273 and possibly #3756 (qgsdecorationitem)

2015-12-30 Thread Duncan
Hi Médéric, Sorry, I saw Nyall's reply and somehow missed yours. The pull request is in...and passed the CI which is nice. I've attached a screen shot of the UI changes. I, like you, don't think this is exactly a critical feature, but nice to have. I don't think it breaks any old projects. We

Re: [Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Nyall Dawson
On 31 Dec 2015 2:01 AM, "Stefan Ziegler" wrote: > > Hi > > I add a virtual field to a layer with e.g. following expression > > attribute(get_feature('pnf_pnf','t_id',afrom),'year') > > This works really great. Then I'm using this new virtual field for filtering the features in the rule based rende

Re: [Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Stefan Ziegler
Hi Nyall I compared 2.12 with current master. But I don't see an improvement. Opening the attribute table takes around 10 seconds for layers with approx. 2000 features with one virtual field (with the attribute(get_feature()) expression). Rendering is also really slow when using rule based rendere

Re: [Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Denis Rouzaud
Why not using joined fields ? Caching mechanism already exists there. Le mer. 30 déc. 2015 8:18 PM, Stefan Ziegler a écrit : > Hi Nyall > > I compared 2.12 with current master. But I don't see an improvement. > Opening the attribute table takes around 10 seconds for layers with approx. > 2000 fe

Re: [Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Nyall Dawson
On 31 December 2015 at 06:18, Stefan Ziegler wrote: > Hi Nyall > > I compared 2.12 with current master. But I don't see an improvement. Opening > the attribute table takes around 10 seconds for layers with approx. 2000 > features with one virtual field (with the attribute(get_feature()) > expressi

Re: [Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Stefan Ziegler
Thanks for the hint. This works perfect. But: the main idea was to avoid creating "new" fields in the layer (virtual fields or joined ones) but only using the expression for rendering. Stefan On Wed, Dec 30, 2015 at 9:02 PM, Denis Rouzaud wrote: > Why not using joined fields ? Caching mechanism

[Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread Nyall Dawson
Hi all, The email chain below is just one example of a user who has issues with QGIS after installing the OpenLayers plugin. Stackexchange is filled with similar examples (See http://gis.stackexchange.com/questions/tagged/qgis-openlayers-plugin). I'm wondering if it's time we discussed the future

Re: [Qgis-developer] Performance of QGIS expressions "attribute" and "get_feature"

2015-12-30 Thread Stefan Ziegler
Two postgres layers with an index on the fields. Do I see some debug messages (when compiled with DEBUG)? On Wed, Dec 30, 2015 at 9:27 PM, Nyall Dawson wrote: > On 31 December 2015 at 06:18, Stefan Ziegler > wrote: > > Hi Nyall > > > > I compared 2.12 with current master. But I don't see an im

Re: [Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread Tom Chadwin
I think deprecation and removal would be good, but for a tangential reason: the name conflicts with OpenLayers the web mapping library. A trivial reason at best, but probably irritating to many, and potentially confusing to users. -- View this message in context: http://osgeo-org.1560.x6.nabbl

Re: [Qgis-developer] Cross heap contamination with OSGEO4W64

2015-12-30 Thread Jürgen E . Fischer
Hi Stuart, On Wed, 30. Dec 2015 at 07:43:13 -0700, Stuart Brittain wrote: > I have tried VS 2008, VS 2013, and VS 2010. Only Release mode in VS 2010 > will run without crash. > Debug mode in VS 2010 will also crash, and the application cannot be > debugged. Use RelWithDebInfo in VS 2010 if you wa

Re: [Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread Joshua Quesenberry
If the plugin is deprecated, what is replacing it? I find the plugin to be very useful. -Original Message- From: Qgis-developer [mailto:qgis-developer-boun...@lists.osgeo.org] On Behalf Of Tom Chadwin Sent: Wednesday, December 30, 2015 5:46 PM To: qgis-developer@lists.osgeo.org Subject:

Re: [Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread Nyall Dawson
On 31 December 2015 at 13:29, Joshua Quesenberry wrote: > If the plugin is deprecated, what is replacing it? I find the plugin to be > very useful. QuickMapServices. It's got numerous improvements over OpenLayers, including reprojection support and not breaking the map composer. Nyall > > --

Re: [Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread Randal Hale
As a non-developer if I can chip in my .02 cents worth - I think deprecating it might be a good thing. To me it was always a plugin that received a lot of applause - but the one that would cause the most questions ("why can't I use this imagery in map composer"). While I liked having access to

Re: [Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread h
On Wed, 30 Dec 2015 22:42:27 -0500 Randal Hale wrote: > As a non-developer if I can chip in my .02 cents worth - I think > deprecating it might be a good thing. To me it was always a plugin > that received a lot of applause - but the one that would cause the > most questions ("why can't I use th

Re: [Qgis-developer] Future of OpenLayers plugin - time to deprecate?

2015-12-30 Thread Paolo Cavallini
Deprecating it makes sense to me, unless authors plan to fix the long standing issues. Thanks for raising this. All the best. Il 31 dicembre 2015 06:47:08 CET, h ha scritto: >On Wed, 30 Dec 2015 22:42:27 -0500 >Randal Hale wrote: > >> As a non-developer if I can chip in my .02 cents worth - I t