[QGIS-Developer] commits revert policy

2024-06-26 Thread Sandro Santilli via QGIS-Developer
I'd like to call core developers and PSC attention on commits revert policy. 3 commits of mine were reverted with this PR: https://github.com/qgis/QGIS/pull/57882 The PR was opened in my sleeptime and approved within 2 hours, so I didn't have a chance to review the PR, which I think does not

Re: [QGIS-Developer] [Qgis-psc] Request for review before new release is cut

2024-06-22 Thread Sandro Santilli via QGIS-Developer
On Sat, Jun 22, 2024 at 09:11:25AM +1000, Nyall Dawson wrote: > On Sat, 22 Jun 2024 at 06:13, Sandro Santilli via QGIS-PSC > wrote: > > On June 21, 2024 11:14:59 AM GMT+02:00, "Jürgen E. Fischer via QGIS-PSC" > > wrote: > > >On Fri, 21. Jun 2024 at 10:22:14 +0200, Sandro Santilli wrote: > > >>

Re: [QGIS-Developer] [Qgis-psc] Request for review before new release is cut

2024-06-21 Thread Sandro Santilli via QGIS-Developer
On June 21, 2024 11:14:59 AM GMT+02:00, "Jürgen E. Fischer via QGIS-PSC" wrote: >On Fri, 21. Jun 2024 at 10:22:14 +0200, Sandro Santilli wrote: >> It's packaging time today but I still have 5 pull requests pending approval >> reviews: >> >> https://github.com/qgis/QGIS/pulls/strk > >As

[QGIS-Developer] Request for review before new release is cut

2024-06-21 Thread Sandro Santilli via QGIS-Developer
It's packaging time today but I still have 5 pull requests pending approval reviews: https://github.com/qgis/QGIS/pulls/strk It is the well-known problem of the current review policy blocking changeflow. One of them was reviewed and approved by Benoit who was the last one touching the file

Re: [QGIS-Developer] Is it allowed to sell data in a QGIS plugin?

2024-06-12 Thread Sandro Santilli via QGIS-Developer
On Tue, Jun 11, 2024 at 09:56:15AM +0200, Alessandro Pasotti via QGIS-Developer wrote: > On Tue, Jun 11, 2024 at 9:44 AM Christopher Frank via QGIS-Developer < > qgis-developer@lists.osgeo.org> wrote: > > > We would like to implement in the plugin the whole order process, open > > source of

Re: [QGIS-Developer] debug messages not coming out, why ?

2024-05-28 Thread Sandro Santilli via QGIS-Developer
On Tue, May 28, 2024 at 05:59:28PM +0200, Richard Duivenvoorde via QGIS-Developer wrote: > running ccmake with -DCMAKE_BUILD_TYPE=Debug and then running form the build > dir still gives me debug messages Uh! I didn't expect "DEBUG" != "Debug" but that was exactly the problem. Thanks! > Other

[QGIS-Developer] debug messages not coming out, why ?

2024-05-28 Thread Sandro Santilli via QGIS-Developer
I'm running cmake with -D CMAKE_BUILD_TYPE=DEBUG but I don't see any debug message printed on the console when starting qgis from build dir, what am I missing ? The INSTALL.md file says something about debugging but seems to be only about the server ? ## 6.5. Debugging ```bash sudo

[QGIS-Developer] github label descriptions

2024-05-03 Thread Sandro Santilli via QGIS-Developer
I've been wondering which label to add to a PR to have it automatically backported and noticed that the labels like "backport release-3_34" and "backport release-3_36" do not have a description. Could someone with powers add such description to make it easier to tell if that's what you need to add

Re: [QGIS-Developer] [Qgis-user] Announce - migrate our mailing lists to Discourse

2024-04-05 Thread Sandro Santilli via QGIS-Developer
On Thu, Apr 04, 2024 at 05:58:32PM +0200, Marco Bernasocchi via QGIS-Developer wrote: > Seems fixed :) > https://trac.osgeo.org/osgeo/ticket/3073#comment:19 That's actually more of a workaround than a fix. Discourse still ruins the body of email text/plain email messages. Even those sent for

Re: [QGIS-Developer] Announce - migrate our mailing lists to Discourse

2024-04-03 Thread Sandro Santilli via QGIS-Developer
[kept only on qgis-developer] On Wed, Apr 03, 2024 at 09:14:47PM +0200, Régis Haubourg via QGIS-Developer wrote: > - I just don't see any usage difference once I changed my settings from the > default digest setting to "one mail per interaction" I do: - Lack of real sender email:

Re: [QGIS-Developer] Official PSC call on pull request policies

2024-02-27 Thread Sandro Santilli via QGIS-Developer
Thanks Nyall for raising this thread! On Mon, Feb 26, 2024 at 09:21:05AM +1000, Nyall Dawson wrote: > Policy #1: https://github.com/qgis/QGIS/pull/56062 > > In short, Sandro proposes that the pull request queue be an open queue > of ALL work happening everywhere, in any state of completeness.

[QGIS-Developer] /usr/bin/ld: cannot find -lprovider_virtuallayer_a: No such file or directory

2024-02-20 Thread Sandro Santilli via QGIS-Developer
Does this error on QGIS building ring any bell ? /usr/bin/ld: cannot find -lprovider_virtuallayer_a: No such file or directory I'm configuring the build with: -DWITH_PDAL=no -DWITH_SPATIALITE=no And the above error results from that. Is it a bug in the build script ? --strk;

Re: [QGIS-Developer] QGIS-Website write permissions

2024-01-31 Thread Sandro Santilli via QGIS-Developer
On Thu, Jan 25, 2024 at 11:39:54AM +0100, Richard Duivenvoorde via QGIS-Developer wrote: > Looking at the last 10 merged PR's I can see at least 5 people > apparently able to merge: > > Marco, Andreas, Juergen, Andrea, Harrisou and myself I think the need to "guess" isn't the most transparent

[QGIS-Developer] QGIS-Website write permissions

2024-01-25 Thread Sandro Santilli via QGIS-Developer
I've noticed a change request I submitted for the QGIS Website [1] has gone unnoticed for 1 week now and thus I wondered what's the contribution policy is for that repo and didn't find an answer in the top-level README.md file [2]. I went looking for other PRs and found one by Harrissou Sant-anna

Re: [QGIS-Developer] Adding a "solution proposed" label?

2024-01-18 Thread Sandro Santilli via QGIS-Developer
On Wed, Jan 17, 2024 at 08:57:33AM -0500, Greg Troxel via QGIS-Developer wrote: > So I would say: > > Establish a policy that questions are not allowed in the issue > tracker. Follow it strictly. +1 and there's now an experimental Discourse service of OSGeo that could be used for

Re: [QGIS-Developer] Running unit tests without "make install"

2024-01-16 Thread Sandro Santilli via QGIS-Developer
On Mon, Jan 15, 2024 at 10:28:19PM +0100, Thomas Larsen Wessel via QGIS-Developer wrote: > Thanks for having a look at it :) I ran a complete test and saved the test > output to this gist. Is that what you were looking for? Please tell me what > other info you need. > >

Re: [QGIS-Developer] [Qgis-psc] Regular paid positions for PR reviews

2024-01-03 Thread Sandro Santilli via QGIS-Developer
On Fri, Dec 08, 2023 at 09:35:32AM +0100, Alessandro Pasotti via QGIS-PSC wrote: > On Fri, Dec 8, 2023 at 9:22 AM Andreas Neumann wrote: > > Another idea is to merge the budgets for bug fixing and code reviewing > > No, I would say we keep it separate, I agree that during the > bug-fixing time

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2024-01-03 Thread Sandro Santilli via QGIS-Developer
On Mon, Nov 27, 2023 at 05:09:07PM +1000, Nyall Dawson via QGIS-PSC wrote: > On Mon, 27 Nov 2023, 4:56 pm Alessandro Pasotti, wrote: > > > https://github.com/qgis/QGIS/pull/55417#issuecomment-1826995755 > > comment the instructions say: > > > > "The full test report (included comparison of

Re: [QGIS-Developer] QGIS repository management

2023-10-17 Thread Sandro Santilli via QGIS-Developer
On Wed, Oct 18, 2023 at 08:18:46AM +1300, Nyall Dawson via QGIS-Developer wrote: > > > > IMHO, the main issue here is that the CI is too often broken for no > > reasons related to the PR content. And most of the time recently, it's > > because of one of the mingw jobs. > > I suggest we move this

Re: [QGIS-Developer] QGIS repository management

2023-10-17 Thread Sandro Santilli via QGIS-Developer
On Tue, Oct 17, 2023 at 03:08:34PM +1300, Nyall Dawson via QGIS-Developer wrote: > On Tue, 17 Oct 2023 at 03:41, Sandro Santilli wrote: > > > > On Mon, Oct 16, 2023 at 09:59:35AM +1300, Nyall Dawson via QGIS-Developer > > wrote: > > > > > If you flip the situation, you'll see that yes, you do

Re: [QGIS-Developer] QGIS repository management

2023-10-16 Thread Sandro Santilli via QGIS-Developer
On Mon, Oct 16, 2023 at 04:41:42PM +0200, Sandro Santilli via QGIS-Developer wrote: > On Mon, Oct 16, 2023 at 09:59:35AM +1300, Nyall Dawson via QGIS-Developer > wrote: > > > If you flip the situation, you'll see that yes, you do have trust! > > > > - a compl

Re: [QGIS-Developer] QGIS repository management

2023-10-16 Thread Sandro Santilli via QGIS-Developer
On Mon, Oct 16, 2023 at 09:59:35AM +1300, Nyall Dawson via QGIS-Developer wrote: > If you flip the situation, you'll see that yes, you do have trust! > > - a complete stranger CANNOT approve their own changes > - a complete stranger CANNOT approve other stranger's changes > - a complete stranger

Re: [QGIS-Developer] QGIS repository management

2023-10-15 Thread Sandro Santilli via QGIS-Developer
On Mon, Oct 16, 2023 at 09:04:38AM +1300, Nyall Dawson wrote: > I have this power too -- and I use it on a daily basis to keep the whole CI > setup flowing (ie restarting workflows in other's PRs, merging approved PRs > when an unrelated workflow failure has blocked a merge, etc). > > I'd like

Re: [QGIS-Developer] QGIS repository management

2023-10-15 Thread Sandro Santilli via QGIS-Developer
On Mon, Oct 16, 2023 at 08:58:30AM +1300, Nyall Dawson wrote: > On Sat, 14 Oct 2023 at 05:43, Sandro Santilli wrote: > > > 2. Allow those with "write access" to self-approve PRs > > -1. What's the real motivation here? Why the urgency to get unreviewed code > into QGIS? A recent example of

Re: [QGIS-Developer] QGIS repository management

2023-10-14 Thread Sandro Santilli via QGIS-Developer
Hi Alessandro, replies inline On Sat, Oct 14, 2023 at 11:17:27AM +0200, Alessandro Pasotti wrote: > I understand your frustration, CI is often failing for no reason and > we are wasting a lot of time (and CPU power) to re-run the failing > workflows, any effort to fix these issues is greatly

[QGIS-Developer] QGIS repository management

2023-10-13 Thread Sandro Santilli via QGIS-Developer
Hello all, today I was finally able to more clearly see the problem that frustrates me everytime a take part to a new QGIS bugfixing drive, and I would like to share it hoping to find a solution togheter. The main problem: - Despite having been granted write access to the QGIS repository in

[QGIS-Developer] Merging MinGW CI workflows ?

2023-10-13 Thread Sandro Santilli via QGIS-Developer
As I got failure in a MingW workflow [1] and could not figure out what the problem was due to the huge size of CI step logs, I'm trying to find a way to reduce that log size and stumbled upon the fact that two different windows-related workflows are using two different approaches: -

Re: [QGIS-Developer] Clang-Tidy failing by not finding qgis_test.h

2023-02-17 Thread Sandro Santilli via QGIS-Developer
On Fri, Feb 17, 2023 at 04:46:03PM +0100, Julien Cabieces via QGIS-Developer wrote: > At the end of the failing job, you have the following instructions > > To reproduce locally: > - launch cmake with option -DCMAKE_EXPORT_COMPILE_COMMANDS=ON > - update build by calling Ninja > - launch

[QGIS-Developer] Clang-Tidy failing by not finding qgis_test.h

2023-02-17 Thread Sandro Santilli via QGIS-Developer
Upon adding a macro to src/test/qgstest.h the "clang-tidy" github workflow started failing by not finding "qgis_test.h" which is a generated header file. The last change in src/test/qgstest.h was committed in August 2022 while the "clang-tidy" github workfow entered the codebase in September

Re: [QGIS-Developer] [solved] weird RuntimeError: qgis._gui cannot import type '����' from PytQT5.QtCore"

2023-02-07 Thread Sandro Santilli via QGIS-Developer
On Mon, Jan 30, 2023 at 03:45:17PM +0100, Even Rouault via QGIS-Developer wrote: > RuntimeError: qgis._gui cannot import type '' from PyQt5.QtCore > > Then the fix is to install python3-pyqt5.qtmultimedia Thanks Even, thanks Alessandro who hinted you and thanks Hannes who hinted me about

[QGIS-Developer] Speedup of PostGIS Topology layers loading

2023-01-24 Thread Sandro Santilli via QGIS-Developer
Hi all, I'd like to bring to your attention a pull request I created that allows making effective use of spatial indexes when showing PostGIS Topology layers in a QGIS map: https://github.com/qgis/QGIS/pull/50906 There's no way to make use of such indexes without changing the SQL query used to

[QGIS-Developer] QgsField::displayString vs. QgsTextEditWrapper::setWidgetValue

2022-10-19 Thread Sandro Santilli via QGIS-Developer
While working on a regression with how geometry attributes are handled by the attributes editor widget I stumbled upon what looks like being an unclear responsibility as to what should convert in/out of text form various type of field values. The QgsTextEditWrapper::setWidgetValue method contains

[QGIS-Developer] how to backport ?

2022-10-17 Thread Sandro Santilli via QGIS-Developer
Is there a guide about backports handling ? Should I apply the "backport queued_ltr_backports" label and let bots handle it ? --strk; Libre GIS consultant/developer https://strk.kbt.io/services.html ___ QGIS-Developer mailing list

Re: [QGIS-Developer] Tests & Merge Request

2022-10-06 Thread Sandro Santilli via QGIS-Developer
On Sun, Sep 11, 2022 at 02:58:23PM +0100, Tim Sutton via QGIS-Developer wrote: > I believe this is normal. I believe this is NOT normal. It may be "expected" (ie: we all know about this problem), but that doesn't make it normal. Normal is for a testing framework to actually only fail if a bug is

Re: [QGIS-Developer] C++ debugging policy/strategy

2022-09-29 Thread Sandro Santilli via QGIS-Developer
On Mon, Sep 26, 2022 at 09:05:14AM +1000, Nyall Dawson wrote: > Don't push code to QGIS master which uses QgsDebugMsg() for anything > BUT reporting unanticipated errors. Shouldn't those report an error rather than a Debug ? > For all other cases you must use > QgsDebugMsgLevel( "message",

[QGIS-Developer] C++ debugging policy/strategy

2022-09-23 Thread Sandro Santilli via QGIS-Developer
I often find myself in need to place console printouts to better understand the flow of data in qgis while analizing bugs, but I never know how to implement such printouts. The attempts I usually make are: (1) qDebug() << "XXX: whatever is " << whatever; (2) std::cerr << "XXX:

Re: [QGIS-Developer] Time for db manager to become an "opt-in" plugin?

2022-09-07 Thread Sandro Santilli via QGIS-Developer
On Tue, Sep 06, 2022 at 06:15:46PM +0200, Paolo Cavallini via QGIS-Developer wrote: > I believe it is the only way to visualize topogeoms from Just a clarification: the DBManager TopoViewer does not visualize "TopoGeometry" objects (which is what I usually refer to by "topogeoms") but simple

Re: [QGIS-Developer] Time for db manager to become an "opt-in" plugin?

2022-09-07 Thread Sandro Santilli via QGIS-Developer
On Tue, Sep 06, 2022 at 05:41:34PM +0200, Julien Cabieces via QGIS-Developer wrote: > I added recently one comment in your table regarding TopoViewer because I met > somebody at Foss4G who was using it. From what I understand, it > generates several vector layers to visualise topology when

Re: [QGIS-Developer] CDash still not working

2022-06-10 Thread Sandro Santilli via QGIS-Developer
On Fri, Jun 10, 2022 at 06:30:43PM +0200, Alessandro Pasotti via QGIS-Developer wrote: > Hi, > > CDash submission from CI does work but the page shows no tests and no > failures, this makes it very hard to understand why some image_diff > tests are failing. I filed this issue yesterday:

[QGIS-Developer] printing information from tests to show in CI ?

2022-05-25 Thread Sandro Santilli via QGIS-Developer
While working on a test fixture to keep an eye on source tree modification I noticed that the test I wrote to do so is skipped. I know this happens because I made the test "skip" when `git` is not functional for some reason, but I'm not getting any message printed on CI so I can't tell exactly

Re: [QGIS-Developer] QGIS-Documentation fails to build

2022-05-19 Thread Sandro Santilli via QGIS-Developer
On Thu, May 19, 2022 at 12:09:05PM +0200, Alessandro Pasotti via QGIS-Developer wrote: > Hi, > > I cannot make promises, but if I'm allowed to spend the paid bugfixing > hours to fix this I think I could have a look. +1 to spend paid bugfixing hours on testing framework, if my vote counts

Re: [QGIS-Developer] I'm running a supported QGIS versino according to the roadmap ?

2022-05-18 Thread Sandro Santilli via QGIS-Developer
On Wed, May 18, 2022 at 06:54:49PM +0200, Jürgen E. Fischer via QGIS-Developer wrote: > Hi Sandro, > > On Wed, 18. May 2022 at 16:08:39 +0200, Sandro Santilli via QGIS-Developer > wrote: > > Reading that page I still don't undertand how to tell if what I'm > > running

Re: [QGIS-Developer] I'm running a supported QGIS versino according to the roadmap ?

2022-05-18 Thread Sandro Santilli via QGIS-Developer
On Wed, May 18, 2022 at 02:42:22PM +0200, Johannes Kröger (WhereGroup) via QGIS-Developer wrote: > Hi! > > It would be great if the link would point directly to the green and blue > lines in the table. By itself the page is completely overwhelming for normal > users. Right, that's what I'm

Re: [QGIS-Developer] I'm running a supported QGIS versino according to the roadmap ?

2022-05-18 Thread Sandro Santilli via QGIS-Developer
On Wed, May 18, 2022 at 01:26:56PM +0200, Andrea Giudiceandrea via QGIS-Developer wrote: > Il 18/05/2022 13:12, Sandro Santilli via QGIS-Developer ha scritto: > > But the question is not clear to me. Should "roadmap" be an hyperlink > > to better understand the what's

[QGIS-Developer] I'm running a supported QGIS versino according to the roadmap ?

2022-05-18 Thread Sandro Santilli via QGIS-Developer
The bug report template (.github/ISSUE_TEMPLATE/10_bug_report.yml) ask people reporting bugs to confirm this: [ ] I'm running a supported QGIS version according to the roadmap ? But the question is not clear to me. Should "roadmap" be an hyperlink to better understand the what's a supported

Re: [QGIS-Developer] Tests failing with PostgreSQL 12/PostGIS 3.0

2022-05-11 Thread Sandro Santilli via QGIS-Developer
On Tue, Sep 29, 2020 at 10:41:17AM -0300, José de Paula Rodrigues via QGIS-Developer wrote: > Hi all, > > I've tried running some test cases locally against PostgreSQL 12 and > PostGIS 3.0.0 ~ 3.0.2. These tests are consistently failing here, > whereas they run successfully on Travis. Attached