Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-22 Thread Régis Haubourg
Hey, for reference purpose, reviewing the issues there is already a feature request about action visibility here https://issues.qgis.org/issues/17581 Regards Régis 2018-02-22 0:01 GMT+01:00 Nyall Dawson : > On 22 February 2018 at 07:15, David Signer

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread Nyall Dawson
On 22 February 2018 at 07:15, David Signer wrote: > Hi Nyall > > It's okay for me, when you merge it to be save and we remove it, when the > issue is resolved. > > But I'll remove the part that the duplicate functions toggles the edit mode > anyway. > So in case there will be

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread David Signer
Hi Nyall It's okay for me, when you merge it to be save and we remove it, when the issue is resolved. But I'll remove the part that the duplicate functions toggles the edit mode anyway. So in case there will be still the action to duplicate on a not editable layer somewhere (what

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread Matthias Kuhn
Hi Dave, hi Nyall, Thanks for all your thoughts and work on this. The approach that is currently being developed sounds like a very reasonable one given the remaining time for 3.0. Another idea I had to handle things like this was an "activate condition" for actions. The activate condition for

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread Nyall Dawson
On 22 February 2018 at 00:55, David Signer wrote: > We could keep it as an Action, only enabled when the layer is editable. > This would include an attribute of MapLayerAction, if it should be enabled > only in editable mode or always (first case for the duplication-action).

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread Nyall Dawson
On 22 February 2018 at 06:20, Matthias Kuhn wrote: > On 02/21/2018 08:55 PM, Nyall Dawson wrote: >> On 22 February 2018 at 05:24, Matthias Kuhn wrote: >>> Hi Dave, hi Nyall, >>> >>> Thanks for all your thoughts and work on this. The approach that is >>>

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread Matthias Kuhn
On 02/21/2018 08:55 PM, Nyall Dawson wrote: > On 22 February 2018 at 05:24, Matthias Kuhn wrote: >> Hi Dave, hi Nyall, >> >> Thanks for all your thoughts and work on this. The approach that is >> currently being developed sounds like a very reasonable one given the >>

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread Nyall Dawson
On 22 February 2018 at 05:24, Matthias Kuhn wrote: > Hi Dave, hi Nyall, > > Thanks for all your thoughts and work on this. The approach that is > currently being developed sounds like a very reasonable one given the > remaining time for 3.0. > In the meantime, I'd like to

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-21 Thread David Signer
Hi Nyall I'll start with it today. So possibly it's done before the 23th. We could keep it as an Action, only enabled when the layer is editable. This would include an attribute of MapLayerAction, if it should be enabled only in editable mode or always (first case for the

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-20 Thread Nyall Dawson
On 19 February 2018 at 16:24, Nyall Dawson wrote: > On 15 February 2018 at 03:16, David Signer wrote: >> Dear all >> >> I agree (and I guess everyone else does), that it's not okay that this >> feature is enabled when the layers are not in editable mode.

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-18 Thread Nyall Dawson
On 15 February 2018 at 03:16, David Signer wrote: > Dear all > > I agree (and I guess everyone else does), that it's not okay that this > feature is enabled when the layers are not in editable mode. I already > started to fix that, but because of time I had to decide to finish

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-14 Thread David Signer
Dear all I agree (and I guess everyone else does), that it's not okay that this feature is enabled when the layers are not in editable mode. I already started to fix that, but because of time I had to decide to finish it next week. Anyway, there is still the question, where it should

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-14 Thread Denis Rouzaud
Le mar. 13 févr. 2018 à 23:34, Nyall Dawson a écrit : > Hi all, > > Just wanted to raise discussion about a concern I have with the new > "duplicate feature" / "duplicate feature and redigitize" actions which > have been added for 3.0. > > While I like the functionality,

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-14 Thread Régis Haubourg
Hi, I totally agree. BTW, having a generic option to display some actions only in edit mode would be a nice addition for 3.2! Regards Régis Le 14 févr. 2018 04:34, "Nyall Dawson" a écrit : Hi all, Just wanted to raise discussion about a concern I have with the new

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-13 Thread Paolo Cavallini
Agreed, thanks Nyall for raising this point. IMHO: * remove duplication, leaving it only under editing * disable it when the layer is not under editing. All the best. Il 14/02/2018 04:57, Mathieu Pellerin ha scritto: > I share those concerns too. > > The integration with parts of QGIS is

Re: [QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-13 Thread Mathieu Pellerin
I share those concerns too. The integration with parts of QGIS is sub-optimal. For e.g., the added (and always visible) menu bar in the attribute form. I'm not sure is should be there at all, and if so, certainly not when the layer's edit mode is OFF. IMHO, I'd disable/remove less-than-optimal

[QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

2018-02-13 Thread Nyall Dawson
Hi all, Just wanted to raise discussion about a concern I have with the new "duplicate feature" / "duplicate feature and redigitize" actions which have been added for 3.0. While I like the functionality, I believe we should re-think the UX of how it is exposed in the QGIS interface. Currently,