Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-20 Thread Jürgen E . Fischer
Hi Sandro, On Wed, 18. Jul 2018 at 11:41:03 +0200, Sandro Santilli wrote: > > -1 this has been standing in my way already - and it'll break the release > > process. > Could release manager(s) be given special powers to circumvent the block? Not specifically - but you can exclude admins - which

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-18 Thread Sandro Santilli
On Wed, Jul 18, 2018 at 10:11:09AM +0200, Jürgen E. Fischer wrote: > Hi Nyall, > > On Tue, 17. Jul 2018 at 15:22:16 +1000, Nyall Dawson wrote: > > I've just enabled this. Let's give it a trial run and see how it works out. > > -1 this has been standing in my way already - and it'll break the

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-18 Thread Jürgen E . Fischer
Hi Nyall, On Tue, 17. Jul 2018 at 15:22:16 +1000, Nyall Dawson wrote: > I've just enabled this. Let's give it a trial run and see how it works out. -1 this has been standing in my way already - and it'll break the release process. Jürgen -- Jürgen E. Fischer norBIT GmbH

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-16 Thread Paolo Cavallini
Great, thanks Nyall. Il 17 luglio 2018 07:22:16 CEST, Nyall Dawson ha scritto: >On Mon, 16 Jul 2018 at 19:04, Nyall Dawson >wrote: >> >> On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini >wrote: >> > >> > Hi all, >> > >> > Il 16/07/2018 00:20, Nyall Dawson ha scritto: >> > >> > > (Possibly we

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-16 Thread Nyall Dawson
On Mon, 16 Jul 2018 at 19:04, Nyall Dawson wrote: > > On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini wrote: > > > > Hi all, > > > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > > > > > (Possibly we should consider switching on github branch protection > > > here, blocking direct commits and

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-16 Thread Alessandro Pasotti
On Mon, Jul 16, 2018 at 12:20 AM, Nyall Dawson wrote: > Hi all, > > This is a gentle request to please please pay very special attention > when backporting fixes to 2.18, and assess carefully whether those > fixes are REALLY necessary in the stable LTR branch. Unfortunately the > last couple of

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-16 Thread Nathan Woodrow
+1. Stable LTR is super important On Mon, Jul 16, 2018 at 7:04 PM Nyall Dawson wrote: > On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini > wrote: > > > > Hi all, > > > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > > > > > (Possibly we should consider switching on github branch protection > >

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-16 Thread Nyall Dawson
On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini wrote: > > Hi all, > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > > > (Possibly we should consider switching on github branch protection > > here, blocking direct commits and requiring a minimum of 2 or 3 > > 'acceptable' reviews from core devs

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-16 Thread Richard Duivenvoorde
On 07/16/2018 06:52 AM, Paolo Cavallini wrote: > Hi all, > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > >> (Possibly we should consider switching on github branch protection >> here, blocking direct commits and requiring a minimum of 2 or 3 >> 'acceptable' reviews from core devs on PRs?) >

Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-15 Thread Paolo Cavallini
Hi all, Il 16/07/2018 00:20, Nyall Dawson ha scritto: > (Possibly we should consider switching on github branch protection > here, blocking direct commits and requiring a minimum of 2 or 3 > 'acceptable' reviews from core devs on PRs?) this proposal makes sense to me - do you think it is

[QGIS-Developer] Gentle request: please be careful with 2.18 backports

2018-07-15 Thread Nyall Dawson
Hi all, This is a gentle request to please please pay very special attention when backporting fixes to 2.18, and assess carefully whether those fixes are REALLY necessary in the stable LTR branch. Unfortunately the last couple of 2.18 patch releases have seen some serious regressions introduced