[QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Mathieu Pellerin
As part of the ongoing upgrade and cleanup done by the Nyall, we should take the opportunity to get rid of one of the overlapping "Zonal Statistics" and "Zonal Statistics (QGIS)" algorithms. The latter relies on QGIS' QgsZonalStatistics. Yesterday, I've resurrected the "Zonal Statistics (QGIS)" al

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Paolo Cavallini
Il 28/06/2017 04:19, Mathieu Pellerin ha scritto: > As part of the ongoing upgrade and cleanup done by the Nyall, we should > take the opportunity to get rid of one of the overlapping "Zonal > Statistics" and "Zonal Statistics (QGIS)" algorithms. The latter relies > on QGIS' QgsZonalStatistics. >

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Nyall Dawson
On 28 June 2017 at 12:19, Mathieu Pellerin wrote: > As part of the ongoing upgrade and cleanup done by the Nyall, we should take > the opportunity to get rid of one of the overlapping "Zonal Statistics" and > "Zonal Statistics (QGIS)" algorithms. The latter relies on QGIS' > QgsZonalStatistics. >

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Mathieu Pellerin
Here's a table showing the overlap (and unique features) of both algs: *QgsZonalStatistics alg* *Alternate alg* Count x x Sum x x Mean x x Median x x StDev x x Min x x Max x x Range x x Minority x Majority x Variety / Unique x x Variance (i.e. numpy.var) x Mode (I.e.scipy.stats.mode) x Two stati

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Nyall Dawson
On 28 June 2017 at 15:55, Mathieu Pellerin wrote: > > Two statistical outputs (variance and mode) aren't available in > QgsZonalStatistics-based alg, while two outputs (minority and majority) are > missing from the alternate alg. Thanks! Mode = majority here, so both algs offer this value. V

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Alexander Bruy
Hi, alternate alg was introduced in the time, when QgsZonalStatistics offered only some basic statistical information, e.g. min/max, count and couple of other values and did not allow to select individual stats. Now, when QgsZonalStatistics is much more powerful personally I (as author if this al

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-27 Thread Paolo Cavallini
Il 28 giugno 2017 08:07:12 CEST, Nyall Dawson ha scritto: >On 28 June 2017 at 15:55, Mathieu Pellerin >wrote: >> > >> Two statistical outputs (variance and mode) aren't available in >QgsZonalStatistics-based alg, while two outputs (minority and majority) >are missing from the alternate alg. > >T

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-28 Thread Nyall Dawson
On 28 June 2017 at 16:23, Paolo Cavallini wrote: > > > Fine. Could we then rename from majority to mode? More understandable IMHO. We could just rename the option as "Majority (mode)" - does that work for you? (or "Mode (majority)"). > Would it be possible to also add variance? Should be trivi

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-28 Thread Paolo Cavallini
Il 28/06/2017 09:48, Nyall Dawson ha scritto: > We could just rename the option as "Majority (mode)" - does that work > for you? (or "Mode (majority)"). fine for me; I just think mode is much more used in stats. >> Would it be possible to also add variance? > > Should be trivial to do - it's ju

Re: [QGIS-Developer] Processing 3.0: Dropping non-QgsZonalStatistics zonal statistics algorithm

2017-06-28 Thread Mathieu Pellerin
This PR (https://github.com/qgis/QGIS/pull/4792) adds variance to QgsZonalStatistics, and remove the duplicate processing zonal statistics algorithm on the basis of a general consensus in this mail tread and more importantly its author, Alexander Bruy, agreeing. Thanks for the time spent discussin