Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-08-21 Thread Patrick Valsecchi
Hi, I'll take the opportunity of being at the codesprint to try to reduce the amount of WKB usage in the code. For those being at the code sprint, don't hesitate do drop by if you have recommendations or just want to talk. CU On Tue, Jul 19, 2016 at 10:52 AM, Martin Dobias wrote: > Hi Patrick

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Martin Dobias
Hi Patrick On Tue, Jul 19, 2016 at 11:30 AM, Patrick Valsecchi wrote: > > So yes, my per function numbers are not very accurate, but they are a very > good indication of where time is spent. But, I still have the global numbers > with a RELEASE build to see if changes are improving things. Cool.

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Patrick Valsecchi
On Tue, Jul 19, 2016 at 11:38 AM, Even Rouault wrote: > I'm not sure to have followed your computation, but it is wrong somewhere > (must be a km vs m confusion). > Yes indeed. Shame on me. The earth circumference is 40'000km, not 40'000m. ___ Qgis-dev

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Even Rouault
> I was a bit sceptical, so I did a quick computation. A 32 bit float allows > an accuracy of 3mm with WGS84 for coordinates around 180°: > 180 takes 8 bits out of the 23 bits of fraction. The remaining 15 bits can > split the earth circumference into chunks of 3mm (4/(2^15)). I'm maybe > off

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Patrick Valsecchi
Hi Martin, On Tue, Jul 19, 2016 at 10:52 AM, Martin Dobias wrote: > Just curious - what did you use for profiling? Release or Debug build? > When trying to optimize code like QGIS server, I tend to do that: 1. Take a scenario that matches the realworld, run it with a RELEASE build on a m

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Patrick Valsecchi
Hi Nyall, On Tue, Jul 19, 2016 at 10:25 AM, Nyall Dawson wrote: > See https://github.com/qgis/qgis3.0_api/issues/15 > > Cool, that would force us to use the coordinates directly instead of the WKB. > We can't use a QPolygonF, as it uses qreal for storage. For certain > architectures this is fl

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Martin Dobias
Hi Patrick On Tue, Jul 19, 2016 at 9:58 AM, Patrick Valsecchi wrote: > Hi, > > I was looking at the perfs of qgis server and I did a small profiling of a > GetMap on a road layer (linestring) with QGIS configured with defaults. We > spend a lot of time converting to and from WKB. For example, for

Re: [Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Nyall Dawson
On 19 July 2016 at 17:58, Patrick Valsecchi wrote: > Hi, > > I was looking at the perfs of qgis server and I did a small profiling of a > GetMap on a road layer (linestring) with QGIS configured with defaults. We > spend a lot of time converting to and from WKB. For example, for rending 67k > feat

[Qgis-developer] Perfs: a lot of WKB conversions

2016-07-19 Thread Patrick Valsecchi
Hi, I was looking at the perfs of qgis server and I did a small profiling of a GetMap on a road layer (linestring) with QGIS configured with defaults. We spend a lot of time converting to and from WKB. For example, for rending 67k features (3 GetMaps), we do this for each feature: - When readi