[Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
Hi devs There seems to be a performance issue in QGIS Server. I tried to compile different versions and got the following results : QGIS master df19fe5e04b0c2ae8f1b1399715559e6bd50 --> works as expected = pretty fast ;) QGIS today's master -> a lot of performance issues. I get a lot of the f

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
I checked other commits : pyqgis-console] allow to disable automatic parentheses insertion from settings (commit 942d6bfa5d5e9cc7471efcd34717613fa6a8b7db ) --> performance issues Fix wmsserver: Do not manipulate maplayerregistry directly (commit df19fe5e04b0c2ae8f1b1399715559e6bd50 ) --> Goo

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread Jürgen E . Fischer
Hi Michael, On Wed, 22. May 2013 at 16:14:50 +0200, kimaidou wrote: > So there is a commit in between which raises the issue. I can go on the > process of compiling every commit to find the one which triggers the > issue, unless someone knows I don't. But git bisect will probably take you there

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
Thanks Jürgen for this great tip I almost trapped the "vicious" commit ! Following commit has BAD Server perfs Fix wmsserver: Do not manipulate maplayerregistry directly df19fe5e04b0c2ae8f1b1399715559e6bd50 Following commit has GOOD Server perfs Merge pull request #591 from ccrook/delimited_

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
Here is the result of git log between the 2 commits df19fe5e04b0c2ae8f1b1399715559e6bd50 Fix wmsserver: Do not manipulate maplayerregistry directly ---> BAD 6fcdc05fde836cb93985a9979636c999ec32 Use a cosmetic pen for snap lines to prevent lines scaling (fix #7524) d88872806ff6d380e396dd1

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread Matthias Kuhn
Hi Michael, It's probably the commit you identified: Fix wmsserver: Do not manipulate maplayerregistry directly df19fe5e04b0c2ae8f1b1399715559e6bd50 I'm almost sure if you revert this one and commit 35de29df9bea0a8d36d54aec677df054d7cd37ba it will run fine. I'll have a look and revert the

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
2013/5/22 Matthias Kuhn > Hi Michael, > > It's probably the commit you identified: > > Fix wmsserver: Do not manipulate maplayerregistry directly > df19fe5e04b0c2ae8f1b1399715559e6bd50 > I think so too. > > I'm almost sure if you revert this one and commit > 35de29df9bea0a8d36d54aec677df0

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread Matthias Kuhn
On top of current master (so checked out most recent commit with bad performance): git revert df19fe5e04b0c2ae8f1b1399715559e6bd50 git revert 35de29df9bea0a8d36d54aec677df054d7cd37ba One more question: Do you have any plugins running? (Is this even supported by server)? On Mit 22 Mai 2013 1

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
Answers below 2013/5/22 Matthias Kuhn > On top of current master (so checked out most recent commit with bad > performance): > git revert df19fe5e04b0c2ae8f1b1399715559e6bd50 > git revert 35de29df9bea0a8d36d54aec677df054d7cd37ba > > Ok. So I reverted these 2 commits. I am now runnin the comp

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
Matthias, Reverting the 2 commits above latests master works -> regression is gone, and QGIS Server is as fast as usual. Let me know if you want me to try some branch of yours for testing QGIS Server. Cheers Michael ___ Qgis-developer mailing list Qgis

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread Matthias Kuhn
The pull request [1] solves this. I don't really like this fix, but I don't know the mapserver source well enough to provide a better fix. Marco, could you have a look at the pull request and give a short feedback. Further discussion could also happen there. Regards, Matthias [1] https://githu

Re: [Qgis-developer] QGIS Server - performance issue in master since one week (after df19fe5e04b0c2ae8f1b13000099715559e6bd50 )

2013-05-22 Thread kimaidou
Thanks Matthias for helping me to solve this out. I subscribed to the Git pull request page. Good evening 2013/5/22 Matthias Kuhn > The pull request [1] solves this. I don't really like this fix, but I > don't know the mapserver source well enough to provide a better fix. > > Marco, could you