Re: [Qgis-developer] Rule-based renderer updates

2012-01-30 Thread Martin Dobias
Hi Richard On Fri, Jan 27, 2012 at 1:21 PM, Richard Duivenvoorde wrote: >> >> Btw. Richard has provided a patch in a pull request for that, it >> might be possible to backport it to 1.7 and 1.8 > > > Martin's rework is in master now, I tried and I think in the new gui my > patch is not neccesary

Re: [Qgis-developer] Rule-based renderer updates

2012-01-30 Thread Martin Dobias
On Fri, Jan 27, 2012 at 5:59 PM, wrote: > Hi Martin, > > I've made some tests playing with a few hundred styles, comparing QGIS 1.7.1 > and 1.9.0. > Overall, I find your commit very good, thanks a lot! > Still there are a few regressions IMHO. Discussion below. Hi Mayeul thanks for your feedba

Re: [Qgis-developer] Rule-based renderer updates

2012-01-27 Thread mayeul . kauffmann
Hi Martin, I've made some tests playing with a few hundred styles, comparing QGIS 1.7.1 and 1.9.0. Overall, I find your commit very good, thanks a lot! Still there are a few regressions IMHO. Discussion below. > Rules now form a hierarchical structure: any rule can contain > further "child" rule

Re: [Qgis-developer] Rule-based renderer updates

2012-01-27 Thread Alexander Bruy
Hi Richard, 2012/1/27 Richard Duivenvoorde : > > Martin's rework is in master now, I tried and I think in the new gui my > patch is not neccesary anymore there (untill further use) ... > > Will the rework also be in 1.8? I mean should I remove the pull request? I think we can add this rework to 1

Re: [Qgis-developer] Rule-based renderer updates

2012-01-27 Thread Richard Duivenvoorde
Another thing I find hard to play with in the current 1.7 versions is the need to click again and again to change rule priority : click the rule, then click the array (increase or decrease), then reclick the rule (which location has changed), then reclick "increase", etc. I think. This is why I

Re: [Qgis-developer] Rule-based renderer updates

2012-01-25 Thread Martin Dobias
On Tue, Jan 24, 2012 at 2:51 PM, kimaidou wrote: > > - filtering of rules in GUI - by label / filter expression / scale > > not a priority for me, since the tree should improve user experience. And > you would have to dynamically change the tree, which could lead to weird > behaviours ? Such as sh

Re: [Qgis-developer] Rule-based renderer updates

2012-01-24 Thread kimaidou
Hi Martin, Just a quick answer to thank you warmly for these improvements. I am working on OpenStreetMap data to print maps, and I think these changes will help me a lot. I have to compile master branch to test it, but will try to do it quickly, and then I would be able to report. About your last

[Qgis-developer] Rule-based renderer updates

2012-01-24 Thread Martin Dobias
Hi all I have just merged improved rule-based renderer to master branch. There are various changes in both backend and GUI: * Rules now form a hierarchical structure: any rule can contain further "child" rules. When rendering, child rules are applied only when their parent rule matches. This allo