Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-20 Thread Matthias Kuhn
PS: Tim, there have been some comments (probably written by you) to deprecate / replace the non-batch signals and methods. I've left them there (and removed the deprecation comments) as convenience methods and signals (and to not break the API). As long as you don't have long-running jobs such as

Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-20 Thread Matthias Kuhn
Just committed these changes. If somebody uses the Georeferencer plugin, I'd be glad if he could check if this still works. API changes listed below (commit message). Matthias $ git show commit 193b6154d213254672061267bac8e6e8ad5ea1f3 Author: Matthias Kuhn Date: Sat Apr 20 10:21:14 2013 +020

Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-19 Thread Tim Sutton
Hi On Fri, Apr 19, 2013 at 11:18 PM, Matthias Kuhn wrote: > Thank you Tim and Martin, > > On Fre 19 Apr 2013 18:02:12 CEST, Tim Sutton wrote: >> Hi >> >> On Fri, Apr 19, 2013 at 10:45 PM, Martin Dobias wrote: >>> Hi Matthias >>> >>> On Fri, Apr 19, 2013 at 4:07 PM, Matthias Kuhn wrote: The

Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-19 Thread Matthias Kuhn
Thank you Tim and Martin, On Fre 19 Apr 2013 18:02:12 CEST, Tim Sutton wrote: > Hi > > On Fri, Apr 19, 2013 at 10:45 PM, Martin Dobias wrote: >> Hi Matthias >> >> On Fri, Apr 19, 2013 at 4:07 PM, Matthias Kuhn wrote: >>> The QgsMapLayerRegistry::removeMapLayers allows to specify a parameter, >>>

Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-19 Thread Tim Sutton
Hi On Fri, Apr 19, 2013 at 10:45 PM, Martin Dobias wrote: > Hi Matthias > > On Fri, Apr 19, 2013 at 4:07 PM, Matthias Kuhn wrote: >> The QgsMapLayerRegistry::removeMapLayers allows to specify a parameter, >> which will suppress emitting signals (altough it seems that this is not >> even properly

Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-19 Thread Tim Sutton
Hi On Fri, Apr 19, 2013 at 9:07 PM, Matthias Kuhn wrote: > The QgsMapLayerRegistry::removeMapLayers allows to specify a parameter, > which will suppress emitting signals (altough it seems that this is not > even properly working [1]). > > This parameter can lead to strange behavior, where some pa

Re: [Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-19 Thread Martin Dobias
Hi Matthias On Fri, Apr 19, 2013 at 4:07 PM, Matthias Kuhn wrote: > The QgsMapLayerRegistry::removeMapLayers allows to specify a parameter, > which will suppress emitting signals (altough it seems that this is not > even properly working [1]). > > This parameter can lead to strange behavior, wher

[Qgis-developer] Suppress emitting of signal: Bad practice?

2013-04-19 Thread Matthias Kuhn
The QgsMapLayerRegistry::removeMapLayers allows to specify a parameter, which will suppress emitting signals (altough it seems that this is not even properly working [1]). This parameter can lead to strange behavior, where some parts of the software might not realize, that a layer has been removed