Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-11 Thread Radim Blazek
On Fri, Feb 8, 2013 at 4:47 PM, Etienne Tourigny wrote: > I haven't really followed this, but I assume this does not affect > existing plugins which use QgsRasterDataProvider::identify() such as > e.g. the value tool plugin? No. Not yet. I am still thinking about some class for identify results

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-08 Thread Etienne Tourigny
I haven't really followed this, but I assume this does not affect existing plugins which use QgsRasterDataProvider::identify() such as e.g. the value tool plugin? regards, Etienne On Thu, Feb 7, 2013 at 6:38 PM, Radim Blazek wrote: > Hi Denis, > > On Thu, Feb 7, 2013 at 11:30 AM, Denis Rouzaud

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-07 Thread Radim Blazek
Hi Denis, On Thu, Feb 7, 2013 at 11:30 AM, Denis Rouzaud wrote: > Hi Radim, > > I just finished the work thanks to Jef's debugging ability! > > Here is the pull request > https://github.com/qgis/Quantum-GIS/pull/421 pushed to master in 4e64d72. Thanks Radim > The identify method now returns di

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-07 Thread Denis Rouzaud
Hi Radim, I just finished the work thanks to Jef's debugging ability! Here is the pull request https://github.com/qgis/Quantum-GIS/pull/421 The identify method now returns directly the IdentifyResults instead of using a private attribute. Also, IdentifyResult is now a single struct (no RasterR

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-06 Thread Radim Blazek
On Wed, Feb 6, 2013 at 3:55 PM, Denis Rouzaud wrote: > Just pay attention, I pull another request > https://github.com/qgis/Quantum-GIS/pull/421 > I changed the behavior of the identify methods: it returns the results > instead of saving them in a > private attribute. Better, I think. > Also,

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-06 Thread Denis Rouzaud
I don't understand why you added an identify method in qgmaptoolindetifyaction in app. are you on irc or something so we can discuss? On 02/06/2013 03:39 PM, Radim Blazek wrote: Jef changed that from ~layerList.isEmpty() to !layerList.isEmpty() but that was not working (current layer was not

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-02-06 Thread Denis Rouzaud
Hi Radim, On 02/06/2013 03:39 PM, Radim Blazek wrote: Hi Denis, I have commited some changes related to identify tool: https://github.com/qgis/Quantum-GIS/commit/50d4bb6d4 I hope it does not break any your original intention. As I see it, it seems to be ok! Just pay attention, I pull another

Re: [Qgis-developer] making QgsMapToolIdentify available to plugins

2013-01-22 Thread Nathan Woodrow
Hey Denis, Yeah it's a bit of a pain. I starting to move it a while ago and then lost motivation as the code was really coupled. The second option is the best if you can afford to fund it or spend time on it :) - Nathan On Tue, Jan 22, 2013 at 5:13 PM, Denis Rouzaud wrote: > Hi all, > > Fol

[Qgis-developer] making QgsMapToolIdentify available to plugins

2013-01-21 Thread Denis Rouzaud
Hi all, Following my previous mail, I am trying to make the identify map tool available to plugins. With Matthias Kuhn's help, I've found two ways to achieve this: - Move QgsMapToolIdentify::identifyVectorLayer and identfiyRasterLayer to mapCanvas - Move QgsMapToolIdentify to gui, and inhe