Re: [qooxdoo-devel] Bad resource leakage

2010-07-07 Thread Per-Ola Stenborg
Hi Derrel At 16:08 2010-07-02, you wrote: >I've fixed it in a slightly different way. Rather than removing and re-adding >the listener, I now track whether the listener is active, and only start if if >it's not already active. > >Thanks again! > >Per-Ola, please get the current version from trun

Re: [qooxdoo-devel] Bad resource leakage

2010-07-02 Thread Fink, Andreas
If I'm right the attached patch should fix the problem. Regards, Andreas Von: Fink, Andreas [mailto:andreas.f...@afb24.com] Gesendet: Freitag, 2. Juli 2010 15:16 An: qooxdoo Development Betreff: Re: [qooxdoo-devel] Bad resource leakage I had a quick look on the TimerManager s

Re: [qooxdoo-devel] Bad resource leakage

2010-07-02 Thread Derrell Lipman
On Fri, Jul 2, 2010 at 09:15, Fink, Andreas wrote: > I had a quick look on the TimerManager source and I hit one section in > __insertNewTimner function: > > > > // If this is the first element on the queue... > > *if* (timerQueue.length == 1) > > { > > // ... then start list

Re: [qooxdoo-devel] Bad resource leakage

2010-07-02 Thread Fink, Andreas
adding the timer to the queue. I think it should be done before re-adding the timer. So maybe this is the problem... Regards, Andreas Von: Derrell Lipman [mailto:derrell.lip...@unwireduniverse.com] Gesendet: Freitag, 2. Juli 2010 14:40 An: qooxdoo Development Betreff: Re: [qooxdoo-devel] Ba

Re: [qooxdoo-devel] Bad resource leakage

2010-07-02 Thread Derrell Lipman
On Fri, Jul 2, 2010 at 05:23, Per-Ola Stenborg wrote: > thanks for the patch and your effort. Unfortunatly it doesn't solv the > problem. > Even the simplest test src > http://www.sadata.se/files/temp/Application.jsshows it in an hour. > What can I do more to help? > As a last resort I tried nat

Re: [qooxdoo-devel] Bad resource leakage

2010-07-02 Thread Per-Ola Stenborg
Hi Derrel, thanks for the patch and your effort. Unfortunatly it doesn't solv the problem. Even the simplest test src http://www.sadata.se/files/temp/Application.js shows it in an hour. What can I do more to help? As a last resort I tried native js "setInterval()" timer during the night in FF, i

Re: [qooxdoo-devel] Bad resource leakage

2010-07-01 Thread Derrell Lipman
On Thu, Jul 1, 2010 at 08:57, Derrell Lipman < derrell.lip...@unwireduniverse.com> wrote: > On Thu, Jul 1, 2010 at 03:45, Per-Ola Stenborg > wrote: > >> Hi Derrel, >> >> Thanks for your answer. You confirmed my suspicion that the patch didn't >> affected continuous timers. Can you explain what y

Re: [qooxdoo-devel] Bad resource leakage

2010-07-01 Thread Derrell Lipman
On Thu, Jul 1, 2010 at 03:45, Per-Ola Stenborg wrote: > Hi Derrel, > > Thanks for your answer. You confirmed my suspicion that the patch didn't > affected continuous timers. Can you explain what you mean with "underlying > Array implementations"? Do you mean the browsers js parser implementation?

Re: [qooxdoo-devel] Bad resource leakage

2010-07-01 Thread Per-Ola Stenborg
Hi Derrel, Thanks for your answer. You confirmed my suspicion that the patch didn't affected continuous timers. Can you explain what you mean with "underlying Array implementations"? Do you mean the browsers js parser implementation? If so, it seems to affect different browsers. Is this a funda

Re: [qooxdoo-devel] Bad resource leakage

2010-06-30 Thread Derrell Lipman
On Wed, Jun 30, 2010 at 05:10, Per-Ola Stenborg wrote: > > 2. The timer issue. > I'm sorry to say I still have the problem. (FF/Chrome/IE) I hope I patched > it correctly as I'm not that used to Qooxdoo yet. If someone else could > confirm this with my test code it would be great. Src > http://www

Re: [qooxdoo-devel] Bad resource leakage

2010-06-30 Thread Per-Ola Stenborg
Hi guys, Some update: 1. The problem with dealocation in qx.io.remote.Request(). This seems to work fine, atleast no complaints by the debugger. I reported yesterday that i did not work in chrome. This was a misstake, it does! (For some reason chrome did not refresh its cache with the new js fi

Re: [qooxdoo-devel] Bad resource leakage

2010-06-30 Thread Peter Schneider
Oh-oh violation of coding conventions / project rules ! ;) O.K. First, here's the bug: http://bugzilla.qooxdoo.org/show_bug.cgi?id=3816 You might have to ask your admin about the right to change the log message in the SVN repository, but that would be another violation of project/company rules I

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread thron7
> I assume that it doesn't make sense anymore to file a bug for this, > right? > Nevertheless, I will wait for any further report on this from Per-Ola > > > For a complete record, it is probably useful to file a bug report and > indicate that the problem should be resolved by r22536

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Derrell Lipman
On Tue, Jun 29, 2010 at 11:45, Peter Schneider wrote: > O.K. Thanks for the commit Derrell, > > I assume that it doesn't make sense anymore to file a bug for this, right? > Nevertheless, I will wait for any further report on this from Per-Ola > For a complete record, it is probably useful to file

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
O.K. Thanks for the commit Derrell, I assume that it doesn't make sense anymore to file a bug for this, right? Nevertheless, I will wait for any further report on this from Per-Ola /Peter On 2010-06-29 17:41 Derrell Lipman wrote: > [...] > This was wrong in the code, and could certainly cause a

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Derrell Lipman
On Tue, Jun 29, 2010 at 08:00, Peter Schneider wrote: > > Index: TimerManager.js > === > --- TimerManager.js (Revision 96) > +++ TimerManager.js (Arbeitskopie) > @@ -297,7 +297,8 @@ > { > // ... then stop listeni

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Per-Ola Stenborg
Hello, I've been busy with other parts of the project this afternoon. Peter please file the report i like, if I find anything more I will add it later. I will add the TimerManager.js patch tomorrow and se how it works. Best regards Per-Ola At 15:33 2010-06-29, you wrote: >On Christian Hagend

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
On Christian Hagendorn wrote: > Hi Peter, > > yes, maybe that's the reason. Could you please add this to the bug report. Sure, as soon as there is one ;) Per-Ola wanted to file that one. I will add all the informations/patches I have to the issue-report when it's available. /Peter > Thanks, >

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Christian Hagendorn
Hi Peter, yes, maybe that's the reason. Could you please add this to the bug report. Thanks, Chris Am 29.06.2010 13:52, schrieb Peter Schneider: > Hey Per-Ola, Christian, Martin, > > I did some quick research on this and I think I have some information: > It seems to me that the listeners that w

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Christian Hagendorn
Thanks! Am 29.06.2010 12:02, schrieb Peter Schneider: >> [...] could please some of you create a bug report for this issue. [...] >> > Done! ;) > > http://bugzilla.qooxdoo.org/show_bug.cgi?id=3812 > > /Peter > > > On Christian Hagendorn wrote: > >> Hi Per-Ola, Hi Peter, >> >> could plea

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
Hey Per-Ola, Christian, Martin, I did some quick research on this and I think I have some information: It seems to me that the listeners that will be added by the Manager will not be removed. Whenever I do a tid = timer.start(); followed by timer.stop(tid); the "entryList" in qx.event.

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
Here's another one ;) It seems that my thought in the last post (wrong context at "removeListener") was correct. @Per-Ola: Could you please try the attached patch and see what happens. /Peter On 2010-06-29 13:57 Per-Ola Stenborg wrote: > Hi Chris and Peter > > I'll do some more invetigation o

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
Hey Per-Ola, thanks for the information about Chrome. I will also add this info to the issue-report [1] /Peter [1] http://bugzilla.qooxdoo.org/show_bug.cgi?id=3812 On 2010-06-29 12:51 Per-Ola Stenborg wrote: > Hi Chris and Peter > > I think there still is a destructor problem in Chrome. Peters

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
> [...] could please some of you create a bug report for this issue. [...] Done! ;) http://bugzilla.qooxdoo.org/show_bug.cgi?id=3812 /Peter On Christian Hagendorn wrote: > Hi Per-Ola, Hi Peter, > > could please some of you create a bug report for this issue. But please > describe the issue s

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Per-Ola Stenborg
Hi Chris and Peter I think there still is a destructor problem in Chrome. Peters patch seems to work in FF but not in Chrome. Thought you should know Peter. Best regards Per-Ola At 11:26 2010-06-29, you wrote: >Hi Peter, > >yes, sorry. Please provide one for the qx.io.remote.transport.Abstract

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Per-Ola Stenborg
Hi Chris and Peter I'll do some more invetigation on the timer issue and will then file a report. It still seems lika a bug. I'm running crome without debuging in the build right now and it still increases cpu usage. Best regards Per-Ola At 11:26 2010-06-29, you wrote: >Hi Peter, > >yes, sorry

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Christian Hagendorn
Hi Peter, yes, sorry. Please provide one for the qx.io.remote.transport.Abstract and one for the timer issue. Thanks! Chris Am 29.06.2010 11:12, schrieb Peter Schneider: > Hi Chris, > > I can provide a bug/report for the qx.io.remote.transport.Abstract thing. > Shouldn't the "timer" issue be h

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
Hi Chris, I can provide a bug/report for the qx.io.remote.transport.Abstract thing. Shouldn't the "timer" issue be handled in a different bug? @Per-Ola: I will create a report on the "transport" issue, right? So we don't do double work. /Peter On Christian Hagendorn wrote: > Hi Per-O

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Per-Ola Stenborg
Hi all, I've implemented the patch and I think it didn't break anything (yet :-) ). The debugger doesn't complain anymore about missing desturctor. Good work Peter! Time will show if it helps reducing the racing memory allocation. Thanks! /Per-Ola At 10:04 2010-06-29, you wrote: >Hi Per-Ola

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Christian Hagendorn
Hi Per-Ola, Hi Peter, could please some of you create a bug report for this issue. But please describe the issue so good as possible perhaps with a code snippet. I talked with Martin and he will have a look at it. Thanks! Chris Am 29.06.2010 09:38, schrieb Peter Schneider: > Hey Per-Ola, > > a

Re: [qooxdoo-devel] Bad resource leakage

2010-06-29 Thread Peter Schneider
Hey Per-Ola, as you wrote you are using qooxdoo 1.1: I experienced similar problems, so this thread http://qooxdoo.678.n2.nabble.com/Missing-destruct-definitions-in-qx-io-remote-transport-XmlHttp-v1-1-tt5018573.html might be about the same root-cause. I was able to reduce my memory-leakage proble

Re: [qooxdoo-devel] Bad resource leakage

2010-06-28 Thread Fink, Andreas
[mailto:per-ola.stenb...@sadata.se] Gesendet: Dienstag, 29. Juni 2010 07:36 An: qooxdoo-devel@lists.sourceforge.net Betreff: [qooxdoo-devel] Bad resource leakage Hi all, I'm developing an application which you can think of as a point of sale client. It needs to be running for days without br

[qooxdoo-devel] Bad resource leakage

2010-06-28 Thread Per-Ola Stenborg
Hi all, I'm developing an application which you can think of as a point of sale client. It needs to be running for days without browser restart. I noticed when starting to test the client that it started to loose performance and consume the PC:s resources after a few hours. This problem might b