Re: [qooxdoo-devel] Parent.removeAll()

2006-09-14 Thread Tomek Loboda
I agree with Sebastian about implicit code. How about adding 'dispose' boolean argument to removeAll()? David: thanks for bringing that up. I wasn't aware of this behavior.. Best, --Tomek Sebastian Werner wrote: > It's not a good idea in my opinion. It's possible that you want to add > the ch

Re: [qooxdoo-devel] Parent.removeAll()

2006-09-14 Thread dperez
Hi Sebastian, In the removeAll() documentation it should be warned that no items are disposed. I have a ComboBox, whose list of possible values I change depending on the value of some other widgets. When I have to renew the list of possible values I do something like this: function updateCombo(

Re: [qooxdoo-devel] Parent.removeAll()

2006-09-14 Thread Sebastian Werner
It's not a good idea in my opinion. It's possible that you want to add the children to another parent afterwards (move them) or just remove them temporary and re-add them afterwards. Implicit code is IMHO in the most cases not a good idea. Better it would be to add new methods like: removeAndDi

Re: [qooxdoo-devel] Parent.removeAll()

2006-09-14 Thread dperez
Here is an implementation that disposes children: qx.Proto.removeAll = function() { var cs = this.getChildren(), co; while (co = cs[0]) { this.remove(co); co.dispose(); } } dperez wrote: > > Hi, > > I've discovered that qx.ui.core.Parent.removeAll() doesn't dispose its > chi

[qooxdoo-devel] Parent.removeAll()

2006-09-14 Thread dperez
Hi, I've discovered that qx.ui.core.Parent.removeAll() doesn't dispose its children, as I first supposed. It could be a good idea if it would. Regards, David -- View this message in context: http://www.nabble.com/Parent.removeAll%28%29-tf2270458.html#a6302101 Sent from the qooxdoo-devel forum