Re: [qooxdoo-devel] destruct() question

2008-06-24 Thread Peter Schneider
Hi again Thomas, > [...] > if it looks like I've de-stabilized the code with all the 'destruct' > entries too much, I'm going to revert all my changes and file bug > reports for each, so people can sort them out with more time and > subtlety. We'll see... > [...] I don't think that you've de-s

Re: [qooxdoo-devel] destruct() question

2008-06-24 Thread thron7
Thanks, Kuddel, for the submission. I'm actually getting to the point, if it looks like I've de-stabilized the code with all the 'destruct' entries too much, I'm going to revert all my changes and file bug reports for each, so people can sort them out with more time and subtlety. We'll see...

Re: [qooxdoo-devel] destruct() question

2008-06-24 Thread Peter Schneider
Hi Thomas, according to your request in the log of R14009 (legacy 0.7.x), "...please check for unintended side effects." I can offer a patch to another (new) destructor issue: The _tableContainer object in qx.ui.table.pane.Pane is created with document.createElement("div"); and is therefore no

Re: [qooxdoo-devel] destruct() question

2008-06-23 Thread Derrell Lipman
On Mon, Jun 23, 2008 at 3:36 AM, thron7 <[EMAIL PROTECTED]> wrote: > > This needs a lot more careful analysis. > > That's perfectly true. Actually, I thought the primary widget > maintainers would jump in and take over for their respective code. Unfortunately, the author of Table hasn't been see

Re: [qooxdoo-devel] destruct() question

2008-06-23 Thread Hugh Gibson
> > And finally could I say that tracing the patches and reasons for > > changes is very difficult when you haven't got an issue for them, > > with full logging of issue number in SVN checkin messages; and SVN > > revision numbersin the issue. > > I see what you're hinting at. I'm not sure, thoug

Re: [qooxdoo-devel] destruct() question

2008-06-23 Thread thron7
Hugh Gibson wrote: > > There may be framework errors from this (see message about combobox). > Fixing these can't be done by simple dispose calls - there's a more > complex question about who has ownership of the created subsidiary > objects. > Well said. > > But when the cell event has finish

Re: [qooxdoo-devel] destruct() question

2008-06-23 Thread thron7
Romain FLIEDEL wrote: > I've seen that you add missing destructs in rev 14009 > I found an issue with qx.ui.table.pane.CellEvent > > I think you should use disposeFields instead of disposeObjects because > right now if a CellEvent is triggered then the table seems not to react > on click anymore

Re: [qooxdoo-devel] destruct() question

2008-06-22 Thread Hugh Gibson
> Also, I've just taken a quick look at some of the code you checked > in > from the patches here and I'm not sure that it's correct due to an > ownership issue. I haven't reviewed it completely, but found the > following. I see that Romain has already reported the problem that resulted from this

Re: [qooxdoo-devel] destruct() question

2008-06-22 Thread Romain FLIEDEL
I've seen that you add missing destructs in rev 14009 I found an issue with qx.ui.table.pane.CellEvent I think you should use disposeFields instead of disposeObjects because right now if a CellEvent is triggered then the table seems not to react on click anymore (no focus change for instance) Wi

Re: [qooxdoo-devel] destruct() question

2008-06-22 Thread Hugh Gibson
> I think I have to jump in this discussion. > I've a problem with memory usage of my qooxdoo application too and > tried the mentioned hints. > If I use the additional options in the make file to show the > missing destruct definitions, the only messages I see, come from > the framework itself:

Re: [qooxdoo-devel] destruct() question

2008-06-20 Thread Romain FLIEDEL
I've seen that you add missing destructs in rev 14009 I found an issue with qx.ui.table.pane.CellEvent I think you should use disposeFields instead of disposeObjects because right now if a CellEvent is triggered then the table seems not to react on click anymore (no focus change for instance) With

Re: [qooxdoo-devel] destruct() question

2008-06-18 Thread thron7
Thanks, guys, for the postings. Thomas > Hi Thomas, > > I've noticed another small issue: > > When a table object is created and disposed again, the event-listener to > "changeLocale" is still attached, which will lead to an error when the locale > is changed after table object disposal. > > The

Re: [qooxdoo-devel] destruct() question

2008-06-18 Thread Peter Schneider
Hi Thomas, I've noticed another small issue: When a table object is created and disposed again, the event-listener to "changeLocale" is still attached, which will lead to an error when the locale is changed after table object disposal. The attached patch worked for our application, but is not te

Re: [qooxdoo-devel] destruct() question

2008-06-17 Thread Romain FLIEDEL
thron7 a écrit : Ah, you guys got us with our pants down :). Yes, these are actually leaks in the framework. I've fixed those from the log output in legacy_0_7_x (but maybe there are more). If you check your applications and come across further 'Missing' entries that pertain to framework class

Re: [qooxdoo-devel] destruct() question

2008-06-06 Thread Fink, Andreas
: Freitag, 6. Juni 2008 14:56 An: qooxdoo Development Betreff: Re: [qooxdoo-devel] destruct() question Ok, recognized :) here is a patch for qx.ui.table.pane.CellEvent: Index: CellEvent.js === --- CellEvent.js(revision 13880

Re: [qooxdoo-devel] destruct() question

2008-06-06 Thread Fink, Andreas
quot;); + this._disposeObjects("_scroller"); } }); Greetings, Andreas -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von thron7 Gesendet: Freitag, 6. Juni 2008 14:09 An: qooxdoo Development Betreff: Re: [qooxdoo-devel] destruct() ques

Re: [qooxdoo-devel] destruct() question

2008-06-06 Thread thron7
[EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Fink, Andreas > Gesendet: Freitag, 6. Juni 2008 11:01 > An: qooxdoo Development > Betreff: Re: [qooxdoo-devel] destruct() question > > Hi, > > I think I have to jump in this discussion. > I've a problem

Re: [qooxdoo-devel] destruct() question

2008-06-06 Thread Tobias Koller (GERMO GmbH)
I get the same warnings ;) Tobias -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Fink, Andreas Gesendet: Freitag, 6. Juni 2008 11:01 An: qooxdoo Development Betreff: Re: [qooxdoo-devel] destruct() question Hi, I think I have to jump in this

Re: [qooxdoo-devel] destruct() question

2008-06-06 Thread Fink, Andreas
4-pre (actual checkout from repository). Greetings, Andreas -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von thron7 Gesendet: Donnerstag, 5. Juni 2008 14:38 An: qooxdoo Development Betreff: Re: [qooxdoo-devel] destruct() question Kanugula, > I foll

Re: [qooxdoo-devel] destruct() question

2008-06-05 Thread thron7
Kanugula, > I followed the link and tried the 1st option "Enable the debug code". After > rebuilding the source script, I didn't see anywhere in the log showing > object distruction. No, that's true. The settings described on the Wiki page are only a preparation to see more *iff* the desposer ac

Re: [qooxdoo-devel] destruct() question

2008-06-05 Thread Hugh Gibson
> But, the memory (the process firefox.exe/IEXPLORER.EXE shown in > Windows Task Manager) in FF2 and IE6 constantly grows as per usage > of my application. My application has 10 tables Table_1.html to > Table_10.html under example folder like Demo Browser. When I go to > different Tables, I see th

Re: [qooxdoo-devel] destruct() question

2008-06-04 Thread kanugula
I profiled my application using the following code in background for every 10 seconds qx.client.Timer.once (function () { alert(qx.dev.ObjectSummary.getInfo()); }, this, 1); Almost constantly it displays 300 total objects, which is g

Re: [qooxdoo-devel] destruct() question

2008-06-04 Thread kanugula
I followed the link and tried the 1st option "Enable the debug code". After rebuilding the source script, I didn't see anywhere in the log showing object distruction. Does it right anything in the log file? The document doesn't say clearly where to check the destructed objects. By the way, I am t

Re: [qooxdoo-devel] destruct() question

2008-06-02 Thread thron7
kanugula wrote: > Hi, > > Using Demo Browser terminology for simplicity. > > If I have something like > var window = new qx.ui.window.Window(); > var group = new qx.ui.groupbox.GroupBox(); > var label = new qx.ui.basic.Label(); > group.add(label); > window.add(group); > > this.window=window; > this

[qooxdoo-devel] destruct() question

2008-06-02 Thread kanugula
Hi, Using Demo Browser terminology for simplicity. If I have something like var window = new qx.ui.window.Window(); var group = new qx.ui.groupbox.GroupBox(); var label = new qx.ui.basic.Label(); group.add(label); window.add(group); this.window=window; this.group=group; this.label=label; 1) Is