Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Chris Lewis
Matt Sergeant wrote: The Received headers won't change. Only the logs created by logterse or other logging plugins that use remote_host will change. That's a very very bad idea. How, exactly, are we supposed to have a plugin filter on NXDOMAIN and not TIMEOUT, or be able to detect DNS proble

Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Ask Bjørn Hansen
On Jun 2, 2008, at 7:04 PM, Matt Sergeant wrote: Wow, that seems MUCH worse to me - to have the logs *not* storing the dns failure reason seems completely at odds to me with what logs should be for. I agree with that. Failures of any kind should always be logged. - ask -- http://deve

Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Matt Sergeant
On 2-Jun-08, at 6:06 PM, Radu Greab wrote: Matt Sergeant wrote: I think that remote_host should not be the error code in case of errors. That contradicts the description of the method and may force other people using remote_host to do their own checks. Well on regular qmail it's set to "Unk

Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Radu Greab
Matt Sergeant wrote: > > > I think that remote_host should not be the error code in case of > > errors. That contradicts the description of the method and may force > > other people using remote_host to do their own checks. > > Well on regular qmail it's set to "Unknown" in case of errors, but

Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Matt Sergeant
On 2-Jun-08, at 5:55 PM, Radu Greab wrote: Matt Sergeant wrote: Why not leave it as NXDOMAIN or SERVFAIL or TIMEOUT in case of errors? I find this useful in my Received headers... I didn't know that you coded it that way on purpose, instead it looked to me like a thing that could be improved

Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Radu Greab
Matt Sergeant wrote: > > Why not leave it as NXDOMAIN or SERVFAIL or TIMEOUT in case of > errors? I find this useful in my Received headers... I didn't know that you coded it that way on purpose, instead it looked to me like a thing that could be improved. I think that remote_host should not

Re: [svn:qpsmtpd] r923 - in trunk: . lib/Qpsmtpd

2008-06-02 Thread Matt Sergeant
Why not leave it as NXDOMAIN or SERVFAIL or TIMEOUT in case of errors? I find this useful in my Received headers... On 2-Jun-08, at 12:48 PM, [EMAIL PROTECTED] wrote: Author: radu Date: Mon Jun 2 09:48:57 2008 New Revision: 923 Modified: trunk/Changes trunk/lib/Qpsmtpd/PollServer.pm