Re: [PATCH] Add 'address notes'

2009-02-12 Thread Robert Spier
In the short term, I've reverted your change in my branch, and will send that upstream to ask. -R Jared Johnson wrote: > > - my $self = shift; > - my $key = shift; > - @_ and $self->{_notes}->{$key} = shift; > - #warn Data::Dumper->Dump([\$self->{_notes}], [qw(notes)]); > - $self->{_notes

Re: Commit log?

2009-02-12 Thread Ask Bjørn Hansen
On Feb 12, 2009, at 7:34, Jose Luis Martinez wrote: I used to follow the actual commits via perl.qpsmtpd.dev news. Now that git is around, is there any substitute? I enabled that in github; we'll see how it works on the next change. Otherwise there's also http://github.com/feeds/abh/c

Re: [PATCH] Add 'address notes'

2009-02-12 Thread Jared Johnson
- my $self = shift; - my $key = shift; - @_ and $self->{_notes}->{$key} = shift; - #warn Data::Dumper->Dump([\$self->{_notes}], [qw(notes)]); - $self->{_notes}->{$key}; + my ($self,$key,$value) = @_; + $self->{_notes}->{$key} = $value if defined $value; + return $self->{_notes}->{$key};

Commit log?

2009-02-12 Thread Jose Luis Martinez
Hi, I used to follow the actual commits via perl.qpsmtpd.dev news. Now that git is around, is there any substitute? Regards, Jose Luis Martinez jlmarti...@capside.com

Re: Plugin docs split + contrib/ dir?

2009-02-12 Thread John Peacock
Guy Hulbert wrote: If not, then why not require that they all use the same one as qpsmtpd ... license wars are a total waste of time. I agree completely; it's why I mentioned it. If a plugin has been developed and distributed independently, it may have a license which conflicts with qpsmtpd.

Re: Plugin docs split + contrib/ dir?

2009-02-12 Thread Guy Hulbert
On Thu, 2009-12-02 at 07:40 -0500, John Peacock wrote: > Robert Spier wrote: > > If a plugin is stable, well documented, generally useful, maybe > > tested?, > > And has an appropriate license? Do current plugins have different licenses ? If not, then why not require that they all use the same

Re: Plugin docs split + contrib/ dir?

2009-02-12 Thread John Peacock
Robert Spier wrote: > If a plugin is stable, well documented, generally useful, maybe > tested?, And has an appropriate license? John

Re: End of headers hook

2009-02-12 Thread Ask Bjørn Hansen
On Feb 12, 2009, at 0:22, Robert Spier wrote: Ah; git is great. :-) Basically this is like passing a patch around, but with tools that are made to work with it. (We could also have had three commits with two of them just having for the history books useless tweaks). Kind of. I used gi

Re: End of headers hook

2009-02-12 Thread Robert Spier
Matt Sergeant wrote: > > Also note this won't work with -async properly. I'll have a look how it > can be made to work asynchronously (you need to follow the respond > style in the rest of the code). For some reason, I thought I looked at the rest of the code and convinced myself it would, be

Re: End of headers hook

2009-02-12 Thread Robert Spier
Ask Bjørn Hansen wrote: > > > On Feb 10, 2009, at 2:43, Robert Spier wrote: > > > Committed as > > > > http://github.com/rspier/qpsmtpd/commit/a0ae0453264fe8dd85c132f2e7305b5ac34bf7e8 > > > > Did you actually test that this worked? I had to tweak the code to > > make it make sense. Also, you