Re: _convert_to_ssl failures with async (Re: Hi, bug report/feature request)

2007-10-29 Thread Charlie Brady
On Mon, 29 Oct 2007, Matt Sergeant wrote: On 29-Oct-07, at 6:11 PM, Ask Bjørn Hansen wrote: On Oct 29, 2007, at 2:06 PM, Matt Sergeant wrote: > SSL with async is > going to be really hard to implement (though doable). Why harder than it's been in perlbal / djabberd? No harder than that

Re: _convert_to_ssl failures with async (Re: Hi, bug report/feature request)

2007-10-29 Thread Charlie Brady
On Mon, 29 Oct 2007, Matt Sergeant wrote: On 29-Oct-07, at 4:32 PM, Charlie Brady wrote: Is there any reason that $self->qp->sock couldn't be set to STDIN for non-async variants? Don't think there's any particular reason, no. Though I should note that the patch doesn't work :-) OK. SSL

Re: _convert_to_ssl failures with async (Re: Hi, bug report/feature request)

2007-10-29 Thread Matt Sergeant
On 29-Oct-07, at 6:11 PM, Ask Bjørn Hansen wrote: On Oct 29, 2007, at 2:06 PM, Matt Sergeant wrote: Though I should note that the patch doesn't work :-) SSL with async is going to be really hard to implement (though doable). Why harder than it's been in perlbal / djabberd? No harder than

Re: _convert_to_ssl failures with async (Re: Hi, bug report/feature request)

2007-10-29 Thread Ask Bjørn Hansen
On Oct 29, 2007, at 2:06 PM, Matt Sergeant wrote: Though I should note that the patch doesn't work :-) SSL with async is going to be really hard to implement (though doable). Why harder than it's been in perlbal / djabberd? - ask -- http://develooper.com/ - http://askask.com/

Re: _convert_to_ssl failures with async (Re: Hi, bug report/feature request)

2007-10-29 Thread Matt Sergeant
On 29-Oct-07, at 4:32 PM, Charlie Brady wrote: Is there any reason that $self->qp->sock couldn't be set to STDIN for non-async variants? Don't think there's any particular reason, no. Though I should note that the patch doesn't work :-) SSL with async is going to be really hard to implemen

_convert_to_ssl failures with async (Re: Hi, bug report/feature request)

2007-10-29 Thread Charlie Brady
On 4-Oct-07, at 1:00 PM, Chris Lewis wrote: Chris Lewis wrote: > Any idea why I'd be getting these: _convert_to_ssl failed (Could not create SSL socket: Socket operation on non-socket at ./plugins/tls line 158 > [At end of _convert_to_ssl(), I'm logging $@ if it's non-null] I've confirmed

Re: Hi, bug report/feature request

2007-10-08 Thread Peter J. Holzer
On 2007-10-08 09:12:53 +0200, Johan Almqvist wrote: > Peter J. Holzer wrote: > >> sub fqdn { > >> my $local = hostname(); > >> return $local unless _is_short($local); > >> return ( gethostbyname($local) )[0] || $local; > >> } > >[...] > > > >It works on your particular Linux distributio

Re: Hi, bug report/feature request

2007-10-08 Thread Johan Almqvist
Peter J. Holzer wrote: sub fqdn { my $local = hostname(); return $local unless _is_short($local); return ( gethostbyname($local) )[0] || $local; } [...] It works on your particular Linux distribution. On some distributions it might return the short name or even "localhost", dep

Re: Hi, bug report/feature request

2007-10-07 Thread Peter J. Holzer
On 2007-10-07 11:49:05 -0500, Dave Rolsky wrote: > I've written code to get the fqdn from just the hostname that works > provided is working in a sane way: > > sub fqdn { > my $local = hostname(); > > return $local unless _is_short($local); > > return ( gethostbyname($local) )[

Re: Hi, bug report/feature request

2007-10-07 Thread Guy Hulbert
On Sun, 2007-10-07 at 11:49 -0500, Dave Rolsky wrote: > > Returns the non-qualified hostname (at least on this Solaris). I guess > > when > > it boils down to it, this machine is misconfigured. Sigh. > > I'm pretty sure that returning just the hostname without the domain name > is not a misco

Re: Hi, bug report/feature request

2007-10-07 Thread Dave Rolsky
On Wed, 3 Oct 2007, Chris Lewis wrote: Robin Bowes wrote: John Peacock wrote: I'm sure that there is a platform-independent way to get the hostname How about: use Sys::Hostname; $host = hostname; Returns the non-qualified hostname (at least on this Solaris). I guess when it boils down t

Re: Hi, bug report/feature request

2007-10-04 Thread Matt Sergeant
On 4-Oct-07, at 1:00 PM, Chris Lewis wrote: Chris Lewis wrote: Any idea why I'd be getting these: _convert_to_ssl failed (Could not create SSL socket: Socket operation on non-socket at ./plugins/tls line 158 [At end of _convert_to_ssl(), I'm logging $@ if it's non-null] I've confirmed, th

Re: Hi, bug report/feature request

2007-10-04 Thread Chris Lewis
Chris Lewis wrote: Any idea why I'd be getting these: _convert_to_ssl failed (Could not create SSL socket: Socket operation on non-socket at ./plugins/tls line 158 [At end of _convert_to_ssl(), I'm logging $@ if it's non-null] I've confirmed, this is only happening in qpsmtpd-async. It wo

Re: Hi, bug report/feature request

2007-10-04 Thread Matt Sergeant
On 4-Oct-07, at 7:59 AM, Chris Lewis wrote: Sending here. Code shamelessly stolen from qpsmtpd-forkserver Thanks. Applied. __ This email has been scanned by the MessageLabs Email Security System. For more information please

Re: Hi, bug report/feature request

2007-10-04 Thread Chris Lewis
Matt Sergeant wrote: On 3-Oct-07, at 5:25 PM, James Turnbull wrote: Chris Lewis wrote: I've hacked qpsmtpd-async to support daemonization and pid locking files. Rather than dig into SVN, who should I send the modified copy to? Matt? Chris Since no one else answered the question I'd recomm

Re: Hi, bug report/feature request

2007-10-03 Thread John Peacock
Chris Lewis wrote: > Any idea why I'd be getting these: > > _convert_to_ssl failed (Could not create SSL socket: Socket operation on > non-socket at ./plugins/tls line 158 > > [At end of _convert_to_ssl(), I'm logging $@ if it's non-null] > > It may be that tls plugin's "init" method is NOT bein

Re: Hi, bug report/feature request

2007-10-03 Thread Ask Bjørn Hansen
On Oct 3, 2007, at 11:09, Chris Lewis wrote: Running 0.40 qpsmtpd-async as a spamtrap on both Linux and Solaris (2.8/2.9). [I use ordinary poll on Linux because my OS is too old] I've hacked qpsmtpd-async to support daemonization and pid locking files. Rather than dig into SVN, who shoul

Re: Hi, bug report/feature request

2007-10-03 Thread Matt Sergeant
On 3-Oct-07, at 5:25 PM, James Turnbull wrote: Chris Lewis wrote: I've hacked qpsmtpd-async to support daemonization and pid locking files. Rather than dig into SVN, who should I send the modified copy to? Matt? Chris Since no one else answered the question I'd recommend logging a ticket a

Re: Hi, bug report/feature request

2007-10-03 Thread James Turnbull
Chris Lewis wrote: > I've hacked qpsmtpd-async to support daemonization and pid locking > files. Rather than dig into SVN, who should I send the modified copy > to? Matt? > Chris Since no one else answered the question I'd recommend logging a ticket at http://code.google.com/p/smtpd/issues/lis

Re: Hi, bug report/feature request

2007-10-03 Thread Chris Lewis
John Peacock wrote: Chris Lewis wrote: I note that plugins/tls_cert clobbers the machine's name on Solaris. It issues `hostname --fqdn` in an attempt to find the machine's full name, and on Solaris, that's treated as setting the hostname to "--fqdn". Ouch. Sorry, that's my fault (but in m

Re: Hi, bug report/feature request

2007-10-03 Thread Chris Lewis
Robin Bowes wrote: John Peacock wrote: I'm sure that there is a platform-independent way to get the hostname How about: use Sys::Hostname; $host = hostname; Returns the non-qualified hostname (at least on this Solaris). I guess when it boils down to it, this machine is misconfigured. Sig

Re: Hi, bug report/feature request

2007-10-03 Thread Robin Bowes
John Peacock wrote: > > I'm sure that there is a platform-independent way to get the hostname How about: use Sys::Hostname; $host = hostname; R.

Re: Hi, bug report/feature request

2007-10-03 Thread John Peacock
Chris Lewis wrote: I note that plugins/tls_cert clobbers the machine's name on Solaris. It issues `hostname --fqdn` in an attempt to find the machine's full name, and on Solaris, that's treated as setting the hostname to "--fqdn". Ouch. Sorry, that's my fault (but in my defense, you should

Hi, bug report/feature request

2007-10-03 Thread Chris Lewis
Running 0.40 qpsmtpd-async as a spamtrap on both Linux and Solaris (2.8/2.9). [I use ordinary poll on Linux because my OS is too old] I've hacked qpsmtpd-async to support daemonization and pid locking files. Rather than dig into SVN, who should I send the modified copy to? Matt? I note th