Re: Plugin modules (My::Plugin) / plugins on CPAN

2006-07-13 Thread Philip M. Gollucci
Ask Bjørn Hansen wrote: # local %ENV = (); You don't want to do that in mp2 land. See the perl.apache.org lists for our struggles. [I realize its commented out] -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708

Re: Plugin modules (My::Plugin) / plugins on CPAN

2006-06-30 Thread David Wheeler
On Jun 27, 2006, at 22:57, Ask Bjørn Hansen wrote: Some time ago there was discussion about contributors distributing plugins on CPAN.I made a change so that should be possible. I didn't do more than the most basic testing, so I didn't commit it. Feedback welcome. Excellent! The

Re: Plugin modules (My::Plugin) / plugins on CPAN

2006-06-28 Thread Matt Sergeant
On 28-Jun-06, at 1:57 AM, Ask Bjørn Hansen wrote: 2) Make load_plugins or Qpsmtpd::Plugin smart enough that we won't need plugin_name in each plugin. That's a trivial change to your patch. Just make line 68 of the patch: + my $eval = require $package;\nsub ${plugin}::plugin_name

Re: Plugin modules (My::Plugin) / plugins on CPAN

2006-06-28 Thread Andrew Pam
On Wed, Jun 28, 2006 at 10:41:51AM -0400, Matt Sergeant wrote: + my $eval = require $package;\nsub ${plugin}::plugin_name { '$plugin' }; Why the \n? It seems to me that a space would be more readable and have the same effect. Regards, Andrew -- mailto:[EMAIL PROTECTED]

Re: Plugin modules (My::Plugin) / plugins on CPAN

2006-06-28 Thread Matt Sergeant
On 28-Jun-06, at 11:43 AM, Andrew Pam wrote: On Wed, Jun 28, 2006 at 10:41:51AM -0400, Matt Sergeant wrote: + my $eval = require $package;\nsub ${plugin}::plugin_name { '$plugin' }; Why the \n? It seems to me that a space would be more readable and have the same effect. Bikeshed