Re: [PATCH] tweak QP's header handling for messages with no body

2011-08-16 Thread Matt Sergeant
Yup there's a lot of this going around right now. Just to be explicit though, the header lines end in \r\r\n. Worth rejecting the bloody lot, frankly :) Chris LewisAugust 15, 2011 4:21 PM As a FYI, I've been seeing bot-emitted spam that appears to have extra \r at the end of

Re: [PATCH] tweak QP's header handling for messages with no body

2011-08-16 Thread Jared Johnson
There's already a special case for something similar to this: # Reject messages that have either bare LF or CR. rjkaes noticed a # lot of spam that is malformed in the header. ($_ eq .\n or $_ eq .\r) and $self-respond(421, See http://smtpd.develooper.com/barelf.html;)

Re: [PATCH] tweak QP's header handling for messages with no body

2011-08-16 Thread Chris Lewis
On 8/16/2011 11:28 AM, Matt Sergeant wrote: Yup there's a lot of this going around right now. Just to be explicit though, the header lines end in \r\r\n. Worth rejecting the bloody lot, frankly :) True enough, but you know well that I want a bit more out of my spam than just to throw it away

Re: [PATCH] tweak QP's header handling for messages with no body

2011-08-16 Thread Matt Sergeant
That line of code doesn't look at the headers though, just at the final dot at the end-of-data. Jared JohnsonAugust 16, 2011 3:00 PM There's already a special case for something similar to this:# Reject messages that have either bare LF or CR. rjkaes noticed a# lot of spam

Re: [PATCH] tweak QP's header handling for messages with no body

2011-08-16 Thread Jared Johnson
True, I was led astray by the comment that seemed to indicate it was all about headers. if the intention of the comment is correct, then it should probably if ( $in_header and ... ), whether or not the new regex is added. That block would also need to be moved to after the block that sets