[quagga-dev 12505] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-27 Thread Nicolas Dichtel
Le 27/05/2015 03:26, Xiaorong (Andrew) Qu a écrit : Hi Jafar, Either way of merging should work. As for terminology, using your example VRF 3 table 2 is not ideal to me. I would like netns 3|blue table 2 as netns is the keyword for namespace anyway. That is right, what I am working on is

[quagga-dev 12507] [PATCH] bgpd: peer_uptime overflows after 1 year

2015-05-27 Thread Paul Jakma
* bgpd.c: (peer_uptime) Wraps after 1 year, and doesn't indicate years. Fix. Assume a year is 365 days, for an easy life - not displaying the hours in that case anyway. Fixes: Bug #836 Reported-by: Rolf Hanßen --- bgpd/bgpd.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

[quagga-dev 12512] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

2015-05-27 Thread Paul Jakma
So something like the below to go before your patch (probably a good few of the types could be removed - I removed the ones that seemed obviously defunct to me (EcoNet, Chaos, the Linux Prism driver type), probably a good few more, if anyone knows - e.g. PRONet, ARCNet, MetriCom ??). commit

[quagga-dev 12511] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-27 Thread Jafar Al-Gharaibeh
On 5/27/2015 3:49 AM, Nicolas Dichtel wrote: Le 27/05/2015 03:26, Xiaorong (Andrew) Qu a écrit : Hi Jafar, Either way of merging should work. As for terminology, using your example VRF 3 table 2 is not ideal to me. I would like netns 3|blue table 2 as netns is the keyword for namespace

[quagga-dev 12514] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-27 Thread David Lamparter
On Wed, May 27, 2015 at 12:11:52PM +0200, Vincent JARDIN wrote: Until now, I did prefer to stay quite to avoid confusions. 1- I understand that there is a consensus on this contribution (both approaches Single Daemon and Multi Daemon make sense and can coexist), 2- my review of the code

[quagga-dev 12517] Re: [PATCH 2/2] lib/privs: Don't use CAP_NET_BROADCAST

2015-05-27 Thread David Lamparter
On Wed, May 13, 2015 at 01:59:18PM +0200, Christian Franke wrote: From what I can tell, CAP_NET_BROADCAST has never been required for any functionality in the Linux kernel, so we do not really need it. Both patches applied, thanks! -David ___

[quagga-dev 12519] Re: [PATCH] lib/sockunion.c wrong #define used

2015-05-27 Thread David Lamparter
On Wed, May 13, 2015 at 08:34:46PM -0400, Donald Sharp wrote: The #define IPV6_MINHOPCNT define is never defined on any unix platform. From what I can tell the original implementation on the linux platform was IPV6_MINHOPCNT, when it got accepted into the mainstream kernel it was transformed

[quagga-dev 12521] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

2015-05-27 Thread Paul Jakma
On Wed, 27 May 2015, David Lamparter wrote: I'd prefer removing *way* more values, If something is clearly defunct and never used, there's no point having it, no. I think we should have two fields: hw_addr_type, identifying the type of information that hw_addr contains, and hw/ll_type,

[quagga-dev 12520] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

2015-05-27 Thread David Lamparter
On Wed, May 27, 2015 at 05:21:52PM +0100, Paul Jakma wrote: So something like the below to go before your patch (probably a good few of the types could be removed - I removed the ones that seemed obviously defunct to me (EcoNet, Chaos, the Linux Prism driver type), probably a good few more,

[quagga-dev 12500] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

2015-05-27 Thread David Lamparter
On Tue, May 26, 2015 at 10:27:54PM +0100, Paul Jakma wrote: On Tue, 26 May 2015, David Lamparter wrote: The simple choice is using it as-is :) It's not that hard, I'll send something tomorrow. What'd really help is a if_gethwaddr() function in lib/if.c, because in isisd/isis_circuit.c:602,

[quagga-dev 12501] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

2015-05-27 Thread Timo Teras
On Wed, 27 May 2015 08:49:02 +0200 David Lamparter da...@opensourcerouting.org wrote: On Tue, May 26, 2015 at 10:27:54PM +0100, Paul Jakma wrote: On Tue, 26 May 2015, David Lamparter wrote: The simple choice is using it as-is :) It's not that hard, I'll send something tomorrow.

[quagga-dev 12528] [PATCH] pim: 'show debugging' collision

2015-05-27 Thread Donald Sharp
The 'show debugging' cli as setup by pim collided with 'show debugging isis'. Fix that and clean up cli help commands to actually display correctly. Signed-off-by: Donald Sharp sha...@cumulusnetworks.com --- pimd/pim_cmd.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

[quagga-dev 12529] [PATCH] Fixup of redhat control files to properly start pimd

2015-05-27 Thread Donald Sharp
--- redhat/quagga.sysconfig |1 + 1 file changed, 1 insertion(+) diff --git a/redhat/quagga.sysconfig b/redhat/quagga.sysconfig index 4d6ec5a..caa0fff 100644 --- a/redhat/quagga.sysconfig +++ b/redhat/quagga.sysconfig @@ -9,6 +9,7 @@ OSPFD_OPTS=-A 127.0.0.1 RIPD_OPTS=-A 127.0.0.1

[quagga-dev 12530] [PATCH] Cleanup of 'show ip mroute' command

2015-05-27 Thread Donald Sharp
The 'show ip mroute' in zebra_vty.c collided with the 'show ip mroute' command in pim_cmd.c. The 'show ip rpf' command is functionally equivalent to the zebra_vty.c 'show ip mroute'. Therefore remove the 'show ip mroute' command in zebra_vty.c. Signed-off-by: Donald Sharp

[quagga-dev 12502] Re: [PATCH 01/10] zebra: redistribute hw_type to connected daemons

2015-05-27 Thread David Lamparter
On Wed, May 27, 2015 at 09:56:03AM +0300, Timo Teras wrote: On Wed, 27 May 2015 08:49:02 +0200 David Lamparter da...@opensourcerouting.org wrote: On Tue, May 26, 2015 at 10:27:54PM +0100, Paul Jakma wrote: On Tue, 26 May 2015, David Lamparter wrote: The simple choice is using it as-is