[quagga-dev 12549] Re: [PATCH 00/10] preparation for nhrpd

2015-05-28 Thread David Lamparter
As they're rather simple & uncontended, I've applied 2,3,5,6,7: On Fri, May 22, 2015 at 01:40:54PM +0300, Timo Teräs wrote: > Timo Teräs (10): > privs: fix privilege dropping to use system defined groups > lib: allow caller to provide prefix storage in sockunion2hostprefix > sockunion: add a

[quagga-dev 12548] [PATCH] Add code to extract.pl.in to prevent further cli function overwrites

2015-05-28 Thread Donald Sharp
Currently extract.pl.in is used to build the vtysh cli. When two different cli's collide with the same command name, the original cli is never called, because it is dropped. This code notes the silent drop and tracks the number of drops. If they change then the code will fail the build. If you

[quagga-dev 12547] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Vincent JARDIN
In a small experiment that I'm running now Quagga (zebra, ospfd, pimd) uses 9MB of RAM. if I start adding VRFs I'm going to hit a wall really quick. Right, memory will be an issue. Even worst, we have seen that time to start many daemons does not scale: https://lists.quagga.net/pipermail/qu

[quagga-dev 12546] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Joachim Nilsson
On 2015-05-28 17:45, Lennart Sorensen wrote: > On Thu, May 28, 2015 at 03:36:30PM +0100, Paul Jakma wrote: >> Are we on the same page with that? Or is there disagreement there? > As someone working on small embedded level boxes without lots of cpu > cores, the separate process per VRF is not desira

[quagga-dev 12545] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Jafar Al-Gharaibeh
On 5/28/2015 11:35 AM, Paul Jakma wrote: On Thu, 28 May 2015, Lennart Sorensen wrote: As someone working on small embedded level boxes without lots of cpu cores, the separate process per VRF is not desirable at all. One process with one config interface running in multiple namespaces is ide

[quagga-dev 12542] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Jafar Al-Gharaibeh
Lennart, I agree. I Kinda made the same statements in earlier emails. I also don't have a strong opinion against moving VRF creation/management to a new daemon. Unlike other protocol daemons that need to be replicated across different VRFs creating a scalability concern on some platforms, a V

[quagga-dev 12544] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Jafar Al-Gharaibeh
On 5/28/2015 11:29 AM, Jafar Al-Gharaibeh wrote: Lennart, I agree. I Kinda made the same statements in earlier emails. I also don't have a strong opinion against moving VRF creation/management to a new daemon. Unlike other protocol daemons that need to be replicated across different VRFs crea

[quagga-dev 12543] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Paul Jakma
On Thu, 28 May 2015, Lennart Sorensen wrote: As someone working on small embedded level boxes without lots of cpu cores, the separate process per VRF is not desirable at all. One process with one config interface running in multiple namespaces is ideal for us (and in fact what we are currentl

[quagga-dev 12541] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Lennart Sorensen
On Thu, May 28, 2015 at 03:36:30PM +0100, Paul Jakma wrote: > Hi Vincent, > > I still have some stuff I need addressed, to be "sold" on. > > First off, we need to discus the end-destination. As it may be very > difficult, if not impossible, to agree on the next step if we're not > agreed on the d

[quagga-dev 12540] Re: [PATCH 04/10] lib: make stream.h lighter to include

2015-05-28 Thread Paul Jakma
On Thu, 28 May 2015, Timo Teras wrote: As alternative, I would then move encoding/decoding of all the complicated structures to where is defined. That is stream_put_prefix() should go in prefix.h (perhaps renamed to prefix_something). The problem is that it's not practical to assume that strea

[quagga-dev 12539] Re: [PATCH 08/10] zebra: make ZEBRA_FLAG_CHANGED internal status

2015-05-28 Thread Paul Jakma
ack -- Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A Fortune: "One's never alone with a rubber duck. " ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 12538] Re: [PATCH 07/10] route table: constify some APIs

2015-05-28 Thread Paul Jakma
Ack -- Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A Fortune: What makes the universe so hard to comprehend is that there's nothing to compare it with. ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/

[quagga-dev 12536] Re: [PATCH 04/10] lib: make stream.h lighter to include

2015-05-28 Thread Timo Teras
On Thu, 28 May 2015 15:53:38 +0100 (BST) Paul Jakma wrote: > On Fri, 22 May 2015, Donald Sharp wrote: > > > I would buy the faster build time if the header wasn't actually > > needed. To take the argument to it's logical conclusion just > > define everything you need right in the c code instead

[quagga-dev 12537] Re: [PATCH 06/10] zebra: simplify redistribution code

2015-05-28 Thread Paul Jakma
Ack. On Fri, 22 May 2015, Timo Teräs wrote: Merge the conditionals as one to avoid code duplication. Signed-off-by: Timo Teräs regards, -- Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A Fortune: About the only thing we have left that actually discriminates in favor of the plain pe

[quagga-dev 12535] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Paul Jakma
On Thu, 28 May 2015, Paul Jakma wrote: daemons, for a use-case that does need the client-daemons to be modified? s/does need/does not need/ regards, -- Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A Fortune: Don't hit the keys so hard, it hurts.

[quagga-dev 12534] Re: [PATCH 04/10] lib: make stream.h lighter to include

2015-05-28 Thread Paul Jakma
On Fri, 22 May 2015, Donald Sharp wrote: I would buy the faster build time if the header wasn't actually needed. To take the argument to it's logical conclusion just define everything you need right in the c code instead of using headers if we are after faster compile time. If there are namesp

[quagga-dev 12533] Re: [PATCH 02/10] privs: fix privilege dropping to use system defined groups

2015-05-28 Thread Paul Jakma
On Fri, 22 May 2015, Timo Teräs wrote: It may be requred for quagga process to belong to additional groups. E.g. nhrp module will need to talk to strongSwan using vici and may require additional permissions. Initialize groups from the system group database. Signed-off-by: Timo Teräs Ack. re

[quagga-dev 12532] Re: [PATCH v3 00/22] VRF support in quagga

2015-05-28 Thread Paul Jakma
Hi Vincent, I still have some stuff I need addressed, to be "sold" on. First off, we need to discus the end-destination. As it may be very difficult, if not impossible, to agree on the next step if we're not agreed on the destination. There seemed to wide agreement that in a perfect world we