[quagga-dev 15236] Re: git archive error.

2016-05-06 Thread Donald Sharp
Your missing some part of the git package. Probably git-buildpackage? What does dpkg -l | grep git return? donald On Fri, May 6, 2016 at 8:35 AM, dexter i wrote: > i'm following the quagga hacking guide. As per the guide when i run the > following > command, i'm getting this error. can someone

[quagga-dev 15235] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

2016-05-06 Thread Donald Sharp
Either would be fine from my perspective too. donald On Fri, May 6, 2016 at 8:33 AM, Lou Berger wrote: > > > On 5/6/2016 8:29 AM, Donald Sharp wrote: > > I agree with Lou that this is a good thing to do. If necessary to get > > this in, I wouldn't be adverse to having a compile time option to

[quagga-dev 15234] git archive error.

2016-05-06 Thread dexter i
i'm following the quagga hacking guide. As per the guide when i run the following command, i'm getting this error. can someone tell me what is missing here. git archive --remote=git://code.quagga.net/quagga.git --prefix=quagga-release/ master | tar -xf - bash: git-archive: command not found tar: T

[quagga-dev 15233] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

2016-05-06 Thread Lou Berger
On 5/6/2016 8:29 AM, Donald Sharp wrote: > I agree with Lou that this is a good thing to do. If necessary to get > this in, I wouldn't be adverse to having a compile time option to > control for people who may be interested. > I like command line flag better, but would be okay with configure opt

[quagga-dev 15232] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

2016-05-06 Thread Donald Sharp
I agree with Lou that this is a good thing to do. If necessary to get this in, I wouldn't be adverse to having a compile time option to control for people who may be interested. Although if you are not rotating your logs, I'm not sure that I care that your log file suddenly has more info in it.

[quagga-dev 15231] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

2016-05-06 Thread Lou Berger
Actually, as this is a security feature it shouldn't be runtime reconfigurable so a program flag is probably more appropriate. Lou On May 6, 2016 7:58:45 AM Lou Berger wrote: Paul, There are different use cases/objectives out there. How about adding configuration to disable command loggin

[quagga-dev 15230] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

2016-05-06 Thread Lou Berger
Paul, There are different use cases/objectives out there. How about adding configuration to disable command logging? E.g. 'no command logging' Lou On May 6, 2016 5:50:46 AM Paul Jakma wrote: Hi Lou, Logging every command unconditionally causes issues with spam to the logs - not all comm

[quagga-dev 15229] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

2016-05-06 Thread Paul Jakma
Hi Lou, Logging every command unconditionally causes issues with spam to the logs - not all commands are interesting (especially not any regular monitoring commands). Can we fix this? :) regards, -- Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A Fortune: The days are all empty and