lib/zebra.h has FILTER_X #define's. These do not belong there.
Put them in lib/filter.h where they belong.
Signed-off-by: Donald Sharp
---
bgpd/bgp_advertise.c|1 +
bgpd/bgp_aspath.c |1 +
bgpd/bgp_attr.c |1 +
bgpd/bgp_btoa.c |
lib/zebra.h has a hodge-podge of different api's in it.
Start the refactoring.
Donald Sharp (3):
lib, bgpd: Remove 'struct fifo' from lib/zebra.h
lib, bgpd: Fixup afi_t to be an enum and cleanup zebra.h
lib, bgpd, tests: Refactor FILTER_X in zebra.h
bgpd/bgp_advertise.
Vincent -
Vipin and I are working on breaking the patch up now to get the data
structures in place upstream. Hopefully in the next week or so.
Sami -
The code will just work if there is no kernel vrf support, ie everything
will just be in the default vrf. I'm not aware of any work being done i
The 'struct fifo' and it's accompanying #defines do not
belong in lib/zebra.h. Move them into their own header.
Signed-off-by: Donald Sharp
---
bgpd/bgp_advertise.h |2 ++
lib/fifo.h | 62 ++
lib/zebra.h
lib/zebra.h has FILTER_X #define's. These do not belong there.
Put them in lib/filter.h where they belong.
Signed-off-by: Donald Sharp
---
bgpd/bgp_advertise.c|1 +
bgpd/bgp_aspath.c |1 +
bgpd/bgp_attr.c |1 +
bgpd/bgp_btoa.c |
Comments inline...
On Thu, Jan 7, 2016 at 8:09 AM, 林守磊 wrote:
> diff --git a/lib/table.h b/lib/table.h
> index ab357a0..946fcb2 100644
> --- a/lib/table.h
> +++ b/lib/table.h
> @@ -53,6 +53,7 @@ struct route_table_delegate_t_
> struct route_table
> {
>struct route_node *top;
> + int tabl
I'm curious. What's your specific reasoning for wanting to do this?
All incoming routes from the linux kernel in rt_netlink.c eventually call
rib_add_ipv[4|6] or rib_add_ipv4_multipath.
gate is assigned on lines 729 and 932 of rt_netlink.c.
An ipv4 address is stored as a struct in_addr. gate i
Wed, Jan 6, 2016 at 1:17 PM, Timo Teras wrote:
> On Tue, 5 Jan 2016 10:16:28 + (GMT)
> Paul Jakma wrote:
>
> > On Mon, 4 Jan 2016, Donald Sharp wrote:
> >
> > > Doesn't 'enum zebra_link_type' actually belong in lib/if.h?
> > > instead of
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> Signed-off-by: Lou Berger
> ---
> doc/bgpd.texi | 25 +
> 1 file changed, 25 insertions(+)
>
> diff --git a/doc/bgpd.texi b/doc/bgpd.texi
> index 5eb0851..02098
HAVE_IPV6 introduced. Otherwise looks good.
donald
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> This patch set adds show commands in the form
>show bgp ...
>
> Signed-off-by: Lou Berger
> ---
> bgpd/bgp_mplsvpn.c | 406
> ++-
I see HAVE_IPV6 introduced, this should be removed.
should bgp_node_safi be a switch statement?
donald
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> This is part of the core VPN and Encap SAFI changes.
>
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> bgpd/bgp_vt
I wouldn't have blinked at either of those levels Sooo..
LOG_NOTICE?
donald
On Wed, Jan 6, 2016 at 9:08 AM, Lou Berger wrote:
> fair enough, LOG_NOTICE or LOG_INFO?
>
> On 1/6/2016 8:57 AM, Donald Sharp wrote:
> > Ok, different use case. Why the LOG_EMERG? I
:
> case BGP_VPNV6_NODE:
> safi = SAFI_MPLS_VPN;
> break;
> case BGP_IPV4M_NODE:
> case BGP_IPV6M_NODE:
> safi = SAFI_MULTICAST;
> break;
> default:
> safi = SAFI_UNICAST;
> break;
> }
> return safi;
> }
>
Ok, different use case. Why the LOG_EMERG? I think this should be
protected by a knob of some sort. Does every cli need to be saved no
matter what?
donald
On Wed, Jan 6, 2016 at 8:42 AM, Lou Berger wrote:
>
>
> On 1/6/2016 8:13 AM, Donald Sharp wrote:
> > Why is this appro
Hit send too soon. To finish off my point. If we ever get smart and move
the #defines to an enum then the switch statement would allow us to catch
missed new states via compiler warnings.
donald
On Wed, Jan 6, 2016 at 8:52 AM, Donald Sharp
wrote:
> Then
>
> switch (vty->node)
Then
switch (vty->node)
{
case :
case :
return AFI_IP6;
default:
return AFI_IP;
}
donald
On Wed, Jan 6, 2016 at 8:48 AM, Lou Berger wrote:
> Donald,
> Thanks for the review. See below.
>
> On 1/6/2016 8:31 AM, Donald Sharp wrote:
> > Comments Inline..
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> This is part of the core VPN and Encap SAFI changes.
>
> Add code to print ENCAP communities.
>
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> bg
Comments Inline
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> This is part of the core VPN and Encap SAFI changes.
>
> diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
> index 5330a22..20aaec6 100644
> --- a/bgpd/bgp_vty.c
> +++ b/bgpd/bgp_vty.c
> @@ -56,8 +56,15 @@ extern struct in_addr
I'm in agreement that the machineparse variable should be dropped. If we
are going to go down the path of machine parsing I would prefer that we
implement something fairly industry standard, like json.
donald
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> [DL: the machineparse foo should
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> bgpd/bgp_network.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bgpd/bgp_network.c b/bgpd/bgp_netw
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> This is part of the core VPN and Encap SAFI changes.
>
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> bgpd/bgp_nexthop.h | 9 +
> 1 file changed, 9 insertions(+)
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> To facilitate debugging and operation.
>
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> lib/command.c | 35 +++
> 1 file changed, 35 inserti
Why is this approach better than touching ~/.history_quagga or modifying
the logging code in vtysh_main.c to log this information where you want?
donald
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> To facilitate debugging and operation.
>
> Signed-off-by: Lou Berger
> Signed-off-by: Da
on of
this patch is? Why only route-maps are we worrying about sub-modes?
donald
On Mon, Jan 4, 2016 at 10:45 PM, Lou Berger wrote:
> Isn't that the purpose of exit? The command ' already there, it's just
> missing from config_write...
>
> Lou
>
> On January 4,
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> zebra/redistribute.c | 18 --
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/zebra/r
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
> zebra/kernel_socket.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/zebra/kernel_socket.c b/zebra/kernel_soc
Why not use '!' instead of 'exit'. I assume the goal is to signal that we
are done route-map input.
I would prefer that we come up with a methodology to handle this for all
end blocks, instead of just for route-maps.
donald
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> The last route-m
Acked-by: Donald Sharp
On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger wrote:
> There was no way to actually set ZEBRA_DEBUG_DETAIL, even though some
> debug output was conditional to it. Add CLI command.
>
> Signed-off-by: Lou Berger
> Signed-off-by: David Lamparter
> ---
&g
Doesn't 'enum zebra_link_type' actually belong in lib/if.h? instead of
lib/zebra.h?
donald
On Sat, Dec 26, 2015 at 4:38 AM, Timo Teräs wrote:
> This removes the BSD specific usage of struct sockaddr_dl
> hardware address. This unifies to use explict hw_addr member for
> the address, and zebra
Acked-by: Donald Sharp
On Wed, Dec 23, 2015 at 9:47 AM, Timo Teräs wrote:
> FIB override routes are for routing protocols that establish
> shortcut routes, or establish point-to-point routes that should
> not be redistributed. Namely this is useful NHRP daemon to come.
>
> Zebra
Acked-by: Donald Sharp
On Wed, Dec 23, 2015 at 9:47 AM, Timo Teräs wrote:
> It simplifies things as we can do atomic replace of route prefix.
> And it seems there's some race condition somewhere that can result
> in an incorrect change request leaving prefixes in kernel wh
My original comment still stands:
I agree that your use of finer grained RT_SCOPE_LINK and RT_SCOPE_UNIVERSE
is a good thing. My only real problem with the patch was the removal of
this line:
- resolved_hop->flags |= NEXTHOP_FLAG_ONLINK;
Put it back and I believe we wo
Timo -
Sorry for the delay in looking at this. Xmas and all that :)
netlink_route_multipath -> Does this need the 4th parameter? Why not just
depend on the prefix?
kernel_rtm_ipv4 & _ipv6 -> Same comment family is never used.
kernel_route_rib adds a HAVE_IPV6. This is not needed anymore.
Loo
I would think it's a bit much. Modifying the cli is starting to become a
major pain in the ass as it stands now. On the other hand patches are
accepted :)
donald
On Thu, Dec 24, 2015 at 12:45 PM, Kei Nohguchi wrote:
> >> So, I assume you are fine with changing zebra commands (such as this)
>
Just don't use the keyword. It's optional.
just like
ip route X/Y vrf distance tag
donald
On Thu, Dec 24, 2015 at 7:29 AM, Lou Berger wrote:
> What's form of the commands when there are no VRFs in use?
>
> Lou
>
> On December 23, 2015 2:28:50 PM Vipin Kumar
> wrote:
>
>> Thanks Nicolas.
7;s part of the take-X branch series now in it's 'proper' place as
part of the patch tree. I'm going to include it there. It is what it is.
I have 100's of patches I'm tracking and this is the way it's going to be.
> On Fri, 2015-12-11 at 18:52 -0500, Donald Sh
They are in table.c: route_node_match and route_node_lookup. I suspect
there will need to be some fairly serious rewrite of the code in order to
take advantage of GPU's.
The reality though is that I don't think these are the current bottlenecks
in handling large #'s of routes and peers in the cod
I applied the patch and ran my smoke test here is the new core that I am
getting:
[New LWP 5727]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/powerpc-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/quagga/ospfd --daemon -A 127.0.0.1'.
Program te
gt; On Thu, 17 Dec 2015, Donald Sharp wrote:
>
> Joakim :
>>
>> I am experiencing issues with an ospf crash associated with this bug:
>>
>> commit 5c1791f28e2e831e4e9b92c3c2f7d8ed832cb968
>> Author: Joakim Tjernlund
>> Date: Fri Apr 25 14:36:16 2014 +0200
&
It shipped and then got shelved because it was available on one platform
and no-one was using it.
But yes I spent a large amount of time getting it to work under EIGRP :)
donald
On Sun, Dec 20, 2015 at 8:55 AM, Daniel Walton
wrote:
>
>
> On Fri, Dec 18, 2015 at 7:24 PM, Jafar Al-Gharaibeh
> w
; > On Thu, 2015-12-17 at 14:11 -0500, Donald Sharp wrote:
> > > Joakim :
> > >
> > > I am experiencing issues with an ospf crash associated with this bug:
> > >
> > > commit 5c1791f28e2e831e4e9b92c3c2f7d8ed832cb968
> > > Author: Joaki
Joakim :
I am experiencing issues with an ospf crash associated with this bug:
commit 5c1791f28e2e831e4e9b92c3c2f7d8ed832cb968
Author: Joakim Tjernlund
Date: Fri Apr 25 14:36:16 2014 +0200
ospfd: PointToPoint neighbors are identified by router ID
According to RFC 2328, section 10.5
Matthias -
No immediate plans to freeze features, but we wanted to start thinking
about it and for people to start thinking about what we can do to finish it
off.
donald
On Wed, Dec 16, 2015 at 2:38 AM, Matthias Waehlisch <
m.waehli...@fu-berlin.de> wrote:
> Hi,
>
> On Tue, 15 D
Yes remove them.
donald
On Thu, Dec 17, 2015 at 4:27 AM, Paul Jakma wrote:
> On Wed, 16 Dec 2015, Donald Sharp wrote:
>
> Both HAVE_OPAQUE_LSA and HAVE_OSPF_TE are turned on by default
>> and a user has to explicitly turn them off. They both
>> are pretty standard
HAVE_OPAQUE_LSA is used by default and you have to actively turn it off
except that OPAQUE_LSA is an industry standard and used pretty much
everywhere. There is no need to have special #defines for this anymore.
Signed-off-by: Donald Sharp
---
configure.ac | 15
Remove from ospf the HAVE_OSPF_TE define and just always have
ospf traffic engineering.
Signed-off-by: Donald Sharp
---
configure.ac|6 --
ospfd/ospf_opaque.c |6 --
ospfd/ospf_te.c |4
3 files changed, 16 deletions(-)
diff --git a/configure.ac b
Both HAVE_OPAQUE_LSA and HAVE_OSPF_TE are turned on by default
and a user has to explicitly turn them off. They both
are pretty standard items to have in ospf.
Donald Sharp (2):
ospfd: Remove HAVE_OPAQUE_LSA
ospfd: Remove HAVE_OSPF_TE
configure.ac | 21
We tested this code with 300 peers and the cpu for bgp was under 5%. We
don't have access to low end devices, although we do run on some slower
power-pc's. Have either of you actually tested this and we have actual
data to back this up?
donald
On Wed, Dec 16, 2015 at 5:12 AM, Nick Hilliard wro
Do we have a document that explains the numbering scheme? Cause I don't
understand it, as an example, why wouldn't have vrf functionality merited a
full major version rev?
donald
On Wed, Dec 16, 2015 at 4:34 AM, Paul Jakma wrote:
> On Wed, 16 Dec 2015, Timo Teras wrote:
>
> I do hope that we c
; the scope of SDN PCE based solution. But, we are also interested in Quagga
> as a whole for standard routing function in the scope of SDN/NFV evolution.
>
> Regards,
>
> Olivier
>
> Le 15/12/2015 16:12, Donald Sharp a écrit :
>
> Thanks for attending everyone! Here a
All -
We are attempting to wrap up the .99.25 development cycle. If you have a
patch that you want included now would be a great time to forward it to the
list. If you have a concern about the contents of .99.25 now would be a
good time to speak up. :)
thanks!
donald
__
ul Jakma wrote:
> On Tue, 15 Dec 2015, Donald Sharp wrote:
>
> Martin -
>>
>> As discussed in the meeting today here is an example of a bogus issue:
>>
>>
>> https://ci1.netdef.org/artifact/QUAGGA-QMASTER/shared/build-82/static_analysis/report-8a9e85.html#EndPat
Martin -
As discussed in the meeting today here is an example of a bogus issue:
https://ci1.netdef.org/artifact/QUAGGA-QMASTER/shared/build-82/static_analysis/report-8a9e85.html#EndPath
Basically the error message boils down to this code construct:
struct prefix p;
if (afi == v4)
set p appro
Thanks for attending everyone! Here are some notes:
Attendees:
Martin, Vincent, Paul, Donald, Daniel, Don, Jafar, Michael, Balaji, Kei,
David Bond
Goals - monthly meeting on Quagga plans
Maintainer's status
Contributors issues
When's the next release:
Paul Jakma
Nack on zserve fix from 6win
rify after it’s on the git.
>
> - Martin
>
>
> On 11 Dec 2015, at 19:40, Donald Sharp wrote:
>
> Martin -
>>
>> Thanks for finding this.
>>
>> Fixed in commit 67b07279bf38db853aab1265bf61fdcb9dfcda4e
>>
>> donald
>>
>> O
1560)
> at linklist.c:266
> #8 0x000077b61ea8 in ospf_write (thread=0x7fffe560) at
> ospf_packet.c:815
> #9 0x778dea39 in thread_call (thread=0x7fffe560) at
> thread.c:1266
> #10 0x004019eb in main (argc=1, argv=0x7fffe6c8) at
> ospf_main
From: Daniel Walton
Signed-off-by: Daniel Walton
---
bgpd/bgp_attr.c | 5 +++--
bgpd/bgp_attr.h | 2 +-
bgpd/bgp_route.c | 14 --
3 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index c4c6cc8..f12f757 100644
--- a/bgpd/bgp_attr.c
route-map.
Currently, the application acts on route-map in or out and on unsuppress
maps.
Signed-off-by: Dinesh G Dutt
Signed-off-by: Donald Sharp
---
bgpd/bgp_route.c | 373 ++-
1 file changed, 316 insertions(+), 57 deletions(-)
diff --git a
he RIB into BGP/OSPF.
- setting tags when redistribing routes from the RIB into BGP/OSPF.
Signed-off-by: Daniel Walton
Signed-off-by: Piotr Chytla
Signed-off-by: Donald Sharp
---
ospfd/ospf_asbr.c | 5 +-
ospfd/ospf_asbr.h | 3 +-
ospfd/ospf_lsa.c |
changed only in the outgoing attributes to the
peers, it doesn't modify any MED specific state of the attributes in BGP on
the local node.
Signed-off-by: Vipin Kumar
Reviewed-by: Daniel Walton
Signed-off-by: Donald Sharp
---
bgpd/bgp_attr.c | 5 +-
bgpd/bgp_fsm.c | 121 +++
he RIB into BGP/OSPF.
- setting tags when redistribing routes from the RIB into BGP/OSPF.
BGP also supports setting a tag via a table-map, when installing BGP
routes into the RIB.
Signed-off-by: Daniel Walton
Signed-off-by: Piotr Chytla
Signed-off-by: Donald Sharp
---
bgpd/bgp_attr.c | 3
rom the RIB into BGP/OSPF.
- setting tags when redistribing routes from the RIB into BGP/OSPF.
BGP also supports setting a tag via a table-map, when installing BGP
routes into the RIB.
Signed-off-by: Daniel Walton
Signed-off-by: Piotr Chytla
Signed-off-by: Donald Sharp
---
ripd/rip_routemap.c
From: Ayan Banerjee
In the "write" direction added a command to ensure that Quagga
is able to send out K (=3 by default) packets per thread-write.
Signed-off-by: Ayan Banerjee
Reviewed-by: JR Rivers
---
ospfd/ospf_packet.c | 213
ospfd/ospf
ned-off-by: Piotr Chytla
Signed-off-by: Donald Sharp
---
bgpd/bgp_zebra.c | 51 +++
lib/zclient.c | 6 ++
lib/zclient.h | 5 +
ospfd/ospf_zebra.c | 6 ++
zebra/zserv.c | 28
5 files c
From: Ayan Banerjee
Modified the number of writes to service at most
20 interfaces.
Signed-off-by: Ayan Banerjee
Reviewed-by: Dinesh G Dutt
---
ospfd/ospf_packet.c | 54 ++---
ospfd/ospf_vty.c| 41
os
From: Dinesh Dutt
Quagga doesn't display default config as part of the running config, only
what is different from the default. However, in the case of rtadv, every
link displays the default "ipv6 nd suppress-ra" as part of running config.
This patch fixes that.
Signed-off-by: Dinesh Dutt
---
From: Dinesh Dutt
To support applying only differences to the existing config, this patch
enables supplying the appropriate end markers to a provided file (or
stdin). By end markers, I mean, adding "end" and "exit-address-family"
at the appropriate places in the configuration to ease finding the
From: Dinesh G Dutt
Set the RCVBUF and SNDBUF sizes to the maximum possible amount to
handle traffic under duress.
Signed-off-by: Dinesh G Dutt
Reviewed-by: Ayan Banerjee
---
ospfd/ospf_network.c | 36
1 file changed, 36 insertions(+)
diff --git a/ospfd/o
The vtysh commands:
service integrated-vtysh-config
hostname
were not being written to the /etc/quagga/Quagga.conf file with a wr mem
when service integrated-vtysh-config was issued. This patch fixes this
issue
Signed-off-by: Donald Sharp
---
vtysh/vtysh.c | 1 +
1 file changed, 1
From: Dinesh G Dutt
Currently, modifications to route maps do not affect already processed
routes; they only affect new route updates. This patch addresses this
limitation.
Signed-off-by: Dinesh G Dutt
Signed-off-by: Donald Sharp
---
bgpd/bgp_clist.c | 14 +-
bgpd/bgp_filter.c
From: Vipin Kumar
Signed-off-by: Vipin Kumar
Reviewed-by: Pradosh Mohapatra
Dinesh Dutt
Signed-off-by: Donald Sharp
---
bgpd/bgp_fsm.c | 6 +
bgpd/bgp_network.c | 23 ++--
bgpd/bgp_route.c | 322 +++-
bgpd/bgp_vty.c | 388
From: Daniel Walton
Paths with global and link-local nexthops should be considered for multipath
Signed-off-by: Daniel Walton
---
bgpd/bgp_mpath.c | 55 ++-
1 file changed, 38 insertions(+), 17 deletions(-)
diff --git a/bgpd/bgp_mpath.c b/bg
From: Vipin Kumar
When a route_node has multiple ospf6_routes under it (common subnet case),
then the current implementation has an issue in adjusting the route_node->info
on a ospf6_route_remove() call.
The main reason is that it ends up using exact match to determine if the next
ospf6_route be
From: Daniel Walton
The column headers for displaying OSPF neighbors are not aligned
Signed-off-by: Daniel Walton
---
ospfd/ospf_vty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
index 3548afb..b05f07b 100644
--- a/ospfd/ospf_vty.c
++
From: Vipin Kumar
If on-shutdown is configured to a large value and 'service quagga restart'
is executed, then the init.d/quagga script doesnt wait more than 120 seconds
for the daemon do stop, worse, it goes ahead and starts the new daemon
regardless. This can result into two ospfd processes run
From: Vivek Venkatraman
Ensure that if 'update-source ' is specified, that interface is
chosen as the source for the local nexthops. Otherwise, do a complete
match on the local IP address of the connection to determine the source
interface for the local nexthops; this will handle scenarios where
From: Vipin Kumar
This is to avoid a crash triggered by process termination
when ospf6d daemon is running and 'router ospf6' config has not been done yet.
Signed-off-by: Vipin Kumar
Reviewed-by: Daniel Walton
---
ospf6d/ospf6d.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ospf6d/osp
From: Daniel Walton
OSPF silently ignores 'no ip ospf hello-interval X' and 'no ip ospf
hello-interval X'
Signed-off-by: Daniel Walton
Reviewed-by: Dinesh G Dutt
---
ospfd/ospf_vty.c | 34 --
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/ospfd
From: Vipin Kumar
As per the RFC, when the NU bit is set, prefix should be ignored.
However, the code is currently ignoring prefix with LA bit too.
Fixing that part.
In future, we should also set LA bit for the loopback addresses. Not doing this
part right away, as quagga wont be backward compa
From: Dinesh Dutt
ANVL test 17.5. The current implementation wouldn't start sending LSReq unti
the DB Desc packets have all been received (no M bit). This caused the test
choke up. RFC 2328 allows for sending LSReq on receiving the first DbDesc
packet as long as the nbr state is Exchange. This pa
From: Daniel Walton
Signed-off-by: Daniel Walton
---
bgpd/bgp_route.c | 309 ---
bgpd/bgp_route.h | 7 ++
2 files changed, 279 insertions(+), 37 deletions(-)
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 9240497..972ec0e 100644
---
From: Vipin Kumar
ISSUE:
LSAcks (for directed acks) are being sent to neighbor's unicast address.
RFC 2328 says:
"The IP destination address for the packet is selected as
follows. On physical point-to-point networks, the IP
destination is always set to the address AllSPFRouters"
Fix is to
From: Daniel Walton
Signed-off-by: Daniel Walton
---
ospf6d/ospf6_asbr.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ospf6d/ospf6_asbr.c b/ospf6d/ospf6_asbr.c
index dc7f1ce..ec08ded 100644
--- a/ospf6d/ospf6_asbr.c
+++ b/ospf6d/ospf6_asbr.c
@@ -679,6 +679,15 @@ DEFUN (no_osp
From: Daniel Walton
If a BGP path has an unreachable nexthop display that path as invalid
Signed-off-by: Daniel Walton
---
bgpd/bgp_route.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 972ec0e..126dc11 100644
--- a/bgpd/bg
From: Vipin Kumar
Clear interface commands for ospfv3
Signed-off-by: Vipin Kumar
---
ospf6d/ospf6_interface.c | 60
ospf6d/ospf6_interface.h | 2 ++
ospf6d/ospf6d.c | 2 ++
3 files changed, 64 insertions(+)
diff --git a/ospf6d/ospf6_
> 12.12.12.12
12.12.12.12/32 -> 11.11.11.11
11.0.0.0/8 ->
- better statistics
Addresses upstream comments.
"show ip bgp nexthop detail" couldn't display multiple NHs due to a bug.
Fix that.
Fix reference counts for the nexthop cache entries
Signed-off-by: Pradosh
From: Vipin Kumar
SYMPTOM:
If some of the ospfv3 commands like 'show ipv6 ospf6 route' are executed
with ospf6d daemon running but before having any ospfv3 configuration, then
ospf6d crash is seen.
ISSUE:
There are a few show commands, which are (unlike others) not checking if
ospf6 instance i
From: Dinesh Dutt
The display of zebra client info is rather paltry: just the name and the FD.
For troubleshooting and general helpfulness, its useful to gather more info
about each client and display that. This patch does just that.
Signed-off-by: Dinesh Dutt
---
zebra/redistribute.c | 50 ++
ned-off-by: Dinesh Dutt
Signed-off-by: Donald Sharp
---
lib/route_types.pl | 23 +-
zebra/rib.h| 9 -
zebra/zebra_rib.c | 6 +-
zebra/zebra_rnh.c | 96 ++--
zebra/zebra_rnh.h | 3 +-
zebra/zebra_rnh_null.c | 2 +-
zebra/zebra_routem
From: Daniel Walton
Signed-off-by: Daniel Walton
---
bgpd/bgp_routemap.c | 20 ++--
ospf6d/ospf6_asbr.c | 6 +++---
ospfd/ospf_routemap.c | 31 +++
ripd/rip_routemap.c | 16
ripngd/ripng_routemap.c | 16
7.
Signed-off-by: Daniel Walton
Signed-off-by: Piotr Chytla
Signed-off-by: Donald Sharp
---
zebra/rib.h | 14 ++-
zebra/zebra_rib.c | 36 ---
zebra/zebra_vty.c | 294 --
3 files changed, 185 insertions(+), 159 deletions(-)
di
From: Vipin Kumar
Signed-off-by: Vipin Kumar
---
ospfd/ospf_main.c | 1 +
ospfd/ospf_vty.c | 45 +
ospfd/ospf_vty.h | 1 +
3 files changed, 47 insertions(+)
diff --git a/ospfd/ospf_main.c b/ospfd/ospf_main.c
index 1e4184f..dae0b8a 100644
--- a/os
From: Daniel Walton
Signed-off-by: Daniel Walton
---
bgpd/bgp_packet.c | 35 +++
bgpd/bgpd.c | 14 +-
bgpd/bgpd.h | 1 +
3 files changed, 45 insertions(+), 5 deletions(-)
diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
index b6744f9..
From: Daniel Walton
There were various failures in ANVL's aggregation tests
Signed-off-by: Daniel Walton
---
bgpd/bgp_aspath.c | 3 +++
bgpd/bgp_attr.c | 1 +
bgpd/bgp_route.c | 28 +++-
3 files changed, 23 insertions(+), 9 deletions(-)
diff --git a/bgpd/bgp_aspat
From: Vipin Kumar
This is a fix to make sure router-LSA is updated when neighbor's interface ID
change
is received in hello packet.
Signed-off-by: Vipin Kumar
---
ospf6d/ospf6_message.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/ospf6d/ospf6_message.c
From: Daniel Walton
Signed-off-by: Daniel Walton
---
bgpd/bgp_route.c | 5 ++-
bgpd/bgp_table.h | 1 +
bgpd/bgp_vty.c | 122 +++
3 files changed, 127 insertions(+), 1 deletion(-)
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index dc
From: JR Rivers
Section 16.0 of rfc2328 (OSPF) specifies that the short-path
calculation to a node should be constructed with the sum of all path
costs (metrics) to the node (pretty simple huh). There is a usage of
metric typified by the "max-metric router-lsa" command in many
networking stacks
From: Vipin Kumar
Block martian address configuration on an interface and also block from
getting installed into the zebra tables.
Idea behind the fix was to not allow martian address configurations in quagga
and also block any connected martian address installation coming from kernel
Signed-of
From: Daniel Walton
AS_PATH comparison is broken if CONFED_AS_SEQ are present
Signed-off-by: Daniel Walton
---
bgpd/bgp_aspath.c | 6 +-
bgpd/bgp_aspath.h | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/bgpd/bgp_aspath.c b/bgpd/bgp_aspath.c
index 3c8436e..11823e9 100
From: Ayan Banerjee
Add a null check to ensure that another thread
does not access the address in the deletion path
of the interface.
Signed-off-by: Ayan Banerjee
Reviewed-by: Dinesh G Dutt
---
ospfd/ospf_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ospfd/ospf_du
201 - 300 of 857 matches
Mail list logo
