On Wed, 25 Nov 2015, Donald Sharp wrote:

Shouldn't the BGP_NOTIFY_OPEN_ERR sub codes be an enum?

The main notify code could be, but there's not much value in the sub-code. Cause the bgp_notify_send function sub-code argument depends on the main code.

This way the compiler can help make sure we don't mess up passing in a wrong value.

It'd be nice, but I don't see an easy way to do it. You could have some kind of notify-codes object thing, that you could query for its sub-code, perhaps. And just pass that as the single argument. I guess.

regards,
--
Paul Jakma      p...@jakma.org  @pjakma Key ID: 64A2FF6A
Fortune:
It's stuck in the Web.

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to