On Tue, Apr 12, 2016 at 12:58:44PM +0100, Paul Jakma wrote:
> - Makes the SPF behaviour configurable with a
>
> "compatible max-metric (infinite|follow)"
The default state of this seems to be "infinite", which is not
RFC-compilant behaviour. There was unanimous consent in the monthly
meeting that RFC-compliant behaviour should be the default.
I also have the following review comments:
- I could not find a rationale for above new command in either the patch
description or inline comments. I do not see the utility of the
config switch, since:
- in a mixed domain of Quagga and other implementations, SPF is
already broken with possible loops. The negative impact of fixing
ospfd's behaviour may change a network from "broken in one way" to
"broken in another way", but the compat switch can't add any
guarantees.
- for a pure Quagga domain, there already is an easy migration path by
configuring 0xfffe instead, as you've pointed out. The
administrative effort of this is no lower or higher (ensuring proper
configuration on all routers) than the new switch.
So, since the proposed new switch adds complexity without providing
any benefit, it should not be implemented.
- H-bit support, while related by topic, should probably be split of
into its own separate patch. This is particularly relevant if a user
is unaware of the discussion on this topic and uses git-bisect to
debug the change in behaviour, which may lead them to the conclusion
H-bit broke their testbed or network.
So, unfortunately, this is a negative review. I have not reviewed
specific code changes (in part because H-bit and 0xffff changes were
mixed into one patch.)
Regards,
-David
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
