On Thu, Apr 21, 2016 at 12:33:50PM +0100, Paul Jakma wrote:
> The previous patch clearly is incomplete, based on the concerns of those
> proposing it and further analysis. Your review of the next patch seems
> to be missing some of the issues, while restating the issue driving this
> that makes the prior patch unsuitable.
My review of your patch argues that updating a Quagga-only setup can
transition through the same path that any mixed setup already is on.
The extra complexity of a special-case pure-Quagga network seems to
provide very little gain at a large cost -- especially since the default
remains at non-standard-compliance *and* will be saved as such in the
config. That means that, 5 years from now, some admin will be shooting
themselves in the foot with it just because some Quaggas on their
network have a saved config, and they're then using 6987 for the first
time.
The fact that we've only gotten one bug report in 9 years indicates to
me that there is a low number of 6987 users. This lends the assumption
that the number of Quagga-only setups using our borked version of 6987
is similarly low, if not lower. And -- they might break not only if a
router is updated; it might just as well be another vendor's router
being added.
Thus, my logical conclusion is still that simply fixing the issue and
issuing a problem description is the best path to progress on. What I
have in mind here, reduced to one and a half sentences, is:
"make sure you're not using OSPF max-metric in your network
until all Quaggas are version 1.xxxxx or newer; check before
upgrading."
>From that perspective, Cumulus' previous patch is perfectly fine. If I
haven't Ack'd it before, let me Ack it here.
Seeing your paraphrase of my review wasn't quite on-spot -- I'll work to
word my mails more aptly. Sometimes it might not be apparent, but if
anyone sees possible ambiguity in my mails, please don't hesitate to
point it out to me! I'll be happy to clarify.
Cheers,
-David
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
