Philippe, I've posted a fix to this (patch on patch) in
https://github.com/LabNConsulting/quagga-vnc/commit/cd54370cb94d598aa95bd7561cc012200920d97a If you can take a look and comment that would be great. My plan is to submit a v2 of the whole patch set once issues raised have been addressed. (this patch will be rolled into the larger vnc patch.) Thanks, Lou On 6/9/2016 4:42 AM, Lou Berger wrote: > Philippe, > > On 6/9/2016 4:15 AM, Philippe Guibert wrote: >> > On Wed, Jun 8, 2016 at 9:22 PM, Lou Berger <lber...@labn.net> wrote: >> > >> > Hi Lou, >>>> >>> * It seems the RD_TYPE_EOI type surfaced again (see >>>> >>> http://patchwork.quagga.net/patch/1728/ ), whereas I don't see where >>>> >>> it >>>> >>> is used. Is there a need to keep this flag ? >>> >> This is used by the ethernet code, see below. >>> >> >> > oh. It seems it is used decode_rd_type ? Would not it be better to set >> > explicitly the value to RD_TYPE_EOI instead of 0xff00 ? >> > >> > --- a/bgpd/bgp_mplsvpn.c >> > +++ b/bgpd/bgp_mplsvpn.c >> > @@ -52,7 +52,7 @@ decode_rd_type (u_char *pnt) >> > * VNC L2 stores LHI in lower byte, so mask it off >> > */ >> > if ((v & 0xff00) == 0xff00) >> > - v = 0xff00; >> > + v = RD_TYPE_EOI; >> > #endif >> > return v; >> > } > Good catch! I suspect this got changed internally when it was removed > from the first patch set and then not restored... > _______________________________________________ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev
