Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-20 Thread Martin Maechler
> Dirk Eddelbuettel > on Mon, 19 Jan 2015 16:35:31 -0600 writes: > On 19 January 2015 at 17:11, Duncan Murdoch wrote: > | The people who would have to maintain the patch can't test it. I agree that this is good reason to not add delicate code to the R sources, indeed, howe

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Felipe Balbi
Hi, On Mon, Jan 19, 2015 at 04:33:15PM -0800, Karl Millar wrote: > Felipe, > > CXXR development has moved to github, and we haven't fixed up the build for > using git yet.  Could you send a pull request with your change to the repo > at  > https://github.com/cxxr-devel/cxxr/? > > Also, this p

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Karl Millar via R-devel
Fellipe, CXXR development has moved to github, and we haven't fixed up the build for using git yet. Could you send a pull request with your change to the repo at https://github.com/cxxr-devel/cxxr/? Also, this patch may be useful for pqR too. https://github.com/radfordneal/pqR Thanks On Mon, J

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Dirk Eddelbuettel
On 19 January 2015 at 17:11, Duncan Murdoch wrote: | The people who would have to maintain the patch can't test it. I don't understand this. The patch, as we may want to recall, was all of +GIT := $(shell if [ -d "$(top_builddir)/.git" ]; then \ +echo "git"; fi) + and -

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Duncan Murdoch
On 19/01/2015 4:13 PM, Nathan Kurz wrote: > On Mon, Jan 19, 2015 at 1:00 PM, Felipe Balbi wrote: >> I just thought that such a small patch which causes no visible change to >> SVN users and allow for git users to build R would be acceptable, but if >> it isn't, that's fine too. > > Felipe --- >

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Joshua Ulrich
On Mon, Jan 19, 2015 at 3:13 PM, Nathan Kurz wrote: > On Mon, Jan 19, 2015 at 1:00 PM, Felipe Balbi wrote: >> I just thought that such a small patch which causes no visible change to >> SVN users and allow for git users to build R would be acceptable, but if >> it isn't, that's fine too. > > Feli

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Nathan Kurz
On Mon, Jan 19, 2015 at 1:00 PM, Felipe Balbi wrote: > I just thought that such a small patch which causes no visible change to > SVN users and allow for git users to build R would be acceptable, but if > it isn't, that's fine too. Felipe --- It would appear that you are unaware that you are wal

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Felipe Balbi
Hi, On Mon, Jan 19, 2015 at 03:44:45PM -0500, Duncan Murdoch wrote: > > git has an interface for cloning SVN repositories into git > > which some users might decide to use. For those users' > > surprise, the repository will always fail to build on > > svnonly target and it will e

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Duncan Murdoch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 19/01/2015 3:34 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 19, 2015 at 03:31:32PM -0500, Duncan Murdoch wrote: > git has an interface for cloning SVN repositories into git > which some users might decide to use. For those users'

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Kevin Ushey
On Mon, Jan 19, 2015 at 12:34 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 19, 2015 at 03:31:32PM -0500, Duncan Murdoch wrote: >> >>> git has an interface for cloning SVN repositories into git >> >>> which some users might decide to use. For those users' >> >>> surprise, the repository will alway

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Duncan Murdoch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 19/01/2015 3:20 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 19, 2015 at 03:06:11PM -0500, Duncan Murdoch wrote: >> On 19/01/2015 2:33 PM, Felipe Balbi wrote: >>> git has an interface for cloning SVN repositories into git >>> which some users m

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Felipe Balbi
Hi, On Mon, Jan 19, 2015 at 03:31:32PM -0500, Duncan Murdoch wrote: > >>> git has an interface for cloning SVN repositories into git > >>> which some users might decide to use. For those users' > >>> surprise, the repository will always fail to build on svnonly > >>> target and it will exit ear

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Felipe Balbi
Hi, On Mon, Jan 19, 2015 at 03:06:11PM -0500, Duncan Murdoch wrote: > On 19/01/2015 2:33 PM, Felipe Balbi wrote: > > git has an interface for cloning SVN repositories into git which > > some users might decide to use. For those users' surprise, the > > repository will always fail to build on svnon

Re: [Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Duncan Murdoch
On 19/01/2015 2:33 PM, Felipe Balbi wrote: > git has an interface for cloning SVN repositories into git which > some users might decide to use. For those users' surprise, the > repository will always fail to build on svnonly target and it will > exit early. > > The problem is simple enough to fix

[Rd] [PATCH] Makefile: add support for git svn clones

2015-01-19 Thread Felipe Balbi
git has an interface for cloning SVN repositories into git which some users might decide to use. For those users' surprise, the repository will always fail to build on svnonly target and it will exit early. The problem is simple enough to fix by just checking if a .git directory exists in top_buil

[Rd] [PATCH] Makefile: add support for git svn clones

2015-01-12 Thread Felipe Balbi
git has an interface for cloning SVN repositories into git which some users might decide to use. For those users' surprise, the repository will always fail to build on svnonly target and it will exit early. The problem is simple enough to fix by just checking if a .git directory exists in top_buil