Re: [Rd] FR: Customize background colour of row and column headers for the View output

2024-05-28 Thread Tomas Kalibera
I think we should do more than this trivial change. The two real dialogs used by the data editor would then also get the new background color (setting the cell width, the "variable" editor). Then, the code clearly distinguishes between cells for names (row, column) and cells for data, so

Re: [Rd] FR: Customize background colour of row and column headers for the View output

2024-05-16 Thread Ivan Krylov via R-devel
The change suggested by Iago Giné Vázquez is indeed very simple. It sets the background colour of the row and column headers to the background of the rest of the dataentry window. With this patch, R passes 'make check'. As Duncan Murdoch mentions, the X11 editor already behaves this way. If it's

Re: [Rd] FR: Customize background colour of row and column headers for the View output

2024-05-15 Thread Duncan Murdoch
A criticism of your suggestion is that it is not backwards compatible. Does that matter? I don't know, but probably not. The X11 version of the viewer does what you suggest. Duncan Murdoch On 2024-05-15 2:20 a.m., Iago Giné Vázquez wrote: About the decisions: Actually, the same way

Re: [Rd] FR: Customize background colour of row and column headers for the View output

2024-05-15 Thread Iago Giné Vázquez
About the decisions: Actually, the same way dataedittext modifies the text colour not only of data, but also of row and column names, and dataedituser modifies the colour of all the borders, I think dataeditbg should modify the background of all the window, at least that "inside" those borders.

Re: [Rd] FR: Customize background colour of row and column headers for the View output

2024-05-14 Thread Duncan Murdoch
This seems like something that should be fairly easily doable. Why don't you work out a patch? Some decisions to make: - What colours are we talking about? Would you want the labels to have their colour set independent of the dialog colours? If so, would you also want to configure the

[Rd] FR: Customize background colour of row and column headers for the View output

2024-05-14 Thread Iago Giné Vázquez
Thanks again Duncan and Ivan, I forward then the email to R-devel. Summarizing, the dataedit options (in RGui preferences or RConsole) to colouring the View output do not have effect on the background of the row and column names (see https://ibb.co/Dkn2pVs). Could this be implemented? Thank