Re: [Rd] colnames for data.frame could be greatly improved

2016-12-29 Thread Martin Maechler
> Hi there, > Any update on this? > Should I create bugzilla ticket and submit patch? > Regards > Jan Gorecki Hi Jan, Why should we care that the do.NULL = FALSE case is slower? After all do.NULL = TRUE is the default. In other words, where are use cases where it is problematic that do.NULL =

Re: [Rd] colnames for data.frame could be greatly improved

2016-12-27 Thread Jan Gorecki
Hi there, Any update on this? Should I create bugzilla ticket and submit patch? Regards Jan Gorecki On 20 December 2016 at 01:27, Jan Gorecki wrote: > Hello, > > colnames seems to be not optimized well for data.frame. It escapes > processing for data.frame in > > if (is.data.frame(x) && do.NULL

[Rd] colnames for data.frame could be greatly improved

2016-12-19 Thread Jan Gorecki
Hello, colnames seems to be not optimized well for data.frame. It escapes processing for data.frame in if (is.data.frame(x) && do.NULL) return(names(x)) but only when do.NULL true. This makes huge difference when do.NULL false. Minimal edit to `colnames`: if (is.data.frame(x)) {