Re: [Rd] quantile() type 1 for some ordered factors in R-devel

2020-05-20 Thread Kurt Hornik
> Trang Le writes: > Hi Kurt, > Thank you for fixing quantile(). However, do you think c.factor() can > potentially break more functions? For example, with this new change, > classification from the partykit package using predict() comes back NA because > of this: >

Re: [Rd] quantile() type 1 for some ordered factors in R-devel

2020-05-20 Thread Trang Le
Hi Kurt, Thank you for fixing quantile(). However, do you think c.factor() can potentially break more functions? For example, with this new change, classification from the partykit package using predict() comes back NA because of this:

Re: [Rd] quantile() type 1 for some ordered factors in R-devel

2020-05-19 Thread Kurt Hornik
> Tobias Rockel writes: Thanks for spotting this, and also to Hadley for reporting to me directly. Fixed now with c78501. Best -k > Hi, > In R-devel (2020-05-17 r78478) quantile() type 1 seems to behave a little > bit strange for some ordered factors: > quantile(factor(1:3, ordered =

Re: [Rd] quantile() type 1 for some ordered factors in R-devel

2020-05-18 Thread Trang Le
Hi Tobias, I believe this is due to the implementation of the new method for c(): c.factor() on May 11, 2020. I have very recently experienced issues around this addition as well. For this particular instance, the following line of code in quantile.default() no longer gives "integer" but instead

[Rd] quantile() type 1 for some ordered factors in R-devel

2020-05-18 Thread Tobias Rockel
Hi, In R-devel (2020-05-17 r78478) quantile() type 1 seems to behave a little bit strange for some ordered factors: quantile(factor(1:3, ordered = TRUE), 0.5, type = 1) returns “2” as expected. But quantile(factor(2:4, ordered = TRUE), 0.5, type = 1) returns “4” and quantile(factor(3:5, ordered =