Re: [Rd] timezone tests and R-devel

2020-10-30 Thread Kasper Daniel Hansen
On Fri, Oct 23, 2020 at 11:10 AM Sebastian Meyer wrote: > Yes, you are absolutely right and I'm pretty sure this will be fixed in > one way or another. > > IMO, the failing test should simply use all.equal.POSIXt's new argument > check.tzone=FALSE. > I agree that this is a simple fix and I am wo

Re: [Rd] timezone tests and R-devel

2020-10-23 Thread Sebastian Meyer
Yes, you are absolutely right and I'm pretty sure this will be fixed in one way or another. IMO, the failing test should simply use all.equal.POSIXt's new argument check.tzone=FALSE. Two simple alternatives modifying all.equal.POSIXt behaviour: - make check.tzone=FALSE the default: this is incon

Re: [Rd] timezone tests and R-devel

2020-10-23 Thread Kasper Daniel Hansen
So let me try to raise this issue once more, and perhaps be more clear about what I think the issue is.. In my opinion there is now a bug in make check in R-development (tested today with r79361). As I see it, I specify a reasonable TZ environment variable and this leads to make check emitting a

Re: [Rd] timezone tests and R-devel

2020-10-02 Thread Kasper Daniel Hansen
Yes, the potential issue I see is that make check fails when I explicitly set TZ. However, I set it to be the same as what the system reports when I login. Details: The system (RHEL) I am working on has $ strings /etc/localtime | tail -n 1 EST5EDT,M3.2.0,M11.1.0 $ date +%Z EDT $ echo $TZ US/East

Re: [Rd] timezone tests and R-devel

2020-10-02 Thread Sebastian Meyer
Thank you for the report. In R-devel, all.equal.POSIXt() by default reports inconsistent time zones. Previously, > x <- Sys.time() > all.equal(x, as.POSIXlt(x, tz = "EST5EDT")) would return TRUE. To ignore the time zone attributes in R-devel, the argument 'check.tzone = FALSE' needs to be used.

Re: [Rd] timezone tests and R-devel

2020-10-02 Thread Martin Maechler
> Kasper Daniel Hansen > on Thu, 1 Oct 2020 20:31:12 +0200 writes: > The return value of Sys.time() today with a timezone of US/Eastern is > unchanged between 4.0.3-patched and devel, but on devel the following test > fails > all.equal(x, as.POSIXlt(x)) > with

[Rd] timezone tests and R-devel

2020-10-01 Thread Kasper Daniel Hansen
The return value of Sys.time() today with a timezone of US/Eastern is unchanged between 4.0.3-patched and devel, but on devel the following test fails all.equal(x, as.POSIXlt(x)) with x = Sys.time() This means that devel does not complete make tests (failure on tests/reg-tests-2.R) It is enti