Re: [Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-30 Thread Gabriel Becker
Submitted to bugzilla here: https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17901 On Sat, Aug 29, 2020 at 1:57 PM Gabriel Becker wrote: > Hi all, > > I have a patch that fixes this and also fixes/improves debugcall so that > it supports pkg::fun(obj) and pkg:::fun(obj) style calls. I'm

Re: [Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-29 Thread Gabriel Becker
Hi all, I have a patch that fixes this and also fixes/improves debugcall so that it supports pkg::fun(obj) and pkg:::fun(obj) style calls. I'm going to test it a bit more and add a regression test for isS3stdGeneric and then I will submit it to bugzilla tonight or tomorrow morning. Best, ~G On

Re: [Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-27 Thread Gabriel Becker
Trace adds something to the body of the function, so it does make sense that it doesn't. Whether traced functions still technically meet the definition of standard s3 generic or not is, I suppose, up for debate, but I would say that they should, I think. As before, if desired I can work on a

Re: [Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-27 Thread Antoine Fabri
Should it work on traced functions ? As it is now it doesn't. Best, Antoine Le jeu. 20 août 2020 à 09:58, Kurt Hornik a écrit : > > Gabriel Becker writes: > > > I added that so I can look at the proposed fix and put it or something > > similar in bugzilla for review final review. > > >

Re: [Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-20 Thread Kurt Hornik
> Gabriel Becker writes: > I added that so I can look at the proposed fix and put it or something > similar in bugzilla for review final review. > Apologies for the oversight. Fixed now with -while(as.character(bdexpr[[1L]]) == "{") +while(is.call(bdexpr) &&

Re: [Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-19 Thread Gabriel Becker
I added that so I can look at the proposed fix and put it or something similar in bugzilla for review final review. Apologies for the oversight. ~G On Wed, Aug 19, 2020 at 3:40 PM Antoine Fabri wrote: > Dear R-devel, > > utils::isS3stdGeneric tries to subset the body of the function it's fed,

[Rd] utils::isS3stdGeneric chokes on primitives and identity

2020-08-19 Thread Antoine Fabri
Dear R-devel, utils::isS3stdGeneric tries to subset the body of the function it's fed, primitives don't like that because they don't have a body, identity doesn't like it either because it's body is a symbol. According to the doc, any function is a legal input. See below: identity #> function