Re: [R-pkg-devel] compilation flags WARNING

On 5 July 2018 at 22:19, Göran Broström wrote: | Thanks Heather and Iñaki: I understand. | | I have an old Makevars file in the src directory of the package. I | guess I can set the flags there? No, because those get scanned by R CMD check and friends. For the one you do not want, Heather's

Re: [R-pkg-devel] compilation flags WARNING

I would suggest not to set the CFLAGS in the package itself - at least not exclusively. R-admin 6.3.3 (the section I linked before) recommends "to enable a reasonable amount of diagnostic messaging (“warnings”) when compiling, such as e.g. -Wall -pedantic for tools from GCC", while R-exts

Re: [R-pkg-devel] compilation flags WARNING

El jue., 5 jul. 2018 a las 22:23, Göran Broström () escribió: > > Thanks Heather and Iñaki: I understand. > > I have an old Makevars file in the src directory of the package. I > guess I can set the flags there? Now it only contains > > # PKG_CFLAGS = -Wall > # PKG_FFLAGS = -Wall -fbounds-check >

Re: [R-pkg-devel] compilation flags WARNING

Thanks Heather and Iñaki: I understand. I have an old Makevars file in the src directory of the package. I guess I can set the flags there? Now it only contains # PKG_CFLAGS = -Wall # PKG_FFLAGS = -Wall -fbounds-check PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS) Göran On 2018-07-05

Re: [R-pkg-devel] Weird error on CRAN linux check

El jue., 5 jul. 2018 21:51, David Hugh-Jones escribió: > That will indeed fail everywhere. The puzzle is why it fails (only > sometimes) when the methods are all exported. The GitHub equivalent is tag > v4.0.1-rc1. > Yeap, but the point is that exporting the methods with 'export' should be

Re: [R-pkg-devel] Weird error on CRAN linux check

That will indeed fail everywhere. The puzzle is why it fails (only sometimes) when the methods are all exported. The GitHub equivalent is tag v4.0.1-rc1. On Thu, 5 Jul 2018 at 20:43, Iñaki Úcar wrote: > > > El jue., 5 jul. 2018 21:35, David Hugh-Jones > escribió: > >> Installed from CRAN or

Re: [R-pkg-devel] Weird error on CRAN linux check

Installed from CRAN or github? CRAN should be OK - I hope! On Thu, 5 Jul 2018 at 20:33, Iñaki Úcar wrote: > I installed huxtable in two environments, my own Fedora installation with > R 3.5.0 and all my packages and in a fresh Ubuntu system with R 3.4.4 and > an empty library. In both cases,

Re: [R-pkg-devel] Weird error on CRAN linux check

El jue., 5 jul. 2018 21:35, David Hugh-Jones escribió: > Installed from CRAN or github? CRAN should be OK - I hope! > >From GitHub before the patch. > On Thu, 5 Jul 2018 at 20:33, Iñaki Úcar wrote: > >> I installed huxtable in two environments, my own Fedora installation with >> R 3.5.0 and

Re: [R-pkg-devel] Weird error on CRAN linux check

I installed huxtable in two environments, my own Fedora installation with R 3.5.0 and all my packages and in a fresh Ubuntu system with R 3.4.4 and an empty library. In both cases, huxtable is unusable: every example I try fails because it doesn't find the methods. So it has nothing to do with R

Re: [R-pkg-devel] Weird error on CRAN linux check

On 05/07/2018 2:06 PM, Duncan Murdoch wrote: On 05/07/2018 9:11 AM, David Hugh-Jones wrote: Agreed. I fixed the roxygen2 and it works fine. But yet, the original v4.0.1 on CRAN has a namespace file which contains S3method(bold,huxtable) export(bold) export(bold.huxtable) and

Re: [R-pkg-devel] Weird error on CRAN linux check

On 05/07/2018 9:11 AM, David Hugh-Jones wrote: Agreed. I fixed the roxygen2 and it works fine. But yet, the original v4.0.1 on CRAN has a namespace file which contains S3method(bold,huxtable) export(bold) export(bold.huxtable) and S3method("align<-",huxtable) export("align<-")

Re: [R-pkg-devel] compilation flags WARNING

On Thu, Jul 5, 2018, at 3:39 PM, Iñaki Úcar wrote: > El jue., 5 jul. 2018 a las 16:11, Göran Broström > () escribió: > > > > I am preparing a CRAN release of eha (a trivial change due to a change > > in the survival package), but when checking the build I get: > > > > goran@M6800:~/R$ R CMD

Re: [R-pkg-devel] Weird error on CRAN linux check

For the record: I've checked this in R 3.5.0 and R 3.4.4, and in both cases this problem exists. Also, I need to correct myself: The correct way to document with roxygen is to use _both_ the @method and @export tag: @method foo bar @export That registers the S3 method correctly (and hence

Re: [R-pkg-devel] compilation flags WARNING

El jue., 5 jul. 2018 a las 16:11, Göran Broström () escribió: > > I am preparing a CRAN release of eha (a trivial change due to a change > in the survival package), but when checking the build I get: > > goran@M6800:~/R$ R CMD check --as-cran eha_2.5.2.tar.gz > ... > * checking compilation flags

Re: [R-pkg-devel] Weird error on CRAN linux check

I see that you realized it was Inaki who gave you he patch, not me :-) I've been looking into this further, and the toy example David put up is actually not the right one to look at. In that example the generic is created in the namespace. But in the original huxtable that was not the case. Try

[R-pkg-devel] compilation flags WARNING

I am preparing a CRAN release of eha (a trivial change due to a change in the survival package), but when checking the build I get: goran@M6800:~/R$ R CMD check --as-cran eha_2.5.2.tar.gz ... * checking compilation flags used ... WARNING Compilation used the following non-portable flag(s):

Re: [R-pkg-devel] Weird error on CRAN linux check

Agreed. I fixed the roxygen2 and it works fine. But yet, the original v4.0.1 on CRAN has a namespace file which contains S3method(bold,huxtable) export(bold) export(bold.huxtable) and S3method("align<-",huxtable) export("align<-") export("align<-.huxtable") yet still fails on linux-patched and

Re: [R-pkg-devel] Weird error on CRAN linux check

On 05/07/2018 5:22 AM, David Hugh-Jones wrote: Wow, this is extremely helpful. I've applied Joris' patch. By the way, the github master has the change that I stopped exporting methods, as per Hadley's suggestion; this caused *all* functions created via make_getter_setters to fail. Version

Re: [R-pkg-devel] Weird error on CRAN linux check

Wow, this is extremely helpful. I've applied Joris' patch. By the way, the github master has the change that I stopped exporting methods, as per Hadley's suggestion; this caused *all* functions created via make_getter_setters to fail. Version 4.0.1 on CRAN has the methods exported, which was

Re: [R-pkg-devel] Weird error on CRAN linux check

El mié., 4 jul. 2018 a las 22:47, Duncan Murdoch () escribió: > > On 04/07/2018 4:04 PM, Joris Meys wrote: > > > > > > On Wed, Jul 4, 2018 at 9:31 PM, Duncan Murdoch > > wrote: > > > > > > That shouldn't matter. That function was created in a local > >