Re: [R-pkg-devel] Issue with use of par() in package

2025-08-22 Thread Jan van der Laan
Thanks Micheal and Martin, I have contacted the people from CRAN, and they have let me know that in this case it is indeed reasonable to set par and not set it back. I will also think about Martins suggestion. Currently I return an other object, but I might be able to add the old par-values t

Re: [R-pkg-devel] Issue with use of par() in package

2025-08-22 Thread Martin Maechler
> Michael Chirico > on Thu, 21 Aug 2025 12:56:41 -0700 writes: > I can understand caution about functions with side effects, but rejecting a > package on those grounds alone seems strange to me. > I can easily find thousands of calls to par() on CRAN without any > as

Re: [R-pkg-devel] Issue with use of par() in package

2025-08-21 Thread Michael Chirico
I can understand caution about functions with side effects, but rejecting a package on those grounds alone seems strange to me. I can easily find thousands of calls to par() on CRAN without any associated on.exit() cleanup ([1] [2] [3] [4] with a full regex search [5]) [1] https://github.com/cran

Re: [R-pkg-devel] Issue with use of par() in package

2025-08-21 Thread Jan van der Laan
Someone asked for the response I got from CRAN. I included it below: --- [... another issue where I forgot a \value{} in the documentation of one of the functions] Please make sure that you do not change the user's options, par or working directory. If you really have to do so within funct

[R-pkg-devel] Issue with use of par() in package

2025-08-20 Thread Jan van der Laan
I recently submitted a package to CRAN that creates a device that outputs into the terminal (for terminals that support the Terminal Graphics Protocol (and hopefully in the future also terminals that support sixel)) [1]. It introduces a 'tgp' function that does the following: 1. It opens a