Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-24 Thread Heikki Vatiainen
On 24.06.2016 14:08, Hartmaier Alexander wrote: >> We also thought about further improvements for unexpectedly closed >> connections so that they can be logged and handled more easily. However, >> this is the first step before doing further changes. > We still get the 'Could not get peer name on

Re: [RADIATOR] OTP Authentication failed logging

2016-06-24 Thread Heikki Vatiainen
On 24.06.2016 13:50, Hartmaier Alexander wrote: > Will you change the log message? Yes. I forgot to say that. >> I'd say the best option is to log any failure reason in the OTP's >> VerifyHook if any special logs are needed. > We don't have a custom VerifyHook but use what comes with Radiator.

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-24 Thread Hartmaier Alexander
Hi Heikki, On 2016-06-21 12:58, Heikki Vatiainen wrote: > On 13.06.2016 10:27, Hartmaier Alexander wrote: > >>> I also noticed that we can get the peer IP and port from accept directly >>> instead of calling getpeername(). What is done now is to check accept >>> return value for success and call g

Re: [RADIATOR] OTP Authentication failed logging

2016-06-24 Thread Hartmaier Alexander
On 2016-06-23 17:04, Heikki Vatiainen wrote: > On 16.06.2016 17:55, Hartmaier Alexander wrote: > >> I've encountered some 'OTP Authentication failed: ()' logs and digged >> deeper where there coming from. >> Line 104 returns if $result is undefined, line 107 if it's a true value >> so the else tree