[Rails-core] Inserts, sequences and Oracle

2006-08-07 Thread Blair Zajac
I'm looking for direction here on finishing a patch that let's RoR work with Oracle installs where the sequences are not available to the database user. This patch also cleans up some regex's that some adapters use to find the table name that is being INSERTed into and saves one SELECT call for

Re: [Rails-core] Showing SQL Server some love...

2006-07-08 Thread Blair Zajac
Ideally, if you could have the same person manage Oracle and other databases, then you could have the Oracle tests run, and if they pass, run the Postgresql tests. While this would delay the report of Postgresql specific problems when there is also an Oracle specific problem, it would redu

Re: [Rails-core] [PROPOSAL] Partial commit access

2006-06-24 Thread Blair Zajac
Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulting and support http://www.orcaware.com/svn/ ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

Re: [Rails-core] Reloadable modules

2006-06-24 Thread Blair Zajac
7;s a small amount of pain that I only have to bear during development so it's okay with me. Trevor, Thanks for the tip. I'm now using it in my code. Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulting and

[Rails-core] Reloadable modules

2006-06-07 Thread Blair Zajac
There's a scenario with the projects I'm working on that could use reloadable modules, instead of just reloadable classes. Ticket and patch with test suite changes are at: http://dev.rubyonrails.org/ticket/5329 The reasoning for doing this is I have a library of 25 and growing plugins that de

Re: [Rails-core] Routing code patch

2006-06-07 Thread Blair Zajac
Jamis, Thanks! Blair Jamis Buck wrote: Blair, thanks for this patch. It's been applied. - Jamis On Jun 6, 2006, at 5:36 PM, Blair Zajac wrote: I just opened a ticket for the new routing code that breaks the restful_rails plugin. The plugin is using the public API for inserting r

[Rails-core] Routing code patch

2006-06-07 Thread Blair Zajac
is using the API can be seen by running $ svn cat svn://rubyforge.org/var/svn/restful-rails/trunk/lib/rest_controller/routes.rb The ticket and a patch is at http://dev.rubyonrails.org/ticket/5314 Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulti

Re: [Rails-core] 22-30% faster and added to_xml functionality

2006-06-05 Thread Blair Zajac
David Heinemeier Hansson wrote: I've been working on improving the performance and functionality of to_xml. Good stuff, Blair. I've taken the liberty to massively refactor the implementation, though. Having a method going on 100+ lines of code was a sure tell sign that it needed some love. And

[Rails-core] [PROPOSAL] Partial commit access

2006-06-05 Thread Blair Zajac
ocumentation, code comments, commit messages, etc. We rely on the committers judgement to determine what is "obvious"; if you're not sure, just ask." http://subversion.tigris.org/hacking.html Some ideas to consider. Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PR

Re: [Rails-core] Rails AR/Oracle Unit Test: [4414] failed (but getting better)

2006-06-05 Thread Blair Zajac
Michael A. Schoen wrote: Blair Zajac wrote: Turns out that Oracle may return a Date object even if the SQL column is a timestamp if the hours, minutes and seconds are all 0. I've proposed a different immediate fix, patch in: http://dev.rubyonrails.org/ticket/5294 taking the app

Re: [Rails-core] Rails AR/Oracle Unit Test: [4414] failed (but getting better)

2006-06-02 Thread Blair Zajac
Turns out that Oracle may return a Date object even if the SQL column is a timestamp if the hours, minutes and seconds are all 0. The attached patch works around this. However, I don't know if this patch is a good idea, with the following code in the Oracle adapter: def guess_date_or_

Re: [Rails-core] Rails AR/Oracle Unit Test: [4413] failed

2006-06-02 Thread Blair Zajac
This passed for me on my tests before submitting the patch, but after doing an 'svn update, it failed with the same error. Looks like a random file ordering issue where the core_ext modules are not loaded in a known order: $ cat activesupport/lib/active_support/core_ext.rb Dir[File.dirname(__

[Rails-core] 22-30% faster and added to_xml functionality

2006-06-02 Thread Blair Zajac
oking with the optimization of using builder.tag!(tag) do builder << value.to_s end instead of builder.tag!(tag, value), but that seems like a small price to pay. 1234 Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulting and

Re: [Rails-core] real bind variables

2006-05-25 Thread Blair Zajac
Michael Koziarski wrote: The implementation involves some funky regex's on the sql sent along to the connection adapter, so I'm going to do some more extensive testing within my own app before posting to Trac. I like the idea, however perhaps it's not ambitious enough? If instead of doing th

Re: [Rails-core] real bind variables

2006-05-25 Thread Blair Zajac
d could try it on our apps. So the sooner you open a Trac ticket, the better :) As an aside, only the pretty comprehensive AR unit tests make a patch like this even possible to think about. So kudos to everyone on that point. Ditto. Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED

Re: [Rails-core] Overriding to_xml and associations

2006-05-05 Thread Blair Zajac
Benjamin Curtis wrote: On May 3, 2006, at 5:23 PM, Blair Zajac wrote: In looking at the to_xml method and its behavior on associations, currently it includes the attributes from the associations into the same hash that represents that AR instance being serialized. Wouldn't it be bett

[Rails-core] Overriding to_xml and associations

2006-05-03 Thread Blair Zajac
but then the other models that have associations with this model need to know that also, which seems like a DRY violation. If people like this idea, I'll code up a patch for it. Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulting an

Re: [Rails-core] oracle boolean support

2006-04-26 Thread Blair Zajac
Corey Donohoe wrote: I currently have to support both postgres and oracle for work. I'd like to use booleans but I ran into a wall when I found oracle didn't support them. The fix was really small and I adopted the convention of NUMERIC(1) being boolean. It also uses a similar approach as the

[Rails-core] Use svnmerge.py for merging trunk to stable branch

2006-04-07 Thread Blair Zajac
ion require File.join(File.dirname(__FILE__), 'boot') # Finally, commit. $ svn commit -F svnmerge-commit-message.txt Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulting and support http://www.orcaware.com/svn/ _

Re: [Rails-core] svn issue on dev.rubyonrails.org?

2006-04-06 Thread Blair Zajac
you want to see the log message for any revision, you need to use the root of the Subversion repository. That's easy to get from a script if your client is 1.3.x: svn info . | grep '^Repository Root:' | awk '{print $3}' Parse for Ruby left as an exercise for th

Re: [Rails-core] please apply patch to fix ActiveRecord

2006-03-30 Thread Blair Zajac
could setup a rails-test list explicitly for the purpose of having reporters ping that. You could have another list with a Reply-To this list and when the build breaks, additionally cc the committer that broke the build. Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subv

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-27 Thread Blair Zajac
like to see it. Regards, Blair -- Blair Zajac, Ph.D. <[EMAIL PROTECTED]> Subversion training, consulting and support http://www.orcaware.com/svn/ ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

Re: [Rails-core] some (long) thoughts on migrations

2006-02-20 Thread Blair Zajac
different migrations. class Section_Migrate003Up < ActiveRecord::Base set_table_name 'output_state' end class Section_Migrate003Down < ActiveRecord::Base set_table_name 'output_state' end Regards, Blair -- Blair Zajac, Ph.D.

Re: [Rails-core] anyone in a committing mood?

2006-02-11 Thread Blair Zajac
icket with "+1 works for me", then that'd be great. Thanks! I can give the rolled up patch a try on our Oracle/Rails apps. Please drop me a note when it's ready to go, or the ticket number that you'll attach the patch to. Regards, Blair -- Blair Zajac, Ph.D. CTO,

Re: [Rails-core] acts_as_taggable and postgresql

2006-02-01 Thread Blair Zajac
d> = tags_posts.post_id GROUP BY posts.id <http://posts.id> HAVING COUNT( posts.id <http://posts.id>) = 1 This has been reported on the acts_as_taggable project and contains a suggested fix: http://rubyforge.org/tracker/index.php?func=detail&aid=2482&group_id=923&ati