[Rails-core] Ticket 5296 wants to be recognized

2006-07-22 Thread Greg Lappen
Hello,I just spoke to my patch (#5296) and he's worried that nobody will ever review him.  I sympathize with him myself as he only wants to help rails work better with postgresql 8.x.   Can someone kindly take a look and let him know if he's good enough?Thanks so much!Greg Lappen (on

Re: [Rails-core] migrations unit test and sqlite3 add_column

2006-06-05 Thread Greg Lappen
Good to hear the patch was applied.  I just submitted another patch, #5296 that improves the unit test more so as to not break on Oracle, and fixes the add_column on Postgresql 8 when there is data in the table and new column is non-null.GregOn Jun 4, 2006, at 11:42 PM, David Heinemeier Hansson wro

[Rails-core] migrations unit test and sqlite3 add_column

2006-06-02 Thread Greg Lappen
Hi all,I submitted a patch the other day for an issue I ran into running an "add_column" migration on a sqlite3 database when there is existing data in the table, and the new column has ":null=>false".  Details at http://dev.rubyonrails.org/ticket/5215.  The issue I encountered was not picked due t

Re: [Rails-core] Rails 1.1 is coming

2006-03-06 Thread Greg Lappen
etter ORM for Ruby I think more and more people will want to do so. Let me know if there's anything I can do to assist. Greg On Mar 6, 2006, at 6:30 AM, Tom Ward wrote: On 3/3/06, Greg Lappen <[EMAIL PROTECTED]> wrote: This may have gotten lost at the bottom of my email re: anot

Re: [Rails-core] Rails 1.1 is coming

2006-03-03 Thread Greg Lappen
This may have gotten lost at the bottom of my email re: another topic so I'm repeating it again. How about that connection pooling adaptor for Rails 1.1? There is a patch attached to http://dev.rubyonrails.org/ticket/2162 that's been hanging out for a while, we'd love to see it make it i

[Rails-core] Validations broken for "external" ActiveRecord models, Rails 1.1 question

2006-03-02 Thread Greg Lappen
I just posted this defect, not sure what the group would rate the severity, but it would be nice to know at least why it doesn't work - its been driving me crazy all night! http://dev.rubyonrails.org/ticket/4059 Can't wait for 1.1! Any chance the ActiveRecord connection pooling adapter wi

Re: [Rails-core] Multithreaded script/runner

2006-02-11 Thread Greg Lappen
that some changes were made in #428 that may affect the pool. I'll take a look at the code I wrote over the weekend, and see how it looks against 1.0 and trunk. I'll comment against #2162 with anything I find. Tom On 2/9/06, Greg Lappen <[EMAIL PROTECTED]> wrote: Your guess is

Re: [Rails-core] Multithreaded script/runner

2006-02-09 Thread Greg Lappen
Your guess is as good as mine. Tom Ward did some work based on my original patch to implement a pooled adaptor which I thought was on track to be integrated into the core, but i still don't see it in subversion. We would like to be able to use Rails with webrick in multithreaded mode for