Re: [Rails-core] Help needed from eager loading enthusiasts

2006-03-04 Thread Rick Olson
FYI: this has been applied as of [3769]: http://dev.rubyonrails.org/changeset/3769 Please report back if this causes any breakage. Now we can tackle some of the eager loading issues regarding polymorphic joins and STI models. -- Rick Olson http://techno-weenie.net __

Re: [Rails-core] Help needed from eager loading enthusiasts

2006-02-25 Thread Rick Olson
> It gets my vote too, as it is superior to the current rails behavior, > but it should be changed so that it fixes all the problems that 1562 > fixed. > ___ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailm

Re: [Rails-core] Help needed from eager loading enthusiasts

2006-02-25 Thread Jeremy Evans
On 2/25/06, Rick Olson <[EMAIL PROTECTED]> wrote: > > I haven't tested the patch, but it aliases the table names in the SQL, > > so it may fix the problems that 1562 addresses (hopefully someone else > > can give a more definitive answer). I hope it does and it gets > > included in Rails 1.1, that

Re: [Rails-core] Help needed from eager loading enthusiasts

2006-02-25 Thread Rick Olson
> I haven't tested the patch, but it aliases the table names in the SQL, > so it may fix the problems that 1562 addresses (hopefully someone else > can give a more definitive answer). I hope it does and it gets > included in Rails 1.1, that way I won't have to keep updating the 1562 > patch and as

Re: [Rails-core] Help needed from eager loading enthusiasts

2006-02-22 Thread Jeremy Evans
On 2/22/06, Pete Yandell <[EMAIL PROTECTED]> wrote: > Does this tie in with http://dev.rubyonrails.org/ticket/1562 which > allows including multiple associations that reference a single table, > but (AFAIK) isn't compatible with edge rails? If this doesn't solve > the same problem as 1562, would th

Re: [Rails-core] Help needed from eager loading enthusiasts

2006-02-22 Thread Pete Yandell
Does this tie in with http://dev.rubyonrails.org/ticket/1562 which allows including multiple associations that reference a single table, but (AFAIK) isn't compatible with edge rails? If this doesn't solve the same problem as 1562, would this make solving it easier? On 22/02/2006, at 8:30 AM

Re: [Rails-core] Help needed from eager loading enthusiasts

2006-02-21 Thread Charles M. Gerungan
On 21-feb-2006, at 19:46, Michael Koziarski wrote: http://dev.rubyonrails.org/ticket/3913 Ah, that's AnnaChan's (irc nick) patch. I will most definitely test this! -- Regards, Charles. ___ Rails-core mailing list Rails-core@lists.rubyonrails.or

[Rails-core] Help needed from eager loading enthusiasts

2006-02-21 Thread Michael Koziarski
Hey guys, If you make extensive use of eager loaded associations in your application, and run on edge, we could really use your help testing a very nice, but quite intrusive patch that's been submitted. http://dev.rubyonrails.org/ticket/3913 It's a nice refactoring of the code, and a great new